From: "Péter Ujfalusi" <peter.ujfalusi@ti.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel@vger.kernel.org, Liam Girdwood <lrg@ti.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
alsa-devel@alsa-project.org
Subject: Re: [PATCH] ASoC: tlv320dac33: Add guarding parentheses to macros
Date: Thu, 29 Sep 2011 09:59:26 +0300 [thread overview]
Message-ID: <3462016.6xldpjznMt@barack> (raw)
In-Reply-To: <1317269397.4561.1.camel@phoenix>
On Thursday 29 September 2011 12:09:57 Axel Lin wrote:
> Put parentheses around macro argument uses. This avoids pitfalls
> for the programmer, where the argument expansion does not give the
> expected result, for example:
>
> SAMPLES_TO_US(substream->runtime->rate, dac33->uthr - DAC33_MODE7_MARGIN +
> 1);
Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
next prev parent reply other threads:[~2011-09-29 6:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-29 4:09 [PATCH] ASoC: tlv320dac33: Add guarding parentheses to macros Axel Lin
2011-09-29 6:59 ` Péter Ujfalusi [this message]
2011-09-29 9:53 ` Mark Brown
2011-09-29 9:53 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3462016.6xldpjznMt@barack \
--to=peter.ujfalusi@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=axel.lin@gmail.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.