* [PATCH] Bug fix in module_init and module_exit
@ 2016-08-29 2:12 Vincent Guo
2016-08-29 9:36 ` Ferruh Yigit
2016-09-02 10:23 ` [PATCH v2] kni: " Vincent Guo
0 siblings, 2 replies; 6+ messages in thread
From: Vincent Guo @ 2016-08-29 2:12 UTC (permalink / raw)
To: dev
Fix pernet calls when HAVE_SIMPLIFIED_PERNET_OPERATIONS is not set.
Signed-off-by: Vincent Guo <guopengfei160@163.com>
---
lib/librte_eal/linuxapp/kni/kni_misc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/librte_eal/linuxapp/kni/kni_misc.c b/lib/librte_eal/linuxapp/kni/kni_misc.c
index 67e9b7d..d7850be 100644
--- a/lib/librte_eal/linuxapp/kni/kni_misc.c
+++ b/lib/librte_eal/linuxapp/kni/kni_misc.c
@@ -194,7 +194,7 @@ out:
#ifdef HAVE_SIMPLIFIED_PERNET_OPERATIONS
unregister_pernet_subsys(&kni_net_ops);
#else
- register_pernet_gen_subsys(&kni_net_id, &kni_net_ops);
+ unregister_pernet_gen_subsys(kni_net_id, &kni_net_ops);
#endif
return rc;
}
@@ -206,7 +206,7 @@ kni_exit(void)
#ifdef HAVE_SIMPLIFIED_PERNET_OPERATIONS
unregister_pernet_subsys(&kni_net_ops);
#else
- register_pernet_gen_subsys(&kni_net_id, &kni_net_ops);
+ unregister_pernet_gen_subsys(kni_net_id, &kni_net_ops);
#endif
KNI_PRINT("####### DPDK kni module unloaded #######\n");
}
--
2.4.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] Bug fix in module_init and module_exit
2016-08-29 2:12 [PATCH] Bug fix in module_init and module_exit Vincent Guo
@ 2016-08-29 9:36 ` Ferruh Yigit
2016-08-29 9:38 ` Ferruh Yigit
2016-09-02 10:23 ` [PATCH v2] kni: " Vincent Guo
1 sibling, 1 reply; 6+ messages in thread
From: Ferruh Yigit @ 2016-08-29 9:36 UTC (permalink / raw)
To: Vincent Guo, dev
Hi Vincent,
On 8/29/2016 3:12 AM, Vincent Guo wrote:
> Fix pernet calls when HAVE_SIMPLIFIED_PERNET_OPERATIONS is not set.
>
> Signed-off-by: Vincent Guo <guopengfei160@163.com>
> ---
Thank you for the update, patch applies well this time.
A few more small details:
- Patch subject should start with a label/tag, that shows the
corresponding subsystem. For this patch it is "kni:".
- In patch subject, after label, sentences starts with lowercase, so
patch subject becomes:
kni: bug fix in module_init and module_exit
- "Fixes:" tag is a line in commit log, to reference the commit that
generated the error. For this patch it is:
Fixes: e6734d21b4e1 ("kni: fix build with kernel 2.6.32")
This line should go above "Signed-off-by", with an empty line between.
- Replying to previous mail thread help others to see the history of the
patch. the option --in-reply-to of the "git send-email" can be used for
this.
It is possible to get Message ID of the mail that you want to reply via
patchwork or from mail client. For example for this patch, you can see
the message id from: http://dpdk.org/dev/patchwork/patch/15506/
- Adding version number to the patch helps following history. Each
updated patch increases the version number. "-vN" option of the "git
format-patch" is useful for this.
- When a new version of the patch sent, the status of the previous
version should be updated in patchwork as "Superseded". For this case
previous version is: http://dpdk.org/dev/patchwork/patch/15506/
Thanks,
ferruh
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Bug fix in module_init and module_exit
2016-08-29 9:36 ` Ferruh Yigit
@ 2016-08-29 9:38 ` Ferruh Yigit
0 siblings, 0 replies; 6+ messages in thread
From: Ferruh Yigit @ 2016-08-29 9:38 UTC (permalink / raw)
To: Vincent Guo, dev
On 8/29/2016 10:36 AM, Ferruh Yigit wrote:
> Hi Vincent,
>
> On 8/29/2016 3:12 AM, Vincent Guo wrote:
>> Fix pernet calls when HAVE_SIMPLIFIED_PERNET_OPERATIONS is not set.
>>
>> Signed-off-by: Vincent Guo <guopengfei160@163.com>
>> ---
>
> Thank you for the update, patch applies well this time.
>
> A few more small details:
>
> - Patch subject should start with a label/tag, that shows the
> corresponding subsystem. For this patch it is "kni:".
>
> - In patch subject, after label, sentences starts with lowercase, so
> patch subject becomes:
>
> kni: bug fix in module_init and module_exit
>
>
> - "Fixes:" tag is a line in commit log, to reference the commit that
> generated the error. For this patch it is:
>
> Fixes: e6734d21b4e1 ("kni: fix build with kernel 2.6.32")
>
> This line should go above "Signed-off-by", with an empty line between.
>
> - Replying to previous mail thread help others to see the history of the
> patch. the option --in-reply-to of the "git send-email" can be used for
> this.
>
> It is possible to get Message ID of the mail that you want to reply via
> patchwork or from mail client. For example for this patch, you can see
> the message id from: http://dpdk.org/dev/patchwork/patch/15506/
>
> - Adding version number to the patch helps following history. Each
> updated patch increases the version number. "-vN" option of the "git
> format-patch" is useful for this.
>
> - When a new version of the patch sent, the status of the previous
> version should be updated in patchwork as "Superseded". For this case
> previous version is: http://dpdk.org/dev/patchwork/patch/15506/
Correction: http://dpdk.org/dev/patchwork/patch/15315/
>
>
> Thanks,
> ferruh
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] kni: Bug fix in module_init and module_exit
2016-08-29 2:12 [PATCH] Bug fix in module_init and module_exit Vincent Guo
2016-08-29 9:36 ` Ferruh Yigit
@ 2016-09-02 10:23 ` Vincent Guo
2016-09-06 8:02 ` Ferruh Yigit
1 sibling, 1 reply; 6+ messages in thread
From: Vincent Guo @ 2016-09-02 10:23 UTC (permalink / raw)
To: dev
Fix pernet calls when HAVE_SIMPLIFIED_PERNET_OPERATIONS is not set.
Fixes: e6734d21b4e1 ("kni: fix build with kernel 2.6.32")
Signed-off-by: Vincent Guo <guopengfei160@163.com>
---
lib/librte_eal/linuxapp/kni/kni_misc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/librte_eal/linuxapp/kni/kni_misc.c b/lib/librte_eal/linuxapp/kni/kni_misc.c
index 67e9b7d..d7850be 100644
--- a/lib/librte_eal/linuxapp/kni/kni_misc.c
+++ b/lib/librte_eal/linuxapp/kni/kni_misc.c
@@ -194,7 +194,7 @@ out:
#ifdef HAVE_SIMPLIFIED_PERNET_OPERATIONS
unregister_pernet_subsys(&kni_net_ops);
#else
- register_pernet_gen_subsys(&kni_net_id, &kni_net_ops);
+ unregister_pernet_gen_subsys(kni_net_id, &kni_net_ops);
#endif
return rc;
}
@@ -206,7 +206,7 @@ kni_exit(void)
#ifdef HAVE_SIMPLIFIED_PERNET_OPERATIONS
unregister_pernet_subsys(&kni_net_ops);
#else
- register_pernet_gen_subsys(&kni_net_id, &kni_net_ops);
+ unregister_pernet_gen_subsys(kni_net_id, &kni_net_ops);
#endif
KNI_PRINT("####### DPDK kni module unloaded #######\n");
}
--
2.4.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2] kni: Bug fix in module_init and module_exit
2016-09-02 10:23 ` [PATCH v2] kni: " Vincent Guo
@ 2016-09-06 8:02 ` Ferruh Yigit
2016-09-09 14:31 ` Thomas Monjalon
0 siblings, 1 reply; 6+ messages in thread
From: Ferruh Yigit @ 2016-09-06 8:02 UTC (permalink / raw)
To: Vincent Guo, dev; +Cc: Thomas Monjalon
On 9/2/2016 11:23 AM, Vincent Guo wrote:
> Fix pernet calls when HAVE_SIMPLIFIED_PERNET_OPERATIONS is not set.
>
> Fixes: e6734d21b4e1 ("kni: fix build with kernel 2.6.32")
>
> Signed-off-by: Vincent Guo <guopengfei160@163.com>
Only patch subject should start with lowercase, Thomas would you mind
fixing this while applying?
Acked-by Ferruh Yigit <ferruh.yigit@intel.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] kni: Bug fix in module_init and module_exit
2016-09-06 8:02 ` Ferruh Yigit
@ 2016-09-09 14:31 ` Thomas Monjalon
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Monjalon @ 2016-09-09 14:31 UTC (permalink / raw)
To: Vincent Guo; +Cc: Ferruh Yigit, dev
2016-09-06 09:02, Ferruh Yigit:
> On 9/2/2016 11:23 AM, Vincent Guo wrote:
> > Fix pernet calls when HAVE_SIMPLIFIED_PERNET_OPERATIONS is not set.
> >
> > Fixes: e6734d21b4e1 ("kni: fix build with kernel 2.6.32")
> >
> > Signed-off-by: Vincent Guo <guopengfei160@163.com>
>
> Only patch subject should start with lowercase, Thomas would you mind
> fixing this while applying?
>
> Acked-by Ferruh Yigit <ferruh.yigit@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-09-09 14:31 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-29 2:12 [PATCH] Bug fix in module_init and module_exit Vincent Guo
2016-08-29 9:36 ` Ferruh Yigit
2016-08-29 9:38 ` Ferruh Yigit
2016-09-02 10:23 ` [PATCH v2] kni: " Vincent Guo
2016-09-06 8:02 ` Ferruh Yigit
2016-09-09 14:31 ` Thomas Monjalon
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.