From: Jan Kiszka <jan.kiszka@siemens.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "André Draszik" <git@andred.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Kieran Bingham" <kieran@ksquared.org.uk>
Subject: Re: [PATCH] scripts/gdb: make lx-dmesg command work (reliably)
Date: Sun, 28 May 2017 18:29:58 +0200 [thread overview]
Message-ID: <346a4a29-5e49-5ac2-24be-667c641b0e56@siemens.com> (raw)
In-Reply-To: <CAHp75Vczsb-nS2PnNBExYzs3+9aZjr_trEr62JfU--ayn_Vbmg@mail.gmail.com>
On 2017-05-27 16:01, Andy Shevchenko wrote:
> On Fri, May 26, 2017 at 2:12 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
>> On 2017-05-26 13:04, André Draszik wrote:
>
>>> + log_buf_addr = int(str(gdb.parse_and_eval("'printk.c'::log_buf")).split()[0], 16)
>>
>> Overlong line. Please stay pep8 compliant.
>
> What I heard from colleague of mine couple of years ago, they (their
> team) moved to 100 characters in Python scripts because of somehow
> stupid recommendations from last century.
Well, it happens to be in line with the kernel preference for C code. We
can discuss a different style when the kernel relaxes its own. ;)
Jan
--
Siemens AG, Corporate Technology, CT RDA ITP SES-DE
Corporate Competence Center Embedded Linux
next prev parent reply other threads:[~2017-05-28 16:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-26 11:04 [PATCH] scripts/gdb: make lx-dmesg command work (reliably) André Draszik
2017-05-26 11:12 ` Jan Kiszka
2017-05-27 14:01 ` Andy Shevchenko
2017-05-28 16:29 ` Jan Kiszka [this message]
2017-05-26 11:13 ` [PATCH v2] " André Draszik
2017-05-26 11:22 ` [PATCH v3] " André Draszik
2017-05-26 11:28 ` Jan Kiszka
2017-05-31 5:10 ` Kieran Bingham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=346a4a29-5e49-5ac2-24be-667c641b0e56@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=andy.shevchenko@gmail.com \
--cc=git@andred.net \
--cc=kieran@ksquared.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.