[MPTCP] Re: [PATCH 0/4] crypto: refactor sha code

[MPTCP] Re: [PATCH 0/4] crypto: refactor sha code

[Peter Krystad]

[-- Attachment #1: Type: text/plain, Size: 2548 bytes --]


Hi Paolo, Matt - 

On Sat, 2019-11-23 at 09:25 +0100, Matthieu Baerts wrote:
> Hi Peter, Paolo,
> 
> On 22/11/2019 19:16, Peter Krystad wrote:
> > Hi Paolo & Matt -
> > 
> > On Fri, 2019-11-22 at 17:47 +0100, Matthieu Baerts wrote:
> > > Hi Paolo,
> > > 
> > > On 22/11/2019 17:41, Paolo Abeni wrote:
> > > > On Fri, 2019-11-22 at 17:26 +0100, Matthieu Baerts wrote:
> > > > > Hi Paolo,
> > > > > 
> > > > > On 22/11/2019 15:30, Paolo Abeni wrote:
> > > > > > On Fri, 2019-11-22 at 15:26 +0100, Paolo Abeni wrote:
> > > > > > > patch 1/4 refactor the crypto code to make it easier transitioning to
> > > > > > > sha256. It includes feedback from Peter about helper renaming.
> > > > > 
> > > > > Thank you for this new version!
> > > > > 
> > > > > It looks good to me after a very very quick review (but the first patch
> > > > > is hard to read).
> > > > > 
> > > > > > > The following patches update the rest of the tree to the new helper name.
> > > > > > > Overall this should generate 3 conflicts along the rebase.
> > > > > > 
> > > > > > Addendum:
> > > > > > 
> > > > > > The squashed tree is avaialble here:
> > > > > > 
> > > > > > https://github.com/pabeni/mptcp/tree/sha_cleanup_2
> > > > > > 
> > > > > > I verified the new code ensuring that the genrated seq number matched
> > > > > > the expectation of the wireshark dissector.
> > > > > 
> > > > > Great!
> > > > > 
> > > > > Because it looks OK and you checked different stuffs, do you want me to:
> > > > > - replace the tree with the commits from your branch? (if needed, we can
> > > > > of course do other fixes later)
> > > > > - stop the CI job, wait for a proper review and then replace the tree?
> > > > > - or wait for a proper review and then I apply the changes, looking at
> > > > > your branch in case of conflict but doing all of that with TopGit to
> > > > > ease the review? :)
> > > > 
> > > > I think the first 2 options are the better ones.
> > > > 
> > > > It would be nice if someone give this an additional review ;)
> > > 
> > > OK for me!
> > > 
> > > I just paused the CI job then. I hope not for too long :-)
> > 
> > This looks good to me. I'll double-check interop with mptcp.org after it is
> > merged.

mptcp.org interop is OK.

Peter.

> Great, thank you for the patches and the reviews!
> 
> I just recreated the tree using Paolo's branch. Tests are still OK!
> 
> Syncing with the latest net-next now and checking that all commits can 
> still compile.
> 
> Cheers,
> Matt

[MPTCP] Re: [PATCH 0/4] crypto: refactor sha code

[Matthieu Baerts]

[-- Attachment #1: Type: text/plain, Size: 2446 bytes --]

Hi Peter,

On 26/11/2019 02:40, Peter Krystad wrote:
> 
> Hi Paolo, Matt -
> 
> On Sat, 2019-11-23 at 09:25 +0100, Matthieu Baerts wrote:
>> Hi Peter, Paolo,
>>
>> On 22/11/2019 19:16, Peter Krystad wrote:
>>> Hi Paolo & Matt -
>>>
>>> On Fri, 2019-11-22 at 17:47 +0100, Matthieu Baerts wrote:
>>>> Hi Paolo,
>>>>
>>>> On 22/11/2019 17:41, Paolo Abeni wrote:
>>>>> On Fri, 2019-11-22 at 17:26 +0100, Matthieu Baerts wrote:
>>>>>> Hi Paolo,
>>>>>>
>>>>>> On 22/11/2019 15:30, Paolo Abeni wrote:
>>>>>>> On Fri, 2019-11-22 at 15:26 +0100, Paolo Abeni wrote:
>>>>>>>> patch 1/4 refactor the crypto code to make it easier transitioning to
>>>>>>>> sha256. It includes feedback from Peter about helper renaming.
>>>>>>
>>>>>> Thank you for this new version!
>>>>>>
>>>>>> It looks good to me after a very very quick review (but the first patch
>>>>>> is hard to read).
>>>>>>
>>>>>>>> The following patches update the rest of the tree to the new helper name.
>>>>>>>> Overall this should generate 3 conflicts along the rebase.
>>>>>>>
>>>>>>> Addendum:
>>>>>>>
>>>>>>> The squashed tree is avaialble here:
>>>>>>>
>>>>>>> https://github.com/pabeni/mptcp/tree/sha_cleanup_2
>>>>>>>
>>>>>>> I verified the new code ensuring that the genrated seq number matched
>>>>>>> the expectation of the wireshark dissector.
>>>>>>
>>>>>> Great!
>>>>>>
>>>>>> Because it looks OK and you checked different stuffs, do you want me to:
>>>>>> - replace the tree with the commits from your branch? (if needed, we can
>>>>>> of course do other fixes later)
>>>>>> - stop the CI job, wait for a proper review and then replace the tree?
>>>>>> - or wait for a proper review and then I apply the changes, looking at
>>>>>> your branch in case of conflict but doing all of that with TopGit to
>>>>>> ease the review? :)
>>>>>
>>>>> I think the first 2 options are the better ones.
>>>>>
>>>>> It would be nice if someone give this an additional review ;)
>>>>
>>>> OK for me!
>>>>
>>>> I just paused the CI job then. I hope not for too long :-)
>>>
>>> This looks good to me. I'll double-check interop with mptcp.org after it is
>>> merged.
> 
> mptcp.org interop is OK.

Great, thank you for having checked that!

Cheers,
Matt
-- 
Matthieu Baerts | R&D Engineer
matthieu.baerts(a)tessares.net
Tessares SA | Hybrid Access Solutions
www.tessares.net
1 Avenue Jean Monnet, 1348 Louvain-la-Neuve, Belgium

[MPTCP] Re: [PATCH 0/4] crypto: refactor sha code

[Matthieu Baerts]

[-- Attachment #1: Type: text/plain, Size: 2335 bytes --]

Hi Peter, Paolo,

On 22/11/2019 19:16, Peter Krystad wrote:
> 
> Hi Paolo & Matt -
> 
> On Fri, 2019-11-22 at 17:47 +0100, Matthieu Baerts wrote:
>> Hi Paolo,
>>
>> On 22/11/2019 17:41, Paolo Abeni wrote:
>>> On Fri, 2019-11-22 at 17:26 +0100, Matthieu Baerts wrote:
>>>> Hi Paolo,
>>>>
>>>> On 22/11/2019 15:30, Paolo Abeni wrote:
>>>>> On Fri, 2019-11-22 at 15:26 +0100, Paolo Abeni wrote:
>>>>>> patch 1/4 refactor the crypto code to make it easier transitioning to
>>>>>> sha256. It includes feedback from Peter about helper renaming.
>>>>
>>>> Thank you for this new version!
>>>>
>>>> It looks good to me after a very very quick review (but the first patch
>>>> is hard to read).
>>>>
>>>>>> The following patches update the rest of the tree to the new helper name.
>>>>>> Overall this should generate 3 conflicts along the rebase.
>>>>>
>>>>> Addendum:
>>>>>
>>>>> The squashed tree is avaialble here:
>>>>>
>>>>> https://github.com/pabeni/mptcp/tree/sha_cleanup_2
>>>>>
>>>>> I verified the new code ensuring that the genrated seq number matched
>>>>> the expectation of the wireshark dissector.
>>>>
>>>> Great!
>>>>
>>>> Because it looks OK and you checked different stuffs, do you want me to:
>>>> - replace the tree with the commits from your branch? (if needed, we can
>>>> of course do other fixes later)
>>>> - stop the CI job, wait for a proper review and then replace the tree?
>>>> - or wait for a proper review and then I apply the changes, looking at
>>>> your branch in case of conflict but doing all of that with TopGit to
>>>> ease the review? :)
>>>
>>> I think the first 2 options are the better ones.
>>>
>>> It would be nice if someone give this an additional review ;)
>>
>> OK for me!
>>
>> I just paused the CI job then. I hope not for too long :-)
> 
> This looks good to me. I'll double-check interop with mptcp.org after it is
> merged.

Great, thank you for the patches and the reviews!

I just recreated the tree using Paolo's branch. Tests are still OK!

Syncing with the latest net-next now and checking that all commits can 
still compile.

Cheers,
Matt
-- 
Matthieu Baerts | R&D Engineer
matthieu.baerts(a)tessares.net
Tessares SA | Hybrid Access Solutions
www.tessares.net
1 Avenue Jean Monnet, 1348 Louvain-la-Neuve, Belgium

[MPTCP] Re: [PATCH 0/4] crypto: refactor sha code

[Peter Krystad]

[-- Attachment #1: Type: text/plain, Size: 1938 bytes --]


Hi Paolo & Matt -

On Fri, 2019-11-22 at 17:47 +0100, Matthieu Baerts wrote:
> Hi Paolo,
> 
> On 22/11/2019 17:41, Paolo Abeni wrote:
> > On Fri, 2019-11-22 at 17:26 +0100, Matthieu Baerts wrote:
> > > Hi Paolo,
> > > 
> > > On 22/11/2019 15:30, Paolo Abeni wrote:
> > > > On Fri, 2019-11-22 at 15:26 +0100, Paolo Abeni wrote:
> > > > > patch 1/4 refactor the crypto code to make it easier transitioning to
> > > > > sha256. It includes feedback from Peter about helper renaming.
> > > 
> > > Thank you for this new version!
> > > 
> > > It looks good to me after a very very quick review (but the first patch
> > > is hard to read).
> > > 
> > > > > The following patches update the rest of the tree to the new helper name.
> > > > > Overall this should generate 3 conflicts along the rebase.
> > > > 
> > > > Addendum:
> > > > 
> > > > The squashed tree is avaialble here:
> > > > 
> > > > https://github.com/pabeni/mptcp/tree/sha_cleanup_2
> > > > 
> > > > I verified the new code ensuring that the genrated seq number matched
> > > > the expectation of the wireshark dissector.
> > > 
> > > Great!
> > > 
> > > Because it looks OK and you checked different stuffs, do you want me to:
> > > - replace the tree with the commits from your branch? (if needed, we can
> > > of course do other fixes later)
> > > - stop the CI job, wait for a proper review and then replace the tree?
> > > - or wait for a proper review and then I apply the changes, looking at
> > > your branch in case of conflict but doing all of that with TopGit to
> > > ease the review? :)
> > 
> > I think the first 2 options are the better ones.
> > 
> > It would be nice if someone give this an additional review ;)
> 
> OK for me!
> 
> I just paused the CI job then. I hope not for too long :-)

This looks good to me. I'll double-check interop with mptcp.org after it is
merged.

Peter.

> Cheers,
> Matt

[MPTCP] Re: [PATCH 0/4] crypto: refactor sha code

[Matthieu Baerts]

[-- Attachment #1: Type: text/plain, Size: 1781 bytes --]

Hi Paolo,

On 22/11/2019 17:41, Paolo Abeni wrote:
> On Fri, 2019-11-22 at 17:26 +0100, Matthieu Baerts wrote:
>> Hi Paolo,
>>
>> On 22/11/2019 15:30, Paolo Abeni wrote:
>>> On Fri, 2019-11-22 at 15:26 +0100, Paolo Abeni wrote:
>>>> patch 1/4 refactor the crypto code to make it easier transitioning to
>>>> sha256. It includes feedback from Peter about helper renaming.
>>
>> Thank you for this new version!
>>
>> It looks good to me after a very very quick review (but the first patch
>> is hard to read).
>>
>>>> The following patches update the rest of the tree to the new helper name.
>>>> Overall this should generate 3 conflicts along the rebase.
>>>
>>> Addendum:
>>>
>>> The squashed tree is avaialble here:
>>>
>>> https://github.com/pabeni/mptcp/tree/sha_cleanup_2
>>>
>>> I verified the new code ensuring that the genrated seq number matched
>>> the expectation of the wireshark dissector.
>>
>> Great!
>>
>> Because it looks OK and you checked different stuffs, do you want me to:
>> - replace the tree with the commits from your branch? (if needed, we can
>> of course do other fixes later)
>> - stop the CI job, wait for a proper review and then replace the tree?
>> - or wait for a proper review and then I apply the changes, looking at
>> your branch in case of conflict but doing all of that with TopGit to
>> ease the review? :)
> 
> I think the first 2 options are the better ones.
> 
> It would be nice if someone give this an additional review ;)

OK for me!

I just paused the CI job then. I hope not for too long :-)

Cheers,
Matt
-- 
Matthieu Baerts | R&D Engineer
matthieu.baerts(a)tessares.net
Tessares SA | Hybrid Access Solutions
www.tessares.net
1 Avenue Jean Monnet, 1348 Louvain-la-Neuve, Belgium

[MPTCP] Re: [PATCH 0/4] crypto: refactor sha code

[Paolo Abeni]

[-- Attachment #1: Type: text/plain, Size: 1465 bytes --]

On Fri, 2019-11-22 at 17:26 +0100, Matthieu Baerts wrote:
> Hi Paolo,
> 
> On 22/11/2019 15:30, Paolo Abeni wrote:
> > On Fri, 2019-11-22 at 15:26 +0100, Paolo Abeni wrote:
> > > patch 1/4 refactor the crypto code to make it easier transitioning to
> > > sha256. It includes feedback from Peter about helper renaming.
> 
> Thank you for this new version!
> 
> It looks good to me after a very very quick review (but the first patch 
> is hard to read).
> 
> > > The following patches update the rest of the tree to the new helper name.
> > > Overall this should generate 3 conflicts along the rebase.
> > 
> > Addendum:
> > 
> > The squashed tree is avaialble here:
> > 
> > https://github.com/pabeni/mptcp/tree/sha_cleanup_2
> > 
> > I verified the new code ensuring that the genrated seq number matched
> > the expectation of the wireshark dissector.
> 
> Great!
> 
> Because it looks OK and you checked different stuffs, do you want me to:
> - replace the tree with the commits from your branch? (if needed, we can 
> of course do other fixes later)
> - stop the CI job, wait for a proper review and then replace the tree?
> - or wait for a proper review and then I apply the changes, looking at 
> your branch in case of conflict but doing all of that with TopGit to 
> ease the review? :)

I think the first 2 options are the better ones.

It would be nice if someone give this an additional review ;)

Cheers,

Paolo

[MPTCP] Re: [PATCH 0/4] crypto: refactor sha code

[Matthieu Baerts]

[-- Attachment #1: Type: text/plain, Size: 1585 bytes --]

Hi Paolo,

On 22/11/2019 15:30, Paolo Abeni wrote:
> On Fri, 2019-11-22 at 15:26 +0100, Paolo Abeni wrote:
>> patch 1/4 refactor the crypto code to make it easier transitioning to
>> sha256. It includes feedback from Peter about helper renaming.

Thank you for this new version!

It looks good to me after a very very quick review (but the first patch 
is hard to read).

>> The following patches update the rest of the tree to the new helper name.
>> Overall this should generate 3 conflicts along the rebase.
> 
> Addendum:
> 
> The squashed tree is avaialble here:
> 
> https://github.com/pabeni/mptcp/tree/sha_cleanup_2
> 
> I verified the new code ensuring that the genrated seq number matched
> the expectation of the wireshark dissector.

Great!

Because it looks OK and you checked different stuffs, do you want me to:
- replace the tree with the commits from your branch? (if needed, we can 
of course do other fixes later)
- stop the CI job, wait for a proper review and then replace the tree?
- or wait for a proper review and then I apply the changes, looking at 
your branch in case of conflict but doing all of that with TopGit to 
ease the review? :)

Cheers,
Matt

> Cheers,
> 
> Paolo
> _______________________________________________
> mptcp mailing list -- mptcp(a)lists.01.org
> To unsubscribe send an email to mptcp-leave(a)lists.01.org
> 

-- 
Matthieu Baerts | R&D Engineer
matthieu.baerts(a)tessares.net
Tessares SA | Hybrid Access Solutions
www.tessares.net
1 Avenue Jean Monnet, 1348 Louvain-la-Neuve, Belgium

[MPTCP] Re: [PATCH 0/4] crypto: refactor sha code

[Paolo Abeni]

[-- Attachment #1: Type: text/plain, Size: 582 bytes --]

On Fri, 2019-11-22 at 15:26 +0100, Paolo Abeni wrote:
> patch 1/4 refactor the crypto code to make it easier transitioning to
> sha256. It includes feedback from Peter about helper renaming.
> 
> The following patches update the rest of the tree to the new helper name.
> Overall this should generate 3 conflicts along the rebase.

Addendum:

The squashed tree is avaialble here:

https://github.com/pabeni/mptcp/tree/sha_cleanup_2

I verified the new code ensuring that the genrated seq number matched
the expectation of the wireshark dissector.

Cheers,

Paolo