[PATCH] [yocto-ab-helper] Add qemux86, qemux86-64 WIC testimage buildset-config

[PATCH] [yocto-ab-helper] Add qemux86, qemux86-64 WIC testimage buildset-config

[Aaron Chan]

Signed-off-by: Aaron Chan <aaron.chun.yew.chan@intel.com>
---
 config.json | 32 +++++++++++++++++++++++++++++++-
 1 file changed, 31 insertions(+), 1 deletion(-)

diff --git a/config.json b/config.json
index c9dc21e..3c1f989 100644
--- a/config.json
+++ b/config.json
@@ -383,6 +383,36 @@
             ],
             "step1" : {
                 "MACHINE" : "qemux86",
+                "SDKMACHINE" : "x86_64",
+                "DISTRO" : "poky-lsb",
+                "BBTARGETS" : "wic-tools core-image-lsb-sdk",
+                "EXTRACMDS" : [
+                    "wic create directdisk -e core-image-lsb-sdk -o ${BUILDDIR}/tmp/deploy/wic_images/qemux86/directdisk/core-image-lsb-sdk/",
+                    "wic create directdisk-gpt -e core-image-lsb-sdk -o ${BUILDDIR}/tmp/deploy/wic_images/qemux86/directdisk/core-image-lsb-sdk/",
+                    "wic create mkefidisk -e core-image-lsb-sdk -o ${BUILDDIR}/tmp/deploy/wic_images/qemux86/directdisk/core-image-lsb-sdk/"
+                ],
+                "extravars" : [
+                    "IMAGES_FSTYPES += ' wic'"
+                ],
+                "SANITYTARGETS" : "core-image-lsb-sdk:do_testimage"
+            },
+            "step2" : {
+                "MACHINE" : "qemux86-64",
+                "SDKMACHINE" : "x86_64",
+                "DISTRO" : "poky-lsb",
+                "BBTARGETS" : "wic-tools core-image-lsb-sdk",
+                "EXTRACMDS" : [
+                    "wic create directdisk -e core-image-lsb-sdk -o ${BUILDDIR}/tmp/deploy/wic_images/qemux86-64/directdisk/core-image-lsb-sdk/",
+                    "wic create directdisk-gpt -e core-image-lsb-sdk -o ${BUILDDIR}/tmp/deploy/wic_images/qemux86-64/directdisk/core-image-lsb-sdk/",
+                    "wic create mkefdisk -e core-image-lsb-sdk -o ${BUILDDIR}/tmp/deploy/wic_images/qemux86-64/directdisk/core-image-lsb-sdk/"
+                ],
+                "extravars" : [
+                    "IMAGES_FSTYPES += ' wic'"
+                ],
+                "SANITYTARGETS" : "core-image-lsb-sdk:do_testimage"
+            },
+            "step3" : {
+                "MACHINE" : "qemux86",
                 "BBTARGETS" : "wic-tools core-image-sato",
                 "EXTRACMDS" : [
                     "wic create directdisk -e core-image-sato -o ${BUILDDIR}/tmp/deploy/wic_images/qemux86/directdisk/core-image-sato/",
@@ -390,7 +420,7 @@
                     "wic create mkefidisk -e core-image-sato -o ${BUILDDIR}/tmp/deploy/wic_images/qemux86/directdisk/core-image-sato/"
                 ]
             },
-            "step2" : {
+            "step4" : {
                 "MACHINE" : "genericx86",
                 "BBTARGETS" : "wic-tools core-image-sato",
                 "EXTRACMDS" : [
-- 
2.7.4

Re: [PATCH] [yocto-ab-helper] Add qemux86, qemux86-64 WIC testimage buildset-config

[Richard Purdie]

On Tue, 2018-06-26 at 16:51 +0800, Aaron Chan wrote:
> Signed-off-by: Aaron Chan <aaron.chun.yew.chan@intel.com>
> ---
>  config.json | 32 +++++++++++++++++++++++++++++++-
>  1 file changed, 31 insertions(+), 1 deletion(-)

This patch looks like it might be correct. I say "might" as your commit
message tells me what you did (kind of) but not why.

I say "kind of" as you're using core-image-lsb-sdk and poky-lsb here,
probably for a good reason but you don't say why.

The key thing I need to know is what extra testing this provides that
isn't already covered elsewhere on the autobuilder - why do we need to
spend the time testing this?

Can you resend with a better description of why we need to do this
please?

Cheers,

Richard

> 

Re: [PATCH] [yocto-ab-helper] Add qemux86, qemux86-64 WIC testimage buildset-config

[Chan, Aaron Chun Yew]

Hi Richard

Fundamentally we are performing  the QA release for Yocto with this buildset config covering qemux86, qemux86-64 on core-image-lsb-sdk image.
If the community feels that we have sufficient coverage which is required, we can omit this support from future QA cycles. 

If this is still "good to have" I will resend a "better description" in the next submission.

Cheers,
Aaron

-----Original Message-----
From: richard.purdie@linuxfoundation.org [mailto:richard.purdie@linuxfoundation.org] 
Sent: Tuesday, June 26, 2018 6:30 PM
To: Chan, Aaron Chun Yew <aaron.chun.yew.chan@intel.com>; yocto@yoctoproject.org; Yeoh, Ee Peng <ee.peng.yeoh@intel.com>
Subject: Re: [PATCH] [yocto-ab-helper] Add qemux86, qemux86-64 WIC testimage buildset-config

On Tue, 2018-06-26 at 16:51 +0800, Aaron Chan wrote:
> Signed-off-by: Aaron Chan <aaron.chun.yew.chan@intel.com>
> ---
>  config.json | 32 +++++++++++++++++++++++++++++++-
>  1 file changed, 31 insertions(+), 1 deletion(-)

This patch looks like it might be correct. I say "might" as your commit message tells me what you did (kind of) but not why.

I say "kind of" as you're using core-image-lsb-sdk and poky-lsb here, probably for a good reason but you don't say why.

The key thing I need to know is what extra testing this provides that isn't already covered elsewhere on the autobuilder - why do we need to spend the time testing this?

Can you resend with a better description of why we need to do this please?

Cheers,

Richard

>