All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Arnd Bergmann" <arnd@arndb.de>
To: "Lee Jones" <lee@kernel.org>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Nathan Chancellor" <nathan@kernel.org>,
	"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	mripard@kernel.org, "Thomas Zimmermann" <tzimmermann@suse.de>,
	"Dave Airlie" <airlied@gmail.com>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"Nick Desaulniers" <ndesaulniers@google.com>,
	"Tom Rix" <trix@redhat.com>,
	"Harry Wentland" <harry.wentland@amd.com>,
	"Leo Li" <sunpeng.li@amd.com>,
	"Rodrigo Siqueira" <Rodrigo.Siqueira@amd.com>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Christian König" <christian.koenig@amd.com>,
	Xinhui.Pan@amd.com
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, llvm@lists.linux.dev,
	amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2 2/2] Kconfig.debug: Provide a little extra FRAME_WARN leeway when KASAN is enabled
Date: Fri, 25 Nov 2022 14:57:55 +0100	[thread overview]
Message-ID: <347df991-4755-4f11-b530-4d0e3994a9db@app.fastmail.com> (raw)
In-Reply-To: <Y4DFx20YXDLcuVJm@google.com>

On Fri, Nov 25, 2022, at 14:40, Lee Jones wrote:
> On Fri, 25 Nov 2022, Lee Jones wrote:
>
>> When enabled, KASAN enlarges function's stack-frames.  Pushing quite a
>> few over the current threshold.  This can mainly be seen on 32-bit
>> architectures where the present limit (when !GCC) is a lowly
>> 1024-Bytes.
>> 
>> Signed-off-by: Lee Jones <lee@kernel.org>
>> ---
>>  lib/Kconfig.debug | 1 +
>>  1 file changed, 1 insertion(+)
>> 
>> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
>> index c3c0b077ade33..82d475168db95 100644
>> --- a/lib/Kconfig.debug
>> +++ b/lib/Kconfig.debug
>> @@ -399,6 +399,7 @@ config FRAME_WARN
>>  	default 2048 if GCC_PLUGIN_LATENT_ENTROPY
>>  	default 2048 if PARISC
>>  	default 1536 if (!64BIT && XTENSA)
>> +	default 1280 if KASAN && !64BIT
>>  	default 1024 if !64BIT
>>  	default 2048 if 64BIT
>>  	help
>
> Note this also fixes 61 warnings when
>
>   (GCC && !GCC_PLUGIN_LATENT_ENTROPY)
>
> ... which as Arnd says should not be enabled by default.  We'll
> address that issue once this set has been applied.

Thanks a lot for checking this!

Reviewed-by: Arnd Bergmann <arnd@arndb.de>

WARNING: multiple messages have this Message-ID (diff)
From: "Arnd Bergmann" <arnd@arndb.de>
To: "Lee Jones" <lee@kernel.org>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Nathan Chancellor" <nathan@kernel.org>,
	"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	mripard@kernel.org, "Thomas Zimmermann" <tzimmermann@suse.de>,
	"Dave Airlie" <airlied@gmail.com>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"Nick Desaulniers" <ndesaulniers@google.com>,
	"Tom Rix" <trix@redhat.com>,
	"Harry Wentland" <harry.wentland@amd.com>,
	"Leo Li" <sunpeng.li@amd.com>,
	"Rodrigo Siqueira" <Rodrigo.Siqueira@amd.com>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Christian König" <christian.koenig@amd.com>,
	Xinhui.Pan@amd.com
Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	llvm@lists.linux.dev, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/2] Kconfig.debug: Provide a little extra FRAME_WARN leeway when KASAN is enabled
Date: Fri, 25 Nov 2022 14:57:55 +0100	[thread overview]
Message-ID: <347df991-4755-4f11-b530-4d0e3994a9db@app.fastmail.com> (raw)
In-Reply-To: <Y4DFx20YXDLcuVJm@google.com>

On Fri, Nov 25, 2022, at 14:40, Lee Jones wrote:
> On Fri, 25 Nov 2022, Lee Jones wrote:
>
>> When enabled, KASAN enlarges function's stack-frames.  Pushing quite a
>> few over the current threshold.  This can mainly be seen on 32-bit
>> architectures where the present limit (when !GCC) is a lowly
>> 1024-Bytes.
>> 
>> Signed-off-by: Lee Jones <lee@kernel.org>
>> ---
>>  lib/Kconfig.debug | 1 +
>>  1 file changed, 1 insertion(+)
>> 
>> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
>> index c3c0b077ade33..82d475168db95 100644
>> --- a/lib/Kconfig.debug
>> +++ b/lib/Kconfig.debug
>> @@ -399,6 +399,7 @@ config FRAME_WARN
>>  	default 2048 if GCC_PLUGIN_LATENT_ENTROPY
>>  	default 2048 if PARISC
>>  	default 1536 if (!64BIT && XTENSA)
>> +	default 1280 if KASAN && !64BIT
>>  	default 1024 if !64BIT
>>  	default 2048 if 64BIT
>>  	help
>
> Note this also fixes 61 warnings when
>
>   (GCC && !GCC_PLUGIN_LATENT_ENTROPY)
>
> ... which as Arnd says should not be enabled by default.  We'll
> address that issue once this set has been applied.

Thanks a lot for checking this!

Reviewed-by: Arnd Bergmann <arnd@arndb.de>

WARNING: multiple messages have this Message-ID (diff)
From: "Arnd Bergmann" <arnd@arndb.de>
To: "Lee Jones" <lee@kernel.org>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Nathan Chancellor" <nathan@kernel.org>,
	"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	mripard@kernel.org, "Thomas Zimmermann" <tzimmermann@suse.de>,
	"Dave Airlie" <airlied@gmail.com>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"Nick Desaulniers" <ndesaulniers@google.com>,
	"Tom Rix" <trix@redhat.com>,
	"Harry Wentland" <harry.wentland@amd.com>,
	"Leo Li" <sunpeng.li@amd.com>,
	"Rodrigo Siqueira" <Rodrigo.Siqueira@amd.com>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Christian König" <christian.koenig@amd.com>,
	Xinhui.Pan@amd.com
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, llvm@lists.linux.dev,
	amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2 2/2] Kconfig.debug: Provide a little extra FRAME_WARN leeway when KASAN is enabled
Date: Fri, 25 Nov 2022 14:57:55 +0100	[thread overview]
Message-ID: <347df991-4755-4f11-b530-4d0e3994a9db@app.fastmail.com> (raw)
In-Reply-To: <Y4DFx20YXDLcuVJm@google.com>

On Fri, Nov 25, 2022, at 14:40, Lee Jones wrote:
> On Fri, 25 Nov 2022, Lee Jones wrote:
>
>> When enabled, KASAN enlarges function's stack-frames.  Pushing quite a
>> few over the current threshold.  This can mainly be seen on 32-bit
>> architectures where the present limit (when !GCC) is a lowly
>> 1024-Bytes.
>> 
>> Signed-off-by: Lee Jones <lee@kernel.org>
>> ---
>>  lib/Kconfig.debug | 1 +
>>  1 file changed, 1 insertion(+)
>> 
>> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
>> index c3c0b077ade33..82d475168db95 100644
>> --- a/lib/Kconfig.debug
>> +++ b/lib/Kconfig.debug
>> @@ -399,6 +399,7 @@ config FRAME_WARN
>>  	default 2048 if GCC_PLUGIN_LATENT_ENTROPY
>>  	default 2048 if PARISC
>>  	default 1536 if (!64BIT && XTENSA)
>> +	default 1280 if KASAN && !64BIT
>>  	default 1024 if !64BIT
>>  	default 2048 if 64BIT
>>  	help
>
> Note this also fixes 61 warnings when
>
>   (GCC && !GCC_PLUGIN_LATENT_ENTROPY)
>
> ... which as Arnd says should not be enabled by default.  We'll
> address that issue once this set has been applied.

Thanks a lot for checking this!

Reviewed-by: Arnd Bergmann <arnd@arndb.de>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-11-25 13:58 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-25 12:07 [PATCH v2 0/2] Fix a bunch of allmodconfig errors Lee Jones
2022-11-25 12:07 ` Lee Jones
2022-11-25 12:07 ` Lee Jones
2022-11-25 12:07 ` [PATCH v2 1/2] drm/amdgpu: Temporarily disable broken Clang builds due to blown stack-frame Lee Jones
2022-11-25 12:07   ` Lee Jones
2022-11-25 12:07   ` Lee Jones
2022-11-25 12:11   ` Arnd Bergmann
2022-11-25 12:11     ` Arnd Bergmann
2022-11-25 12:11     ` Arnd Bergmann
2022-11-28  5:52   ` Nathan Chancellor
2022-11-28  5:52     ` Nathan Chancellor
2022-11-28  5:52     ` Nathan Chancellor
2022-11-28  5:52     ` Nathan Chancellor
2022-11-25 12:07 ` [PATCH v2 2/2] Kconfig.debug: Provide a little extra FRAME_WARN leeway when KASAN is enabled Lee Jones
2022-11-25 12:07   ` Lee Jones
2022-11-25 12:07   ` Lee Jones
2022-11-25 13:40   ` Lee Jones
2022-11-25 13:40     ` Lee Jones
2022-11-25 13:40     ` Lee Jones
2022-11-25 13:57     ` Arnd Bergmann [this message]
2022-11-25 13:57       ` Arnd Bergmann
2022-11-25 13:57       ` Arnd Bergmann
2022-11-28  5:53   ` Nathan Chancellor
2022-11-28  5:53     ` Nathan Chancellor
2022-11-28  5:53     ` Nathan Chancellor
2022-11-28  5:53     ` Nathan Chancellor
2022-11-26  0:13 ` [PATCH v2 0/2] Fix a bunch of allmodconfig errors Andrew Morton
2022-11-26  0:13   ` Andrew Morton
2022-11-26  0:13   ` Andrew Morton
2022-11-26  0:13   ` Andrew Morton
2022-11-28  7:47   ` Lee Jones
2022-11-28  7:47     ` Lee Jones
2022-11-28  7:47     ` Lee Jones
2022-11-28  7:47     ` Lee Jones
2022-11-26  0:17 ` Andrew Morton
2022-11-26  0:17   ` Andrew Morton
2022-11-26  0:17   ` Andrew Morton
2022-11-26  0:17   ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=347df991-4755-4f11-b530-4d0e3994a9db@app.fastmail.com \
    --to=arnd@arndb.de \
    --cc=Rodrigo.Siqueira@amd.com \
    --cc=Xinhui.Pan@amd.com \
    --cc=airlied@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=christian.koenig@amd.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=harry.wentland@amd.com \
    --cc=lee@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=nathan@kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=sunpeng.li@amd.com \
    --cc=trix@redhat.com \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.