All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Trahe, Fiona" <fiona.trahe@intel.com>
To: Shally Verma <shally.verma@caviumnetworks.com>,
	"De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
Cc: "Doherty, Declan" <declan.doherty@intel.com>,
	"pathreya@caviumnetworks.com" <pathreya@caviumnetworks.com>,
	"ssahu@caviumnetworks.com" <ssahu@caviumnetworks.com>,
	"agupta@caviumnetworks.com" <agupta@caviumnetworks.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	Sunila Sahu <sunila.sahu@caviumnetworks.com>,
	Ashish Gupta <ashish.gupta@caviumnetworks.com>
Subject: Re: [PATCH v2 2/6] lib/cryptodev: add asym op support in cryptodev
Date: Tue, 8 May 2018 14:43:57 +0000	[thread overview]
Message-ID: <348A99DA5F5B7549AA880327E580B4358947CD2B@IRSMSX103.ger.corp.intel.com> (raw)
In-Reply-To: <1522927489-23668-3-git-send-email-shally.verma@caviumnetworks.com>

Hi Shally,


> -----Original Message-----
> From: Shally Verma [mailto:shally.verma@caviumnetworks.com]
> Sent: Thursday, April 5, 2018 12:25 PM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Cc: Doherty, Declan <declan.doherty@intel.com>; Trahe, Fiona <fiona.trahe@intel.com>;
> pathreya@caviumnetworks.com; ssahu@caviumnetworks.com; agupta@caviumnetworks.com;
> dev@dpdk.org; Sunila Sahu <sunila.sahu@caviumnetworks.com>; Ashish Gupta
> <ashish.gupta@caviumnetworks.com>
> Subject: [PATCH v2 2/6] lib/cryptodev: add asym op support in cryptodev
> 
>  struct rte_cryptodev_sym_session *
>  rte_cryptodev_sym_session_create(struct rte_mempool *mp)
>  {
>  	struct rte_cryptodev_sym_session *sess;
> 
>  	/* Allocate a session structure from the session pool */
> -	if (rte_mempool_get(mp, (void **)&sess)) {
> +	if (rte_mempool_get(mp, (void *)&sess)) {
[Fiona] Are you introducing a bug here?
The fn expects a void **
Also this will need rebasing - the latest code has an extra byte.

  parent reply	other threads:[~2018-05-08 14:44 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-05 11:24 [PATCH v2 0/6] crypto: add asym crypto support Shally Verma
2018-04-05 11:24 ` [PATCH v2 1/6] lib/cryptodev: add asymmetric algos in cryptodev Shally Verma
2018-05-08 15:08   ` Trahe, Fiona
2018-04-05 11:24 ` [PATCH v2 2/6] lib/cryptodev: add asym op support " Shally Verma
2018-05-08 10:51   ` Trahe, Fiona
2018-05-08 10:58     ` Verma, Shally
2018-05-08 18:32       ` De Lara Guarch, Pablo
2018-05-08 14:43   ` Trahe, Fiona [this message]
2018-05-09  7:33     ` Verma, Shally
2018-04-05 11:24 ` [PATCH v2 3/6] lib/cryptodev: add asymmetric crypto capability " Shally Verma
2018-05-08 15:00   ` Trahe, Fiona
2018-05-09  7:34     ` Verma, Shally
2018-04-05 11:24 ` [PATCH v2 4/6] test/crypto: add unit testcase for asym crypto Shally Verma
2018-04-05 11:24 ` [PATCH v2 5/6] crypto/openssl: add asym crypto support Shally Verma
2018-05-09 10:33   ` Trahe, Fiona
2018-05-09 10:56     ` Verma, Shally
2018-04-05 11:24 ` [PATCH v2 6/6] doc: add asym crypto in cryptodev programmer guide Shally Verma
2018-04-11 12:37 ` [PATCH v2 0/6] crypto: add asym crypto support De Lara Guarch, Pablo
2018-04-11 14:14   ` Verma, Shally
2018-04-20  6:16 ` Verma, Shally

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=348A99DA5F5B7549AA880327E580B4358947CD2B@IRSMSX103.ger.corp.intel.com \
    --to=fiona.trahe@intel.com \
    --cc=agupta@caviumnetworks.com \
    --cc=ashish.gupta@caviumnetworks.com \
    --cc=declan.doherty@intel.com \
    --cc=dev@dpdk.org \
    --cc=pablo.de.lara.guarch@intel.com \
    --cc=pathreya@caviumnetworks.com \
    --cc=shally.verma@caviumnetworks.com \
    --cc=ssahu@caviumnetworks.com \
    --cc=sunila.sahu@caviumnetworks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.