* [Qemu-devel] [PATCH] replay: finish record/replay before closing the disks
@ 2018-03-19 9:25 Pavel Dovgalyuk
2018-03-19 15:53 ` Paolo Bonzini
0 siblings, 1 reply; 2+ messages in thread
From: Pavel Dovgalyuk @ 2018-03-19 9:25 UTC (permalink / raw)
To: qemu-devel; +Cc: pbonzini, maria.klimushenkova, dovgaluk, pavel.dovgaluk
After recent updates block devices cannot be closed on qemu exit.
This happens due to the block request polling when replay is not finished.
Therefore now we stop execution recording before closing the block devices.
Signed-off-by: Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru>
---
replay/replay.c | 2 ++
vl.c | 1 +
2 files changed, 3 insertions(+)
diff --git a/replay/replay.c b/replay/replay.c
index 8228261..58a986f 100644
--- a/replay/replay.c
+++ b/replay/replay.c
@@ -366,6 +366,8 @@ void replay_finish(void)
g_free(replay_snapshot);
replay_snapshot = NULL;
+ replay_mode = REPLAY_MODE_NONE;
+
replay_finish_events();
}
diff --git a/vl.c b/vl.c
index e8bebda..f4d9153 100644
--- a/vl.c
+++ b/vl.c
@@ -4733,6 +4733,7 @@ int main(int argc, char **argv, char **envp)
/* No more vcpu or device emulation activity beyond this point */
vm_shutdown();
+ replay_finish();
bdrv_close_all();
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] replay: finish record/replay before closing the disks
2018-03-19 9:25 [Qemu-devel] [PATCH] replay: finish record/replay before closing the disks Pavel Dovgalyuk
@ 2018-03-19 15:53 ` Paolo Bonzini
0 siblings, 0 replies; 2+ messages in thread
From: Paolo Bonzini @ 2018-03-19 15:53 UTC (permalink / raw)
To: Pavel Dovgalyuk, qemu-devel; +Cc: maria.klimushenkova, dovgaluk
On 19/03/2018 10:25, Pavel Dovgalyuk wrote:
> After recent updates block devices cannot be closed on qemu exit.
> This happens due to the block request polling when replay is not finished.
> Therefore now we stop execution recording before closing the block devices.
>
> Signed-off-by: Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru>
> ---
> replay/replay.c | 2 ++
> vl.c | 1 +
> 2 files changed, 3 insertions(+)
>
> diff --git a/replay/replay.c b/replay/replay.c
> index 8228261..58a986f 100644
> --- a/replay/replay.c
> +++ b/replay/replay.c
> @@ -366,6 +366,8 @@ void replay_finish(void)
> g_free(replay_snapshot);
> replay_snapshot = NULL;
>
> + replay_mode = REPLAY_MODE_NONE;
> +
> replay_finish_events();
> }
>
> diff --git a/vl.c b/vl.c
> index e8bebda..f4d9153 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -4733,6 +4733,7 @@ int main(int argc, char **argv, char **envp)
>
> /* No more vcpu or device emulation activity beyond this point */
> vm_shutdown();
> + replay_finish();
>
> bdrv_close_all();
>
>
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-03-19 15:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-19 9:25 [Qemu-devel] [PATCH] replay: finish record/replay before closing the disks Pavel Dovgalyuk
2018-03-19 15:53 ` Paolo Bonzini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.