All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: "Gimcuan Hui" <gimcuan@gmail.com>,
	"Radim Krčmář" <rkrcmar@redhat.com>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Ingo Molnar" <mingo@redhat.com>,
	"H. Peter Anvin" <hpa@zytor.com>
Cc: x86@kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: kvm: mmu: make kvm_mmu_clear_all_pte_masks static
Date: Mon, 13 Nov 2017 16:17:42 +0100	[thread overview]
Message-ID: <34b5d42d-781f-4a2b-19a7-268eeffb87e4@redhat.com> (raw)
In-Reply-To: <20171103185246.5999-1-gimcuan@gmail.com>

On 03/11/2017 19:52, Gimcuan Hui wrote:
> The kvm_mmu_clear_all_pte_masks interface is only used by kvm_mmu_module_init
> locally, and does not need to be called by other module, make it static.
> 
> This patch cleans up sparse warning:
> symbol 'kvm_mmu_clear_all_pte_masks' was not declared. Should it be static?
> 
> Signed-off-by: Gimcuan Hui <gimcuan@gmail.com>
> ---
>  arch/x86/kvm/mmu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c
> index 7a69cf053711..6b247d64926e 100644
> --- a/arch/x86/kvm/mmu.c
> +++ b/arch/x86/kvm/mmu.c
> @@ -367,7 +367,7 @@ void kvm_mmu_set_mask_ptes(u64 user_mask, u64 accessed_mask,
>  }
>  EXPORT_SYMBOL_GPL(kvm_mmu_set_mask_ptes);
>  
> -void kvm_mmu_clear_all_pte_masks(void)
> +static void kvm_mmu_clear_all_pte_masks(void)
>  {
>  	shadow_user_mask = 0;
>  	shadow_accessed_mask = 0;
> 

Queued, thanks.

Paolo

      parent reply	other threads:[~2017-11-13 15:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-03 18:52 [PATCH] x86: kvm: mmu: make kvm_mmu_clear_all_pte_masks static Gimcuan Hui
2017-11-06 11:59 ` David Hildenbrand
2017-11-13 15:17 ` Paolo Bonzini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=34b5d42d-781f-4a2b-19a7-268eeffb87e4@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=gimcuan@gmail.com \
    --cc=hpa@zytor.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=rkrcmar@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.