All of lore.kernel.org
 help / color / mirror / Atom feed
* [vmwgfx] crash upon vmw_open_channel() when booting on Oracle VM VirtualBox
@ 2023-01-28 11:44 Tetsuo Handa
  2023-01-29  6:00 ` Zack Rusin
  0 siblings, 1 reply; 4+ messages in thread
From: Tetsuo Handa @ 2023-01-28 11:44 UTC (permalink / raw)
  To: Zack Rusin, VMware Graphics Reviewers; +Cc: DRI

Hello.

I noticed that a kernel built with vmwgfx driver fails to boot a Linux guest
on Oracle VM VirtualBox 7.0.4 on Windows 11 on DELL Inspiron 14 5420.
I didn't notice this problem when I booted an older kernel on an older version
of Oracle VM VirtualBox on Windows 8.1 on an older PC.

The location that crashes is

        VMW_PORT(VMW_PORT_CMD_OPEN_CHANNEL,
                (protocol | GUESTMSG_FLAG_COOKIE), si, di,
                0,
                VMW_HYPERVISOR_MAGIC,
                eax, ebx, ecx, edx, si, di);

in vmw_open_channel(). It might be that some changes in VirtualBox side
is conflicting with how VMware tries to test if the guest is VMware.
How can I debug this problem?

Kernel config is at https://I-love.SAKURA.ne.jp/tmp/config-6.2.0-rc5-20230128 .

$ ./scripts/faddr2line vmlinux vmw_host_printf+0x31e/0x600
vmw_host_printf+0x31e/0x600:
vmw_open_channel at drivers/gpu/drm/vmwgfx/vmwgfx_msg.c:109
(inlined by) vmw_host_printf at drivers/gpu/drm/vmwgfx/vmwgfx_msg.c:530

----------------------------------------
[    0.000000][    T0] Linux version 6.2.0-rc5-00199-g5af6ce704936 (root@fuzz) (Ubuntu clang version 14.0.0-1ubuntu1, Ubuntu LLD 14.0.0) #937 SMP PREEMPT_DYNAMIC Sat Jan 28 20:13:16 JST 2023
(...snipped...)
[   10.701088][    T1] Linux agpgart interface v0.103
[   10.709269][    T1] ACPI: bus type drm_connector registered
[   10.715161][    T1] vmwgfx 0000:00:02.0: vgaarb: deactivate vga console
[   10.722965][    T1] Console: switching to colour dummy device 80x25
[   10.751077][    T1] vmwgfx 0000:00:02.0: [drm] FIFO at 0x00000000f0000000 size is 2048 kiB
[   10.751077][    T1] vmwgfx 0000:00:02.0: [drm] VRAM at 0x00000000e0000000 size is 16384 kiB
[   10.751077][    T1] vmwgfx 0000:00:02.0: [drm] Running on SVGA version 2.
[   10.751077][    T1] vmwgfx 0000:00:02.0: [drm] Capabilities: rect copy, cursor, cursor bypass, cursor bypass 2, alpha cursor, extended fifo, pitchlock, irq mask, gmr, traces, gmr2, screen object 2, command buffers, 
[   10.751077][    T1] vmwgfx 0000:00:02.0: [drm] DMA map mode: Caching DMA mappings.
[   10.751077][    T1] vmwgfx 0000:00:02.0: [drm] Legacy memory limits: VRAM = 16384 kB, FIFO = 2048 kB, surface = 507904 kB
[   10.751077][    T1] vmwgfx 0000:00:02.0: [drm] MOB limits: max mob size = 0 kB, max mob pages = 0
[   10.751077][    T1] vmwgfx 0000:00:02.0: [drm] Max GMR ids is 8192
[   10.751077][    T1] vmwgfx 0000:00:02.0: [drm] Max number of GMR pages is 1048576
[   10.751077][    T1] vmwgfx 0000:00:02.0: [drm] Maximum display memory size is 16384 kiB
[   10.765114][    T1] vmwgfx 0000:00:02.0: [drm] Screen Object display unit initialized
[   10.774544][    T1] vmwgfx 0000:00:02.0: [drm] Fifo max 0x00200000 min 0x00001000 cap 0x00000355
[   10.779261][    T1] vmwgfx 0000:00:02.0: [drm] Using command buffers with DMA pool.
[   10.779261][    T1] vmwgfx 0000:00:02.0: [drm] Available shader model: Legacy.
[   10.779261][    T1] BUG: unable to handle page fault for address: 00000000c943508a
[   10.779261][    T1] #PF: supervisor write access in kernel mode
[   10.779261][    T1] #PF: error_code(0x0002) - not-present page
[   10.779261][    T1] PGD 0 P4D 0 
[   10.779261][    T1] Oops: 0002 [#1] PREEMPT SMP
[   10.779261][    T1] CPU: 1 PID: 1 Comm: swapper/0 Not tainted 6.2.0-rc5-00199-g5af6ce704936 #937
[   10.779261][    T1] Hardware name: innotek GmbH VirtualBox/VirtualBox, BIOS VirtualBox 12/01/2006
[   10.779261][    T1] RIP: 0010:vmw_host_printf+0x31e/0x600
[   10.779261][    T1] Code: 53 08 48 89 43 18 4c 89 63 20 bb 52 50 43 c9 b8 68 58 4d 56 b9 1e 00 00 00 31 f6 31 ff 31 d2 66 ba 58 56 ed 49 89 cc 49 89 d7 <48> 89 73 38 48 89 7b 40 49 c7 06 00 00 00 00 49 c7 46 08 00 00 00
[   10.779261][    T1] RSP: 0000:ffff8881001c2fe0 EFLAGS: 00010246
[   10.779261][    T1] RAX: 00000000ffffffff RBX: 00000000c9435052 RCX: 000000000000001e
[   10.779261][    T1] RDX: 0000000000005658 RSI: 0000000000000000 RDI: 0000000000000000
[   10.779261][    T1] RBP: ffff8881001c3130 R08: ffffffff864b246e R09: ffffffff90bf0700
[   10.779261][    T1] R10: 0000000000000012 R11: ffff8881208d8000 R12: 000000000000001e
[   10.779261][    T1] R13: 0000000000000000 R14: ffff8881208d8b10 R15: 0000000000005658
[   10.779261][    T1] FS:  0000000000000000(0000) GS:ffff88821fa00000(0000) knlGS:0000000000000000
[   10.779261][    T1] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[   10.779261][    T1] CR2: 00000000c943508a CR3: 0000000012029000 CR4: 00000000000106e0
[   10.779261][    T1] Call Trace:
[   10.779261][    T1]  <TASK>
[   10.779261][    T1]  ? kmsan_get_shadow_origin_ptr+0x49/0xa0
[   10.779261][    T1]  vmw_probe+0x6ecb/0x73e0
[   10.779261][    T1]  ? rpm_resume+0x1730/0x2d70
[   10.779261][    T1]  ? kmsan_get_shadow_origin_ptr+0x49/0xa0
[   10.779261][    T1]  ? preempt_count_sub+0xf8/0x330
[   10.779261][    T1]  ? _raw_spin_unlock_irqrestore+0x78/0xb0
[   10.779261][    T1]  ? kmsan_get_shadow_origin_ptr+0x49/0xa0
[   10.779261][    T1]  ? vmw_write+0x280/0x280
[   10.779261][    T1]  pci_device_probe+0xb1d/0xf00
[   10.779261][    T1]  ? pci_uevent+0x820/0x820
[   10.779261][    T1]  really_probe+0x6a2/0x1540
[   10.779261][    T1]  ? kmsan_internal_unpoison_memory+0x10/0x20
[   10.779261][    T1]  __driver_probe_device+0x3e9/0x530
[   10.779261][    T1]  driver_probe_device+0xaf/0x850
[   10.779261][    T1]  ? __msan_instrument_asm_store+0xb5/0xe0
[   10.779261][    T1]  __driver_attach+0x8d8/0xc90
[   10.779261][    T1]  bus_for_each_dev+0x20e/0x340
[   10.779261][    T1]  ? driver_attach+0xb0/0xb0
[   10.779261][    T1]  driver_attach+0x89/0xb0
[   10.779261][    T1]  bus_add_driver+0x692/0xc70
[   10.779261][    T1]  driver_register+0x478/0x8d0
[   10.779261][    T1]  __pci_register_driver+0x25d/0x3f0
[   10.779261][    T1]  ? i915_vma_resource_module_init+0xf0/0xf0
[   10.779261][    T1]  drm_pci_register_driver+0x72/0xa0
[   10.779261][    T1]  vmw_pci_driver_init+0x21/0x30
[   10.779261][    T1]  do_one_initcall+0x352/0x9b0
[   10.779261][    T1]  ? filter_irq_stacks+0x1d4/0x230
[   10.779261][    T1]  ? __stack_depot_save+0x21/0x4b0
[   10.779261][    T1]  ? kmsan_get_shadow_origin_ptr+0x49/0xa0
[   10.779261][    T1]  ? kmsan_get_shadow_origin_ptr+0x49/0xa0
[   10.779261][    T1]  ? __msan_metadata_ptr_for_load_1+0x20/0x30
[   10.779261][    T1]  ? parse_args+0x1763/0x1840
[   10.779261][    T1]  ? kmsan_get_shadow_origin_ptr+0x49/0xa0
[   10.779261][    T1]  ? i915_vma_resource_module_init+0xf0/0xf0
[   10.779261][    T1]  do_initcall_level+0x1ed/0x3e0
[   10.779261][    T1]  do_initcalls+0x129/0x1e0
[   10.779261][    T1]  ? smp_cpu_index_default+0x170/0x170
[   10.779261][    T1]  do_basic_setup+0x22/0x30
[   10.779261][    T1]  kernel_init_freeable+0x324/0x4e0
[   10.779261][    T1]  ? rest_init+0x2d0/0x2d0
[   10.779261][    T1]  kernel_init+0x33/0x860
[   10.779261][    T1]  ? rest_init+0x2d0/0x2d0
[   10.779261][    T1]  ret_from_fork+0x1f/0x30
[   10.779261][    T1]  </TASK>
[   10.779261][    T1] Modules linked in:
[   10.779261][    T1] CR2: 00000000c943508a
[   10.779261][    T1] ---[ end trace 0000000000000000 ]---
[   10.779261][    T1] RIP: 0010:vmw_host_printf+0x31e/0x600
[   10.779261][    T1] Code: 53 08 48 89 43 18 4c 89 63 20 bb 52 50 43 c9 b8 68 58 4d 56 b9 1e 00 00 00 31 f6 31 ff 31 d2 66 ba 58 56 ed 49 89 cc 49 89 d7 <48> 89 73 38 48 89 7b 40 49 c7 06 00 00 00 00 49 c7 46 08 00 00 00
[   10.779261][    T1] RSP: 0000:ffff8881001c2fe0 EFLAGS: 00010246
[   10.779261][    T1] RAX: 00000000ffffffff RBX: 00000000c9435052 RCX: 000000000000001e
[   10.779261][    T1] RDX: 0000000000005658 RSI: 0000000000000000 RDI: 0000000000000000
[   10.779261][    T1] RBP: ffff8881001c3130 R08: ffffffff864b246e R09: ffffffff90bf0700
[   10.779261][    T1] R10: 0000000000000012 R11: ffff8881208d8000 R12: 000000000000001e
[   10.779261][    T1] R13: 0000000000000000 R14: ffff8881208d8b10 R15: 0000000000005658
[   10.779261][    T1] FS:  0000000000000000(0000) GS:ffff88821fa00000(0000) knlGS:0000000000000000
[   10.779261][    T1] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[   10.779261][    T1] CR2: 00000000c943508a CR3: 0000000012029000 CR4: 00000000000106e0
[   10.779261][    T1] Kernel panic - not syncing: Fatal exception
[   10.779261][    T1] Kernel Offset: disabled
[   10.779261][    T1] Rebooting in 86400 seconds..
----------------------------------------

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [vmwgfx] crash upon vmw_open_channel() when booting on Oracle VM VirtualBox
  2023-01-28 11:44 [vmwgfx] crash upon vmw_open_channel() when booting on Oracle VM VirtualBox Tetsuo Handa
@ 2023-01-29  6:00 ` Zack Rusin
  2023-01-29  8:11   ` Tetsuo Handa
  0 siblings, 1 reply; 4+ messages in thread
From: Zack Rusin @ 2023-01-29  6:00 UTC (permalink / raw)
  To: penguin-kernel, Linux-graphics-maintainer; +Cc: dri-devel

[-- Attachment #1: Type: text/plain, Size: 1426 bytes --]

On Sat, 2023-01-28 at 20:44 +0900, Tetsuo Handa wrote:
> Hello.
> 
> I noticed that a kernel built with vmwgfx driver fails to boot a Linux guest
> on Oracle VM VirtualBox 7.0.4 on Windows 11 on DELL Inspiron 14 5420.
> I didn't notice this problem when I booted an older kernel on an older version
> of Oracle VM VirtualBox on Windows 8.1 on an older PC.
> 
> The location that crashes is
> 
>         VMW_PORT(VMW_PORT_CMD_OPEN_CHANNEL,
>                 (protocol | GUESTMSG_FLAG_COOKIE), si, di,
>                 0,
>                 VMW_HYPERVISOR_MAGIC,
>                 eax, ebx, ecx, edx, si, di);
> 
> in vmw_open_channel(). It might be that some changes in VirtualBox side
> is conflicting with how VMware tries to test if the guest is VMware.
> How can I debug this problem?

You'd have to figure out what exactly is the problem. I couldn't reproduce it on
vmware hypervisors with your .config. FWIW that code has been there and hasn't been
changed in years. Oracle emulated svga device always had problems, was never
supported by vmwgfx and afaict is not maintained by Oracle so I'd strongly suggest
that you switch to some other graphics device on virtualbox.

In the meantime I think the attached patch should at least get you booting. You can
give it a try and if it works I can push it sometime this week.

z


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-drm-vmwgfx-Print-errors-when-running-on-broken-unsup.patch --]
[-- Type: text/x-patch; name="0001-drm-vmwgfx-Print-errors-when-running-on-broken-unsup.patch", Size: 3733 bytes --]

From db6405fb221a9b8e8232dff8695775584d341ca8 Mon Sep 17 00:00:00 2001
From: Zack Rusin <zackr@vmware.com>
Date: Sun, 29 Jan 2023 00:42:20 -0500
Subject: [PATCH] drm/vmwgfx: Print errors when running on broken/unsupported
 configs

virtualbox implemented an incomplete version of the svga device which
they decided to drop soon after the initial release. The device was
always broken in various ways and never supported by vmwgfx.

vmwgfx should refuse to load on those configurations but currently
drm has no way of reloading fbdev when the specific pci driver refuses
to load, which would leave users without a usable fb. Instead of
refusing to load print an error and disable a bunch of functionality
that virtualbox never implemented to at least get fb to work on their
setup.

Signed-off-by: Zack Rusin <zackr@vmware.com>
---
 drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 28 ++++++++++++++++++++++++++++
 drivers/gpu/drm/vmwgfx/vmwgfx_drv.h |  3 +++
 drivers/gpu/drm/vmwgfx/vmwgfx_msg.c |  2 +-
 3 files changed, 32 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c
index 8e1cd9d6ced2..339a0725ed0c 100644
--- a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c
@@ -46,6 +46,7 @@
 #include <drm/ttm/ttm_placement.h>
 #include <generated/utsrelease.h>
 
+#include <asm/hypervisor.h>
 #include <linux/cc_platform.h>
 #include <linux/dma-mapping.h>
 #include <linux/module.h>
@@ -898,6 +899,16 @@ static int vmw_driver_load(struct vmw_private *dev_priv, u32 pci_id)
 				 cap2_names, ARRAY_SIZE(cap2_names));
 	}
 
+	if (!vmwgfx_supported(dev_priv)) {
+		vmw_msg_enabled = 0;
+		drm_err_once(
+			&dev_priv->drm,
+			"vmwgfx seems to be running on an unsupported hypervisor. "
+			"This configuration is likely broken. "
+			"Please switch to a supported graphics device to avoid problems."
+			);
+	}
+
 	ret = vmw_dma_select_mode(dev_priv);
 	if (unlikely(ret != 0)) {
 		drm_info(&dev_priv->drm,
@@ -1321,6 +1332,23 @@ static void vmw_master_drop(struct drm_device *dev,
 	vmw_kms_legacy_hotspot_clear(dev_priv);
 }
 
+
+bool vmwgfx_supported(struct vmw_private *vmw)
+{
+#if defined(__i386__) || defined(__x86_64__)
+	return hypervisor_is_type(X86_HYPER_VMWARE);
+#elif defined(__aarch64__)
+	/*
+	 * On aarch64 only svga3 is supported
+	 */
+	return vmw->pci_id == VMWGFX_PCI_ID_SVGA3;
+#else
+	drm_warn_once(&dev->drm,
+		"vmwgfx is running on an unknown architecture.");
+	return false;
+#endif
+}
+
 /**
  * __vmw_svga_enable - Enable SVGA mode, FIFO and use of VRAM.
  *
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.h b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.h
index c230cdfa1475..e436b8d042bc 100644
--- a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.h
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.h
@@ -653,6 +653,8 @@ struct vmw_private {
 #endif
 };
 
+bool vmwgfx_supported(struct vmw_private *vmw);
+
 static inline struct vmw_surface *vmw_res_to_srf(struct vmw_resource *res)
 {
 	return container_of(res, struct vmw_surface, res);
@@ -1356,6 +1358,7 @@ int vmw_bo_cpu_blit(struct ttm_buffer_object *dst,
 		    struct vmw_diff_cpy *diff);
 
 /* Host messaging -vmwgfx_msg.c: */
+extern u32 vmw_msg_enabled;
 int vmw_host_get_guestinfo(const char *guest_info_param,
 			   char *buffer, size_t *length);
 __printf(1, 2) int vmw_host_printf(const char *fmt, ...);
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_msg.c b/drivers/gpu/drm/vmwgfx/vmwgfx_msg.c
index e76976a95a1e..1458e1ad967a 100644
--- a/drivers/gpu/drm/vmwgfx/vmwgfx_msg.c
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_msg.c
@@ -67,7 +67,7 @@
 
 #define MAX_USER_MSG_LENGTH	PAGE_SIZE
 
-static u32 vmw_msg_enabled = 1;
+u32 vmw_msg_enabled = 1;
 
 enum rpc_msg_type {
 	MSG_TYPE_OPEN,
-- 
2.38.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [vmwgfx] crash upon vmw_open_channel() when booting on Oracle VM VirtualBox
  2023-01-29  6:00 ` Zack Rusin
@ 2023-01-29  8:11   ` Tetsuo Handa
  2023-01-30  1:43     ` Zack Rusin
  0 siblings, 1 reply; 4+ messages in thread
From: Tetsuo Handa @ 2023-01-29  8:11 UTC (permalink / raw)
  To: Zack Rusin, Linux-graphics-maintainer; +Cc: dri-devel

On 2023/01/29 15:00, Zack Rusin wrote:
> On Sat, 2023-01-28 at 20:44 +0900, Tetsuo Handa wrote:
>> Hello.
>>
>> I noticed that a kernel built with vmwgfx driver fails to boot a Linux guest
>> on Oracle VM VirtualBox 7.0.4 on Windows 11 on DELL Inspiron 14 5420.
>> I didn't notice this problem when I booted an older kernel on an older version
>> of Oracle VM VirtualBox on Windows 8.1 on an older PC.
>>
>> The location that crashes is
>>
>>         VMW_PORT(VMW_PORT_CMD_OPEN_CHANNEL,
>>                 (protocol | GUESTMSG_FLAG_COOKIE), si, di,
>>                 0,
>>                 VMW_HYPERVISOR_MAGIC,
>>                 eax, ebx, ecx, edx, si, di);
>>
>> in vmw_open_channel(). It might be that some changes in VirtualBox side
>> is conflicting with how VMware tries to test if the guest is VMware.
>> How can I debug this problem?
> 
> You'd have to figure out what exactly is the problem. I couldn't reproduce it on
> vmware hypervisors with your .config.

This problem happens on not VMware hypervisors but VirtualBox hypervisors. 

>                                       FWIW that code has been there and hasn't been
> changed in years. Oracle emulated svga device always had problems, was never
> supported by vmwgfx and afaict is not maintained by Oracle so I'd strongly suggest
> that you switch to some other graphics device on virtualbox.

Indeed, not selecting VMSVGA as Graphics Controller in the screen tab of display
setting allowed me to boot the guest.

The reason I built-in vmwgfx is that I want to reuse the same kernel configuration on
multiple environments; syzbot uses a large kernel configuration that builts-in almost
everything.

> 
> In the meantime I think the attached patch should at least get you booting. You can
> give it a try and if it works I can push it sometime this week.

Yes, this patch allowed me to boot the guest when selecting VMSVGA as Graphics Controller.

Thank you.


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [vmwgfx] crash upon vmw_open_channel() when booting on Oracle VM VirtualBox
  2023-01-29  8:11   ` Tetsuo Handa
@ 2023-01-30  1:43     ` Zack Rusin
  0 siblings, 0 replies; 4+ messages in thread
From: Zack Rusin @ 2023-01-30  1:43 UTC (permalink / raw)
  To: penguin-kernel, Linux-graphics-maintainer; +Cc: dri-devel

On Sun, 2023-01-29 at 17:11 +0900, Tetsuo Handa wrote:
> On 2023/01/29 15:00, Zack Rusin wrote:
> > On Sat, 2023-01-28 at 20:44 +0900, Tetsuo Handa wrote:
> > > Hello.
> > > 
> > > I noticed that a kernel built with vmwgfx driver fails to boot a Linux guest
> > > on Oracle VM VirtualBox 7.0.4 on Windows 11 on DELL Inspiron 14 5420.
> > > I didn't notice this problem when I booted an older kernel on an older version
> > > of Oracle VM VirtualBox on Windows 8.1 on an older PC.
> > > 
> > > The location that crashes is
> > > 
> > >         VMW_PORT(VMW_PORT_CMD_OPEN_CHANNEL,
> > >                 (protocol | GUESTMSG_FLAG_COOKIE), si, di,
> > >                 0,
> > >                 VMW_HYPERVISOR_MAGIC,
> > >                 eax, ebx, ecx, edx, si, di);
> > > 
> > > in vmw_open_channel(). It might be that some changes in VirtualBox side
> > > is conflicting with how VMware tries to test if the guest is VMware.
> > > How can I debug this problem?
> > 
> > You'd have to figure out what exactly is the problem. I couldn't reproduce it on
> > vmware hypervisors with your .config.
> 
> This problem happens on not VMware hypervisors but VirtualBox hypervisors. 

Yea, that's why I can't debug it myself and would need someone else to figure out
the exact issue.

> 
> >                                       FWIW that code has been there and hasn't
> > been
> > changed in years. Oracle emulated svga device always had problems, was never
> > supported by vmwgfx and afaict is not maintained by Oracle so I'd strongly
> > suggest
> > that you switch to some other graphics device on virtualbox.
> 
> Indeed, not selecting VMSVGA as Graphics Controller in the screen tab of display
> setting allowed me to boot the guest.
> 
> The reason I built-in vmwgfx is that I want to reuse the same kernel configuration
> on
> multiple environments; syzbot uses a large kernel configuration that builts-in
> almost
> everything.

Building vmwgfx is great, it's selecting the vmsvga device in virtualbox that's the
problem. afaict that device is unmaintained and unsupported.


> > In the meantime I think the attached patch should at least get you booting. You
> > can
> > give it a try and if it works I can push it sometime this week.
> 
> Yes, this patch allowed me to boot the guest when selecting VMSVGA as Graphics
> Controller.
> 
> Thank you.

Great. I'll clean it up and send it for review to dri-devel sometime this week.

z

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-01-30  1:43 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-28 11:44 [vmwgfx] crash upon vmw_open_channel() when booting on Oracle VM VirtualBox Tetsuo Handa
2023-01-29  6:00 ` Zack Rusin
2023-01-29  8:11   ` Tetsuo Handa
2023-01-30  1:43     ` Zack Rusin

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.