All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] package/dbus-python: fix build failure due to wrong auto-detected extra libs
@ 2019-04-04 18:52 Giulio Benetti
  2019-04-04 18:55 ` Giulio Benetti
  2019-04-04 20:51 ` Thomas Petazzoni
  0 siblings, 2 replies; 3+ messages in thread
From: Giulio Benetti @ 2019-04-04 18:52 UTC (permalink / raw)
  To: buildroot

Using Python 3, during configuration, if PYTHON_EXTRA_LIBS is not
defined, ./configure will launch a python script to retrieve LIBS and
SYSLIBS variables, but this is done using host-python resulting in
obtaining libraries that are not present in target. So while trying to
link configuration test it fails complaining it can't find a
library(i.e. libintl).

Set PYTHON_EXTRA_LIBS the same as PYTHON_LIBS to be sure host libs are
not used at all.

Fixes:
http://autobuild.buildroot.net/results/4078ee9e8aa304f044dc92e9345c28341349d468/

Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
---
 package/dbus-python/dbus-python.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/package/dbus-python/dbus-python.mk b/package/dbus-python/dbus-python.mk
index d6af7454af..49f0de5455 100644
--- a/package/dbus-python/dbus-python.mk
+++ b/package/dbus-python/dbus-python.mk
@@ -25,7 +25,8 @@ DBUS_PYTHON_DEPENDENCIES += python3 host-python3
 DBUS_PYTHON_CONF_ENV += \
 	PYTHON=$(HOST_DIR)/bin/python3 \
 	PYTHON_INCLUDES="`$(STAGING_DIR)/usr/bin/python3-config --includes`" \
-	PYTHON_LIBS="`$(STAGING_DIR)/usr/bin/python3-config --ldflags`"
+	PYTHON_LIBS="`$(STAGING_DIR)/usr/bin/python3-config --ldflags`" \
+	PYTHON_EXTRA_LIBS="`$(STAGING_DIR)/usr/bin/python3-config --ldflags`"
 endif
 
 $(eval $(autotools-package))
-- 
2.17.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] package/dbus-python: fix build failure due to wrong auto-detected extra libs
  2019-04-04 18:52 [Buildroot] [PATCH] package/dbus-python: fix build failure due to wrong auto-detected extra libs Giulio Benetti
@ 2019-04-04 18:55 ` Giulio Benetti
  2019-04-04 20:51 ` Thomas Petazzoni
  1 sibling, 0 replies; 3+ messages in thread
From: Giulio Benetti @ 2019-04-04 18:55 UTC (permalink / raw)
  To: buildroot

Hello all,

Il 04/04/2019 20:52, Giulio Benetti ha scritto:
> Using Python 3, during configuration, if PYTHON_EXTRA_LIBS is not
> defined, ./configure will launch a python script to retrieve LIBS and
> SYSLIBS variables, but this is done using host-python resulting in
> obtaining libraries that are not present in target. So while trying to
> link configuration test it fails complaining it can't find a
> library(i.e. libintl).
> 
> Set PYTHON_EXTRA_LIBS the same as PYTHON_LIBS to be sure host libs are
> not used at all.
> 
> Fixes:
> http://autobuild.buildroot.net/results/4078ee9e8aa304f044dc92e9345c28341349d468/
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
> ---
>   package/dbus-python/dbus-python.mk | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/package/dbus-python/dbus-python.mk b/package/dbus-python/dbus-python.mk
> index d6af7454af..49f0de5455 100644
> --- a/package/dbus-python/dbus-python.mk
> +++ b/package/dbus-python/dbus-python.mk
> @@ -25,7 +25,8 @@ DBUS_PYTHON_DEPENDENCIES += python3 host-python3
>   DBUS_PYTHON_CONF_ENV += \
>   	PYTHON=$(HOST_DIR)/bin/python3 \
>   	PYTHON_INCLUDES="`$(STAGING_DIR)/usr/bin/python3-config --includes`" \
> -	PYTHON_LIBS="`$(STAGING_DIR)/usr/bin/python3-config --ldflags`"
> +	PYTHON_LIBS="`$(STAGING_DIR)/usr/bin/python3-config --ldflags`" \
> +	PYTHON_EXTRA_LIBS="`$(STAGING_DIR)/usr/bin/python3-config --ldflags`"
>   endif
>   
>   $(eval $(autotools-package))
> 

I'm not very happy about this solution, but I couldn't find a better one 
with my experience.

Does anyone have suggestion about it?

Thanks in advance
-- 
Giulio Benetti
CTO

MICRONOVA SRL
Sede: Via A. Niedda 3 - 35010 Vigonza (PD)
Tel. 049/8931563 - Fax 049/8931346
Cod.Fiscale - P.IVA 02663420285
Capitale Sociale ? 26.000 i.v.
Iscritta al Reg. Imprese di Padova N. 02663420285
Numero R.E.A. 258642

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] package/dbus-python: fix build failure due to wrong auto-detected extra libs
  2019-04-04 18:52 [Buildroot] [PATCH] package/dbus-python: fix build failure due to wrong auto-detected extra libs Giulio Benetti
  2019-04-04 18:55 ` Giulio Benetti
@ 2019-04-04 20:51 ` Thomas Petazzoni
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2019-04-04 20:51 UTC (permalink / raw)
  To: buildroot

Hello,

On Thu,  4 Apr 2019 20:52:28 +0200
Giulio Benetti <giulio.benetti@micronovasrl.com> wrote:

> Using Python 3, during configuration, if PYTHON_EXTRA_LIBS is not
> defined, ./configure will launch a python script to retrieve LIBS and
> SYSLIBS variables, but this is done using host-python resulting in
> obtaining libraries that are not present in target. So while trying to
> link configuration test it fails complaining it can't find a
> library(i.e. libintl).
> 
> Set PYTHON_EXTRA_LIBS the same as PYTHON_LIBS to be sure host libs are
> not used at all.
> 
> Fixes:
> http://autobuild.buildroot.net/results/4078ee9e8aa304f044dc92e9345c28341349d468/
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>

So it started failing with the introduction of gettext-tiny ? Do we
understand why it makes a difference for dbus-python ?

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-04-04 20:51 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-04 18:52 [Buildroot] [PATCH] package/dbus-python: fix build failure due to wrong auto-detected extra libs Giulio Benetti
2019-04-04 18:55 ` Giulio Benetti
2019-04-04 20:51 ` Thomas Petazzoni

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.