[Buildroot] [PATCH 1/1] package/dhcp: use internal bind

[Buildroot] [PATCH 1/1] package/dhcp: use internal bind

[Fabrice Fontaine]

Use internal bind as dhcp doesn't build since bump of bind to version
9.16.26 in commit 8adeaec8afacbc680edebae91524f6144926ac92 and upstream
doesn't plan to fix it any time soon:
https://gitlab.isc.org/isc-projects/dhcp/-/issues/233#note_276883

In file included from ../includes/dhcpd.h:91,
                 from ctrace.c:29:
../includes/omapip/isclib.h:51:10: fatal error: isc/boolean.h: No such file or directory
   51 | #include <isc/boolean.h>
      |          ^~~~~~~~~~~~~~~

Fixes:
 - http://autobuild.buildroot.org/results/d18b006dce7b46631ce8f4c72fb97eb861993939

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/dhcp/Config.in |  1 -
 package/dhcp/dhcp.mk   | 19 ++++++++++++++++---
 2 files changed, 16 insertions(+), 4 deletions(-)

diff --git a/package/dhcp/Config.in b/package/dhcp/Config.in
index 515040c612..e0706efafb 100644
--- a/package/dhcp/Config.in
+++ b/package/dhcp/Config.in
@@ -3,7 +3,6 @@ config BR2_PACKAGE_DHCP
 	# fork()
 	depends on BR2_USE_MMU
 	depends on BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
-	select BR2_PACKAGE_BIND
 	help
 	  DHCP relay agent from the ISC DHCP distribution.
 
diff --git a/package/dhcp/dhcp.mk b/package/dhcp/dhcp.mk
index 18765a3639..f1e3c22f1c 100644
--- a/package/dhcp/dhcp.mk
+++ b/package/dhcp/dhcp.mk
@@ -9,8 +9,10 @@ DHCP_SITE = https://ftp.isc.org/isc/dhcp/$(DHCP_VERSION)
 DHCP_INSTALL_STAGING = YES
 DHCP_LICENSE = MPL-2.0
 DHCP_LICENSE_FILES = LICENSE
-DHCP_DEPENDENCIES = bind host-gawk
+DHCP_DEPENDENCIES = host-gawk
 DHCP_CPE_ID_VENDOR = isc
+# internal bind does not support parallel builds.
+DHCP_MAKE = $(MAKE1)
 
 # use libtool-enabled configure.ac
 define DHCP_LIBTOOL_AUTORECONF
@@ -21,11 +23,12 @@ DHCP_CONF_ENV = \
 	CPPFLAGS='-D_PATH_DHCPD_CONF=\"/etc/dhcp/dhcpd.conf\" \
 		-D_PATH_DHCLIENT_CONF=\"/etc/dhcp/dhclient.conf\"' \
 	CFLAGS='$(TARGET_CFLAGS) -DISC_CHECK_NONE=1'
+DHCP_BIND_EXTRA_CONFIG = BUILD_CC='$(TARGET_CC)'
 
 DHCP_CONF_ENV += ac_cv_prog_AWK=$(HOST_DIR)/bin/gawk
 
 DHCP_CONF_OPTS = \
-	--with-libbind=$(STAGING_DIR)/usr \
+	--with-bind-extra-config="$(DHCP_BIND_EXTRA_CONFIG)" \
 	--with-randomdev=/dev/random \
 	--with-srv-lease-file=/var/lib/dhcp/dhcpd.leases \
 	--with-srv6-lease-file=/var/lib/dhcp/dhcpd6.leases \
@@ -38,8 +41,18 @@ DHCP_CONF_OPTS = \
 	--with-relay-pid-file=/var/run/dhcrelay.pid \
 	--with-relay6-pid-file=/var/run/dhcrelay6.pid
 
+ifeq ($(BR2_PACKAGE_ZLIB),y)
+DHCP_BIND_EXTRA_CONFIG += --with-zlib
+DHCP_DEPENDENCIES += zlib
+else
+DHCP_BIND_EXTRA_CONFIG += --without-zlib
+endif
+
+ifeq ($(BR2_TOOLCHAIN_HAS_LIBATOMIC),y)
+DHCP_CONF_ENV += LIBS=-latomic
+endif
+
 ifeq ($(BR2_STATIC_LIBS),y)
-DHCP_CONF_ENV += LIBS="`$(STAGING_DIR)/usr/bin/bind9-config --libs bind9`"
 DHCP_CONF_OPTS += --disable-libtool
 else
 DHCP_POST_EXTRACT_HOOKS += DHCP_LIBTOOL_AUTORECONF
-- 
2.35.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/dhcp: use internal bind

[James Hilliard]

On Sun, Apr 3, 2022 at 4:05 AM Fabrice Fontaine
<fontaine.fabrice@gmail.com> wrote:
>
> Use internal bind as dhcp doesn't build since bump of bind to version
> 9.16.26 in commit 8adeaec8afacbc680edebae91524f6144926ac92 and upstream
> doesn't plan to fix it any time soon:
> https://gitlab.isc.org/isc-projects/dhcp/-/issues/233#note_276883
>
> In file included from ../includes/dhcpd.h:91,
>                  from ctrace.c:29:
> ../includes/omapip/isclib.h:51:10: fatal error: isc/boolean.h: No such file or directory
>    51 | #include <isc/boolean.h>
>       |          ^~~~~~~~~~~~~~~
>
> Fixes:
>  - http://autobuild.buildroot.org/results/d18b006dce7b46631ce8f4c72fb97eb861993939

Also fixes a different issue caused by the bind depends not being
propagated to dhcp:
http://autobuild.buildroot.net/results/c06/c06d57b57c9d7867e3fb7fedd8b5ab39872af285

>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Reviewed-by: James Hilliard <james.hilliard1@gmail.com>
> ---
>  package/dhcp/Config.in |  1 -
>  package/dhcp/dhcp.mk   | 19 ++++++++++++++++---
>  2 files changed, 16 insertions(+), 4 deletions(-)
>
> diff --git a/package/dhcp/Config.in b/package/dhcp/Config.in
> index 515040c612..e0706efafb 100644
> --- a/package/dhcp/Config.in
> +++ b/package/dhcp/Config.in
> @@ -3,7 +3,6 @@ config BR2_PACKAGE_DHCP
>         # fork()
>         depends on BR2_USE_MMU
>         depends on BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
> -       select BR2_PACKAGE_BIND
>         help
>           DHCP relay agent from the ISC DHCP distribution.
>
> diff --git a/package/dhcp/dhcp.mk b/package/dhcp/dhcp.mk
> index 18765a3639..f1e3c22f1c 100644
> --- a/package/dhcp/dhcp.mk
> +++ b/package/dhcp/dhcp.mk
> @@ -9,8 +9,10 @@ DHCP_SITE = https://ftp.isc.org/isc/dhcp/$(DHCP_VERSION)
>  DHCP_INSTALL_STAGING = YES
>  DHCP_LICENSE = MPL-2.0
>  DHCP_LICENSE_FILES = LICENSE
> -DHCP_DEPENDENCIES = bind host-gawk
> +DHCP_DEPENDENCIES = host-gawk
>  DHCP_CPE_ID_VENDOR = isc
> +# internal bind does not support parallel builds.
> +DHCP_MAKE = $(MAKE1)
>
>  # use libtool-enabled configure.ac
>  define DHCP_LIBTOOL_AUTORECONF
> @@ -21,11 +23,12 @@ DHCP_CONF_ENV = \
>         CPPFLAGS='-D_PATH_DHCPD_CONF=\"/etc/dhcp/dhcpd.conf\" \
>                 -D_PATH_DHCLIENT_CONF=\"/etc/dhcp/dhclient.conf\"' \
>         CFLAGS='$(TARGET_CFLAGS) -DISC_CHECK_NONE=1'
> +DHCP_BIND_EXTRA_CONFIG = BUILD_CC='$(TARGET_CC)'
>
>  DHCP_CONF_ENV += ac_cv_prog_AWK=$(HOST_DIR)/bin/gawk
>
>  DHCP_CONF_OPTS = \
> -       --with-libbind=$(STAGING_DIR)/usr \
> +       --with-bind-extra-config="$(DHCP_BIND_EXTRA_CONFIG)" \
>         --with-randomdev=/dev/random \
>         --with-srv-lease-file=/var/lib/dhcp/dhcpd.leases \
>         --with-srv6-lease-file=/var/lib/dhcp/dhcpd6.leases \
> @@ -38,8 +41,18 @@ DHCP_CONF_OPTS = \
>         --with-relay-pid-file=/var/run/dhcrelay.pid \
>         --with-relay6-pid-file=/var/run/dhcrelay6.pid
>
> +ifeq ($(BR2_PACKAGE_ZLIB),y)
> +DHCP_BIND_EXTRA_CONFIG += --with-zlib
> +DHCP_DEPENDENCIES += zlib
> +else
> +DHCP_BIND_EXTRA_CONFIG += --without-zlib
> +endif
> +
> +ifeq ($(BR2_TOOLCHAIN_HAS_LIBATOMIC),y)
> +DHCP_CONF_ENV += LIBS=-latomic
> +endif
> +
>  ifeq ($(BR2_STATIC_LIBS),y)
> -DHCP_CONF_ENV += LIBS="`$(STAGING_DIR)/usr/bin/bind9-config --libs bind9`"
>  DHCP_CONF_OPTS += --disable-libtool
>  else
>  DHCP_POST_EXTRACT_HOOKS += DHCP_LIBTOOL_AUTORECONF
> --
> 2.35.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/dhcp: use internal bind

[Arnout Vandecappelle]

On 03/04/2022 12:03, Fabrice Fontaine wrote:
> Use internal bind as dhcp doesn't build since bump of bind to version
> 9.16.26 in commit 8adeaec8afacbc680edebae91524f6144926ac92 and upstream
> doesn't plan to fix it any time soon:
> https://gitlab.isc.org/isc-projects/dhcp/-/issues/233#note_276883
> 
> In file included from ../includes/dhcpd.h:91,
>                   from ctrace.c:29:
> ../includes/omapip/isclib.h:51:10: fatal error: isc/boolean.h: No such file or directory
>     51 | #include <isc/boolean.h>
>        |          ^~~~~~~~~~~~~~~
> 
> Fixes:
>   - http://autobuild.buildroot.org/results/d18b006dce7b46631ce8f4c72fb97eb861993939
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

  Applied to master, thanks.

  If dhcp is not developed anymore, maybe we should say that in the help text or 
something.

  Regards,
  Arnout

> ---
>   package/dhcp/Config.in |  1 -
>   package/dhcp/dhcp.mk   | 19 ++++++++++++++++---
>   2 files changed, 16 insertions(+), 4 deletions(-)
> 
> diff --git a/package/dhcp/Config.in b/package/dhcp/Config.in
> index 515040c612..e0706efafb 100644
> --- a/package/dhcp/Config.in
> +++ b/package/dhcp/Config.in
> @@ -3,7 +3,6 @@ config BR2_PACKAGE_DHCP
>   	# fork()
>   	depends on BR2_USE_MMU
>   	depends on BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
> -	select BR2_PACKAGE_BIND
>   	help
>   	  DHCP relay agent from the ISC DHCP distribution.
>   
> diff --git a/package/dhcp/dhcp.mk b/package/dhcp/dhcp.mk
> index 18765a3639..f1e3c22f1c 100644
> --- a/package/dhcp/dhcp.mk
> +++ b/package/dhcp/dhcp.mk
> @@ -9,8 +9,10 @@ DHCP_SITE = https://ftp.isc.org/isc/dhcp/$(DHCP_VERSION)
>   DHCP_INSTALL_STAGING = YES
>   DHCP_LICENSE = MPL-2.0
>   DHCP_LICENSE_FILES = LICENSE
> -DHCP_DEPENDENCIES = bind host-gawk
> +DHCP_DEPENDENCIES = host-gawk
>   DHCP_CPE_ID_VENDOR = isc
> +# internal bind does not support parallel builds.
> +DHCP_MAKE = $(MAKE1)
>   
>   # use libtool-enabled configure.ac
>   define DHCP_LIBTOOL_AUTORECONF
> @@ -21,11 +23,12 @@ DHCP_CONF_ENV = \
>   	CPPFLAGS='-D_PATH_DHCPD_CONF=\"/etc/dhcp/dhcpd.conf\" \
>   		-D_PATH_DHCLIENT_CONF=\"/etc/dhcp/dhclient.conf\"' \
>   	CFLAGS='$(TARGET_CFLAGS) -DISC_CHECK_NONE=1'
> +DHCP_BIND_EXTRA_CONFIG = BUILD_CC='$(TARGET_CC)'
>   
>   DHCP_CONF_ENV += ac_cv_prog_AWK=$(HOST_DIR)/bin/gawk
>   
>   DHCP_CONF_OPTS = \
> -	--with-libbind=$(STAGING_DIR)/usr \
> +	--with-bind-extra-config="$(DHCP_BIND_EXTRA_CONFIG)" \
>   	--with-randomdev=/dev/random \
>   	--with-srv-lease-file=/var/lib/dhcp/dhcpd.leases \
>   	--with-srv6-lease-file=/var/lib/dhcp/dhcpd6.leases \
> @@ -38,8 +41,18 @@ DHCP_CONF_OPTS = \
>   	--with-relay-pid-file=/var/run/dhcrelay.pid \
>   	--with-relay6-pid-file=/var/run/dhcrelay6.pid
>   
> +ifeq ($(BR2_PACKAGE_ZLIB),y)
> +DHCP_BIND_EXTRA_CONFIG += --with-zlib
> +DHCP_DEPENDENCIES += zlib
> +else
> +DHCP_BIND_EXTRA_CONFIG += --without-zlib
> +endif
> +
> +ifeq ($(BR2_TOOLCHAIN_HAS_LIBATOMIC),y)
> +DHCP_CONF_ENV += LIBS=-latomic
> +endif
> +
>   ifeq ($(BR2_STATIC_LIBS),y)
> -DHCP_CONF_ENV += LIBS="`$(STAGING_DIR)/usr/bin/bind9-config --libs bind9`"
>   DHCP_CONF_OPTS += --disable-libtool
>   else
>   DHCP_POST_EXTRACT_HOOKS += DHCP_LIBTOOL_AUTORECONF
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/dhcp: use internal bind

[Yann E. MORIN]

Fabrice, All,

On 2022-04-03 12:03 +0200, Fabrice Fontaine spake thusly:
> Use internal bind as dhcp doesn't build since bump of bind to version
> 9.16.26 in commit 8adeaec8afacbc680edebae91524f6144926ac92 and upstream
> doesn't plan to fix it any time soon:
> https://gitlab.isc.org/isc-projects/dhcp/-/issues/233#note_276883
> 
> In file included from ../includes/dhcpd.h:91,
>                  from ctrace.c:29:
> ../includes/omapip/isclib.h:51:10: fatal error: isc/boolean.h: No such file or directory
>    51 | #include <isc/boolean.h>
>       |          ^~~~~~~~~~~~~~~
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/d18b006dce7b46631ce8f4c72fb97eb861993939

That config still does not build for me even with this patch:

    >>> dhcp 4.4.2-P1 Building
    PATH="/home/ymorin/dev/buildroot/O/host/bin:/home/ymorin/dev/buildroot/O/host/sbin:/home/ymorin/bin:/home/ymorin/bin:/opt/mutt/bin:/opt/containerd/bin:/home/ymorin/bin:/home/ymorin/bin:/opt/mutt/bin:/opt/containerd/bin:/home/ymorin/bin:/home/ymorin/bin:/opt/mutt/bin:/opt/containerd/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin" /usr/bin/make -j1  -C /home/ymorin/dev/buildroot/O/build/dhcp-4.4.2-P1/
    Making all in ./bind
    Configuring BIND libraries for DHCP.
    configure: WARNING: using cross tools not prefixed with host triplet
    configure: error: include/zlib.h not found.
    make[3]: *** [Makefile:42: bind1] Error 1
    make[2]: *** [Makefile:495: all-recursive] Error 1
    make[1]: *** [package/pkg-generic.mk:292: /home/ymorin/dev/buildroot/O/build/dhcp-4.4.2-P1/.stamp_built] Error 2
    make: *** [Makefile:23: _all] Error 2

Regards,
Yann E. MORIN.

> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/dhcp/Config.in |  1 -
>  package/dhcp/dhcp.mk   | 19 ++++++++++++++++---
>  2 files changed, 16 insertions(+), 4 deletions(-)
> 
> diff --git a/package/dhcp/Config.in b/package/dhcp/Config.in
> index 515040c612..e0706efafb 100644
> --- a/package/dhcp/Config.in
> +++ b/package/dhcp/Config.in
> @@ -3,7 +3,6 @@ config BR2_PACKAGE_DHCP
>  	# fork()
>  	depends on BR2_USE_MMU
>  	depends on BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
> -	select BR2_PACKAGE_BIND
>  	help
>  	  DHCP relay agent from the ISC DHCP distribution.
>  
> diff --git a/package/dhcp/dhcp.mk b/package/dhcp/dhcp.mk
> index 18765a3639..f1e3c22f1c 100644
> --- a/package/dhcp/dhcp.mk
> +++ b/package/dhcp/dhcp.mk
> @@ -9,8 +9,10 @@ DHCP_SITE = https://ftp.isc.org/isc/dhcp/$(DHCP_VERSION)
>  DHCP_INSTALL_STAGING = YES
>  DHCP_LICENSE = MPL-2.0
>  DHCP_LICENSE_FILES = LICENSE
> -DHCP_DEPENDENCIES = bind host-gawk
> +DHCP_DEPENDENCIES = host-gawk
>  DHCP_CPE_ID_VENDOR = isc
> +# internal bind does not support parallel builds.
> +DHCP_MAKE = $(MAKE1)
>  
>  # use libtool-enabled configure.ac
>  define DHCP_LIBTOOL_AUTORECONF
> @@ -21,11 +23,12 @@ DHCP_CONF_ENV = \
>  	CPPFLAGS='-D_PATH_DHCPD_CONF=\"/etc/dhcp/dhcpd.conf\" \
>  		-D_PATH_DHCLIENT_CONF=\"/etc/dhcp/dhclient.conf\"' \
>  	CFLAGS='$(TARGET_CFLAGS) -DISC_CHECK_NONE=1'
> +DHCP_BIND_EXTRA_CONFIG = BUILD_CC='$(TARGET_CC)'
>  
>  DHCP_CONF_ENV += ac_cv_prog_AWK=$(HOST_DIR)/bin/gawk
>  
>  DHCP_CONF_OPTS = \
> -	--with-libbind=$(STAGING_DIR)/usr \
> +	--with-bind-extra-config="$(DHCP_BIND_EXTRA_CONFIG)" \
>  	--with-randomdev=/dev/random \
>  	--with-srv-lease-file=/var/lib/dhcp/dhcpd.leases \
>  	--with-srv6-lease-file=/var/lib/dhcp/dhcpd6.leases \
> @@ -38,8 +41,18 @@ DHCP_CONF_OPTS = \
>  	--with-relay-pid-file=/var/run/dhcrelay.pid \
>  	--with-relay6-pid-file=/var/run/dhcrelay6.pid
>  
> +ifeq ($(BR2_PACKAGE_ZLIB),y)
> +DHCP_BIND_EXTRA_CONFIG += --with-zlib
> +DHCP_DEPENDENCIES += zlib
> +else
> +DHCP_BIND_EXTRA_CONFIG += --without-zlib
> +endif
> +
> +ifeq ($(BR2_TOOLCHAIN_HAS_LIBATOMIC),y)
> +DHCP_CONF_ENV += LIBS=-latomic
> +endif
> +
>  ifeq ($(BR2_STATIC_LIBS),y)
> -DHCP_CONF_ENV += LIBS="`$(STAGING_DIR)/usr/bin/bind9-config --libs bind9`"
>  DHCP_CONF_OPTS += --disable-libtool
>  else
>  DHCP_POST_EXTRACT_HOOKS += DHCP_LIBTOOL_AUTORECONF
> -- 
> 2.35.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/dhcp: use internal bind

[Peter Korsgaard]

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > Use internal bind as dhcp doesn't build since bump of bind to version
 > 9.16.26 in commit 8adeaec8afacbc680edebae91524f6144926ac92 and upstream
 > doesn't plan to fix it any time soon:
 > https://gitlab.isc.org/isc-projects/dhcp/-/issues/233#note_276883

 > In file included from ../includes/dhcpd.h:91,
 >                  from ctrace.c:29:
 > ../includes/omapip/isclib.h:51:10: fatal error: isc/boolean.h: No such file or directory
 >    51 | #include <isc/boolean.h>
 >       |          ^~~~~~~~~~~~~~~

 > Fixes:
 >  - http://autobuild.buildroot.org/results/d18b006dce7b46631ce8f4c72fb97eb861993939

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Committed to 2022.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/dhcp: use internal bind

[Eugen.Hristev--- via buildroot]

On 4/9/22 5:09 PM, Peter Korsgaard wrote:
>>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> 
>   > Use internal bind as dhcp doesn't build since bump of bind to version
>   > 9.16.26 in commit 8adeaec8afacbc680edebae91524f6144926ac92 and upstream
>   > doesn't plan to fix it any time soon:
>   > https://gitlab.isc.org/isc-projects/dhcp/-/issues/233#note_276883
> 
>   > In file included from ../includes/dhcpd.h:91,
>   >                  from ctrace.c:29:
>   > ../includes/omapip/isclib.h:51:10: fatal error: isc/boolean.h: No such file or directory
>   >    51 | #include <isc/boolean.h>
>   >       |          ^~~~~~~~~~~~~~~
> 
>   > Fixes:
>   >  - http://autobuild.buildroot.org/results/d18b006dce7b46631ce8f4c72fb97eb861993939
> 
>   > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> 
> Committed to 2022.02.x, thanks.
> 
> --
> Bye, Peter Korsgaard
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
> 


Hello Peter, Fabrice,

While your patch solves the isc/boolean.h problem, now I get several 
other problems when building an arm926 platform with this package :
(sam9x60ek)

Could you help please? 2022.01.1 is broken for me atm.

Thanks,
Eugen


 >>> dhcp 4.4.2-P1 Building
PATH="/home/eugen/buildroot-2022.02/buildroot/output/host/bin:/home/eugen/buildroot-2022.02/buildroot/output/host/sbin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin" 
  /usr/bin/make -j1  -C 
/home/eugen/buildroot-2022.02/buildroot/output/build/dhcp-4.4.2-P1/
Making all in ./bind
/home/eugen/buildroot-2022.02/buildroot/output/build/dhcp-4.4.2-P1/bind/bind-9.11.14 
already unpacked...
Bind libraries already configured
Building BIND libraries - this takes some time.
Building isc library in 
/home/eugen/buildroot-2022.02/buildroot/output/build/dhcp-4.4.2-P1/bind/bind-9.11.14/lib/isc
stats.c: In function ‘setcounter’:
stats.c:300:29: error: ‘val’ undeclared (first use in this function); 
did you mean ‘value’?
   300 |  stats->counters[counter] = val;
       |                             ^~~
       |                             value
stats.c:300:29: note: each undeclared identifier is reported only once 
for each function it appears in
stats.c:286:20: warning: unused parameter ‘value’ [-Wunused-parameter]
   286 |     const uint64_t value)
       |     ~~~~~~~~~~~~~~~^~~~~
make[4]: *** [Makefile:290: stats.lo] Error 1 
 

Building dns library in 
/home/eugen/buildroot-2022.02/buildroot/output/build/dhcp-4.4.2-P1/bind/bind-9.11.14/lib/dns 

/lib/ld-linux.so.3: No such file or directory 
 

make[5]: *** [Makefile:605: include/dns/enumtype.h] Error 1 
 

make[4]: *** [Makefile:599: include] Error 2 
 

Building isccfg library in 
/home/eugen/buildroot-2022.02/buildroot/output/build/dhcp-4.4.2-P1/bind/bind-9.11.14/lib/isccfg
In file included from 
/home/eugen/buildroot-2022.02/buildroot/output/build/dhcp-4.4.2-P1/bind/bind-9.11.14/lib/isccfg/include/isccfg/aclconf.h:24,
                  from aclconf.c:24:
/home/eugen/buildroot-2022.02/buildroot/output/build/dhcp-4.4.2-P1/bind/bind-9.11.14/lib/dns/include/dns/types.h:230:10: 
fatal error: dns/enumtype.h: No such file or directory
   230 | #include <dns/enumtype.h> /* Provides dns_rdatatype_t. */
       |          ^~~~~~~~~~~~~~~~
compilation terminated.
make[4]: *** [Makefile:241: aclconf.lo] Error 1
Building irs library in 
/home/eugen/buildroot-2022.02/buildroot/output/build/dhcp-4.4.2-P1/bind/bind-9.11.14/lib/irs
In file included from 
/home/eugen/buildroot-2022.02/buildroot/output/build/dhcp-4.4.2-P1/bind/bind-9.11.14/lib/dns/include/dns/tsig.h:28,
                  from 
/home/eugen/buildroot-2022.02/buildroot/output/build/dhcp-4.4.2-P1/bind/bind-9.11.14/lib/dns/include/dns/client.h:45,
                  from context.c:28:
/home/eugen/buildroot-2022.02/buildroot/output/build/dhcp-4.4.2-P1/bind/bind-9.11.14/lib/dns/include/dns/types.h:230:10: 
fatal error: dns/enumtype.h: No such file or directory
   230 | #include <dns/enumtype.h> /* Provides dns_rdatatype_t. */
       |          ^~~~~~~~~~~~~~~~
compilation terminated.
make[4]: *** [Makefile:239: context.lo] Error 1
Installing BIND libraries to 
/home/eugen/buildroot-2022.02/buildroot/output/build/dhcp-4.4.2-P1/bind.
stats.c: In function ‘setcounter’:
stats.c:300:29: error: ‘val’ undeclared (first use in this function); 
did you mean ‘value’?
   300 |  stats->counters[counter] = val;
       |                             ^~~
       |                             value
stats.c:300:29: note: each undeclared identifier is reported only once 
for each function it appears in
stats.c:286:20: warning: unused parameter ‘value’ [-Wunused-parameter]
   286 |     const uint64_t value)
       |     ~~~~~~~~~~~~~~~^~~~~
make[4]: *** [Makefile:290: stats.lo] Error 1
/lib/ld-linux.so.3: No such file or directory
make[5]: *** [Makefile:605: include/dns/enumtype.h] Error 1
make[4]: *** [Makefile:599: include] Error 2
In file included from 
/home/eugen/buildroot-2022.02/buildroot/output/build/dhcp-4.4.2-P1/bind/bind-9.11.14/lib/isccfg/include/isccfg/aclconf.h:24,
                  from aclconf.c:24:
/home/eugen/buildroot-2022.02/buildroot/output/build/dhcp-4.4.2-P1/bind/bind-9.11.14/lib/dns/include/dns/types.h:230:10: 
fatal error: dns/enumtype.h: No such file or directory
   230 | #include <dns/enumtype.h> /* Provides dns_rdatatype_t. */
       |          ^~~~~~~~~~~~~~~~
compilation terminated.
make[4]: *** [Makefile:241: aclconf.lo] Error 1
In file included from 
/home/eugen/buildroot-2022.02/buildroot/output/build/dhcp-4.4.2-P1/bind/bind-9.11.14/lib/dns/include/dns/tsig.h:28,
                  from 
/home/eugen/buildroot-2022.02/buildroot/output/build/dhcp-4.4.2-P1/bind/bind-9.11.14/lib/dns/include/dns/client.h:45,
                  from context.c:28:
/home/eugen/buildroot-2022.02/buildroot/output/build/dhcp-4.4.2-P1/bind/bind-9.11.14/lib/dns/include/dns/types.h:230:10: 
fatal error: dns/enumtype.h: No such file or directory
   230 | #include <dns/enumtype.h> /* Provides dns_rdatatype_t. */
       |          ^~~~~~~~~~~~~~~~
compilation terminated.
make[4]: *** [Makefile:239: context.lo] Error 1
make[3]: *** [Makefile:76: bind2] Error 2
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/dhcp: use internal bind

[Fabrice Fontaine]

Hello Eugen,

Le mar. 12 avr. 2022 à 13:15, <Eugen.Hristev@microchip.com> a écrit :
>
> On 4/9/22 5:09 PM, Peter Korsgaard wrote:
> >>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> >
> >   > Use internal bind as dhcp doesn't build since bump of bind to version
> >   > 9.16.26 in commit 8adeaec8afacbc680edebae91524f6144926ac92 and upstream
> >   > doesn't plan to fix it any time soon:
> >   > https://gitlab.isc.org/isc-projects/dhcp/-/issues/233#note_276883
> >
> >   > In file included from ../includes/dhcpd.h:91,
> >   >                  from ctrace.c:29:
> >   > ../includes/omapip/isclib.h:51:10: fatal error: isc/boolean.h: No such file or directory
> >   >    51 | #include <isc/boolean.h>
> >   >       |          ^~~~~~~~~~~~~~~
> >
> >   > Fixes:
> >   >  - http://autobuild.buildroot.org/results/d18b006dce7b46631ce8f4c72fb97eb861993939
> >
> >   > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> >
> > Committed to 2022.02.x, thanks.
> >
> > --
> > Bye, Peter Korsgaard
> > _______________________________________________
> > buildroot mailing list
> > buildroot@buildroot.org
> > https://lists.buildroot.org/mailman/listinfo/buildroot
> >
>
>
> Hello Peter, Fabrice,
>
> While your patch solves the isc/boolean.h problem, now I get several
> other problems when building an arm926 platform with this package :
> (sam9x60ek)
>
> Could you help please? 2022.01.1 is broken for me atm.

You should apply:
https://git.buildroot.net/buildroot/commit/?id=789a08dac5808401629d6fc586b7377f54ebb316
as well as
https://patchwork.ozlabs.org/project/buildroot/patch/DU0P251MB07797CAAE80C985DC8976335E3E79@DU0P251MB0779.EURP251.PROD.OUTLOOK.COM/

Having said that, I fear that dhcp will have to be removed soon due to
security concerns:
https://gitlab.isc.org/isc-projects/dhcp/-/issues/233

>
> Thanks,
> Eugen
>
>
>  >>> dhcp 4.4.2-P1 Building
> PATH="/home/eugen/buildroot-2022.02/buildroot/output/host/bin:/home/eugen/buildroot-2022.02/buildroot/output/host/sbin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin"
>   /usr/bin/make -j1  -C
> /home/eugen/buildroot-2022.02/buildroot/output/build/dhcp-4.4.2-P1/
> Making all in ./bind
> /home/eugen/buildroot-2022.02/buildroot/output/build/dhcp-4.4.2-P1/bind/bind-9.11.14
> already unpacked...
> Bind libraries already configured
> Building BIND libraries - this takes some time.
> Building isc library in
> /home/eugen/buildroot-2022.02/buildroot/output/build/dhcp-4.4.2-P1/bind/bind-9.11.14/lib/isc
> stats.c: In function ‘setcounter’:
> stats.c:300:29: error: ‘val’ undeclared (first use in this function);
> did you mean ‘value’?
>    300 |  stats->counters[counter] = val;
>        |                             ^~~
>        |                             value
> stats.c:300:29: note: each undeclared identifier is reported only once
> for each function it appears in
> stats.c:286:20: warning: unused parameter ‘value’ [-Wunused-parameter]
>    286 |     const uint64_t value)
>        |     ~~~~~~~~~~~~~~~^~~~~
> make[4]: *** [Makefile:290: stats.lo] Error 1
>
>
> Building dns library in
> /home/eugen/buildroot-2022.02/buildroot/output/build/dhcp-4.4.2-P1/bind/bind-9.11.14/lib/dns
>
> /lib/ld-linux.so.3: No such file or directory
>
>
> make[5]: *** [Makefile:605: include/dns/enumtype.h] Error 1
>
>
> make[4]: *** [Makefile:599: include] Error 2
>
>
> Building isccfg library in
> /home/eugen/buildroot-2022.02/buildroot/output/build/dhcp-4.4.2-P1/bind/bind-9.11.14/lib/isccfg
> In file included from
> /home/eugen/buildroot-2022.02/buildroot/output/build/dhcp-4.4.2-P1/bind/bind-9.11.14/lib/isccfg/include/isccfg/aclconf.h:24,
>                   from aclconf.c:24:
> /home/eugen/buildroot-2022.02/buildroot/output/build/dhcp-4.4.2-P1/bind/bind-9.11.14/lib/dns/include/dns/types.h:230:10:
> fatal error: dns/enumtype.h: No such file or directory
>    230 | #include <dns/enumtype.h> /* Provides dns_rdatatype_t. */
>        |          ^~~~~~~~~~~~~~~~
> compilation terminated.
> make[4]: *** [Makefile:241: aclconf.lo] Error 1
> Building irs library in
> /home/eugen/buildroot-2022.02/buildroot/output/build/dhcp-4.4.2-P1/bind/bind-9.11.14/lib/irs
> In file included from
> /home/eugen/buildroot-2022.02/buildroot/output/build/dhcp-4.4.2-P1/bind/bind-9.11.14/lib/dns/include/dns/tsig.h:28,
>                   from
> /home/eugen/buildroot-2022.02/buildroot/output/build/dhcp-4.4.2-P1/bind/bind-9.11.14/lib/dns/include/dns/client.h:45,
>                   from context.c:28:
> /home/eugen/buildroot-2022.02/buildroot/output/build/dhcp-4.4.2-P1/bind/bind-9.11.14/lib/dns/include/dns/types.h:230:10:
> fatal error: dns/enumtype.h: No such file or directory
>    230 | #include <dns/enumtype.h> /* Provides dns_rdatatype_t. */
>        |          ^~~~~~~~~~~~~~~~
> compilation terminated.
> make[4]: *** [Makefile:239: context.lo] Error 1
> Installing BIND libraries to
> /home/eugen/buildroot-2022.02/buildroot/output/build/dhcp-4.4.2-P1/bind.
> stats.c: In function ‘setcounter’:
> stats.c:300:29: error: ‘val’ undeclared (first use in this function);
> did you mean ‘value’?
>    300 |  stats->counters[counter] = val;
>        |                             ^~~
>        |                             value
> stats.c:300:29: note: each undeclared identifier is reported only once
> for each function it appears in
> stats.c:286:20: warning: unused parameter ‘value’ [-Wunused-parameter]
>    286 |     const uint64_t value)
>        |     ~~~~~~~~~~~~~~~^~~~~
> make[4]: *** [Makefile:290: stats.lo] Error 1
> /lib/ld-linux.so.3: No such file or directory
> make[5]: *** [Makefile:605: include/dns/enumtype.h] Error 1
> make[4]: *** [Makefile:599: include] Error 2
> In file included from
> /home/eugen/buildroot-2022.02/buildroot/output/build/dhcp-4.4.2-P1/bind/bind-9.11.14/lib/isccfg/include/isccfg/aclconf.h:24,
>                   from aclconf.c:24:
> /home/eugen/buildroot-2022.02/buildroot/output/build/dhcp-4.4.2-P1/bind/bind-9.11.14/lib/dns/include/dns/types.h:230:10:
> fatal error: dns/enumtype.h: No such file or directory
>    230 | #include <dns/enumtype.h> /* Provides dns_rdatatype_t. */
>        |          ^~~~~~~~~~~~~~~~
> compilation terminated.
> make[4]: *** [Makefile:241: aclconf.lo] Error 1
> In file included from
> /home/eugen/buildroot-2022.02/buildroot/output/build/dhcp-4.4.2-P1/bind/bind-9.11.14/lib/dns/include/dns/tsig.h:28,
>                   from
> /home/eugen/buildroot-2022.02/buildroot/output/build/dhcp-4.4.2-P1/bind/bind-9.11.14/lib/dns/include/dns/client.h:45,
>                   from context.c:28:
> /home/eugen/buildroot-2022.02/buildroot/output/build/dhcp-4.4.2-P1/bind/bind-9.11.14/lib/dns/include/dns/types.h:230:10:
> fatal error: dns/enumtype.h: No such file or directory
>    230 | #include <dns/enumtype.h> /* Provides dns_rdatatype_t. */
>        |          ^~~~~~~~~~~~~~~~
> compilation terminated.
> make[4]: *** [Makefile:239: context.lo] Error 1
> make[3]: *** [Makefile:76: bind2] Error 2

Best Regards,

Fabrice
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/dhcp: use internal bind

[Peter Korsgaard]

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

Hi,

>> Hello Peter, Fabrice,
 >> 
 >> While your patch solves the isc/boolean.h problem, now I get several
 >> other problems when building an arm926 platform with this package :
 >> (sam9x60ek)
 >> 
 >> Could you help please? 2022.01.1 is broken for me atm.

 > You should apply:
 > https://git.buildroot.net/buildroot/commit/?id=789a08dac5808401629d6fc586b7377f54ebb316

That is already in 202.02.1:

https://git.buildroot.net/buildroot/commit/?h=2022.02.x&id=0397064a9a147903e9e0c16b2506319ea4a246fb

> as well as
 > https://patchwork.ozlabs.org/project/buildroot/patch/DU0P251MB07797CAAE80C985DC8976335E3E79@DU0P251MB0779.EURP251.PROD.OUTLOOK.COM/

Is that an ack? ;)

 > Having said that, I fear that dhcp will have to be removed soon due to
 > security concerns:
 > https://gitlab.isc.org/isc-projects/dhcp/-/issues/233

Yeah. Eugen, is there any specific reason why you use the dhcp package
over the other DHCP clients we provide?

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/dhcp: use internal bind

[Eugen.Hristev--- via buildroot]

On 4/12/22 2:33 PM, Peter Korsgaard wrote:
>>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> 
> Hi,
> 
>>> Hello Peter, Fabrice,
>   >>
>   >> While your patch solves the isc/boolean.h problem, now I get several
>   >> other problems when building an arm926 platform with this package :
>   >> (sam9x60ek)
>   >>
>   >> Could you help please? 2022.01.1 is broken for me atm.
> 
>   > You should apply:
>   > https://git.buildroot.net/buildroot/commit/?id=789a08dac5808401629d6fc586b7377f54ebb316
> 
> That is already in 202.02.1:
> 
> https://git.buildroot.net/buildroot/commit/?h=2022.02.x&id=0397064a9a147903e9e0c16b2506319ea4a246fb
> 
>> as well as
>   > https://patchwork.ozlabs.org/project/buildroot/patch/DU0P251MB07797CAAE80C985DC8976335E3E79@DU0P251MB0779.EURP251.PROD.OUTLOOK.COM/
> 
> Is that an ack? ;)

I am testing that patch to see if it improves anything, but as you said 
Peter, the commit above is already in my tree.
> 
>   > Having said that, I fear that dhcp will have to be removed soon due to
>   > security concerns:
>   > https://gitlab.isc.org/isc-projects/dhcp/-/issues/233
> 
> Yeah. Eugen, is there any specific reason why you use the dhcp package
> over the other DHCP clients we provide?

Historical reasons, and the fact that people have working configurations 
using this package... I was unaware that it was due to be removed.
We will try to switch to a different package in the future. Thanks for 
letting me know.
However, if the package is still in this buildroot release, it has to 
work right ?
> 
> --
> Bye, Peter Korsgaard
> 

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/dhcp: use internal bind

[Eugen.Hristev--- via buildroot]

On 4/12/22 2:43 PM, Eugen Hristev - M18282 wrote:
> On 4/12/22 2:33 PM, Peter Korsgaard wrote:
>>>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
>>
>> Hi,
>>
>>>> Hello Peter, Fabrice,
>>    >>
>>    >> While your patch solves the isc/boolean.h problem, now I get several
>>    >> other problems when building an arm926 platform with this package :
>>    >> (sam9x60ek)
>>    >>
>>    >> Could you help please? 2022.01.1 is broken for me atm.
>>
>>    > You should apply:
>>    > https://git.buildroot.net/buildroot/commit/?id=789a08dac5808401629d6fc586b7377f54ebb316
>>
>> That is already in 202.02.1:
>>
>> https://git.buildroot.net/buildroot/commit/?h=2022.02.x&id=0397064a9a147903e9e0c16b2506319ea4a246fb
>>
>>> as well as
>>    > https://patchwork.ozlabs.org/project/buildroot/patch/DU0P251MB07797CAAE80C985DC8976335E3E79@DU0P251MB0779.EURP251.PROD.OUTLOOK.COM/
>>
>> Is that an ack? ;)
> 
> I am testing that patch to see if it improves anything, but as you said
> Peter, the commit above is already in my tree.

It appears that with this patch, I am getting both errors :


 >>> dhcp 4.4.2-P1 Building
PATH="/home/eugen/buildroot-2022.02/buildroot/output/host/bin:/home/eugen/buildroot-2022.02/buildroot/output/host/sbin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin" 
  /usr/bin/make -j1  -C 
/home/eugen/buildroot-2022.02/buildroot/output/build/dhcp-4.4.2-P1/
Making all in ./bind
Configuring BIND libraries for DHCP.
configure: WARNING: using cross tools not prefixed with host triplet
Building BIND libraries - this takes some time.
Building isc library in 
/home/eugen/buildroot-2022.02/buildroot/output/build/dhcp-4.4.2-P1/bind/bind-9.11.14/lib/isc
In file included from 
/home/eugen/buildroot-2022.02/buildroot/output/host/arm-buildroot-linux-gnueabi/sysroot/usr/include/bits/libc-header-start.h:33,
                  from 
/home/eugen/buildroot-2022.02/buildroot/output/host/arm-buildroot-linux-gnueabi/sysroot/usr/include/limits.h:26,
                  from 
/home/eugen/buildroot-2022.02/buildroot/output/host/lib/gcc/arm-buildroot-linux-gnueabi/10.3.0/include-fixed/limits.h:195,
                  from 
/home/eugen/buildroot-2022.02/buildroot/output/host/lib/gcc/arm-buildroot-linux-gnueabi/10.3.0/include-fixed/syslimits.h:7,
                  from 
/home/eugen/buildroot-2022.02/buildroot/output/host/lib/gcc/arm-buildroot-linux-gnueabi/10.3.0/include-fixed/limits.h:34,
                  from ./include/isc/platform.h:218,
                  from ./include/isc/bind9.h:18,
                  from ./include/isc/types.h:19,
                  from ./include/isc/safe.h:20,
                  from ./safe.c:18:
/home/eugen/buildroot-2022.02/buildroot/output/host/arm-buildroot-linux-gnueabi/sysroot/usr/include/features.h:412:4: 
warning: #warning _FORTIFY_SOURCE requires compiling with optimization 
(-O) [-Wcpp]
   412 | #  warning _FORTIFY_SOURCE requires compiling with optimization 
(-O)
       |    ^~~~~~~
stats.c: In function ‘setcounter’:
stats.c:300:29: error: ‘val’ undeclared (first use in this function); 
did you mean ‘value’?
   300 |  stats->counters[counter] = val;
       |                             ^~~
       |                             value
stats.c:300:29: note: each undeclared identifier is reported only once 
for each function it appears in
stats.c:286:20: warning: unused parameter ‘value’ [-Wunused-parameter]
   286 |     const uint64_t value)
       |     ~~~~~~~~~~~~~~~^~~~~
make[4]: *** [Makefile:290: stats.lo] Error 1
Building dns library in 
/home/eugen/buildroot-2022.02/buildroot/output/build/dhcp-4.4.2-P1/bind/bind-9.11.14/lib/dns
libtool:   error: cannot find the library '../../lib/isc/libisc.la' or 
unhandled argument '../../lib/isc/libisc.la'
make[4]: *** [Makefile:593: libdns.la] Error 1
Building isccfg library in 
/home/eugen/buildroot-2022.02/buildroot/output/build/dhcp-4.4.2-P1/bind/bind-9.11.14/lib/isccfg
libtool:   error: cannot find the library '../../lib/dns/libdns.la' or 
unhandled argument '../../lib/dns/libdns.la'
make[4]: *** [Makefile:482: libisccfg.la] Error 1
Building irs library in 
/home/eugen/buildroot-2022.02/buildroot/output/build/dhcp-4.4.2-P1/bind/bind-9.11.14/lib/irs
/usr/bin/ar: `u' modifier ignored since `D' is the default (see `U')
Installing BIND libraries to 
/home/eugen/buildroot-2022.02/buildroot/output/build/dhcp-4.4.2-P1/bind.
stats.c: In function ‘setcounter’:
stats.c:300:29: error: ‘val’ undeclared (first use in this function); 
did you mean ‘value’?
   300 |  stats->counters[counter] = val;
       |                             ^~~
       |                             value
stats.c:300:29: note: each undeclared identifier is reported only once 
for each function it appears in
stats.c:286:20: warning: unused parameter ‘value’ [-Wunused-parameter]
   286 |     const uint64_t value)
       |     ~~~~~~~~~~~~~~~^~~~~
make[4]: *** [Makefile:290: stats.lo] Error 1
libtool:   error: cannot find the library '../../lib/isc/libisc.la' or 
unhandled argument '../../lib/isc/libisc.la'
make[4]: *** [Makefile:593: libdns.la] Error 1
libtool:   error: cannot find the library '../../lib/dns/libdns.la' or 
unhandled argument '../../lib/dns/libdns.la'
make[4]: *** [Makefile:482: libisccfg.la] Error 1
mkdir 
/home/eugen/buildroot-2022.02/buildroot/output/build/dhcp-4.4.2-P1/bind/include
mkdir 
/home/eugen/buildroot-2022.02/buildroot/output/build/dhcp-4.4.2-P1/bind/include/irs
mkdir 
/home/eugen/buildroot-2022.02/buildroot/output/build/dhcp-4.4.2-P1/bind/lib
Making all in includes
/usr/bin/make  all-am
Making all in tests
make[3]: Nothing to be done for 'all'.
Making all in common
Making all in .
/bin/bash ../libtool  --tag=CC   --mode=compile 
/home/eugen/buildroot-2022.02/buildroot/output/host/bin/arm-buildroot-linux-gnueabi-gcc 
-DHAVE_CONFIG_H -I. -I../includes  -I.. -DLOCALSTATEDIR='"/var"' 
-D_PATH_DHCPD_CONF=\"/etc/dhcp/dhcpd.conf\" 
-D_PATH_DHCLIENT_CONF=\"/etc/dhcp/dhclient.conf\"  -D_LARGEFILE_SOURCE 
-D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64  -Ofast -g0 
-D_FORTIFY_SOURCE=1 -DISC_CHECK_NONE=1  -I../includes 
-I/home/eugen/buildroot-2022.02/buildroot/output/build/dhcp-4.4.2-P1/bind/include 
-c -o alloc.lo alloc.c
libtool: compile: 
/home/eugen/buildroot-2022.02/buildroot/output/host/bin/arm-buildroot-linux-gnueabi-gcc 
-DHAVE_CONFIG_H -I. -I../includes -I.. -DLOCALSTATEDIR=\"/var\" 
-D_PATH_DHCPD_CONF=\"/etc/dhcp/dhcpd.conf\" 
-D_PATH_DHCLIENT_CONF=\"/etc/dhcp/dhclient.conf\" -D_LARGEFILE_SOURCE 
-D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Ofast -g0 
-D_FORTIFY_SOURCE=1 -DISC_CHECK_NONE=1 -I../includes 
-I/home/eugen/buildroot-2022.02/buildroot/output/build/dhcp-4.4.2-P1/bind/include 
-c alloc.c  -fPIC -DPIC -o .libs/alloc.o
In file included from ../includes/dhcpd.h:91,
                  from alloc.c:29:
../includes/omapip/isclib.h:51:10: fatal error: isc/boolean.h: No such 
file or directory
    51 | #include <isc/boolean.h>
       |          ^~~~~~~~~~~~~~~
compilation terminated.
make[4]: *** [Makefile:561: alloc.lo] Error 1
make[3]: *** [Makefile:619: all-recursive] Error 1
make[2]: *** [Makefile:495: all-recursive] Error 1
make[1]: *** [package/pkg-generic.mk:292: 
/home/eugen/buildroot-2022.02/buildroot/output/build/dhcp-4.4.2-P1/.stamp_built] 
Error 2
make: *** [Makefile:84: _all] Error 2


>>
>>    > Having said that, I fear that dhcp will have to be removed soon due to
>>    > security concerns:
>>    > https://gitlab.isc.org/isc-projects/dhcp/-/issues/233
>>
>> Yeah. Eugen, is there any specific reason why you use the dhcp package
>> over the other DHCP clients we provide?
> 
> Historical reasons, and the fact that people have working configurations
> using this package... I was unaware that it was due to be removed.
> We will try to switch to a different package in the future. Thanks for
> letting me know.
> However, if the package is still in this buildroot release, it has to
> work right ?
>>
>> --
>> Bye, Peter Korsgaard
>>
> 

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/dhcp: use internal bind

[Peter Korsgaard]

>>>>>   <Eugen.Hristev@microchip.com> writes:

Hi,

 >> Yeah. Eugen, is there any specific reason why you use the dhcp package
 >> over the other DHCP clients we provide?

 > Historical reasons, and the fact that people have working configurations 
 > using this package... I was unaware that it was due to be removed.
 > We will try to switch to a different package in the future. Thanks for 
 > letting me know.
 > However, if the package is still in this buildroot release, it has to 
 > work right ?

Yes, that is the idea. If it is dead upstream and hard to fix then that
naturally makes it harder to do, but the intention is to fix it.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/dhcp: use internal bind

[Fabrice Fontaine]

Le mar. 12 avr. 2022 à 14:34, Peter Korsgaard <peter@korsgaard.com> a écrit :
>
> >>>>>   <Eugen.Hristev@microchip.com> writes:
>
> Hi,
>
>  >> Yeah. Eugen, is there any specific reason why you use the dhcp package
>  >> over the other DHCP clients we provide?
>
>  > Historical reasons, and the fact that people have working configurations
>  > using this package... I was unaware that it was due to be removed.
>  > We will try to switch to a different package in the future. Thanks for
>  > letting me know.
>  > However, if the package is still in this buildroot release, it has to
>  > work right ?
>
> Yes, that is the idea. If it is dead upstream and hard to fix then that
> naturally makes it harder to do, but the intention is to fix it.

The following patch should fix the issue:
https://patchwork.ozlabs.org/project/buildroot/patch/20220412181607.1451580-1-fontaine.fabrice@gmail.com/

>
> --
> Bye, Peter Korsgaard

Best Regards,

Fabrice
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/dhcp: use internal bind

[Eugen.Hristev--- via buildroot]

On 4/12/22 9:17 PM, Fabrice Fontaine wrote:
> Le mar. 12 avr. 2022 à 14:34, Peter Korsgaard <peter@korsgaard.com> a écrit :
>>
>>>>>>>    <Eugen.Hristev@microchip.com> writes:
>>
>> Hi,
>>
>>   >> Yeah. Eugen, is there any specific reason why you use the dhcp package
>>   >> over the other DHCP clients we provide?
>>
>>   > Historical reasons, and the fact that people have working configurations
>>   > using this package... I was unaware that it was due to be removed.
>>   > We will try to switch to a different package in the future. Thanks for
>>   > letting me know.
>>   > However, if the package is still in this buildroot release, it has to
>>   > work right ?
>>
>> Yes, that is the idea. If it is dead upstream and hard to fix then that
>> naturally makes it harder to do, but the intention is to fix it.
> 
> The following patch should fix the issue:
> https://patchwork.ozlabs.org/project/buildroot/patch/20220412181607.1451580-1-fontaine.fabrice@gmail.com/

Hi,

your patch together with the other one ( 
https://patchwork.ozlabs.org/project/buildroot/patch/DU0P251MB07797CAAE80C985DC8976335E3E79@DU0P251MB0779.EURP251.PROD.OUTLOOK.COM/ 
),

solve the build problem for this package.

Thank you !

Eugen

> 
>>
>> --
>> Bye, Peter Korsgaard
> 
> Best Regards,
> 
> Fabrice
> 

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/dhcp: use internal bind

[Peter Korsgaard]

>>>>>   <Eugen.Hristev@microchip.com> writes:

 > On 4/12/22 9:17 PM, Fabrice Fontaine wrote:
 >> Le mar. 12 avr. 2022 à 14:34, Peter Korsgaard <peter@korsgaard.com> a écrit :
 >>> 
 >>>>>>>> <Eugen.Hristev@microchip.com> writes:
 >>> 
 >>> Hi,
 >>> 
 >>> >> Yeah. Eugen, is there any specific reason why you use the dhcp package
 >>> >> over the other DHCP clients we provide?
 >>> 
 >>> > Historical reasons, and the fact that people have working configurations
 >>> > using this package... I was unaware that it was due to be removed.
 >>> > We will try to switch to a different package in the future. Thanks for
 >>> > letting me know.
 >>> > However, if the package is still in this buildroot release, it has to
 >>> > work right ?
 >>> 
 >>> Yes, that is the idea. If it is dead upstream and hard to fix then that
 >>> naturally makes it harder to do, but the intention is to fix it.
 >> 
 >> The following patch should fix the issue:
 >> https://patchwork.ozlabs.org/project/buildroot/patch/20220412181607.1451580-1-fontaine.fabrice@gmail.com/

 > Hi,

 > your patch together with the other one ( 
 > https://patchwork.ozlabs.org/project/buildroot/patch/DU0P251MB07797CAAE80C985DC8976335E3E79@DU0P251MB0779.EURP251.PROD.OUTLOOK.COM/
 > ),

 > solve the build problem for this package.

They are now both added to the 2022.02.x branch, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/dhcp: use internal bind

[Eugen.Hristev--- via buildroot]

On 4/13/22 11:29 AM, Peter Korsgaard wrote:
>>>>>>    <Eugen.Hristev@microchip.com> writes:
> 
>   > On 4/12/22 9:17 PM, Fabrice Fontaine wrote:
>   >> Le mar. 12 avr. 2022 à 14:34, Peter Korsgaard <peter@korsgaard.com> a écrit :
>   >>>
>   >>>>>>>> <Eugen.Hristev@microchip.com> writes:
>   >>>
>   >>> Hi,
>   >>>
>   >>> >> Yeah. Eugen, is there any specific reason why you use the dhcp package
>   >>> >> over the other DHCP clients we provide?
>   >>>
>   >>> > Historical reasons, and the fact that people have working configurations
>   >>> > using this package... I was unaware that it was due to be removed.
>   >>> > We will try to switch to a different package in the future. Thanks for
>   >>> > letting me know.
>   >>> > However, if the package is still in this buildroot release, it has to
>   >>> > work right ?
>   >>>
>   >>> Yes, that is the idea. If it is dead upstream and hard to fix then that
>   >>> naturally makes it harder to do, but the intention is to fix it.
>   >>
>   >> The following patch should fix the issue:
>   >> https://patchwork.ozlabs.org/project/buildroot/patch/20220412181607.1451580-1-fontaine.fabrice@gmail.com/
> 
>   > Hi,
> 
>   > your patch together with the other one (
>   > https://patchwork.ozlabs.org/project/buildroot/patch/DU0P251MB07797CAAE80C985DC8976335E3E79@DU0P251MB0779.EURP251.PROD.OUTLOOK.COM/
>   > ),
> 
>   > solve the build problem for this package.
> 
> They are now both added to the 2022.02.x branch, thanks.
> 
> --
> Bye, Peter Korsgaard
> 

Hello again Fabrice,

After managing to successfully build all our defconfigs now, while 
testing on another board (sama7g5ek), I noticed this message at boot log :

Starting DHCP server: /usr/sbin/dhcpd: error while loading shared 
libraries: libirs.so.161: cannot open shared object file: No such file 
or directory

Digging yields that libirs is part of bind package. Do you know why this 
happens and what could be the cause? Could latest patches affect the dhcpd ?

Thanks !
Eugen
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/dhcp: use internal bind

[Fabrice Fontaine]

Hello Eugen,

Le jeu. 14 avr. 2022 à 11:10, <Eugen.Hristev@microchip.com> a écrit :
>
> On 4/13/22 11:29 AM, Peter Korsgaard wrote:
> >>>>>>    <Eugen.Hristev@microchip.com> writes:
> >
> >   > On 4/12/22 9:17 PM, Fabrice Fontaine wrote:
> >   >> Le mar. 12 avr. 2022 à 14:34, Peter Korsgaard <peter@korsgaard.com> a écrit :
> >   >>>
> >   >>>>>>>> <Eugen.Hristev@microchip.com> writes:
> >   >>>
> >   >>> Hi,
> >   >>>
> >   >>> >> Yeah. Eugen, is there any specific reason why you use the dhcp package
> >   >>> >> over the other DHCP clients we provide?
> >   >>>
> >   >>> > Historical reasons, and the fact that people have working configurations
> >   >>> > using this package... I was unaware that it was due to be removed.
> >   >>> > We will try to switch to a different package in the future. Thanks for
> >   >>> > letting me know.
> >   >>> > However, if the package is still in this buildroot release, it has to
> >   >>> > work right ?
> >   >>>
> >   >>> Yes, that is the idea. If it is dead upstream and hard to fix then that
> >   >>> naturally makes it harder to do, but the intention is to fix it.
> >   >>
> >   >> The following patch should fix the issue:
> >   >> https://patchwork.ozlabs.org/project/buildroot/patch/20220412181607.1451580-1-fontaine.fabrice@gmail.com/
> >
> >   > Hi,
> >
> >   > your patch together with the other one (
> >   > https://patchwork.ozlabs.org/project/buildroot/patch/DU0P251MB07797CAAE80C985DC8976335E3E79@DU0P251MB0779.EURP251.PROD.OUTLOOK.COM/
> >   > ),
> >
> >   > solve the build problem for this package.
> >
> > They are now both added to the 2022.02.x branch, thanks.
> >
> > --
> > Bye, Peter Korsgaard
> >
>
> Hello again Fabrice,
>
> After managing to successfully build all our defconfigs now, while
> testing on another board (sama7g5ek), I noticed this message at boot log :
>
> Starting DHCP server: /usr/sbin/dhcpd: error while loading shared
> libraries: libirs.so.161: cannot open shared object file: No such file
> or directory
>
> Digging yields that libirs is part of bind package. Do you know why this
> happens and what could be the cause? Could latest patches affect the dhcpd ?

Indeed, the internal bind libraries (including libirs.so.161) are
correctly installed in staging directory but not in the target
directory because dhcp.mk is overriding DHCP_INSTALL_TARGET_CMDS.
I'll send a patch by the end of the day.

>
> Thanks !
> Eugen

Best Regards,

Fabrice
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/dhcp: use internal bind

[Fabrice Fontaine]

Le jeu. 14 avr. 2022 à 11:59, Fabrice Fontaine
<fontaine.fabrice@gmail.com> a écrit :
>
> Hello Eugen,
>
> Le jeu. 14 avr. 2022 à 11:10, <Eugen.Hristev@microchip.com> a écrit :
> >
> > On 4/13/22 11:29 AM, Peter Korsgaard wrote:
> > >>>>>>    <Eugen.Hristev@microchip.com> writes:
> > >
> > >   > On 4/12/22 9:17 PM, Fabrice Fontaine wrote:
> > >   >> Le mar. 12 avr. 2022 à 14:34, Peter Korsgaard <peter@korsgaard.com> a écrit :
> > >   >>>
> > >   >>>>>>>> <Eugen.Hristev@microchip.com> writes:
> > >   >>>
> > >   >>> Hi,
> > >   >>>
> > >   >>> >> Yeah. Eugen, is there any specific reason why you use the dhcp package
> > >   >>> >> over the other DHCP clients we provide?
> > >   >>>
> > >   >>> > Historical reasons, and the fact that people have working configurations
> > >   >>> > using this package... I was unaware that it was due to be removed.
> > >   >>> > We will try to switch to a different package in the future. Thanks for
> > >   >>> > letting me know.
> > >   >>> > However, if the package is still in this buildroot release, it has to
> > >   >>> > work right ?
> > >   >>>
> > >   >>> Yes, that is the idea. If it is dead upstream and hard to fix then that
> > >   >>> naturally makes it harder to do, but the intention is to fix it.
> > >   >>
> > >   >> The following patch should fix the issue:
> > >   >> https://patchwork.ozlabs.org/project/buildroot/patch/20220412181607.1451580-1-fontaine.fabrice@gmail.com/
> > >
> > >   > Hi,
> > >
> > >   > your patch together with the other one (
> > >   > https://patchwork.ozlabs.org/project/buildroot/patch/DU0P251MB07797CAAE80C985DC8976335E3E79@DU0P251MB0779.EURP251.PROD.OUTLOOK.COM/
> > >   > ),
> > >
> > >   > solve the build problem for this package.
> > >
> > > They are now both added to the 2022.02.x branch, thanks.
> > >
> > > --
> > > Bye, Peter Korsgaard
> > >
> >
> > Hello again Fabrice,
> >
> > After managing to successfully build all our defconfigs now, while
> > testing on another board (sama7g5ek), I noticed this message at boot log :
> >
> > Starting DHCP server: /usr/sbin/dhcpd: error while loading shared
> > libraries: libirs.so.161: cannot open shared object file: No such file
> > or directory
> >
> > Digging yields that libirs is part of bind package. Do you know why this
> > happens and what could be the cause? Could latest patches affect the dhcpd ?
>
> Indeed, the internal bind libraries (including libirs.so.161) are
> correctly installed in staging directory but not in the target
> directory because dhcp.mk is overriding DHCP_INSTALL_TARGET_CMDS.
> I'll send a patch by the end of the day.

The following patch should fix the issue:
https://patchwork.ozlabs.org/project/buildroot/patch/20220414164109.1724873-1-fontaine.fabrice@gmail.com/

>
> >
> > Thanks !
> > Eugen
>
> Best Regards,
>
> Fabrice

Best Regards,

Fabrice
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/dhcp: use internal bind

[Eugen.Hristev--- via buildroot]

On 4/14/22 7:44 PM, Fabrice Fontaine wrote:
> Le jeu. 14 avr. 2022 à 11:59, Fabrice Fontaine
> <fontaine.fabrice@gmail.com> a écrit :
>>
>> Hello Eugen,
>>
>> Le jeu. 14 avr. 2022 à 11:10, <Eugen.Hristev@microchip.com> a écrit :
>>>
>>> On 4/13/22 11:29 AM, Peter Korsgaard wrote:
>>>>>>>>>     <Eugen.Hristev@microchip.com> writes:
>>>>
>>>>    > On 4/12/22 9:17 PM, Fabrice Fontaine wrote:
>>>>    >> Le mar. 12 avr. 2022 à 14:34, Peter Korsgaard <peter@korsgaard.com> a écrit :
>>>>    >>>
>>>>    >>>>>>>> <Eugen.Hristev@microchip.com> writes:
>>>>    >>>
>>>>    >>> Hi,
>>>>    >>>
>>>>    >>> >> Yeah. Eugen, is there any specific reason why you use the dhcp package
>>>>    >>> >> over the other DHCP clients we provide?
>>>>    >>>
>>>>    >>> > Historical reasons, and the fact that people have working configurations
>>>>    >>> > using this package... I was unaware that it was due to be removed.
>>>>    >>> > We will try to switch to a different package in the future. Thanks for
>>>>    >>> > letting me know.
>>>>    >>> > However, if the package is still in this buildroot release, it has to
>>>>    >>> > work right ?
>>>>    >>>
>>>>    >>> Yes, that is the idea. If it is dead upstream and hard to fix then that
>>>>    >>> naturally makes it harder to do, but the intention is to fix it.
>>>>    >>
>>>>    >> The following patch should fix the issue:
>>>>    >> https://patchwork.ozlabs.org/project/buildroot/patch/20220412181607.1451580-1-fontaine.fabrice@gmail.com/
>>>>
>>>>    > Hi,
>>>>
>>>>    > your patch together with the other one (
>>>>    > https://patchwork.ozlabs.org/project/buildroot/patch/DU0P251MB07797CAAE80C985DC8976335E3E79@DU0P251MB0779.EURP251.PROD.OUTLOOK.COM/
>>>>    > ),
>>>>
>>>>    > solve the build problem for this package.
>>>>
>>>> They are now both added to the 2022.02.x branch, thanks.
>>>>
>>>> --
>>>> Bye, Peter Korsgaard
>>>>
>>>
>>> Hello again Fabrice,
>>>
>>> After managing to successfully build all our defconfigs now, while
>>> testing on another board (sama7g5ek), I noticed this message at boot log :
>>>
>>> Starting DHCP server: /usr/sbin/dhcpd: error while loading shared
>>> libraries: libirs.so.161: cannot open shared object file: No such file
>>> or directory
>>>
>>> Digging yields that libirs is part of bind package. Do you know why this
>>> happens and what could be the cause? Could latest patches affect the dhcpd ?
>>
>> Indeed, the internal bind libraries (including libirs.so.161) are
>> correctly installed in staging directory but not in the target
>> directory because dhcp.mk is overriding DHCP_INSTALL_TARGET_CMDS.
>> I'll send a patch by the end of the day.
> 
> The following patch should fix the issue:
> https://patchwork.ozlabs.org/project/buildroot/patch/20220414164109.1724873-1-fontaine.fabrice@gmail.com/
> 

Hello Fabrice,

The libirs problem is gone now, thanks. However, I get a new error:


Starting DHCP server: /usr/sbin/dhcpd: error while loading shared 
libraries: libisccfg.so.163: cannot open shared object file: No such 
file or directory

Looks like there are still problems on my side

Thanks,
Eugen

>>
>>>
>>> Thanks !
>>> Eugen
>>
>> Best Regards,
>>
>> Fabrice
> 
> Best Regards,
> 
> Fabrice
> 

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/dhcp: use internal bind

[Fabrice Fontaine]

Hello Eugen,

Le mar. 19 avr. 2022 à 07:21, <Eugen.Hristev@microchip.com> a écrit :
>
> On 4/14/22 7:44 PM, Fabrice Fontaine wrote:
> > Le jeu. 14 avr. 2022 à 11:59, Fabrice Fontaine
> > <fontaine.fabrice@gmail.com> a écrit :
> >>
> >> Hello Eugen,
> >>
> >> Le jeu. 14 avr. 2022 à 11:10, <Eugen.Hristev@microchip.com> a écrit :
> >>>
> >>> On 4/13/22 11:29 AM, Peter Korsgaard wrote:
> >>>>>>>>>     <Eugen.Hristev@microchip.com> writes:
> >>>>
> >>>>    > On 4/12/22 9:17 PM, Fabrice Fontaine wrote:
> >>>>    >> Le mar. 12 avr. 2022 à 14:34, Peter Korsgaard <peter@korsgaard.com> a écrit :
> >>>>    >>>
> >>>>    >>>>>>>> <Eugen.Hristev@microchip.com> writes:
> >>>>    >>>
> >>>>    >>> Hi,
> >>>>    >>>
> >>>>    >>> >> Yeah. Eugen, is there any specific reason why you use the dhcp package
> >>>>    >>> >> over the other DHCP clients we provide?
> >>>>    >>>
> >>>>    >>> > Historical reasons, and the fact that people have working configurations
> >>>>    >>> > using this package... I was unaware that it was due to be removed.
> >>>>    >>> > We will try to switch to a different package in the future. Thanks for
> >>>>    >>> > letting me know.
> >>>>    >>> > However, if the package is still in this buildroot release, it has to
> >>>>    >>> > work right ?
> >>>>    >>>
> >>>>    >>> Yes, that is the idea. If it is dead upstream and hard to fix then that
> >>>>    >>> naturally makes it harder to do, but the intention is to fix it.
> >>>>    >>
> >>>>    >> The following patch should fix the issue:
> >>>>    >> https://patchwork.ozlabs.org/project/buildroot/patch/20220412181607.1451580-1-fontaine.fabrice@gmail.com/
> >>>>
> >>>>    > Hi,
> >>>>
> >>>>    > your patch together with the other one (
> >>>>    > https://patchwork.ozlabs.org/project/buildroot/patch/DU0P251MB07797CAAE80C985DC8976335E3E79@DU0P251MB0779.EURP251.PROD.OUTLOOK.COM/
> >>>>    > ),
> >>>>
> >>>>    > solve the build problem for this package.
> >>>>
> >>>> They are now both added to the 2022.02.x branch, thanks.
> >>>>
> >>>> --
> >>>> Bye, Peter Korsgaard
> >>>>
> >>>
> >>> Hello again Fabrice,
> >>>
> >>> After managing to successfully build all our defconfigs now, while
> >>> testing on another board (sama7g5ek), I noticed this message at boot log :
> >>>
> >>> Starting DHCP server: /usr/sbin/dhcpd: error while loading shared
> >>> libraries: libirs.so.161: cannot open shared object file: No such file
> >>> or directory
> >>>
> >>> Digging yields that libirs is part of bind package. Do you know why this
> >>> happens and what could be the cause? Could latest patches affect the dhcpd ?
> >>
> >> Indeed, the internal bind libraries (including libirs.so.161) are
> >> correctly installed in staging directory but not in the target
> >> directory because dhcp.mk is overriding DHCP_INSTALL_TARGET_CMDS.
> >> I'll send a patch by the end of the day.
> >
> > The following patch should fix the issue:
> > https://patchwork.ozlabs.org/project/buildroot/patch/20220414164109.1724873-1-fontaine.fabrice@gmail.com/
> >
>
> Hello Fabrice,
>
> The libirs problem is gone now, thanks. However, I get a new error:
>
>
> Starting DHCP server: /usr/sbin/dhcpd: error while loading shared
> libraries: libisccfg.so.163: cannot open shared object file: No such
> file or directory
>
> Looks like there are still problems on my side

libisccfg.so.163 is installed on target rootfs (in /usr/lib). Can you
check that this is also the case on your side?

>
> Thanks,
> Eugen
>
> >>
> >>>
> >>> Thanks !
> >>> Eugen
> >>
> >> Best Regards,
> >>
> >> Fabrice
> >
> > Best Regards,
> >
> > Fabrice
> >
>

Best Regards,

Fabrice
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/dhcp: use internal bind

[Eugen.Hristev--- via buildroot]

On 4/19/22 12:08 PM, Fabrice Fontaine wrote:
> Hello Eugen,
> 
> Le mar. 19 avr. 2022 à 07:21, <Eugen.Hristev@microchip.com> a écrit :
>>
>> On 4/14/22 7:44 PM, Fabrice Fontaine wrote:
>>> Le jeu. 14 avr. 2022 à 11:59, Fabrice Fontaine
>>> <fontaine.fabrice@gmail.com> a écrit :
>>>>
>>>> Hello Eugen,
>>>>
>>>> Le jeu. 14 avr. 2022 à 11:10, <Eugen.Hristev@microchip.com> a écrit :
>>>>>
>>>>> On 4/13/22 11:29 AM, Peter Korsgaard wrote:
>>>>>>>>>>>      <Eugen.Hristev@microchip.com> writes:
>>>>>>
>>>>>>     > On 4/12/22 9:17 PM, Fabrice Fontaine wrote:
>>>>>>     >> Le mar. 12 avr. 2022 à 14:34, Peter Korsgaard <peter@korsgaard.com> a écrit :
>>>>>>     >>>
>>>>>>     >>>>>>>> <Eugen.Hristev@microchip.com> writes:
>>>>>>     >>>
>>>>>>     >>> Hi,
>>>>>>     >>>
>>>>>>     >>> >> Yeah. Eugen, is there any specific reason why you use the dhcp package
>>>>>>     >>> >> over the other DHCP clients we provide?
>>>>>>     >>>
>>>>>>     >>> > Historical reasons, and the fact that people have working configurations
>>>>>>     >>> > using this package... I was unaware that it was due to be removed.
>>>>>>     >>> > We will try to switch to a different package in the future. Thanks for
>>>>>>     >>> > letting me know.
>>>>>>     >>> > However, if the package is still in this buildroot release, it has to
>>>>>>     >>> > work right ?
>>>>>>     >>>
>>>>>>     >>> Yes, that is the idea. If it is dead upstream and hard to fix then that
>>>>>>     >>> naturally makes it harder to do, but the intention is to fix it.
>>>>>>     >>
>>>>>>     >> The following patch should fix the issue:
>>>>>>     >> https://patchwork.ozlabs.org/project/buildroot/patch/20220412181607.1451580-1-fontaine.fabrice@gmail.com/
>>>>>>
>>>>>>     > Hi,
>>>>>>
>>>>>>     > your patch together with the other one (
>>>>>>     > https://patchwork.ozlabs.org/project/buildroot/patch/DU0P251MB07797CAAE80C985DC8976335E3E79@DU0P251MB0779.EURP251.PROD.OUTLOOK.COM/
>>>>>>     > ),
>>>>>>
>>>>>>     > solve the build problem for this package.
>>>>>>
>>>>>> They are now both added to the 2022.02.x branch, thanks.
>>>>>>
>>>>>> --
>>>>>> Bye, Peter Korsgaard
>>>>>>
>>>>>
>>>>> Hello again Fabrice,
>>>>>
>>>>> After managing to successfully build all our defconfigs now, while
>>>>> testing on another board (sama7g5ek), I noticed this message at boot log :
>>>>>
>>>>> Starting DHCP server: /usr/sbin/dhcpd: error while loading shared
>>>>> libraries: libirs.so.161: cannot open shared object file: No such file
>>>>> or directory
>>>>>
>>>>> Digging yields that libirs is part of bind package. Do you know why this
>>>>> happens and what could be the cause? Could latest patches affect the dhcpd ?
>>>>
>>>> Indeed, the internal bind libraries (including libirs.so.161) are
>>>> correctly installed in staging directory but not in the target
>>>> directory because dhcp.mk is overriding DHCP_INSTALL_TARGET_CMDS.
>>>> I'll send a patch by the end of the day.
>>>
>>> The following patch should fix the issue:
>>> https://patchwork.ozlabs.org/project/buildroot/patch/20220414164109.1724873-1-fontaine.fabrice@gmail.com/
>>>
>>
>> Hello Fabrice,
>>
>> The libirs problem is gone now, thanks. However, I get a new error:
>>
>>
>> Starting DHCP server: /usr/sbin/dhcpd: error while loading shared
>> libraries: libisccfg.so.163: cannot open shared object file: No such
>> file or directory
>>
>> Looks like there are still problems on my side
> 
> libisccfg.so.163 is installed on target rootfs (in /usr/lib). Can you
> check that this is also the case on your side?

# ls -la /usr/lib/libisc*
lrwxrwxrwx    1 root     root            18 Apr 18  2022 
/usr/lib/libisc.so -> libisc.so.1107.0.7
lrwxrwxrwx    1 root     root            18 Apr 18  2022 
/usr/lib/libisc.so.1107 -> libisc.so.1107.0.7
-rwxr-xr-x    1 root     root        317960 Apr 18  2022 
/usr/lib/libisc.so.1107.0.7
#


It looks like it's not.

> 
>>
>> Thanks,
>> Eugen
>>
>>>>
>>>>>
>>>>> Thanks !
>>>>> Eugen
>>>>
>>>> Best Regards,
>>>>
>>>> Fabrice
>>>
>>> Best Regards,
>>>
>>> Fabrice
>>>
>>
> 
> Best Regards,
> 
> Fabrice
> 

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/dhcp: use internal bind

[Fabrice Fontaine]

Le mar. 19 avr. 2022 à 12:19, <Eugen.Hristev@microchip.com> a écrit :
>
> On 4/19/22 12:08 PM, Fabrice Fontaine wrote:
> > Hello Eugen,
> >
> > Le mar. 19 avr. 2022 à 07:21, <Eugen.Hristev@microchip.com> a écrit :
> >>
> >> On 4/14/22 7:44 PM, Fabrice Fontaine wrote:
> >>> Le jeu. 14 avr. 2022 à 11:59, Fabrice Fontaine
> >>> <fontaine.fabrice@gmail.com> a écrit :
> >>>>
> >>>> Hello Eugen,
> >>>>
> >>>> Le jeu. 14 avr. 2022 à 11:10, <Eugen.Hristev@microchip.com> a écrit :
> >>>>>
> >>>>> On 4/13/22 11:29 AM, Peter Korsgaard wrote:
> >>>>>>>>>>>      <Eugen.Hristev@microchip.com> writes:
> >>>>>>
> >>>>>>     > On 4/12/22 9:17 PM, Fabrice Fontaine wrote:
> >>>>>>     >> Le mar. 12 avr. 2022 à 14:34, Peter Korsgaard <peter@korsgaard.com> a écrit :
> >>>>>>     >>>
> >>>>>>     >>>>>>>> <Eugen.Hristev@microchip.com> writes:
> >>>>>>     >>>
> >>>>>>     >>> Hi,
> >>>>>>     >>>
> >>>>>>     >>> >> Yeah. Eugen, is there any specific reason why you use the dhcp package
> >>>>>>     >>> >> over the other DHCP clients we provide?
> >>>>>>     >>>
> >>>>>>     >>> > Historical reasons, and the fact that people have working configurations
> >>>>>>     >>> > using this package... I was unaware that it was due to be removed.
> >>>>>>     >>> > We will try to switch to a different package in the future. Thanks for
> >>>>>>     >>> > letting me know.
> >>>>>>     >>> > However, if the package is still in this buildroot release, it has to
> >>>>>>     >>> > work right ?
> >>>>>>     >>>
> >>>>>>     >>> Yes, that is the idea. If it is dead upstream and hard to fix then that
> >>>>>>     >>> naturally makes it harder to do, but the intention is to fix it.
> >>>>>>     >>
> >>>>>>     >> The following patch should fix the issue:
> >>>>>>     >> https://patchwork.ozlabs.org/project/buildroot/patch/20220412181607.1451580-1-fontaine.fabrice@gmail.com/
> >>>>>>
> >>>>>>     > Hi,
> >>>>>>
> >>>>>>     > your patch together with the other one (
> >>>>>>     > https://patchwork.ozlabs.org/project/buildroot/patch/DU0P251MB07797CAAE80C985DC8976335E3E79@DU0P251MB0779.EURP251.PROD.OUTLOOK.COM/
> >>>>>>     > ),
> >>>>>>
> >>>>>>     > solve the build problem for this package.
> >>>>>>
> >>>>>> They are now both added to the 2022.02.x branch, thanks.
> >>>>>>
> >>>>>> --
> >>>>>> Bye, Peter Korsgaard
> >>>>>>
> >>>>>
> >>>>> Hello again Fabrice,
> >>>>>
> >>>>> After managing to successfully build all our defconfigs now, while
> >>>>> testing on another board (sama7g5ek), I noticed this message at boot log :
> >>>>>
> >>>>> Starting DHCP server: /usr/sbin/dhcpd: error while loading shared
> >>>>> libraries: libirs.so.161: cannot open shared object file: No such file
> >>>>> or directory
> >>>>>
> >>>>> Digging yields that libirs is part of bind package. Do you know why this
> >>>>> happens and what could be the cause? Could latest patches affect the dhcpd ?
> >>>>
> >>>> Indeed, the internal bind libraries (including libirs.so.161) are
> >>>> correctly installed in staging directory but not in the target
> >>>> directory because dhcp.mk is overriding DHCP_INSTALL_TARGET_CMDS.
> >>>> I'll send a patch by the end of the day.
> >>>
> >>> The following patch should fix the issue:
> >>> https://patchwork.ozlabs.org/project/buildroot/patch/20220414164109.1724873-1-fontaine.fabrice@gmail.com/
> >>>
> >>
> >> Hello Fabrice,
> >>
> >> The libirs problem is gone now, thanks. However, I get a new error:
> >>
> >>
> >> Starting DHCP server: /usr/sbin/dhcpd: error while loading shared
> >> libraries: libisccfg.so.163: cannot open shared object file: No such
> >> file or directory
> >>
> >> Looks like there are still problems on my side
> >
> > libisccfg.so.163 is installed on target rootfs (in /usr/lib). Can you
> > check that this is also the case on your side?
>
> # ls -la /usr/lib/libisc*
> lrwxrwxrwx    1 root     root            18 Apr 18  2022
> /usr/lib/libisc.so -> libisc.so.1107.0.7
> lrwxrwxrwx    1 root     root            18 Apr 18  2022
> /usr/lib/libisc.so.1107 -> libisc.so.1107.0.7
> -rwxr-xr-x    1 root     root        317960 Apr 18  2022
> /usr/lib/libisc.so.1107.0.7
> #
>
>
> It looks like it's not.

I was able to find and fix the issue:
https://patchwork.ozlabs.org/project/buildroot/patch/20220419161130.3431492-1-fontaine.fabrice@gmail.com/

>
> >
> >>
> >> Thanks,
> >> Eugen
> >>
> >>>>
> >>>>>
> >>>>> Thanks !
> >>>>> Eugen
> >>>>
> >>>> Best Regards,
> >>>>
> >>>> Fabrice
> >>>
> >>> Best Regards,
> >>>
> >>> Fabrice
> >>>
> >>
> >
> > Best Regards,
> >
> > Fabrice
> >
>
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/dhcp: use internal bind

[Eugen.Hristev--- via buildroot]

On 4/19/22 7:12 PM, Fabrice Fontaine wrote:
> Le mar. 19 avr. 2022 à 12:19, <Eugen.Hristev@microchip.com> a écrit :
>>
>> On 4/19/22 12:08 PM, Fabrice Fontaine wrote:
>>> Hello Eugen,
>>>
>>> Le mar. 19 avr. 2022 à 07:21, <Eugen.Hristev@microchip.com> a écrit :
>>>>
>>>> On 4/14/22 7:44 PM, Fabrice Fontaine wrote:
>>>>> Le jeu. 14 avr. 2022 à 11:59, Fabrice Fontaine
>>>>> <fontaine.fabrice@gmail.com> a écrit :
>>>>>>
>>>>>> Hello Eugen,
>>>>>>
>>>>>> Le jeu. 14 avr. 2022 à 11:10, <Eugen.Hristev@microchip.com> a écrit :
>>>>>>>
>>>>>>> On 4/13/22 11:29 AM, Peter Korsgaard wrote:
>>>>>>>>>>>>>       <Eugen.Hristev@microchip.com> writes:
>>>>>>>>
>>>>>>>>      > On 4/12/22 9:17 PM, Fabrice Fontaine wrote:
>>>>>>>>      >> Le mar. 12 avr. 2022 à 14:34, Peter Korsgaard <peter@korsgaard.com> a écrit :
>>>>>>>>      >>>
>>>>>>>>      >>>>>>>> <Eugen.Hristev@microchip.com> writes:
>>>>>>>>      >>>
>>>>>>>>      >>> Hi,
>>>>>>>>      >>>
>>>>>>>>      >>> >> Yeah. Eugen, is there any specific reason why you use the dhcp package
>>>>>>>>      >>> >> over the other DHCP clients we provide?
>>>>>>>>      >>>
>>>>>>>>      >>> > Historical reasons, and the fact that people have working configurations
>>>>>>>>      >>> > using this package... I was unaware that it was due to be removed.
>>>>>>>>      >>> > We will try to switch to a different package in the future. Thanks for
>>>>>>>>      >>> > letting me know.
>>>>>>>>      >>> > However, if the package is still in this buildroot release, it has to
>>>>>>>>      >>> > work right ?
>>>>>>>>      >>>
>>>>>>>>      >>> Yes, that is the idea. If it is dead upstream and hard to fix then that
>>>>>>>>      >>> naturally makes it harder to do, but the intention is to fix it.
>>>>>>>>      >>
>>>>>>>>      >> The following patch should fix the issue:
>>>>>>>>      >> https://patchwork.ozlabs.org/project/buildroot/patch/20220412181607.1451580-1-fontaine.fabrice@gmail.com/
>>>>>>>>
>>>>>>>>      > Hi,
>>>>>>>>
>>>>>>>>      > your patch together with the other one (
>>>>>>>>      > https://patchwork.ozlabs.org/project/buildroot/patch/DU0P251MB07797CAAE80C985DC8976335E3E79@DU0P251MB0779.EURP251.PROD.OUTLOOK.COM/
>>>>>>>>      > ),
>>>>>>>>
>>>>>>>>      > solve the build problem for this package.
>>>>>>>>
>>>>>>>> They are now both added to the 2022.02.x branch, thanks.
>>>>>>>>
>>>>>>>> --
>>>>>>>> Bye, Peter Korsgaard
>>>>>>>>
>>>>>>>
>>>>>>> Hello again Fabrice,
>>>>>>>
>>>>>>> After managing to successfully build all our defconfigs now, while
>>>>>>> testing on another board (sama7g5ek), I noticed this message at boot log :
>>>>>>>
>>>>>>> Starting DHCP server: /usr/sbin/dhcpd: error while loading shared
>>>>>>> libraries: libirs.so.161: cannot open shared object file: No such file
>>>>>>> or directory
>>>>>>>
>>>>>>> Digging yields that libirs is part of bind package. Do you know why this
>>>>>>> happens and what could be the cause? Could latest patches affect the dhcpd ?
>>>>>>
>>>>>> Indeed, the internal bind libraries (including libirs.so.161) are
>>>>>> correctly installed in staging directory but not in the target
>>>>>> directory because dhcp.mk is overriding DHCP_INSTALL_TARGET_CMDS.
>>>>>> I'll send a patch by the end of the day.
>>>>>
>>>>> The following patch should fix the issue:
>>>>> https://patchwork.ozlabs.org/project/buildroot/patch/20220414164109.1724873-1-fontaine.fabrice@gmail.com/
>>>>>
>>>>
>>>> Hello Fabrice,
>>>>
>>>> The libirs problem is gone now, thanks. However, I get a new error:
>>>>
>>>>
>>>> Starting DHCP server: /usr/sbin/dhcpd: error while loading shared
>>>> libraries: libisccfg.so.163: cannot open shared object file: No such
>>>> file or directory
>>>>
>>>> Looks like there are still problems on my side
>>>
>>> libisccfg.so.163 is installed on target rootfs (in /usr/lib). Can you
>>> check that this is also the case on your side?
>>
>> # ls -la /usr/lib/libisc*
>> lrwxrwxrwx    1 root     root            18 Apr 18  2022
>> /usr/lib/libisc.so -> libisc.so.1107.0.7
>> lrwxrwxrwx    1 root     root            18 Apr 18  2022
>> /usr/lib/libisc.so.1107 -> libisc.so.1107.0.7
>> -rwxr-xr-x    1 root     root        317960 Apr 18  2022
>> /usr/lib/libisc.so.1107.0.7
>> #
>>
>>
>> It looks like it's not.
> 
> I was able to find and fix the issue:
> https://patchwork.ozlabs.org/project/buildroot/patch/20220419161130.3431492-1-fontaine.fabrice@gmail.com/
> 

Thank you for your patches !
It looks that it works fine now.

Sent a reviewed-by tag on your patch.

Eugen
>>
>>>
>>>>
>>>> Thanks,
>>>> Eugen
>>>>
>>>>>>
>>>>>>>
>>>>>>> Thanks !
>>>>>>> Eugen
>>>>>>
>>>>>> Best Regards,
>>>>>>
>>>>>> Fabrice
>>>>>
>>>>> Best Regards,
>>>>>
>>>>> Fabrice
>>>>>
>>>>
>>>
>>> Best Regards,
>>>
>>> Fabrice
>>>
>>

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 1/1] package/dhcp: use internal bind

[Edmundo Ferreira]

On Sun, 2022-04-03 at 12:03 +0200, Fabrice Fontaine wrote:

> Use internal bind as dhcp doesn't build since bump of bind to version
> 9.16.26 in commit 8adeaec8afacbc680edebae91524f6144926ac92 and
> upstream
> doesn't plan to fix it any time soon:
> https://gitlab.isc.org/isc-projects/dhcp/-/issues/233#note_276883
>
> In file included from ../includes/dhcpd.h:91,
>                  from ctrace.c:29:
> ../includes/omapip/isclib.h:51:10: fatal error: isc/boolean.h: No
> such file or directory
>    51 | #include <isc/boolean.h>
>       |          ^~~~~~~~~~~~~~~
>
> Fixes:
>  -
> http://autobuild.buildroot.org/results/d18b006dce7b46631ce8f4c72fb97eb861993939
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> Reviewed-by: James Hilliard <james.hilliard1@gmail.com>
> ---
>  package/dhcp/Config.in |  1 -
>  package/dhcp/dhcp.mk   | 19 ++++++++++++++++---
>  2 files changed, 16 insertions(+), 4 deletions(-)
>
> diff --git a/package/dhcp/Config.in b/package/dhcp/Config.in
> index 515040c612..e0706efafb 100644
> --- a/package/dhcp/Config.in
> +++ b/package/dhcp/Config.in
> @@ -3,7 +3,6 @@ config BR2_PACKAGE_DHCP
>         # fork()
>         depends on BR2_USE_MMU
>         depends on BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
> -       select BR2_PACKAGE_BIND
>         help
>           DHCP relay agent from the ISC DHCP distribution.
>
> diff --git a/package/dhcp/dhcp.mk b/package/dhcp/dhcp.mk
> index 18765a3639..f1e3c22f1c 100644
> --- a/package/dhcp/dhcp.mk
> +++ b/package/dhcp/dhcp.mk
> @@ -9,8 +9,10 @@ DHCP_SITE =
> https://ftp.isc.org/isc/dhcp/$(DHCP_VERSION)
>  DHCP_INSTALL_STAGING = YES
>  DHCP_LICENSE = MPL-2.0
>  DHCP_LICENSE_FILES = LICENSE
> -DHCP_DEPENDENCIES = bind host-gawk
> +DHCP_DEPENDENCIES = host-gawk
>  DHCP_CPE_ID_VENDOR = isc
> +# internal bind does not support parallel builds.
> +DHCP_MAKE = $(MAKE1)
>
>  # use libtool-enabled configure.ac
>  define DHCP_LIBTOOL_AUTORECONF
> @@ -21,11 +23,12 @@ DHCP_CONF_ENV = \
>         CPPFLAGS='-D_PATH_DHCPD_CONF=\"/etc/dhcp/dhcpd.conf\" \
>                 -D_PATH_DHCLIENT_CONF=\"/etc/dhcp/dhclient.conf\"' \
>         CFLAGS='$(TARGET_CFLAGS) -DISC_CHECK_NONE=1'
> +DHCP_BIND_EXTRA_CONFIG = BUILD_CC='$(TARGET_CC)'
>
>  DHCP_CONF_ENV += ac_cv_prog_AWK=$(HOST_DIR)/bin/gawk
>
>  DHCP_CONF_OPTS = \
> -       --with-libbind=$(STAGING_DIR)/usr \
> +       --with-bind-extra-config="$(DHCP_BIND_EXTRA_CONFIG)" \
>         --with-randomdev=/dev/random \
>         --with-srv-lease-file=/var/lib/dhcp/dhcpd.leases \
>         --with-srv6-lease-file=/var/lib/dhcp/dhcpd6.leases \
> @@ -38,8 +41,18 @@ DHCP_CONF_OPTS = \
>         --with-relay-pid-file=/var/run/dhcrelay.pid \
>         --with-relay6-pid-file=/var/run/dhcrelay6.pid
>
> +ifeq ($(BR2_PACKAGE_ZLIB),y)
> +DHCP_BIND_EXTRA_CONFIG += --with-zlib
> +DHCP_DEPENDENCIES += zlib
> +else
> +DHCP_BIND_EXTRA_CONFIG += --without-zlib
> +endif
> +
> +ifeq ($(BR2_TOOLCHAIN_HAS_LIBATOMIC),y)
> +DHCP_CONF_ENV += LIBS=-latomic
> +endif
> +
>  ifeq ($(BR2_STATIC_LIBS),y)
> -DHCP_CONF_ENV += LIBS="`$(STAGING_DIR)/usr/bin/bind9-config --libs
> bind9`"
>  DHCP_CONF_OPTS += --disable-libtool
>  else
>  DHCP_POST_EXTRACT_HOOKS += DHCP_LIBTOOL_AUTORECONF

I can confirm that this issue is also present in 2022.02.x branch.
A backport to that branch would be nice.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/dhcp: use internal bind

[Tim Hammer]

On Sun, Apr 03, 2022 at 12:03:18PM +0200, Fabrice Fontaine wrote:
> Use internal bind as dhcp doesn't build since bump of bind to version
> 9.16.26 in commit 8adeaec8afacbc680edebae91524f6144926ac92 and upstream
> doesn't plan to fix it any time soon:
> https://gitlab.isc.org/isc-projects/dhcp/-/issues/233#note_276883
> 
> In file included from ../includes/dhcpd.h:91,
>                  from ctrace.c:29:
> ../includes/omapip/isclib.h:51:10: fatal error: isc/boolean.h: No such file or directory
>    51 | #include <isc/boolean.h>
>       |          ^~~~~~~~~~~~~~~
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/d18b006dce7b46631ce8f4c72fb97eb861993939
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/dhcp/Config.in |  1 -
>  package/dhcp/dhcp.mk   | 19 ++++++++++++++++---
>  2 files changed, 16 insertions(+), 4 deletions(-)
> 
> diff --git a/package/dhcp/Config.in b/package/dhcp/Config.in
> index 515040c612..e0706efafb 100644
> --- a/package/dhcp/Config.in
> +++ b/package/dhcp/Config.in
> @@ -3,7 +3,6 @@ config BR2_PACKAGE_DHCP
>  	# fork()
>  	depends on BR2_USE_MMU
>  	depends on BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
> -	select BR2_PACKAGE_BIND
>  	help
>  	  DHCP relay agent from the ISC DHCP distribution.
>  
> diff --git a/package/dhcp/dhcp.mk b/package/dhcp/dhcp.mk
> index 18765a3639..f1e3c22f1c 100644
> --- a/package/dhcp/dhcp.mk
> +++ b/package/dhcp/dhcp.mk
> @@ -9,8 +9,10 @@ DHCP_SITE = https://ftp.isc.org/isc/dhcp/$(DHCP_VERSION)
>  DHCP_INSTALL_STAGING = YES
>  DHCP_LICENSE = MPL-2.0
>  DHCP_LICENSE_FILES = LICENSE
> -DHCP_DEPENDENCIES = bind host-gawk
> +DHCP_DEPENDENCIES = host-gawk
>  DHCP_CPE_ID_VENDOR = isc
> +# internal bind does not support parallel builds.
> +DHCP_MAKE = $(MAKE1)
>  
>  # use libtool-enabled configure.ac
>  define DHCP_LIBTOOL_AUTORECONF
> @@ -21,11 +23,12 @@ DHCP_CONF_ENV = \
>  	CPPFLAGS='-D_PATH_DHCPD_CONF=\"/etc/dhcp/dhcpd.conf\" \
>  		-D_PATH_DHCLIENT_CONF=\"/etc/dhcp/dhclient.conf\"' \
>  	CFLAGS='$(TARGET_CFLAGS) -DISC_CHECK_NONE=1'
> +DHCP_BIND_EXTRA_CONFIG = BUILD_CC='$(TARGET_CC)'
>  

The only place BUILD_CC is used in the bundled bind-9.11 is to build lib/dns/gen, which needs to run on the host.
So this should be the host compiler, not the target.
I do not know the best/correct way to indicate this. To get past the issue I changed it to '/usr/bin/gcc'...

.Tim
Tim D. Hammer
tim.hammer@orolia.com

>  DHCP_CONF_ENV += ac_cv_prog_AWK=$(HOST_DIR)/bin/gawk
>  
>  DHCP_CONF_OPTS = \
> -	--with-libbind=$(STAGING_DIR)/usr \
> +	--with-bind-extra-config="$(DHCP_BIND_EXTRA_CONFIG)" \
>  	--with-randomdev=/dev/random \
>  	--with-srv-lease-file=/var/lib/dhcp/dhcpd.leases \
>  	--with-srv6-lease-file=/var/lib/dhcp/dhcpd6.leases \
> @@ -38,8 +41,18 @@ DHCP_CONF_OPTS = \
>  	--with-relay-pid-file=/var/run/dhcrelay.pid \
>  	--with-relay6-pid-file=/var/run/dhcrelay6.pid
>  
> +ifeq ($(BR2_PACKAGE_ZLIB),y)
> +DHCP_BIND_EXTRA_CONFIG += --with-zlib
> +DHCP_DEPENDENCIES += zlib
> +else
> +DHCP_BIND_EXTRA_CONFIG += --without-zlib
> +endif
> +
> +ifeq ($(BR2_TOOLCHAIN_HAS_LIBATOMIC),y)
> +DHCP_CONF_ENV += LIBS=-latomic
> +endif
> +
>  ifeq ($(BR2_STATIC_LIBS),y)
> -DHCP_CONF_ENV += LIBS="`$(STAGING_DIR)/usr/bin/bind9-config --libs bind9`"
>  DHCP_CONF_OPTS += --disable-libtool
>  else
>  DHCP_POST_EXTRACT_HOOKS += DHCP_LIBTOOL_AUTORECONF
> -- 
> 2.35.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/dhcp: use internal bind

[Fabrice Fontaine]

Dear Tim,

Le mar. 5 avr. 2022 à 05:54, Tim Hammer <Tim.Hammer@orolia.com> a écrit :
>
> On Sun, Apr 03, 2022 at 12:03:18PM +0200, Fabrice Fontaine wrote:
> > Use internal bind as dhcp doesn't build since bump of bind to version
> > 9.16.26 in commit 8adeaec8afacbc680edebae91524f6144926ac92 and upstream
> > doesn't plan to fix it any time soon:
> > https://gitlab.isc.org/isc-projects/dhcp/-/issues/233#note_276883
> >
> > In file included from ../includes/dhcpd.h:91,
> >                  from ctrace.c:29:
> > ../includes/omapip/isclib.h:51:10: fatal error: isc/boolean.h: No such file or directory
> >    51 | #include <isc/boolean.h>
> >       |          ^~~~~~~~~~~~~~~
> >
> > Fixes:
> >  - http://autobuild.buildroot.org/results/d18b006dce7b46631ce8f4c72fb97eb861993939
> >
> > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> > ---
> >  package/dhcp/Config.in |  1 -
> >  package/dhcp/dhcp.mk   | 19 ++++++++++++++++---
> >  2 files changed, 16 insertions(+), 4 deletions(-)
> >
> > diff --git a/package/dhcp/Config.in b/package/dhcp/Config.in
> > index 515040c612..e0706efafb 100644
> > --- a/package/dhcp/Config.in
> > +++ b/package/dhcp/Config.in
> > @@ -3,7 +3,6 @@ config BR2_PACKAGE_DHCP
> >       # fork()
> >       depends on BR2_USE_MMU
> >       depends on BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
> > -     select BR2_PACKAGE_BIND
> >       help
> >         DHCP relay agent from the ISC DHCP distribution.
> >
> > diff --git a/package/dhcp/dhcp.mk b/package/dhcp/dhcp.mk
> > index 18765a3639..f1e3c22f1c 100644
> > --- a/package/dhcp/dhcp.mk
> > +++ b/package/dhcp/dhcp.mk
> > @@ -9,8 +9,10 @@ DHCP_SITE = https://ftp.isc.org/isc/dhcp/$(DHCP_VERSION)
> >  DHCP_INSTALL_STAGING = YES
> >  DHCP_LICENSE = MPL-2.0
> >  DHCP_LICENSE_FILES = LICENSE
> > -DHCP_DEPENDENCIES = bind host-gawk
> > +DHCP_DEPENDENCIES = host-gawk
> >  DHCP_CPE_ID_VENDOR = isc
> > +# internal bind does not support parallel builds.
> > +DHCP_MAKE = $(MAKE1)
> >
> >  # use libtool-enabled configure.ac
> >  define DHCP_LIBTOOL_AUTORECONF
> > @@ -21,11 +23,12 @@ DHCP_CONF_ENV = \
> >       CPPFLAGS='-D_PATH_DHCPD_CONF=\"/etc/dhcp/dhcpd.conf\" \
> >               -D_PATH_DHCLIENT_CONF=\"/etc/dhcp/dhclient.conf\"' \
> >       CFLAGS='$(TARGET_CFLAGS) -DISC_CHECK_NONE=1'
> > +DHCP_BIND_EXTRA_CONFIG = BUILD_CC='$(TARGET_CC)'
> >
>
> The only place BUILD_CC is used in the bundled bind-9.11 is to build lib/dns/gen, which needs to run on the host.
> So this should be the host compiler, not the target.
> I do not know the best/correct way to indicate this. To get past the issue I changed it to '/usr/bin/gcc'...

Thanks for spotting this, I basically copy/pasted what was done in bind.mk.
The correct way to do this is to use $(HOST_CC) instead of $(TARGET_CC).

However, I assume that BUILD_CC and BUILD_CFLAGS in bind.mk should
also be updated?

Could you send those two patches (dhcp and bind) to the buildroot
mailing or do you prefer that I send them?

>
> .Tim
> Tim D. Hammer
> tim.hammer@orolia.com
>
> >  DHCP_CONF_ENV += ac_cv_prog_AWK=$(HOST_DIR)/bin/gawk
> >
> >  DHCP_CONF_OPTS = \
> > -     --with-libbind=$(STAGING_DIR)/usr \
> > +     --with-bind-extra-config="$(DHCP_BIND_EXTRA_CONFIG)" \
> >       --with-randomdev=/dev/random \
> >       --with-srv-lease-file=/var/lib/dhcp/dhcpd.leases \
> >       --with-srv6-lease-file=/var/lib/dhcp/dhcpd6.leases \
> > @@ -38,8 +41,18 @@ DHCP_CONF_OPTS = \
> >       --with-relay-pid-file=/var/run/dhcrelay.pid \
> >       --with-relay6-pid-file=/var/run/dhcrelay6.pid
> >
> > +ifeq ($(BR2_PACKAGE_ZLIB),y)
> > +DHCP_BIND_EXTRA_CONFIG += --with-zlib
> > +DHCP_DEPENDENCIES += zlib
> > +else
> > +DHCP_BIND_EXTRA_CONFIG += --without-zlib
> > +endif
> > +
> > +ifeq ($(BR2_TOOLCHAIN_HAS_LIBATOMIC),y)
> > +DHCP_CONF_ENV += LIBS=-latomic
> > +endif
> > +
> >  ifeq ($(BR2_STATIC_LIBS),y)
> > -DHCP_CONF_ENV += LIBS="`$(STAGING_DIR)/usr/bin/bind9-config --libs bind9`"
> >  DHCP_CONF_OPTS += --disable-libtool
> >  else
> >  DHCP_POST_EXTRACT_HOOKS += DHCP_LIBTOOL_AUTORECONF
> > --
> > 2.35.1
> >
> > _______________________________________________
> > buildroot mailing list
> > buildroot@buildroot.org
> > https://lists.buildroot.org/mailman/listinfo/buildroot
>

Best Regards,

Fabrice
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/dhcp: use internal bind

[Tim Hammer]

On Tue, Apr 05, 2022 at 08:19:08AM +0200, Fabrice Fontaine wrote:
> Dear Tim,
> 
> Le mar. 5 avr. 2022 à 05:54, Tim Hammer <Tim.Hammer@orolia.com> a écrit :
> >
> > On Sun, Apr 03, 2022 at 12:03:18PM +0200, Fabrice Fontaine wrote:
> > > Use internal bind as dhcp doesn't build since bump of bind to version
> > > 9.16.26 in commit 8adeaec8afacbc680edebae91524f6144926ac92 and upstream
> > > doesn't plan to fix it any time soon:
> > > https://gitlab.isc.org/isc-projects/dhcp/-/issues/233#note_276883
> > >
> > > In file included from ../includes/dhcpd.h:91,
> > >                  from ctrace.c:29:
> > > ../includes/omapip/isclib.h:51:10: fatal error: isc/boolean.h: No such file or directory
> > >    51 | #include <isc/boolean.h>
> > >       |          ^~~~~~~~~~~~~~~
> > >
> > >   ...
> > >
> > >  # use libtool-enabled configure.ac
> > >  define DHCP_LIBTOOL_AUTORECONF
> > > @@ -21,11 +23,12 @@ DHCP_CONF_ENV = \
> > >       CPPFLAGS='-D_PATH_DHCPD_CONF=\"/etc/dhcp/dhcpd.conf\" \
> > >               -D_PATH_DHCLIENT_CONF=\"/etc/dhcp/dhclient.conf\"' \
> > >       CFLAGS='$(TARGET_CFLAGS) -DISC_CHECK_NONE=1'
> > > +DHCP_BIND_EXTRA_CONFIG = BUILD_CC='$(TARGET_CC)'
> > >
> >
> > The only place BUILD_CC is used in the bundled bind-9.11 is to build lib/dns/gen, which needs to run on the host.
> > So this should be the host compiler, not the target.
> > I do not know the best/correct way to indicate this. To get past the issue I changed it to '/usr/bin/gcc'...
> 
> Thanks for spotting this, I basically copy/pasted what was done in bind.mk.
> The correct way to do this is to use $(HOST_CC) instead of $(TARGET_CC).
> 

This is why I said I do not know the correct way- when I use $(HOST_CC), I get
     >>> dhcp 4.4.2-P1 Building
     PATH="/home/thammer/Public/buildroot/TEST/host/bin:/home/thammer/Public/buildroot/TEST/host/sbin:/home/thammer/.local/bin:/home/thammer/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin:/opt/altera/nios2eds/bin/gnu/H-x86_64-pc-linux-gnu/bin:/opt/altera/nios2eds/sdk2/bin:/opt/altera/nios2eds/bin:/opt/altera/quartus/bin:/opt/altera/quartus/sopc_builder/bin"  /usr/bin/make -j1  -C /home/thammer/Public/buildroot/TEST/build/dhcp-4.4.2-P1/
     Making all in ./bind
     Configuring BIND libraries for DHCP.
     configure: WARNING: using cross tools not prefixed with host triplet
     configure: error: BUILD_CC not set
     make[3]: *** [Makefile:42: bind1] Error 1


> However, I assume that BUILD_CC and BUILD_CFLAGS in bind.mk should
> also be updated?

I do not have the issue building bind (9.16.26), there lib/dns/Makefile.in seems to be better written:

     gen: gen.c
	${HOSTCC} ${HOST_CFLAGS} -I${top_srcdir}/lib/isc/include \
	${HOST_LDFLAGS} -o $@ ${srcdir}/gen.c

Perhaps we should be patching that file instead of the config?

> 
> Could you send those two patches (dhcp and bind) to the buildroot
> mailing or do you prefer that I send them?
> 

I can try out my other thought and send that in a while (if it seems to work).

> > ...
> >
> 
> Best Regards,
> Fabrice

.Tim
Tim D. Hammer
tim.hammer@orolia.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/dhcp: use internal bind

[Peter Seiderer]

Hello Tim,

On Tue, 5 Apr 2022 12:15:14 +0000, Tim Hammer <Tim.Hammer@orolia.com> wrote:

> On Tue, Apr 05, 2022 at 08:19:08AM +0200, Fabrice Fontaine wrote:
> > Dear Tim,
> > 
> > Le mar. 5 avr. 2022 à 05:54, Tim Hammer <Tim.Hammer@orolia.com> a écrit :  
> > >
> > > On Sun, Apr 03, 2022 at 12:03:18PM +0200, Fabrice Fontaine wrote:  
> > > > Use internal bind as dhcp doesn't build since bump of bind to version
> > > > 9.16.26 in commit 8adeaec8afacbc680edebae91524f6144926ac92 and upstream
> > > > doesn't plan to fix it any time soon:
> > > > https://gitlab.isc.org/isc-projects/dhcp/-/issues/233#note_276883
> > > >
> > > > In file included from ../includes/dhcpd.h:91,
> > > >                  from ctrace.c:29:
> > > > ../includes/omapip/isclib.h:51:10: fatal error: isc/boolean.h: No such file or directory
> > > >    51 | #include <isc/boolean.h>
> > > >       |          ^~~~~~~~~~~~~~~
> > > >
> > > >   ...
> > > >
> > > >  # use libtool-enabled configure.ac
> > > >  define DHCP_LIBTOOL_AUTORECONF
> > > > @@ -21,11 +23,12 @@ DHCP_CONF_ENV = \
> > > >       CPPFLAGS='-D_PATH_DHCPD_CONF=\"/etc/dhcp/dhcpd.conf\" \
> > > >               -D_PATH_DHCLIENT_CONF=\"/etc/dhcp/dhclient.conf\"' \
> > > >       CFLAGS='$(TARGET_CFLAGS) -DISC_CHECK_NONE=1'
> > > > +DHCP_BIND_EXTRA_CONFIG = BUILD_CC='$(TARGET_CC)'
> > > >  
> > >
> > > The only place BUILD_CC is used in the bundled bind-9.11 is to build lib/dns/gen, which needs to run on the host.
> > > So this should be the host compiler, not the target.
> > > I do not know the best/correct way to indicate this. To get past the issue I changed it to '/usr/bin/gcc'...  
> > 
> > Thanks for spotting this, I basically copy/pasted what was done in bind.mk.
> > The correct way to do this is to use $(HOST_CC) instead of $(TARGET_CC).
> >   
> 
> This is why I said I do not know the correct way- when I use $(HOST_CC), I get
>      >>> dhcp 4.4.2-P1 Building  
>      PATH="/home/thammer/Public/buildroot/TEST/host/bin:/home/thammer/Public/buildroot/TEST/host/sbin:/home/thammer/.local/bin:/home/thammer/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin:/opt/altera/nios2eds/bin/gnu/H-x86_64-pc-linux-gnu/bin:/opt/altera/nios2eds/sdk2/bin:/opt/altera/nios2eds/bin:/opt/altera/quartus/bin:/opt/altera/quartus/sopc_builder/bin"  /usr/bin/make -j1  -C /home/thammer/Public/buildroot/TEST/build/dhcp-4.4.2-P1/
>      Making all in ./bind
>      Configuring BIND libraries for DHCP.
>      configure: WARNING: using cross tools not prefixed with host triplet
>      configure: error: BUILD_CC not set
>      make[3]: *** [Makefile:42: bind1] Error 1
> 
> 
> > However, I assume that BUILD_CC and BUILD_CFLAGS in bind.mk should
> > also be updated?  
> 
> I do not have the issue building bind (9.16.26), there lib/dns/Makefile.in seems to be better written:
> 
>      gen: gen.c
> 	${HOSTCC} ${HOST_CFLAGS} -I${top_srcdir}/lib/isc/include \
> 	${HOST_LDFLAGS} -o $@ ${srcdir}/gen.c
> 
> Perhaps we should be patching that file instead of the config?

See https://git.buildroot.net/buildroot/tree/package/bind/0001-cross.patch

Regards,
Peter


> 
> > 
> > Could you send those two patches (dhcp and bind) to the buildroot
> > mailing or do you prefer that I send them?
> >   
> 
> I can try out my other thought and send that in a while (if it seems to work).
> 
> > > ...
> > >  
> > 
> > Best Regards,
> > Fabrice  
> 
> .Tim
> Tim D. Hammer
> tim.hammer@orolia.com
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/dhcp: use internal bind

[Tim Hammer]

On Tue, Apr 05, 2022 at 06:18:15PM +0200, Peter Seiderer wrote:
> Hello Tim,
> 
> On Tue, 5 Apr 2022 12:15:14 +0000, Tim Hammer <Tim.Hammer@orolia.com> wrote:
> 
> > On Tue, Apr 05, 2022 at 08:19:08AM +0200, Fabrice Fontaine wrote:
> > > Dear Tim,
> > > 
> > > Le mar. 5 avr. 2022 à 05:54, Tim Hammer <Tim.Hammer@orolia.com> a écrit :  
> > > >
> > > > On Sun, Apr 03, 2022 at 12:03:18PM +0200, Fabrice Fontaine wrote:  
> > > > > Use internal bind as dhcp doesn't build since bump of bind to version
> > > > > 9.16.26 in commit 8adeaec8afacbc680edebae91524f6144926ac92 and upstream
> > > > > doesn't plan to fix it any time soon:
> > > > > https://gitlab.isc.org/isc-projects/dhcp/-/issues/233#note_276883
> > > > >
> > > > > In file included from ../includes/dhcpd.h:91,
> > > > >                  from ctrace.c:29:
> > > > > ../includes/omapip/isclib.h:51:10: fatal error: isc/boolean.h: No such file or directory
> > > > >    51 | #include <isc/boolean.h>
> > > > >       |          ^~~~~~~~~~~~~~~
> > > > >
> > > > >   ...
> > > > >
> > > > >  # use libtool-enabled configure.ac
> > > > >  define DHCP_LIBTOOL_AUTORECONF
> > > > > @@ -21,11 +23,12 @@ DHCP_CONF_ENV = \
> > > > >       CPPFLAGS='-D_PATH_DHCPD_CONF=\"/etc/dhcp/dhcpd.conf\" \
> > > > >               -D_PATH_DHCLIENT_CONF=\"/etc/dhcp/dhclient.conf\"' \
> > > > >       CFLAGS='$(TARGET_CFLAGS) -DISC_CHECK_NONE=1'
> > > > > +DHCP_BIND_EXTRA_CONFIG = BUILD_CC='$(TARGET_CC)'
> > > > >  
> > > >
> > > > The only place BUILD_CC is used in the bundled bind-9.11 is to build lib/dns/gen, which needs to run on the host.
> > > > So this should be the host compiler, not the target.
> > > > I do not know the best/correct way to indicate this. To get past the issue I changed it to '/usr/bin/gcc'...  
> > > 
> > > Thanks for spotting this, I basically copy/pasted what was done in bind.mk.
> > > The correct way to do this is to use $(HOST_CC) instead of $(TARGET_CC).
> > >   
> > 
> > This is why I said I do not know the correct way- when I use $(HOST_CC), I get
> >      >>> dhcp 4.4.2-P1 Building  
> >      PATH="/home/thammer/Public/buildroot/TEST/host/bin:/home/thammer/Public/buildroot/TEST/host/sbin:/home/thammer/.local/bin:/home/thammer/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin:/opt/altera/nios2eds/bin/gnu/H-x86_64-pc-linux-gnu/bin:/opt/altera/nios2eds/sdk2/bin:/opt/altera/nios2eds/bin:/opt/altera/quartus/bin:/opt/altera/quartus/sopc_builder/bin"  /usr/bin/make -j1  -C /home/thammer/Public/buildroot/TEST/build/dhcp-4.4.2-P1/
> >      Making all in ./bind
> >      Configuring BIND libraries for DHCP.
> >      configure: WARNING: using cross tools not prefixed with host triplet
> >      configure: error: BUILD_CC not set
> >      make[3]: *** [Makefile:42: bind1] Error 1
> > 
> > 
> > > However, I assume that BUILD_CC and BUILD_CFLAGS in bind.mk should
> > > also be updated?  
> > 
> > I do not have the issue building bind (9.16.26), there lib/dns/Makefile.in seems to be better written:
> > 
> >      gen: gen.c
> > 	${HOSTCC} ${HOST_CFLAGS} -I${top_srcdir}/lib/isc/include \
> > 	${HOST_LDFLAGS} -o $@ ${srcdir}/gen.c
> > 
> > Perhaps we should be patching that file instead of the config?
> 
> See https://git.buildroot.net/buildroot/tree/package/bind/0001-cross.patch
> 
> Regards,
> Peter
> 

Yes, that reinforces my thinking. Unfortunately, the bundled bind is not unzipped until the build step
and I have not figured out a good way to get this diff in place.
Perhaps someone with more experience can see the solution that is eluding me?

.Tim
Tim D. Hammer
tim.hammer@orolia.com

> 
> > 
> > > 
> > > Could you send those two patches (dhcp and bind) to the buildroot
> > > mailing or do you prefer that I send them?
> > >   
> > 
> > I can try out my other thought and send that in a while (if it seems to work).
> > 
> > > > ...
> > > >  
> > > 
> > > Best Regards,
> > > Fabrice  
> > 
> > .Tim
> > Tim D. Hammer
> > tim.hammer@orolia.com
> > _______________________________________________
> > buildroot mailing list
> > buildroot@buildroot.org
> > https://lists.buildroot.org/mailman/listinfo/buildroot
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/dhcp: use internal bind

[Fabrice Fontaine]

Le mer. 6 avr. 2022 à 03:58, Tim Hammer <Tim.Hammer@orolia.com> a écrit :
>
> On Tue, Apr 05, 2022 at 06:18:15PM +0200, Peter Seiderer wrote:
> > Hello Tim,
> >
> > On Tue, 5 Apr 2022 12:15:14 +0000, Tim Hammer <Tim.Hammer@orolia.com> wrote:
> >
> > > On Tue, Apr 05, 2022 at 08:19:08AM +0200, Fabrice Fontaine wrote:
> > > > Dear Tim,
> > > >
> > > > Le mar. 5 avr. 2022 à 05:54, Tim Hammer <Tim.Hammer@orolia.com> a écrit :
> > > > >
> > > > > On Sun, Apr 03, 2022 at 12:03:18PM +0200, Fabrice Fontaine wrote:
> > > > > > Use internal bind as dhcp doesn't build since bump of bind to version
> > > > > > 9.16.26 in commit 8adeaec8afacbc680edebae91524f6144926ac92 and upstream
> > > > > > doesn't plan to fix it any time soon:
> > > > > > https://gitlab.isc.org/isc-projects/dhcp/-/issues/233#note_276883
> > > > > >
> > > > > > In file included from ../includes/dhcpd.h:91,
> > > > > >                  from ctrace.c:29:
> > > > > > ../includes/omapip/isclib.h:51:10: fatal error: isc/boolean.h: No such file or directory
> > > > > >    51 | #include <isc/boolean.h>
> > > > > >       |          ^~~~~~~~~~~~~~~
> > > > > >
> > > > > >   ...
> > > > > >
> > > > > >  # use libtool-enabled configure.ac
> > > > > >  define DHCP_LIBTOOL_AUTORECONF
> > > > > > @@ -21,11 +23,12 @@ DHCP_CONF_ENV = \
> > > > > >       CPPFLAGS='-D_PATH_DHCPD_CONF=\"/etc/dhcp/dhcpd.conf\" \
> > > > > >               -D_PATH_DHCLIENT_CONF=\"/etc/dhcp/dhclient.conf\"' \
> > > > > >       CFLAGS='$(TARGET_CFLAGS) -DISC_CHECK_NONE=1'
> > > > > > +DHCP_BIND_EXTRA_CONFIG = BUILD_CC='$(TARGET_CC)'
> > > > > >
> > > > >
> > > > > The only place BUILD_CC is used in the bundled bind-9.11 is to build lib/dns/gen, which needs to run on the host.
> > > > > So this should be the host compiler, not the target.
> > > > > I do not know the best/correct way to indicate this. To get past the issue I changed it to '/usr/bin/gcc'...
> > > >
> > > > Thanks for spotting this, I basically copy/pasted what was done in bind.mk.
> > > > The correct way to do this is to use $(HOST_CC) instead of $(TARGET_CC).
> > > >
> > >
> > > This is why I said I do not know the correct way- when I use $(HOST_CC), I get
> > >      >>> dhcp 4.4.2-P1 Building
> > >      PATH="/home/thammer/Public/buildroot/TEST/host/bin:/home/thammer/Public/buildroot/TEST/host/sbin:/home/thammer/.local/bin:/home/thammer/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin:/opt/altera/nios2eds/bin/gnu/H-x86_64-pc-linux-gnu/bin:/opt/altera/nios2eds/sdk2/bin:/opt/altera/nios2eds/bin:/opt/altera/quartus/bin:/opt/altera/quartus/sopc_builder/bin"  /usr/bin/make -j1  -C /home/thammer/Public/buildroot/TEST/build/dhcp-4.4.2-P1/
> > >      Making all in ./bind
> > >      Configuring BIND libraries for DHCP.
> > >      configure: WARNING: using cross tools not prefixed with host triplet
> > >      configure: error: BUILD_CC not set
> > >      make[3]: *** [Makefile:42: bind1] Error 1
> > >
> > >
> > > > However, I assume that BUILD_CC and BUILD_CFLAGS in bind.mk should
> > > > also be updated?
> > >
> > > I do not have the issue building bind (9.16.26), there lib/dns/Makefile.in seems to be better written:
> > >
> > >      gen: gen.c
> > >     ${HOSTCC} ${HOST_CFLAGS} -I${top_srcdir}/lib/isc/include \
> > >     ${HOST_LDFLAGS} -o $@ ${srcdir}/gen.c
> > >
> > > Perhaps we should be patching that file instead of the config?
> >
> > See https://git.buildroot.net/buildroot/tree/package/bind/0001-cross.patch
> >
> > Regards,
> > Peter
> >
>
> Yes, that reinforces my thinking. Unfortunately, the bundled bind is not unzipped until the build step
> and I have not figured out a good way to get this diff in place.
> Perhaps someone with more experience can see the solution that is eluding me?

My bad, I made a typo in my first mail, you should use $(HOSTCC) and
not $(HOST_CC).
Patching bind is not needed.
I can send the patch or let you handle it.

>
> .Tim
> Tim D. Hammer
> tim.hammer@orolia.com
>
> >
> > >
> > > >
> > > > Could you send those two patches (dhcp and bind) to the buildroot
> > > > mailing or do you prefer that I send them?
> > > >
> > >
> > > I can try out my other thought and send that in a while (if it seems to work).
> > >
> > > > > ...
> > > > >
> > > >
> > > > Best Regards,
> > > > Fabrice
> > >
> > > .Tim
> > > Tim D. Hammer
> > > tim.hammer@orolia.com
> > > _______________________________________________
> > > buildroot mailing list
> > > buildroot@buildroot.org
> > > https://lists.buildroot.org/mailman/listinfo/buildroot
> >
> > _______________________________________________
> > buildroot mailing list
> > buildroot@buildroot.org
> > https://lists.buildroot.org/mailman/listinfo/buildroot

Best Regards,

Fabrice
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/dhcp: use internal bind

[Tim Hammer]

On Wed, Apr 06, 2022 at 09:08:58AM +0200, Fabrice Fontaine wrote:
> Le mer. 6 avr. 2022 à 03:58, Tim Hammer <Tim.Hammer@orolia.com> a écrit :
> >
> > On Tue, Apr 05, 2022 at 06:18:15PM +0200, Peter Seiderer wrote:
> > > Hello Tim,
> > >
> > > On Tue, 5 Apr 2022 12:15:14 +0000, Tim Hammer <Tim.Hammer@orolia.com> wrote:
> > >
> > > > On Tue, Apr 05, 2022 at 08:19:08AM +0200, Fabrice Fontaine wrote:
> > > > > Dear Tim,
> > > > >
> > > > > Le mar. 5 avr. 2022 à 05:54, Tim Hammer <Tim.Hammer@orolia.com> a écrit :
> > > > > >
> > > > > > On Sun, Apr 03, 2022 at 12:03:18PM +0200, Fabrice Fontaine wrote:
> > > > > > > Use internal bind as dhcp doesn't build since bump of bind to version
> > > > > > > 9.16.26 in commit 8adeaec8afacbc680edebae91524f6144926ac92 and upstream
> > > > > > > doesn't plan to fix it any time soon:
> > > > > > > https://gitlab.isc.org/isc-projects/dhcp/-/issues/233#note_276883
> > > > > > >
...
> > > >
> > > >
> > > > > However, I assume that BUILD_CC and BUILD_CFLAGS in bind.mk should
> > > > > also be updated?
> > > >
> > > > I do not have the issue building bind (9.16.26), there lib/dns/Makefile.in seems to be better written:
> > > >
> > > >      gen: gen.c
> > > >     ${HOSTCC} ${HOST_CFLAGS} -I${top_srcdir}/lib/isc/include \
> > > >     ${HOST_LDFLAGS} -o $@ ${srcdir}/gen.c
> > > >
> > > > Perhaps we should be patching that file instead of the config?
> > >
> > > See https://git.buildroot.net/buildroot/tree/package/bind/0001-cross.patch
> > >
> > > Regards,
> > > Peter
> > >
> >
> > Yes, that reinforces my thinking. Unfortunately, the bundled bind is not unzipped until the build step
> > and I have not figured out a good way to get this diff in place.
> > Perhaps someone with more experience can see the solution that is eluding me?
> 
> My bad, I made a typo in my first mail, you should use $(HOSTCC) and
> not $(HOST_CC).

Wow, how many times did I look at those lines and not see the difference! ;-(
Thanks for catching that!

> Patching bind is not needed.
> I can send the patch or let you handle it.

I am still concerned about my ability to verify-
I added "corrections" for BUILD_CFLAGS & BUILD_LDFLAGS so those match the changes in bind.mk,
        -DHCP_BIND_EXTRA_CONFIG = BUILD_CC='$(TARGET_CC)'
        +
        +DHCP_BIND_EXTRA_CONFIG = BUILD_CC='$(HOSTCC)'
        +DHCP_BIND_EXTRA_CONFIG += BUILD_CFLAGS='$(HOST_CFLAGS)'
        +DHCP_BIND_EXTRA_CONFIG += BUILD_LDFLAGS='$(HOST_LDFLAGS)'
but I am unsure about the others used (BUILD_CPPFLAGS, BUILD_LIBS, LFS_*)...
        ${BUILD_CC} ${BUILD_CFLAGS} -I${top_srcdir}/lib/isc/include \
        ${LFS_CFLAGS} ${LFS_LDFLAGS} \
        ${BUILD_CPPFLAGS} ${BUILD_LDFLAGS} -o $@ ${srcdir}/gen.c \
        ${BUILD_LIBS} ${LFS_LIBS}
Should those be set to empty strings? Or is it safe to assume they are undefined by default?

>
...
> 
> Best Regards,
> 
> Fabrice

.Tim
Tim D. Hammer
tim.hammer@orolia.com


_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/dhcp: use internal bind

[Fabrice Fontaine]

Le mer. 6 avr. 2022 à 14:58, Tim Hammer <Tim.Hammer@orolia.com> a écrit :
>
> On Wed, Apr 06, 2022 at 09:08:58AM +0200, Fabrice Fontaine wrote:
> > Le mer. 6 avr. 2022 à 03:58, Tim Hammer <Tim.Hammer@orolia.com> a écrit :
> > >
> > > On Tue, Apr 05, 2022 at 06:18:15PM +0200, Peter Seiderer wrote:
> > > > Hello Tim,
> > > >
> > > > On Tue, 5 Apr 2022 12:15:14 +0000, Tim Hammer <Tim.Hammer@orolia.com> wrote:
> > > >
> > > > > On Tue, Apr 05, 2022 at 08:19:08AM +0200, Fabrice Fontaine wrote:
> > > > > > Dear Tim,
> > > > > >
> > > > > > Le mar. 5 avr. 2022 à 05:54, Tim Hammer <Tim.Hammer@orolia.com> a écrit :
> > > > > > >
> > > > > > > On Sun, Apr 03, 2022 at 12:03:18PM +0200, Fabrice Fontaine wrote:
> > > > > > > > Use internal bind as dhcp doesn't build since bump of bind to version
> > > > > > > > 9.16.26 in commit 8adeaec8afacbc680edebae91524f6144926ac92 and upstream
> > > > > > > > doesn't plan to fix it any time soon:
> > > > > > > > https://gitlab.isc.org/isc-projects/dhcp/-/issues/233#note_276883
> > > > > > > >
> ...
> > > > >
> > > > >
> > > > > > However, I assume that BUILD_CC and BUILD_CFLAGS in bind.mk should
> > > > > > also be updated?
> > > > >
> > > > > I do not have the issue building bind (9.16.26), there lib/dns/Makefile.in seems to be better written:
> > > > >
> > > > >      gen: gen.c
> > > > >     ${HOSTCC} ${HOST_CFLAGS} -I${top_srcdir}/lib/isc/include \
> > > > >     ${HOST_LDFLAGS} -o $@ ${srcdir}/gen.c
> > > > >
> > > > > Perhaps we should be patching that file instead of the config?
> > > >
> > > > See https://git.buildroot.net/buildroot/tree/package/bind/0001-cross.patch
> > > >
> > > > Regards,
> > > > Peter
> > > >
> > >
> > > Yes, that reinforces my thinking. Unfortunately, the bundled bind is not unzipped until the build step
> > > and I have not figured out a good way to get this diff in place.
> > > Perhaps someone with more experience can see the solution that is eluding me?
> >
> > My bad, I made a typo in my first mail, you should use $(HOSTCC) and
> > not $(HOST_CC).
>
> Wow, how many times did I look at those lines and not see the difference! ;-(
> Thanks for catching that!
>
> > Patching bind is not needed.
> > I can send the patch or let you handle it.
>
> I am still concerned about my ability to verify-
> I added "corrections" for BUILD_CFLAGS & BUILD_LDFLAGS so those match the changes in bind.mk,
>         -DHCP_BIND_EXTRA_CONFIG = BUILD_CC='$(TARGET_CC)'
>         +
>         +DHCP_BIND_EXTRA_CONFIG = BUILD_CC='$(HOSTCC)'
>         +DHCP_BIND_EXTRA_CONFIG += BUILD_CFLAGS='$(HOST_CFLAGS)'
>         +DHCP_BIND_EXTRA_CONFIG += BUILD_LDFLAGS='$(HOST_LDFLAGS)'
> but I am unsure about the others used (BUILD_CPPFLAGS, BUILD_LIBS, LFS_*)...
>         ${BUILD_CC} ${BUILD_CFLAGS} -I${top_srcdir}/lib/isc/include \
>         ${LFS_CFLAGS} ${LFS_LDFLAGS} \
>         ${BUILD_CPPFLAGS} ${BUILD_LDFLAGS} -o $@ ${srcdir}/gen.c \
>         ${BUILD_LIBS} ${LFS_LIBS}
> Should those be set to empty strings? Or is it safe to assume they are undefined by default?

BUILD_CPPFLAGS should be set to HOST_CPPFLAGS.
IMHO it is safe to assume that BUILD_LIBS and LFS_* are empty.

Feel free to send your patch with a link to the autobuilder failure such as:

Fixes:
 - http://autobuild.buildroot.org/results/7a5cdf30881d208807976cf98960c5fe2abfed50

Arnout or the others will make a second review and spot any remaining issues.

>
> >
> ...
> >
> > Best Regards,
> >
> > Fabrice
>
> .Tim
> Tim D. Hammer
> tim.hammer@orolia.com
>
>

Best Regards,

Fabrice
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/dhcp: use internal bind

[Fabrice Fontaine]

Le mer. 6 avr. 2022 à 15:30, Fabrice Fontaine
<fontaine.fabrice@gmail.com> a écrit :
>
> Le mer. 6 avr. 2022 à 14:58, Tim Hammer <Tim.Hammer@orolia.com> a écrit :
> >
> > On Wed, Apr 06, 2022 at 09:08:58AM +0200, Fabrice Fontaine wrote:
> > > Le mer. 6 avr. 2022 à 03:58, Tim Hammer <Tim.Hammer@orolia.com> a écrit :
> > > >
> > > > On Tue, Apr 05, 2022 at 06:18:15PM +0200, Peter Seiderer wrote:
> > > > > Hello Tim,
> > > > >
> > > > > On Tue, 5 Apr 2022 12:15:14 +0000, Tim Hammer <Tim.Hammer@orolia.com> wrote:
> > > > >
> > > > > > On Tue, Apr 05, 2022 at 08:19:08AM +0200, Fabrice Fontaine wrote:
> > > > > > > Dear Tim,
> > > > > > >
> > > > > > > Le mar. 5 avr. 2022 à 05:54, Tim Hammer <Tim.Hammer@orolia.com> a écrit :
> > > > > > > >
> > > > > > > > On Sun, Apr 03, 2022 at 12:03:18PM +0200, Fabrice Fontaine wrote:
> > > > > > > > > Use internal bind as dhcp doesn't build since bump of bind to version
> > > > > > > > > 9.16.26 in commit 8adeaec8afacbc680edebae91524f6144926ac92 and upstream
> > > > > > > > > doesn't plan to fix it any time soon:
> > > > > > > > > https://gitlab.isc.org/isc-projects/dhcp/-/issues/233#note_276883
> > > > > > > > >
> > ...
> > > > > >
> > > > > >
> > > > > > > However, I assume that BUILD_CC and BUILD_CFLAGS in bind.mk should
> > > > > > > also be updated?
> > > > > >
> > > > > > I do not have the issue building bind (9.16.26), there lib/dns/Makefile.in seems to be better written:
> > > > > >
> > > > > >      gen: gen.c
> > > > > >     ${HOSTCC} ${HOST_CFLAGS} -I${top_srcdir}/lib/isc/include \
> > > > > >     ${HOST_LDFLAGS} -o $@ ${srcdir}/gen.c
> > > > > >
> > > > > > Perhaps we should be patching that file instead of the config?
> > > > >
> > > > > See https://git.buildroot.net/buildroot/tree/package/bind/0001-cross.patch
> > > > >
> > > > > Regards,
> > > > > Peter
> > > > >
> > > >
> > > > Yes, that reinforces my thinking. Unfortunately, the bundled bind is not unzipped until the build step
> > > > and I have not figured out a good way to get this diff in place.
> > > > Perhaps someone with more experience can see the solution that is eluding me?
> > >
> > > My bad, I made a typo in my first mail, you should use $(HOSTCC) and
> > > not $(HOST_CC).
> >
> > Wow, how many times did I look at those lines and not see the difference! ;-(
> > Thanks for catching that!
> >
> > > Patching bind is not needed.
> > > I can send the patch or let you handle it.
> >
> > I am still concerned about my ability to verify-
> > I added "corrections" for BUILD_CFLAGS & BUILD_LDFLAGS so those match the changes in bind.mk,
> >         -DHCP_BIND_EXTRA_CONFIG = BUILD_CC='$(TARGET_CC)'
> >         +
> >         +DHCP_BIND_EXTRA_CONFIG = BUILD_CC='$(HOSTCC)'
> >         +DHCP_BIND_EXTRA_CONFIG += BUILD_CFLAGS='$(HOST_CFLAGS)'
> >         +DHCP_BIND_EXTRA_CONFIG += BUILD_LDFLAGS='$(HOST_LDFLAGS)'
> > but I am unsure about the others used (BUILD_CPPFLAGS, BUILD_LIBS, LFS_*)...
> >         ${BUILD_CC} ${BUILD_CFLAGS} -I${top_srcdir}/lib/isc/include \
> >         ${LFS_CFLAGS} ${LFS_LDFLAGS} \
> >         ${BUILD_CPPFLAGS} ${BUILD_LDFLAGS} -o $@ ${srcdir}/gen.c \
> >         ${BUILD_LIBS} ${LFS_LIBS}
> > Should those be set to empty strings? Or is it safe to assume they are undefined by default?
>
> BUILD_CPPFLAGS should be set to HOST_CPPFLAGS.
> IMHO it is safe to assume that BUILD_LIBS and LFS_* are empty.
>
> Feel free to send your patch with a link to the autobuilder failure such as:
>
> Fixes:
>  - http://autobuild.buildroot.org/results/7a5cdf30881d208807976cf98960c5fe2abfed50

The correct link is
http://autobuild.buildroot.org/results/da6fd904d1a6bae73b6ff89dd008de1f459bb7d7

The previous one is about zlib, I'll investigate it.


>
> Arnout or the others will make a second review and spot any remaining issues.
>
> >
> > >
> > ...
> > >
> > > Best Regards,
> > >
> > > Fabrice
> >
> > .Tim
> > Tim D. Hammer
> > tim.hammer@orolia.com
> >
> >
>
> Best Regards,
>
> Fabrice

Best Regards,

Fabrice
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot