All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Noralf Trønnes" <noralf@tronnes.org>
To: Paul Bolle <pebolle@tiscali.nl>, Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 6/6] drm: Add helper for simple display pipeline
Date: Wed, 11 May 2016 21:30:44 +0200	[thread overview]
Message-ID: <350ccaa0-5164-d022-1eca-5da10b766156@tronnes.org> (raw)
In-Reply-To: <1462993816.7800.17.camel@tiscali.nl>


Den 11.05.2016 21:10, skrev Paul Bolle:
> On wo, 2016-05-11 at 19:09 +0200, Daniel Vetter wrote:
>> On Wed, May 11, 2016 at 06:09:22PM +0200, Noralf Trønnes wrote:
>>> --- a/drivers/gpu/drm/Kconfig
>>> +++ b/drivers/gpu/drm/Kconfig
>>> +config DRM_SIMPLE_KMS_HELPER
>>> +	tristate
>>> +	depends on DRM
>>> +	select DRM_KMS_HELPER
>>> +	help
>>> +	  Helpers for very simple KMS drivers.
>> Personally not sold on piles of Kconfig knobs for tiny amounts of code
>> like this one. I'd just drop it. For a more elaborate argument see
>> http://sietch-tagr.blogspot.ch/2016/04/display-panels-are-not-special.html
>>
>> Note that almost all the other helpers do not have a Kconfig option, the
>> only real exception is the fbdev helpers. And those have a good reason:
>> They'd drag in all of fbdev, and that is actually a pile of code.
> Moreover, this adds a kconfig entry without a prompt. The entry also
> doesn't have a "default". And I didn't spot a patch adding a select for
> this symbol. So, based on just this series, I think that
> DRM_SIMPLE_KMS_HELPER can't actually be set.
>
> I didn't test this, so perhaps I missed something. Did I, Noralf?

It would have been selected in the tinydrm follow-up patchset, but
I'll do as Daniel suggests and add it to drm_kms_helper-y.

Noralf.

WARNING: multiple messages have this Message-ID (diff)
From: "Noralf Trønnes" <noralf@tronnes.org>
To: Paul Bolle <pebolle@tiscali.nl>, Daniel Vetter <daniel@ffwll.ch>
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2 6/6] drm: Add helper for simple display pipeline
Date: Wed, 11 May 2016 21:30:44 +0200	[thread overview]
Message-ID: <350ccaa0-5164-d022-1eca-5da10b766156@tronnes.org> (raw)
In-Reply-To: <1462993816.7800.17.camel@tiscali.nl>


Den 11.05.2016 21:10, skrev Paul Bolle:
> On wo, 2016-05-11 at 19:09 +0200, Daniel Vetter wrote:
>> On Wed, May 11, 2016 at 06:09:22PM +0200, Noralf Trønnes wrote:
>>> --- a/drivers/gpu/drm/Kconfig
>>> +++ b/drivers/gpu/drm/Kconfig
>>> +config DRM_SIMPLE_KMS_HELPER
>>> +	tristate
>>> +	depends on DRM
>>> +	select DRM_KMS_HELPER
>>> +	help
>>> +	  Helpers for very simple KMS drivers.
>> Personally not sold on piles of Kconfig knobs for tiny amounts of code
>> like this one. I'd just drop it. For a more elaborate argument see
>> http://sietch-tagr.blogspot.ch/2016/04/display-panels-are-not-special.html
>>
>> Note that almost all the other helpers do not have a Kconfig option, the
>> only real exception is the fbdev helpers. And those have a good reason:
>> They'd drag in all of fbdev, and that is actually a pile of code.
> Moreover, this adds a kconfig entry without a prompt. The entry also
> doesn't have a "default". And I didn't spot a patch adding a select for
> this symbol. So, based on just this series, I think that
> DRM_SIMPLE_KMS_HELPER can't actually be set.
>
> I didn't test this, so perhaps I missed something. Did I, Noralf?

It would have been selected in the tinydrm follow-up patchset, but
I'll do as Daniel suggests and add it to drm_kms_helper-y.

Noralf.

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2016-05-11 19:30 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-11 16:09 [PATCH v2 0/6] drm: Add various helpers for simple drivers Noralf Trønnes
2016-05-11 16:09 ` Noralf Trønnes
2016-05-11 16:09 ` [PATCH v2 1/6] drm/fb-helper: Remove mention of CONFIG_FB_DEFERRED_IO in docs Noralf Trønnes
2016-05-11 16:09   ` Noralf Trønnes
2016-05-11 16:09 ` [PATCH v2 2/6] drm/fb-cma-helper: Hook up to DocBook and fix some docs Noralf Trønnes
2016-05-11 16:09   ` Noralf Trønnes
2016-05-11 16:48   ` Daniel Vetter
2016-05-11 16:48     ` Daniel Vetter
2016-05-11 16:09 ` [PATCH v2 3/6] drm/fb-cma-helper: Add function drm_fb_cma_create_with_funcs() Noralf Trønnes
2016-05-11 16:09   ` Noralf Trønnes
2016-05-11 16:09 ` [PATCH v2 4/6] drm/atomic: Don't skip drm_bridge_*() calls if !drm_encoder_helper_funcs Noralf Trønnes
2016-05-11 16:09   ` Noralf Trønnes
2016-05-11 16:55   ` Daniel Vetter
2016-05-11 16:55     ` Daniel Vetter
2016-05-11 16:09 ` [PATCH v2 5/6] drm/atomic: Add drm_atomic_helper_best_encoder() Noralf Trønnes
2016-05-11 16:09   ` Noralf Trønnes
2016-05-11 16:55   ` Daniel Vetter
2016-05-11 16:55     ` Daniel Vetter
2016-05-11 16:09 ` [PATCH v2 6/6] drm: Add helper for simple display pipeline Noralf Trønnes
2016-05-11 16:09   ` Noralf Trønnes
2016-05-11 17:09   ` Daniel Vetter
2016-05-11 17:09     ` Daniel Vetter
2016-05-11 19:10     ` Paul Bolle
2016-05-11 19:10       ` Paul Bolle
2016-05-11 19:30       ` Noralf Trønnes [this message]
2016-05-11 19:30         ` Noralf Trønnes
2016-05-11 19:27     ` Noralf Trønnes
2016-05-11 19:27       ` Noralf Trønnes
2016-05-12  8:11     ` Daniel Vetter
2016-05-12  8:11       ` Daniel Vetter
2016-05-12 10:18       ` Noralf Trønnes
2016-05-12 10:18         ` Noralf Trønnes
2016-05-12 10:44         ` Daniel Vetter
2016-05-12 10:44           ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=350ccaa0-5164-d022-1eca-5da10b766156@tronnes.org \
    --to=noralf@tronnes.org \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pebolle@tiscali.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.