All of lore.kernel.org
 help / color / mirror / Atom feed
* BUG: brcmfmac: rework headroom check in .start_xmit() causes 43430a1 to fail.
@ 2017-07-17 19:03 Ian Molton
  2017-07-17 19:14 ` Arend van Spriel
  0 siblings, 1 reply; 4+ messages in thread
From: Ian Molton @ 2017-07-17 19:03 UTC (permalink / raw)
  To: linux-wireless; +Cc: Arend Van Spriel, Franky Lin, Hante Meuleman, davem

Hi folks,

I've found that:

270a6c1f65fe brcmfmac: rework headroom check in .start_xmit()

Causes the 43430a1 to become non-responsive. The log starts emitting
these messages:

brcmfmac: brcmf_proto_bcdc_hdrpull: wlan0: non-BCDC packet received,
flags 0x0
brcmfmac: brcmf_proto_bcdc_hdrpull: wlan0: non-BCDC packet received,
flags 0x0
brcmfmac: brcmf_proto_bcdc_hdrpull: wlan0: non-BCDC packet received,
flags 0x0
brcmfmac: brcmf_proto_bcdc_hdrpull: wlan0: non-BCDC packet received,
flags 0x0
brcmfmac: brcmf_proto_bcdc_hdrpull: wlan0: non-BCDC packet received,
flags 0x0
brcmfmac: brcmf_proto_bcdc_hdrpull: wlan0: non-BCDC packet received,
flags 0x0
brcmfmac: brcmf_proto_bcdc_hdrpull: wlan0: non-BCDC packet received,
flags 0x0
brcmfmac: brcmf_proto_bcdc_hdrpull: wlan0: non-BCDC packet received,
flags 0x0
brcmfmac: brcmf_proto_bcdc_hdrpull: wlan0: non-BCDC packet received,
flags 0x0
brcmfmac: brcmf_proto_bcdc_hdrpull: wlan0: non-BCDC packet received,
flags 0x0
net_ratelimit: 3 callbacks suppressed
brcmfmac: brcmf_proto_bcdc_hdrpull: wlan0: non-BCDC packet received,
flags 0x0
brcmfmac: brcmf_proto_bcdc_hdrpull: wlan0: non-BCDC packet received,
flags 0x0

Without this commit, the card works fine.

Again, Firmware version = wl0: Aug 29 2016 20:48:16 version 7.45.41.26
(r640327) FWID 01-4527cfab

Does anyone actually test these commits before applying to mainline?

Thats two total breakages I've found that are verifiable at module load
time in the last couple of hours.

Even if this is a case of me having old firmware - this should not cause
this issue- at worst the driver should refuse to load. Better, it should
disable or work around known bugs.

-Ian

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: BUG: brcmfmac: rework headroom check in .start_xmit() causes 43430a1 to fail.
  2017-07-17 19:03 BUG: brcmfmac: rework headroom check in .start_xmit() causes 43430a1 to fail Ian Molton
@ 2017-07-17 19:14 ` Arend van Spriel
  2017-07-17 19:56   ` Ian Molton
  0 siblings, 1 reply; 4+ messages in thread
From: Arend van Spriel @ 2017-07-17 19:14 UTC (permalink / raw)
  To: Ian Molton, linux-wireless; +Cc: Franky Lin, Hante Meuleman, davem



On 17-07-17 21:03, Ian Molton wrote:
> Hi folks,
> 
> I've found that:
> 
> 270a6c1f65fe brcmfmac: rework headroom check in .start_xmit()
> 
> Causes the 43430a1 to become non-responsive. The log starts emitting
> these messages:

A fix is already pending in patchwork:

https://patchwork.kernel.org/patch/9836383/

Thanks,
Arend

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: BUG: brcmfmac: rework headroom check in .start_xmit() causes 43430a1 to fail.
  2017-07-17 19:14 ` Arend van Spriel
@ 2017-07-17 19:56   ` Ian Molton
  2017-07-17 19:58     ` Arend van Spriel
  0 siblings, 1 reply; 4+ messages in thread
From: Ian Molton @ 2017-07-17 19:56 UTC (permalink / raw)
  To: Arend van Spriel, linux-wireless; +Cc: Franky Lin, Hante Meuleman, davem

On 17/07/17 20:14, Arend van Spriel wrote:
> 
> On 17-07-17 21:03, Ian Molton wrote:
>> Hi folks,
>>
>> I've found that:
>>
>> 270a6c1f65fe brcmfmac: rework headroom check in .start_xmit()
>>
>> Causes the 43430a1 to become non-responsive. The log starts emitting
>> these messages:
> 
> A fix is already pending in patchwork:
> 
> https://patchwork.kernel.org/patch/9836383/

Confirmed, this fix does fix the breakage.

-Ian

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: BUG: brcmfmac: rework headroom check in .start_xmit() causes 43430a1 to fail.
  2017-07-17 19:56   ` Ian Molton
@ 2017-07-17 19:58     ` Arend van Spriel
  0 siblings, 0 replies; 4+ messages in thread
From: Arend van Spriel @ 2017-07-17 19:58 UTC (permalink / raw)
  To: Ian Molton, linux-wireless; +Cc: Franky Lin, Hante Meuleman, davem



On 17-07-17 21:56, Ian Molton wrote:
> On 17/07/17 20:14, Arend van Spriel wrote:
>>
>> On 17-07-17 21:03, Ian Molton wrote:
>>> Hi folks,
>>>
>>> I've found that:
>>>
>>> 270a6c1f65fe brcmfmac: rework headroom check in .start_xmit()
>>>
>>> Causes the 43430a1 to become non-responsive. The log starts emitting
>>> these messages:
>>
>> A fix is already pending in patchwork:
>>
>> https://patchwork.kernel.org/patch/9836383/
> 
> Confirmed, this fix does fix the breakage.

one to go...

Regards,
Arend

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2017-07-17 19:58 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-17 19:03 BUG: brcmfmac: rework headroom check in .start_xmit() causes 43430a1 to fail Ian Molton
2017-07-17 19:14 ` Arend van Spriel
2017-07-17 19:56   ` Ian Molton
2017-07-17 19:58     ` Arend van Spriel

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.