From: Johannes Berg <johannes@sipsolutions.net>
To: Jakub Kicinski <kuba@kernel.org>
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [RFC PATCH 2/2] mac80211: use the new drop reasons infrastructure
Date: Thu, 30 Mar 2023 10:14:18 +0200 [thread overview]
Message-ID: <3529dbe11a6067f0e959beab77762c74365ae2e7.camel@sipsolutions.net> (raw)
In-Reply-To: <20230329210557.3a5890fd@kernel.org>
On Wed, 2023-03-29 at 21:05 -0700, Jakub Kicinski wrote:
> On Wed, 29 Mar 2023 23:46:20 +0200 Johannes Berg wrote:
> > + /** @SKB_DROP_REASON_SUBSYS_MAC80211_UNUSABLE: mac80211 drop reasons
> > + * for unusable frames, see net/mac80211/drop.h
> > + */
> > + SKB_DROP_REASON_SUBSYS_MAC80211_UNUSABLE,
> > +
> > + /** @SKB_DROP_REASON_SUBSYS_MAC80211_MONITOR: mac80211 drop reasons
> > + * for frames still going to monitor, see net/mac80211/drop.h
> > + */
> > + SKB_DROP_REASON_SUBSYS_MAC80211_MONITOR,
>
> heh, didn't expect you'd have two different subsystems TBH
>
Hah, me neither!
But then when I came to implement it, I wanted to use some bit in the
reason for he drop/unusable distinction. In fact I did that at first,
until I got to the string list, and realised that no matter how I sliced
it, I'd always have a very sparse array there. If I use the lowest bit
it'd be as compact as possible, but I'd expect the two spaces to not be
equivalently filled, so I'd still get a whole bunch NULLs in the array.
So then I switched to using two subsystems, since that way we have two
distinct string lists.
johannes
next prev parent reply other threads:[~2023-03-30 8:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-29 21:46 [RFC PATCH 1/2] net: extend drop reasons for multiple subsystems Johannes Berg
2023-03-29 21:46 ` [RFC PATCH 2/2] mac80211: use the new drop reasons infrastructure Johannes Berg
2023-03-29 21:56 ` Johannes Berg
2023-03-30 4:06 ` Jakub Kicinski
2023-03-30 8:14 ` Johannes Berg
2023-03-30 4:05 ` Jakub Kicinski
2023-03-30 8:14 ` Johannes Berg [this message]
2023-03-29 23:36 ` [RFC PATCH 1/2] net: extend drop reasons for multiple subsystems kernel test robot
2023-03-30 0:07 ` kernel test robot
2023-03-30 4:05 ` Jakub Kicinski
2023-03-30 8:11 ` Johannes Berg
2023-03-30 17:37 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3529dbe11a6067f0e959beab77762c74365ae2e7.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=kuba@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.