All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Jakub Kicinski <kuba@kernel.org>
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [RFC PATCH 2/2] mac80211: use the new drop reasons infrastructure
Date: Thu, 30 Mar 2023 10:14:43 +0200	[thread overview]
Message-ID: <b7b09926e76112e79d0683089c85cad894d8d6de.camel@sipsolutions.net> (raw)
In-Reply-To: <20230329210633.39cca656@kernel.org>

On Wed, 2023-03-29 at 21:06 -0700, Jakub Kicinski wrote:
> On Wed, 29 Mar 2023 23:56:31 +0200 Johannes Berg wrote:
> > > +	drop_reasons_unregister_subsys(SKB_DROP_REASON_SUBSYS_MAC80211_MONITOR);
> > > +	drop_reasons_unregister_subsys(SKB_DROP_REASON_SUBSYS_MAC80211_UNUSABLE);
> > > +
> > >  	rcu_barrier();  
> > 
> > This is making me think that perhaps we don't want synchronize_rcu()
> > inside drop_reasons_unregister_subsys(), since I have two now and also
> > already have an rcu_barrier() ... so maybe just document that it's
> > needed?
> 
> premature optimization? some workload is reloading mac80211 in a loop?

Yeah, true, nobody is going to do that :-)

Let's leave it this way.

johannes

  reply	other threads:[~2023-03-30  8:14 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-29 21:46 [RFC PATCH 1/2] net: extend drop reasons for multiple subsystems Johannes Berg
2023-03-29 21:46 ` [RFC PATCH 2/2] mac80211: use the new drop reasons infrastructure Johannes Berg
2023-03-29 21:56   ` Johannes Berg
2023-03-30  4:06     ` Jakub Kicinski
2023-03-30  8:14       ` Johannes Berg [this message]
2023-03-30  4:05   ` Jakub Kicinski
2023-03-30  8:14     ` Johannes Berg
2023-03-29 23:36 ` [RFC PATCH 1/2] net: extend drop reasons for multiple subsystems kernel test robot
2023-03-30  0:07 ` kernel test robot
2023-03-30  4:05 ` Jakub Kicinski
2023-03-30  8:11   ` Johannes Berg
2023-03-30 17:37     ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b7b09926e76112e79d0683089c85cad894d8d6de.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=kuba@kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.