[PATCH net-next] rocker: Remove port_attr_bridge_flags_get assignment

[PATCH net-next] rocker: Remove port_attr_bridge_flags_get assignment

[Florian Fainelli]

After 610d2b601bba ("rocker: Remove getting PORT_BRIDGE_FLAGS") we no
longer have a port_attr_bridge_flags_get member in the rocker_world_ops
structre, fix that.

Fixes: 610d2b601bba ("rocker: Remove getting PORT_BRIDGE_FLAGS")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
 drivers/net/ethernet/rocker/rocker_ofdpa.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/rocker/rocker_ofdpa.c b/drivers/net/ethernet/rocker/rocker_ofdpa.c
index 9c07f6040720..fa296a7c255d 100644
--- a/drivers/net/ethernet/rocker/rocker_ofdpa.c
+++ b/drivers/net/ethernet/rocker/rocker_ofdpa.c
@@ -2813,7 +2813,6 @@ struct rocker_world_ops rocker_ofdpa_ops = {
 	.port_stop = ofdpa_port_stop,
 	.port_attr_stp_state_set = ofdpa_port_attr_stp_state_set,
 	.port_attr_bridge_flags_set = ofdpa_port_attr_bridge_flags_set,
-	.port_attr_bridge_flags_get = ofdpa_port_attr_bridge_flags_get,
 	.port_attr_bridge_flags_support_get = ofdpa_port_attr_bridge_flags_support_get,
 	.port_attr_bridge_ageing_time_set = ofdpa_port_attr_bridge_ageing_time_set,
 	.port_obj_vlan_add = ofdpa_port_obj_vlan_add,
-- 
2.17.1

Re: [PATCH net-next] rocker: Remove port_attr_bridge_flags_get assignment

[David Miller]

From: Florian Fainelli <f.fainelli@gmail.com>
Date: Tue, 12 Feb 2019 13:39:05 -0800

> After 610d2b601bba ("rocker: Remove getting PORT_BRIDGE_FLAGS") we no
> longer have a port_attr_bridge_flags_get member in the rocker_world_ops
> structre, fix that.
> 
> Fixes: 610d2b601bba ("rocker: Remove getting PORT_BRIDGE_FLAGS")
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>

Applied, I'm also getting this:

drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c: In function ‘mlxsw_sp_port_attr_get’:
drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c:438:19: warning: unused variable ‘mlxsw_sp’ [-Wunused-variable]
  struct mlxsw_sp *mlxsw_sp = mlxsw_sp_port->mlxsw_sp;
                   ^~~~~~~~

Related?

Re: [PATCH net-next] rocker: Remove port_attr_bridge_flags_get assignment

[Florian Fainelli]

On 2/12/2019 1:54 PM, David Miller wrote:
> From: Florian Fainelli <f.fainelli@gmail.com>
> Date: Tue, 12 Feb 2019 13:39:05 -0800
> 
>> After 610d2b601bba ("rocker: Remove getting PORT_BRIDGE_FLAGS") we no
>> longer have a port_attr_bridge_flags_get member in the rocker_world_ops
>> structre, fix that.
>>
>> Fixes: 610d2b601bba ("rocker: Remove getting PORT_BRIDGE_FLAGS")
>> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> 
> Applied, I'm also getting this:
> 
> drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c: In function ‘mlxsw_sp_port_attr_get’:
> drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c:438:19: warning: unused variable ‘mlxsw_sp’ [-Wunused-variable]
>   struct mlxsw_sp *mlxsw_sp = mlxsw_sp_port->mlxsw_sp;
>                    ^~~~~~~~
> 
> Related?

Unfortunately yes, that whole patch series was used as test for my build
scripts, which clearly failed miserably here.. Follow-up patches in the
next hours.
-- 
Florian