All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Stein <alexander.stein@ew.tq-group.com>
To: Rob Herring <robh@kernel.org>, Xu Yang <xu.yang_2@nxp.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>, Peng Fan <peng.fan@nxp.com>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [EXT] Re: [PATCH 1/1] dt-bindings: usb: ci-hdrc-usb2: Fix number of clocks
Date: Fri, 07 Jul 2023 10:34:57 +0200	[thread overview]
Message-ID: <3547043.jE0xQCEvom@steina-w> (raw)
In-Reply-To: <DB7PR04MB450585C112FA299FE46023828C2DA@DB7PR04MB4505.eurprd04.prod.outlook.com>

Hi Xu Yang,

thanks for your feedback.

Am Freitag, 7. Juli 2023, 09:06:09 CEST schrieb Xu Yang:
> Hi Alexander,
> 
> > -----Original Message-----
> > 
> > Hi,
> > 
> > Am Donnerstag, 6. Juli 2023, 21:18:25 CEST schrieb Rob Herring:
> > > On Thu, Jul 06, 2023 at 11:39:28AM +0200, Alexander Stein wrote:
> > > > Some (older) IP cores require 3 clocks, named 'ipg', 'ahb' and 'per'
> > > > while
> > > > more recent IP cores just require one. Fix the number and explicitly
> > > > state the clock-names.
> > > > 
> > > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> > > > ---
> > > > 
> > > > >From I can tell, is that imx25, imx27, imx35 have specified 3 clocks
> > > > >in
> > > > 
> > > > their DT.
> > > > IMHO minItems for 'clock-names' can be removed as I presume that this
> > > > property is not set when only one clock is used.
> > > 
> > > Rather than presume, did you test that? Well, I did[1] and can confirm.
> > 
> > Okay, probably my wording was bad. There are a lot of users (e.g. imx8mm,
> > imx8mn) which only have one clock but still provide some clock-names
> > property. It works just because it is not called 'ipg', but some SoC
> > specific clock name.
> > So this patch should cause some warnings, but these users were incorrect
> > in
> > the first place. Following up this patch, they need to be fixed.
> 
> It means that all the usb nodes need to contain 'ipg', 'ahb', 'per' clock
> names with your patch.

That's not true. They only need these 3 clocks iff they specify clock-names. 
If there is only one clock, there is no need to specify clock-names.
TBH: If there is just one clock, which is not called 'ipg', the driver doesn't 
care about the name at all.

> It's unexpected due to only imx25, imx27, imx35
> need this. I think you need to narrow this property to specific SoCs.

That's a good idea, but I would consider adding property conditionals as a 
follow up patch.

Best regards,
Alexander

> Thanks,
> Xu Yang
> 
> > Best regards,
> > Alexander
> > 
> > > Reviewed-by: Rob Herring <robh@kernel.org>


-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/



      reply	other threads:[~2023-07-07  8:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-06  9:39 [PATCH 1/1] dt-bindings: usb: ci-hdrc-usb2: Fix number of clocks Alexander Stein
2023-07-06 19:18 ` Rob Herring
2023-07-07  5:59   ` Alexander Stein
2023-07-07  7:06     ` [EXT] " Xu Yang
2023-07-07  8:34       ` Alexander Stein [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3547043.jE0xQCEvom@steina-w \
    --to=alexander.stein@ew.tq-group.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=peng.fan@nxp.com \
    --cc=robh@kernel.org \
    --cc=xu.yang_2@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.