All of lore.kernel.org
 help / color / mirror / Atom feed
From: Xu Yang <xu.yang_2@nxp.com>
To: Alexander Stein <alexander.stein@ew.tq-group.com>,
	Rob Herring <robh@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>, Peng Fan <peng.fan@nxp.com>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: RE: [EXT] Re: [PATCH 1/1] dt-bindings: usb: ci-hdrc-usb2: Fix number of clocks
Date: Fri, 7 Jul 2023 07:06:09 +0000	[thread overview]
Message-ID: <DB7PR04MB450585C112FA299FE46023828C2DA@DB7PR04MB4505.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <4814813.MHq7AAxBmi@steina-w>

Hi Alexander,

> -----Original Message-----
> 
> Hi,
> 
> Am Donnerstag, 6. Juli 2023, 21:18:25 CEST schrieb Rob Herring:
> > On Thu, Jul 06, 2023 at 11:39:28AM +0200, Alexander Stein wrote:
> > > Some (older) IP cores require 3 clocks, named 'ipg', 'ahb' and 'per' while
> > > more recent IP cores just require one. Fix the number and explicitly
> > > state the clock-names.
> > >
> > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> > > ---
> > >
> > > >From I can tell, is that imx25, imx27, imx35 have specified 3 clocks in
> > >
> > > their DT.
> > > IMHO minItems for 'clock-names' can be removed as I presume that this
> > > property is not set when only one clock is used.
> >
> > Rather than presume, did you test that? Well, I did[1] and can confirm.
> 
> Okay, probably my wording was bad. There are a lot of users (e.g. imx8mm,
> imx8mn) which only have one clock but still provide some clock-names property.
> It works just because it is not called 'ipg', but some SoC specific clock
> name.
> So this patch should cause some warnings, but these users were incorrect in
> the first place. Following up this patch, they need to be fixed.

It means that all the usb nodes need to contain 'ipg', 'ahb', 'per' clock
names with your patch. It's unexpected due to only imx25, imx27, imx35
need this. I think you need to narrow this property to specific SoCs.

Thanks,
Xu Yang

> 
> Best regards,
> Alexander
> 
> > Reviewed-by: Rob Herring <robh@kernel.org>
> >

  reply	other threads:[~2023-07-07  7:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-06  9:39 [PATCH 1/1] dt-bindings: usb: ci-hdrc-usb2: Fix number of clocks Alexander Stein
2023-07-06 19:18 ` Rob Herring
2023-07-07  5:59   ` Alexander Stein
2023-07-07  7:06     ` Xu Yang [this message]
2023-07-07  8:34       ` [EXT] " Alexander Stein

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DB7PR04MB450585C112FA299FE46023828C2DA@DB7PR04MB4505.eurprd04.prod.outlook.com \
    --to=xu.yang_2@nxp.com \
    --cc=alexander.stein@ew.tq-group.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=peng.fan@nxp.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.