From: Steven Price <steven.price@arm.com> To: Sudeep Holla <sudeep.holla@arm.com>, linux-arm-kernel@lists.infradead.org Cc: Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>, linux-kernel@vger.kernel.org, harb@amperecomputing.com Subject: Re: [PATCH v2 4/5] firmware: psci: Add function to fetch SMCCC version Date: Mon, 4 May 2020 15:11:10 +0100 [thread overview] Message-ID: <3554928d-2b7c-a3d3-f16e-20e25e761710@arm.com> (raw) In-Reply-To: <20200504092905.10580-5-sudeep.holla@arm.com> On 04/05/2020 10:29, Sudeep Holla wrote: > For backward compatibility reasons, PSCI maintains SMCCC version as > SMCCC didn't provide ARM_SMCCC_VERSION_FUNC_ID until v1.1 > > Let us provide accessors to fetch the SMCCC version in PSCI so that > other SMCCC v1.1+ features can use it. Since it seems there is a good reason for this patch... ;) Reviewed-by: Steven Price <steven.price@arm.com> Steve > Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> > --- > drivers/firmware/psci/psci.c | 5 +++++ > include/linux/arm-smccc.h | 9 +++++++++ > 2 files changed, 14 insertions(+) > > diff --git a/drivers/firmware/psci/psci.c b/drivers/firmware/psci/psci.c > index 6a56d7196697..04426e16fee6 100644 > --- a/drivers/firmware/psci/psci.c > +++ b/drivers/firmware/psci/psci.c > @@ -65,6 +65,11 @@ enum arm_smccc_conduit arm_smccc_1_1_get_conduit(void) > return psci_ops.conduit; > } > > +u32 arm_smccc_get_version(void) > +{ > + return psci_ops.smccc_version; > +} > + > typedef unsigned long (psci_fn)(unsigned long, unsigned long, > unsigned long, unsigned long); > static psci_fn *invoke_psci_fn; > diff --git a/include/linux/arm-smccc.h b/include/linux/arm-smccc.h > index 9d9a2e42e919..d6b0f4acc707 100644 > --- a/include/linux/arm-smccc.h > +++ b/include/linux/arm-smccc.h > @@ -98,6 +98,15 @@ enum arm_smccc_conduit { > */ > enum arm_smccc_conduit arm_smccc_1_1_get_conduit(void); > > +/** > + * arm_smccc_get_version() > + * > + * Returns the version to be used for SMCCCv1.1 or later. > + * > + * When SMCCCv1.1 or above is not present, assumes and returns SMCCCv1.0. > + */ > +u32 arm_smccc_get_version(void); > + > /** > * struct arm_smccc_res - Result from SMC/HVC call > * @a0-a3 result values from registers 0 to 3 >
WARNING: multiple messages have this Message-ID (diff)
From: Steven Price <steven.price@arm.com> To: Sudeep Holla <sudeep.holla@arm.com>, linux-arm-kernel@lists.infradead.org Cc: Mark Rutland <mark.rutland@arm.com>, Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>, Catalin Marinas <catalin.marinas@arm.com>, linux-kernel@vger.kernel.org, harb@amperecomputing.com, Will Deacon <will@kernel.org> Subject: Re: [PATCH v2 4/5] firmware: psci: Add function to fetch SMCCC version Date: Mon, 4 May 2020 15:11:10 +0100 [thread overview] Message-ID: <3554928d-2b7c-a3d3-f16e-20e25e761710@arm.com> (raw) In-Reply-To: <20200504092905.10580-5-sudeep.holla@arm.com> On 04/05/2020 10:29, Sudeep Holla wrote: > For backward compatibility reasons, PSCI maintains SMCCC version as > SMCCC didn't provide ARM_SMCCC_VERSION_FUNC_ID until v1.1 > > Let us provide accessors to fetch the SMCCC version in PSCI so that > other SMCCC v1.1+ features can use it. Since it seems there is a good reason for this patch... ;) Reviewed-by: Steven Price <steven.price@arm.com> Steve > Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> > --- > drivers/firmware/psci/psci.c | 5 +++++ > include/linux/arm-smccc.h | 9 +++++++++ > 2 files changed, 14 insertions(+) > > diff --git a/drivers/firmware/psci/psci.c b/drivers/firmware/psci/psci.c > index 6a56d7196697..04426e16fee6 100644 > --- a/drivers/firmware/psci/psci.c > +++ b/drivers/firmware/psci/psci.c > @@ -65,6 +65,11 @@ enum arm_smccc_conduit arm_smccc_1_1_get_conduit(void) > return psci_ops.conduit; > } > > +u32 arm_smccc_get_version(void) > +{ > + return psci_ops.smccc_version; > +} > + > typedef unsigned long (psci_fn)(unsigned long, unsigned long, > unsigned long, unsigned long); > static psci_fn *invoke_psci_fn; > diff --git a/include/linux/arm-smccc.h b/include/linux/arm-smccc.h > index 9d9a2e42e919..d6b0f4acc707 100644 > --- a/include/linux/arm-smccc.h > +++ b/include/linux/arm-smccc.h > @@ -98,6 +98,15 @@ enum arm_smccc_conduit { > */ > enum arm_smccc_conduit arm_smccc_1_1_get_conduit(void); > > +/** > + * arm_smccc_get_version() > + * > + * Returns the version to be used for SMCCCv1.1 or later. > + * > + * When SMCCCv1.1 or above is not present, assumes and returns SMCCCv1.0. > + */ > +u32 arm_smccc_get_version(void); > + > /** > * struct arm_smccc_res - Result from SMC/HVC call > * @a0-a3 result values from registers 0 to 3 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-05-04 14:11 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-05-04 9:29 [PATCH v2 0/5] arm/arm64: smccc: Add ARCH_SOC_ID support Sudeep Holla 2020-05-04 9:29 ` Sudeep Holla 2020-05-04 9:29 ` [PATCH v2 1/5] arm/arm64: smccc: Update link to latest SMCCC specification Sudeep Holla 2020-05-04 9:29 ` Sudeep Holla 2020-05-04 9:29 ` [PATCH v2 2/5] arm/arm64: smccc: Add the definition for SMCCCv1.2 version/error codes Sudeep Holla 2020-05-04 9:29 ` Sudeep Holla 2020-05-04 9:29 ` [PATCH v2 3/5] arm/arm64: smccc: Drop smccc_version enum and use ARM_SMCCC_VERSION_1_x instead Sudeep Holla 2020-05-04 9:29 ` Sudeep Holla 2020-05-04 9:29 ` [PATCH v2 4/5] firmware: psci: Add function to fetch SMCCC version Sudeep Holla 2020-05-04 9:29 ` Sudeep Holla 2020-05-04 14:11 ` Steven Price [this message] 2020-05-04 14:11 ` Steven Price 2020-05-04 9:29 ` [PATCH v2 5/5] arm/arm64: smccc: Add ARCH_SOC_ID support Sudeep Holla 2020-05-04 9:29 ` Sudeep Holla 2020-05-04 14:10 ` Steven Price 2020-05-04 14:10 ` Steven Price 2020-05-04 14:49 ` Sudeep Holla 2020-05-04 14:49 ` Sudeep Holla 2020-05-05 16:20 ` Will Deacon 2020-05-05 16:20 ` Will Deacon 2020-05-05 17:59 ` Sudeep Holla 2020-05-05 17:59 ` Sudeep Holla
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=3554928d-2b7c-a3d3-f16e-20e25e761710@arm.com \ --to=steven.price@arm.com \ --cc=catalin.marinas@arm.com \ --cc=harb@amperecomputing.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=lorenzo.pieralisi@arm.com \ --cc=mark.rutland@arm.com \ --cc=sudeep.holla@arm.com \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.