All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] ARM: dts: sun6i: Add pmic / regulator nodes to Mele A1000G quad dts
@ 2016-06-05 13:37 ` Hans de Goede
  0 siblings, 0 replies; 14+ messages in thread
From: Hans de Goede @ 2016-06-05 13:37 UTC (permalink / raw)
  To: Chen-Yu Tsai, Maxime Ripard
  Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, devicetree,
	Hans de Goede

Add pmic / regulator nodes to Mele A1000G quad dts.

Signed-off-by: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
---
 arch/arm/boot/dts/sun6i-a31-mele-a1000g-quad.dts | 88 +++++++++++++++++++++++-
 1 file changed, 87 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/sun6i-a31-mele-a1000g-quad.dts b/arch/arm/boot/dts/sun6i-a31-mele-a1000g-quad.dts
index e063dab..9782113 100644
--- a/arch/arm/boot/dts/sun6i-a31-mele-a1000g-quad.dts
+++ b/arch/arm/boot/dts/sun6i-a31-mele-a1000g-quad.dts
@@ -72,6 +72,10 @@
 	};
 };
 
+&cpu0 {
+	cpu-supply = <&reg_dcdc3>;
+};
+
 &ehci0 {
 	status = "okay";
 };
@@ -85,6 +89,7 @@
 	pinctrl-0 = <&gmac_pins_mii_a>;
 	phy = <&phy1>;
 	phy-mode = "mii";
+	phy-supply = <&reg_dldo1>;
 	status = "okay";
 
 	phy1: ethernet-phy@1 {
@@ -101,13 +106,26 @@
 &mmc0 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&mmc0_pins_a>, <&mmc0_cd_pin_m9>;
-	vmmc-supply = <&reg_vcc3v3>;
+	vmmc-supply = <&reg_dcdc1>;
 	bus-width = <4>;
 	cd-gpios = <&pio 7 22 GPIO_ACTIVE_HIGH>; /* PH22 */
 	cd-inverted;
 	status = "okay";
 };
 
+&p2wi {
+	status = "okay";
+
+	axp22x: pmic@68 {
+		compatible = "x-powers,axp221";
+		reg = <0x68>;
+		interrupt-parent = <&nmi_intc>;
+		interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
+	};
+};
+
+#include "axp22x.dtsi"
+
 &pio {
 	led_pins_m9: led_pins@0 {
 		allwinner,pins = "PH13";
@@ -131,6 +149,73 @@
 	};
 };
 
+&reg_aldo1 {
+	regulator-min-microvolt = <3300000>;
+	regulator-max-microvolt = <3300000>;
+	regulator-name = "vcc-wifi";
+};
+
+&reg_aldo3 {
+	regulator-always-on;
+	regulator-min-microvolt = <2700000>;
+	regulator-max-microvolt = <3300000>;
+	regulator-name = "avcc";
+};
+
+&reg_dc5ldo {
+	regulator-always-on;
+	regulator-min-microvolt = <700000>;
+	regulator-max-microvolt = <1320000>;
+	regulator-name = "vdd-cpus"; /* This is an educated guess */
+};
+
+&reg_dcdc1 {
+	regulator-always-on;
+	regulator-min-microvolt = <3300000>;
+	regulator-max-microvolt = <3300000>;
+	regulator-name = "vcc-3v3";
+};
+
+&reg_dcdc2 {
+	regulator-min-microvolt = <700000>;
+	regulator-max-microvolt = <1320000>;
+	regulator-name = "vdd-gpu";
+};
+
+&reg_dcdc3 {
+	regulator-always-on;
+	regulator-min-microvolt = <700000>;
+	regulator-max-microvolt = <1320000>;
+	regulator-name = "vdd-cpu";
+};
+
+&reg_dcdc4 {
+	regulator-always-on;
+	regulator-min-microvolt = <700000>;
+	regulator-max-microvolt = <1320000>;
+	regulator-name = "vdd-sys-dll";
+};
+
+&reg_dcdc5 {
+	regulator-always-on;
+	regulator-min-microvolt = <1500000>;
+	regulator-max-microvolt = <1500000>;
+	regulator-name = "vcc-dram";
+};
+
+&reg_dldo1 {
+	regulator-min-microvolt = <3300000>;
+	regulator-max-microvolt = <3300000>;
+	regulator-name = "vcc-ethernet-phy";
+};
+
+&reg_dldo4 {
+	regulator-always-on;
+	regulator-min-microvolt = <3300000>;
+	regulator-max-microvolt = <3300000>;
+	regulator-name = "vcc-usb-hub";
+};
+
 &reg_usb1_vbus {
 	pinctrl-names = "default";
 	pinctrl-0 = <&usb1_vbus_pin_m9>;
@@ -151,5 +236,6 @@
 
 &usbphy {
 	usb1_vbus-supply = <&reg_usb1_vbus>;
+	usb2_vbus-supply = <&reg_aldo1>;
 	status = "okay";
 };
-- 
2.7.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 14+ messages in thread
* [PATCH 1/2] ARM: dts: sun6i: Add pmic / regulator nodes to Mele A1000G quad dts
@ 2016-06-05 13:37 ` Hans de Goede
  0 siblings, 0 replies; 14+ messages in thread
From: Hans de Goede @ 2016-06-05 13:37 UTC (permalink / raw)
  To: linux-arm-kernel

Add pmic / regulator nodes to Mele A1000G quad dts.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 arch/arm/boot/dts/sun6i-a31-mele-a1000g-quad.dts | 88 +++++++++++++++++++++++-
 1 file changed, 87 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/sun6i-a31-mele-a1000g-quad.dts b/arch/arm/boot/dts/sun6i-a31-mele-a1000g-quad.dts
index e063dab..9782113 100644
--- a/arch/arm/boot/dts/sun6i-a31-mele-a1000g-quad.dts
+++ b/arch/arm/boot/dts/sun6i-a31-mele-a1000g-quad.dts
@@ -72,6 +72,10 @@
 	};
 };
 
+&cpu0 {
+	cpu-supply = <&reg_dcdc3>;
+};
+
 &ehci0 {
 	status = "okay";
 };
@@ -85,6 +89,7 @@
 	pinctrl-0 = <&gmac_pins_mii_a>;
 	phy = <&phy1>;
 	phy-mode = "mii";
+	phy-supply = <&reg_dldo1>;
 	status = "okay";
 
 	phy1: ethernet-phy at 1 {
@@ -101,13 +106,26 @@
 &mmc0 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&mmc0_pins_a>, <&mmc0_cd_pin_m9>;
-	vmmc-supply = <&reg_vcc3v3>;
+	vmmc-supply = <&reg_dcdc1>;
 	bus-width = <4>;
 	cd-gpios = <&pio 7 22 GPIO_ACTIVE_HIGH>; /* PH22 */
 	cd-inverted;
 	status = "okay";
 };
 
+&p2wi {
+	status = "okay";
+
+	axp22x: pmic at 68 {
+		compatible = "x-powers,axp221";
+		reg = <0x68>;
+		interrupt-parent = <&nmi_intc>;
+		interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
+	};
+};
+
+#include "axp22x.dtsi"
+
 &pio {
 	led_pins_m9: led_pins at 0 {
 		allwinner,pins = "PH13";
@@ -131,6 +149,73 @@
 	};
 };
 
+&reg_aldo1 {
+	regulator-min-microvolt = <3300000>;
+	regulator-max-microvolt = <3300000>;
+	regulator-name = "vcc-wifi";
+};
+
+&reg_aldo3 {
+	regulator-always-on;
+	regulator-min-microvolt = <2700000>;
+	regulator-max-microvolt = <3300000>;
+	regulator-name = "avcc";
+};
+
+&reg_dc5ldo {
+	regulator-always-on;
+	regulator-min-microvolt = <700000>;
+	regulator-max-microvolt = <1320000>;
+	regulator-name = "vdd-cpus"; /* This is an educated guess */
+};
+
+&reg_dcdc1 {
+	regulator-always-on;
+	regulator-min-microvolt = <3300000>;
+	regulator-max-microvolt = <3300000>;
+	regulator-name = "vcc-3v3";
+};
+
+&reg_dcdc2 {
+	regulator-min-microvolt = <700000>;
+	regulator-max-microvolt = <1320000>;
+	regulator-name = "vdd-gpu";
+};
+
+&reg_dcdc3 {
+	regulator-always-on;
+	regulator-min-microvolt = <700000>;
+	regulator-max-microvolt = <1320000>;
+	regulator-name = "vdd-cpu";
+};
+
+&reg_dcdc4 {
+	regulator-always-on;
+	regulator-min-microvolt = <700000>;
+	regulator-max-microvolt = <1320000>;
+	regulator-name = "vdd-sys-dll";
+};
+
+&reg_dcdc5 {
+	regulator-always-on;
+	regulator-min-microvolt = <1500000>;
+	regulator-max-microvolt = <1500000>;
+	regulator-name = "vcc-dram";
+};
+
+&reg_dldo1 {
+	regulator-min-microvolt = <3300000>;
+	regulator-max-microvolt = <3300000>;
+	regulator-name = "vcc-ethernet-phy";
+};
+
+&reg_dldo4 {
+	regulator-always-on;
+	regulator-min-microvolt = <3300000>;
+	regulator-max-microvolt = <3300000>;
+	regulator-name = "vcc-usb-hub";
+};
+
 &reg_usb1_vbus {
 	pinctrl-names = "default";
 	pinctrl-0 = <&usb1_vbus_pin_m9>;
@@ -151,5 +236,6 @@
 
 &usbphy {
 	usb1_vbus-supply = <&reg_usb1_vbus>;
+	usb2_vbus-supply = <&reg_aldo1>;
 	status = "okay";
 };
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 14+ messages in thread
* [PATCH 2/2] ARM: dts: sun6i: Add pmic / regulator nodes to Mele M9 dts
  2016-06-05 13:37 ` Hans de Goede
@ 2016-06-05 13:38     ` Hans de Goede
  -1 siblings, 0 replies; 14+ messages in thread
From: Hans de Goede @ 2016-06-05 13:38 UTC (permalink / raw)
  To: Chen-Yu Tsai, Maxime Ripard
  Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, devicetree,
	Hans de Goede

Add pmic / regulator nodes to Mele M9 dts.

Signed-off-by: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
---
 arch/arm/boot/dts/sun6i-a31-m9.dts | 88 +++++++++++++++++++++++++++++++++++++-
 1 file changed, 87 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/sun6i-a31-m9.dts b/arch/arm/boot/dts/sun6i-a31-m9.dts
index 66d29b8..2d3cd9d 100644
--- a/arch/arm/boot/dts/sun6i-a31-m9.dts
+++ b/arch/arm/boot/dts/sun6i-a31-m9.dts
@@ -72,6 +72,10 @@
 	};
 };
 
+&cpu0 {
+	cpu-supply = <&reg_dcdc3>;
+};
+
 &ehci0 {
 	status = "okay";
 };
@@ -85,6 +89,7 @@
 	pinctrl-0 = <&gmac_pins_mii_a>;
 	phy = <&phy1>;
 	phy-mode = "mii";
+	phy-supply = <&reg_dldo1>;
 	status = "okay";
 
 	phy1: ethernet-phy@1 {
@@ -101,13 +106,26 @@
 &mmc0 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&mmc0_pins_a>, <&mmc0_cd_pin_m9>;
-	vmmc-supply = <&reg_vcc3v3>;
+	vmmc-supply = <&reg_dcdc1>;
 	bus-width = <4>;
 	cd-gpios = <&pio 7 22 GPIO_ACTIVE_HIGH>; /* PH22 */
 	cd-inverted;
 	status = "okay";
 };
 
+&p2wi {
+	status = "okay";
+
+	axp22x: pmic@68 {
+		compatible = "x-powers,axp221";
+		reg = <0x68>;
+		interrupt-parent = <&nmi_intc>;
+		interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
+	};
+};
+
+#include "axp22x.dtsi"
+
 &pio {
 	led_pins_m9: led_pins@0 {
 		allwinner,pins = "PH13";
@@ -131,6 +149,73 @@
 	};
 };
 
+&reg_aldo1 {
+	regulator-min-microvolt = <3300000>;
+	regulator-max-microvolt = <3300000>;
+	regulator-name = "vcc-wifi";
+};
+
+&reg_aldo3 {
+	regulator-always-on;
+	regulator-min-microvolt = <2700000>;
+	regulator-max-microvolt = <3300000>;
+	regulator-name = "avcc";
+};
+
+&reg_dc5ldo {
+	regulator-always-on;
+	regulator-min-microvolt = <700000>;
+	regulator-max-microvolt = <1320000>;
+	regulator-name = "vdd-cpus"; /* This is an educated guess */
+};
+
+&reg_dcdc1 {
+	regulator-always-on;
+	regulator-min-microvolt = <3300000>;
+	regulator-max-microvolt = <3300000>;
+	regulator-name = "vcc-3v3";
+};
+
+&reg_dcdc2 {
+	regulator-min-microvolt = <700000>;
+	regulator-max-microvolt = <1320000>;
+	regulator-name = "vdd-gpu";
+};
+
+&reg_dcdc3 {
+	regulator-always-on;
+	regulator-min-microvolt = <700000>;
+	regulator-max-microvolt = <1320000>;
+	regulator-name = "vdd-cpu";
+};
+
+&reg_dcdc4 {
+	regulator-always-on;
+	regulator-min-microvolt = <700000>;
+	regulator-max-microvolt = <1320000>;
+	regulator-name = "vdd-sys-dll";
+};
+
+&reg_dcdc5 {
+	regulator-always-on;
+	regulator-min-microvolt = <1500000>;
+	regulator-max-microvolt = <1500000>;
+	regulator-name = "vcc-dram";
+};
+
+&reg_dldo1 {
+	regulator-min-microvolt = <3300000>;
+	regulator-max-microvolt = <3300000>;
+	regulator-name = "vcc-ethernet-phy";
+};
+
+&reg_dldo4 {
+	regulator-always-on;
+	regulator-min-microvolt = <3300000>;
+	regulator-max-microvolt = <3300000>;
+	regulator-name = "vcc-usb-hub";
+};
+
 &reg_usb1_vbus {
 	pinctrl-names = "default";
 	pinctrl-0 = <&usb1_vbus_pin_m9>;
@@ -146,5 +231,6 @@
 
 &usbphy {
 	usb1_vbus-supply = <&reg_usb1_vbus>;
+	usb2_vbus-supply = <&reg_aldo1>;
 	status = "okay";
 };
-- 
2.7.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 14+ messages in thread
* [PATCH 2/2] ARM: dts: sun6i: Add pmic / regulator nodes to Mele M9 dts
@ 2016-06-05 13:38     ` Hans de Goede
  0 siblings, 0 replies; 14+ messages in thread
From: Hans de Goede @ 2016-06-05 13:38 UTC (permalink / raw)
  To: linux-arm-kernel

Add pmic / regulator nodes to Mele M9 dts.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 arch/arm/boot/dts/sun6i-a31-m9.dts | 88 +++++++++++++++++++++++++++++++++++++-
 1 file changed, 87 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/sun6i-a31-m9.dts b/arch/arm/boot/dts/sun6i-a31-m9.dts
index 66d29b8..2d3cd9d 100644
--- a/arch/arm/boot/dts/sun6i-a31-m9.dts
+++ b/arch/arm/boot/dts/sun6i-a31-m9.dts
@@ -72,6 +72,10 @@
 	};
 };
 
+&cpu0 {
+	cpu-supply = <&reg_dcdc3>;
+};
+
 &ehci0 {
 	status = "okay";
 };
@@ -85,6 +89,7 @@
 	pinctrl-0 = <&gmac_pins_mii_a>;
 	phy = <&phy1>;
 	phy-mode = "mii";
+	phy-supply = <&reg_dldo1>;
 	status = "okay";
 
 	phy1: ethernet-phy at 1 {
@@ -101,13 +106,26 @@
 &mmc0 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&mmc0_pins_a>, <&mmc0_cd_pin_m9>;
-	vmmc-supply = <&reg_vcc3v3>;
+	vmmc-supply = <&reg_dcdc1>;
 	bus-width = <4>;
 	cd-gpios = <&pio 7 22 GPIO_ACTIVE_HIGH>; /* PH22 */
 	cd-inverted;
 	status = "okay";
 };
 
+&p2wi {
+	status = "okay";
+
+	axp22x: pmic at 68 {
+		compatible = "x-powers,axp221";
+		reg = <0x68>;
+		interrupt-parent = <&nmi_intc>;
+		interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
+	};
+};
+
+#include "axp22x.dtsi"
+
 &pio {
 	led_pins_m9: led_pins at 0 {
 		allwinner,pins = "PH13";
@@ -131,6 +149,73 @@
 	};
 };
 
+&reg_aldo1 {
+	regulator-min-microvolt = <3300000>;
+	regulator-max-microvolt = <3300000>;
+	regulator-name = "vcc-wifi";
+};
+
+&reg_aldo3 {
+	regulator-always-on;
+	regulator-min-microvolt = <2700000>;
+	regulator-max-microvolt = <3300000>;
+	regulator-name = "avcc";
+};
+
+&reg_dc5ldo {
+	regulator-always-on;
+	regulator-min-microvolt = <700000>;
+	regulator-max-microvolt = <1320000>;
+	regulator-name = "vdd-cpus"; /* This is an educated guess */
+};
+
+&reg_dcdc1 {
+	regulator-always-on;
+	regulator-min-microvolt = <3300000>;
+	regulator-max-microvolt = <3300000>;
+	regulator-name = "vcc-3v3";
+};
+
+&reg_dcdc2 {
+	regulator-min-microvolt = <700000>;
+	regulator-max-microvolt = <1320000>;
+	regulator-name = "vdd-gpu";
+};
+
+&reg_dcdc3 {
+	regulator-always-on;
+	regulator-min-microvolt = <700000>;
+	regulator-max-microvolt = <1320000>;
+	regulator-name = "vdd-cpu";
+};
+
+&reg_dcdc4 {
+	regulator-always-on;
+	regulator-min-microvolt = <700000>;
+	regulator-max-microvolt = <1320000>;
+	regulator-name = "vdd-sys-dll";
+};
+
+&reg_dcdc5 {
+	regulator-always-on;
+	regulator-min-microvolt = <1500000>;
+	regulator-max-microvolt = <1500000>;
+	regulator-name = "vcc-dram";
+};
+
+&reg_dldo1 {
+	regulator-min-microvolt = <3300000>;
+	regulator-max-microvolt = <3300000>;
+	regulator-name = "vcc-ethernet-phy";
+};
+
+&reg_dldo4 {
+	regulator-always-on;
+	regulator-min-microvolt = <3300000>;
+	regulator-max-microvolt = <3300000>;
+	regulator-name = "vcc-usb-hub";
+};
+
 &reg_usb1_vbus {
 	pinctrl-names = "default";
 	pinctrl-0 = <&usb1_vbus_pin_m9>;
@@ -146,5 +231,6 @@
 
 &usbphy {
 	usb1_vbus-supply = <&reg_usb1_vbus>;
+	usb2_vbus-supply = <&reg_aldo1>;
 	status = "okay";
 };
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 14+ messages in thread
* Re: [PATCH 1/2] ARM: dts: sun6i: Add pmic / regulator nodes to Mele A1000G quad dts
  2016-06-05 13:37 ` Hans de Goede
@ 2016-06-06  7:12     ` Chen-Yu Tsai
  -1 siblings, 0 replies; 14+ messages in thread
From: Chen-Yu Tsai @ 2016-06-06  7:12 UTC (permalink / raw)
  To: Hans de Goede; +Cc: Chen-Yu Tsai, Maxime Ripard, linux-arm-kernel, devicetree

On Sun, Jun 5, 2016 at 9:37 PM, Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> wrote:
> Add pmic / regulator nodes to Mele A1000G quad dts.
>
> Signed-off-by: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> ---
>  arch/arm/boot/dts/sun6i-a31-mele-a1000g-quad.dts | 88 +++++++++++++++++++++++-
>  1 file changed, 87 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/sun6i-a31-mele-a1000g-quad.dts b/arch/arm/boot/dts/sun6i-a31-mele-a1000g-quad.dts
> index e063dab..9782113 100644
> --- a/arch/arm/boot/dts/sun6i-a31-mele-a1000g-quad.dts
> +++ b/arch/arm/boot/dts/sun6i-a31-mele-a1000g-quad.dts
> @@ -72,6 +72,10 @@
>         };
>  };
>
> +&cpu0 {
> +       cpu-supply = <&reg_dcdc3>;
> +};
> +
>  &ehci0 {
>         status = "okay";
>  };
> @@ -85,6 +89,7 @@
>         pinctrl-0 = <&gmac_pins_mii_a>;
>         phy = <&phy1>;
>         phy-mode = "mii";
> +       phy-supply = <&reg_dldo1>;
>         status = "okay";
>
>         phy1: ethernet-phy@1 {
> @@ -101,13 +106,26 @@
>  &mmc0 {
>         pinctrl-names = "default";
>         pinctrl-0 = <&mmc0_pins_a>, <&mmc0_cd_pin_m9>;
> -       vmmc-supply = <&reg_vcc3v3>;
> +       vmmc-supply = <&reg_dcdc1>;
>         bus-width = <4>;
>         cd-gpios = <&pio 7 22 GPIO_ACTIVE_HIGH>; /* PH22 */
>         cd-inverted;
>         status = "okay";
>  };
>
> +&p2wi {
> +       status = "okay";
> +
> +       axp22x: pmic@68 {
> +               compatible = "x-powers,axp221";
> +               reg = <0x68>;
> +               interrupt-parent = <&nmi_intc>;
> +               interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
> +       };
> +};
> +
> +#include "axp22x.dtsi"
> +
>  &pio {
>         led_pins_m9: led_pins@0 {
>                 allwinner,pins = "PH13";
> @@ -131,6 +149,73 @@
>         };
>  };
>
> +&reg_aldo1 {
> +       regulator-min-microvolt = <3300000>;
> +       regulator-max-microvolt = <3300000>;
> +       regulator-name = "vcc-wifi";
> +};
> +
> +&reg_aldo3 {
> +       regulator-always-on;
> +       regulator-min-microvolt = <2700000>;
> +       regulator-max-microvolt = <3300000>;
> +       regulator-name = "avcc";
> +};
> +
> +&reg_dc5ldo {
> +       regulator-always-on;
> +       regulator-min-microvolt = <700000>;
> +       regulator-max-microvolt = <1320000>;
> +       regulator-name = "vdd-cpus"; /* This is an educated guess */
> +};
> +
> +&reg_dcdc1 {
> +       regulator-always-on;
> +       regulator-min-microvolt = <3300000>;
> +       regulator-max-microvolt = <3300000>;
> +       regulator-name = "vcc-3v3";
> +};
> +
> +&reg_dcdc2 {
> +       regulator-min-microvolt = <700000>;
> +       regulator-max-microvolt = <1320000>;
> +       regulator-name = "vdd-gpu";
> +};
> +
> +&reg_dcdc3 {
> +       regulator-always-on;
> +       regulator-min-microvolt = <700000>;
> +       regulator-max-microvolt = <1320000>;
> +       regulator-name = "vdd-cpu";
> +};
> +
> +&reg_dcdc4 {
> +       regulator-always-on;
> +       regulator-min-microvolt = <700000>;
> +       regulator-max-microvolt = <1320000>;
> +       regulator-name = "vdd-sys-dll";
> +};
> +
> +&reg_dcdc5 {
> +       regulator-always-on;
> +       regulator-min-microvolt = <1500000>;
> +       regulator-max-microvolt = <1500000>;
> +       regulator-name = "vcc-dram";
> +};
> +
> +&reg_dldo1 {
> +       regulator-min-microvolt = <3300000>;
> +       regulator-max-microvolt = <3300000>;
> +       regulator-name = "vcc-ethernet-phy";
> +};
> +
> +&reg_dldo4 {
> +       regulator-always-on;

Why not tie this to the usbphy? Same for the other patch.

ChenYu

> +       regulator-min-microvolt = <3300000>;
> +       regulator-max-microvolt = <3300000>;
> +       regulator-name = "vcc-usb-hub";
> +};
> +
>  &reg_usb1_vbus {
>         pinctrl-names = "default";
>         pinctrl-0 = <&usb1_vbus_pin_m9>;
> @@ -151,5 +236,6 @@
>
>  &usbphy {
>         usb1_vbus-supply = <&reg_usb1_vbus>;
> +       usb2_vbus-supply = <&reg_aldo1>;
>         status = "okay";
>  };
> --
> 2.7.4
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 14+ messages in thread
* [PATCH 1/2] ARM: dts: sun6i: Add pmic / regulator nodes to Mele A1000G quad dts
@ 2016-06-06  7:12     ` Chen-Yu Tsai
  0 siblings, 0 replies; 14+ messages in thread
From: Chen-Yu Tsai @ 2016-06-06  7:12 UTC (permalink / raw)
  To: linux-arm-kernel

On Sun, Jun 5, 2016 at 9:37 PM, Hans de Goede <hdegoede@redhat.com> wrote:
> Add pmic / regulator nodes to Mele A1000G quad dts.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
>  arch/arm/boot/dts/sun6i-a31-mele-a1000g-quad.dts | 88 +++++++++++++++++++++++-
>  1 file changed, 87 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/sun6i-a31-mele-a1000g-quad.dts b/arch/arm/boot/dts/sun6i-a31-mele-a1000g-quad.dts
> index e063dab..9782113 100644
> --- a/arch/arm/boot/dts/sun6i-a31-mele-a1000g-quad.dts
> +++ b/arch/arm/boot/dts/sun6i-a31-mele-a1000g-quad.dts
> @@ -72,6 +72,10 @@
>         };
>  };
>
> +&cpu0 {
> +       cpu-supply = <&reg_dcdc3>;
> +};
> +
>  &ehci0 {
>         status = "okay";
>  };
> @@ -85,6 +89,7 @@
>         pinctrl-0 = <&gmac_pins_mii_a>;
>         phy = <&phy1>;
>         phy-mode = "mii";
> +       phy-supply = <&reg_dldo1>;
>         status = "okay";
>
>         phy1: ethernet-phy at 1 {
> @@ -101,13 +106,26 @@
>  &mmc0 {
>         pinctrl-names = "default";
>         pinctrl-0 = <&mmc0_pins_a>, <&mmc0_cd_pin_m9>;
> -       vmmc-supply = <&reg_vcc3v3>;
> +       vmmc-supply = <&reg_dcdc1>;
>         bus-width = <4>;
>         cd-gpios = <&pio 7 22 GPIO_ACTIVE_HIGH>; /* PH22 */
>         cd-inverted;
>         status = "okay";
>  };
>
> +&p2wi {
> +       status = "okay";
> +
> +       axp22x: pmic at 68 {
> +               compatible = "x-powers,axp221";
> +               reg = <0x68>;
> +               interrupt-parent = <&nmi_intc>;
> +               interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
> +       };
> +};
> +
> +#include "axp22x.dtsi"
> +
>  &pio {
>         led_pins_m9: led_pins at 0 {
>                 allwinner,pins = "PH13";
> @@ -131,6 +149,73 @@
>         };
>  };
>
> +&reg_aldo1 {
> +       regulator-min-microvolt = <3300000>;
> +       regulator-max-microvolt = <3300000>;
> +       regulator-name = "vcc-wifi";
> +};
> +
> +&reg_aldo3 {
> +       regulator-always-on;
> +       regulator-min-microvolt = <2700000>;
> +       regulator-max-microvolt = <3300000>;
> +       regulator-name = "avcc";
> +};
> +
> +&reg_dc5ldo {
> +       regulator-always-on;
> +       regulator-min-microvolt = <700000>;
> +       regulator-max-microvolt = <1320000>;
> +       regulator-name = "vdd-cpus"; /* This is an educated guess */
> +};
> +
> +&reg_dcdc1 {
> +       regulator-always-on;
> +       regulator-min-microvolt = <3300000>;
> +       regulator-max-microvolt = <3300000>;
> +       regulator-name = "vcc-3v3";
> +};
> +
> +&reg_dcdc2 {
> +       regulator-min-microvolt = <700000>;
> +       regulator-max-microvolt = <1320000>;
> +       regulator-name = "vdd-gpu";
> +};
> +
> +&reg_dcdc3 {
> +       regulator-always-on;
> +       regulator-min-microvolt = <700000>;
> +       regulator-max-microvolt = <1320000>;
> +       regulator-name = "vdd-cpu";
> +};
> +
> +&reg_dcdc4 {
> +       regulator-always-on;
> +       regulator-min-microvolt = <700000>;
> +       regulator-max-microvolt = <1320000>;
> +       regulator-name = "vdd-sys-dll";
> +};
> +
> +&reg_dcdc5 {
> +       regulator-always-on;
> +       regulator-min-microvolt = <1500000>;
> +       regulator-max-microvolt = <1500000>;
> +       regulator-name = "vcc-dram";
> +};
> +
> +&reg_dldo1 {
> +       regulator-min-microvolt = <3300000>;
> +       regulator-max-microvolt = <3300000>;
> +       regulator-name = "vcc-ethernet-phy";
> +};
> +
> +&reg_dldo4 {
> +       regulator-always-on;

Why not tie this to the usbphy? Same for the other patch.

ChenYu

> +       regulator-min-microvolt = <3300000>;
> +       regulator-max-microvolt = <3300000>;
> +       regulator-name = "vcc-usb-hub";
> +};
> +
>  &reg_usb1_vbus {
>         pinctrl-names = "default";
>         pinctrl-0 = <&usb1_vbus_pin_m9>;
> @@ -151,5 +236,6 @@
>
>  &usbphy {
>         usb1_vbus-supply = <&reg_usb1_vbus>;
> +       usb2_vbus-supply = <&reg_aldo1>;
>         status = "okay";
>  };
> --
> 2.7.4
>

^ permalink raw reply	[flat|nested] 14+ messages in thread
* Re: [PATCH 1/2] ARM: dts: sun6i: Add pmic / regulator nodes to Mele A1000G quad dts
  2016-06-06  7:12     ` Chen-Yu Tsai
@ 2016-06-06  7:23         ` Hans de Goede
  -1 siblings, 0 replies; 14+ messages in thread
From: Hans de Goede @ 2016-06-06  7:23 UTC (permalink / raw)
  To: Chen-Yu Tsai; +Cc: Maxime Ripard, linux-arm-kernel, devicetree

Hi,

On 06-06-16 09:12, Chen-Yu Tsai wrote:
> On Sun, Jun 5, 2016 at 9:37 PM, Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> wrote:
>> Add pmic / regulator nodes to Mele A1000G quad dts.
>>
>> Signed-off-by: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
>> ---
>>  arch/arm/boot/dts/sun6i-a31-mele-a1000g-quad.dts | 88 +++++++++++++++++++++++-
>>  1 file changed, 87 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/sun6i-a31-mele-a1000g-quad.dts b/arch/arm/boot/dts/sun6i-a31-mele-a1000g-quad.dts
>> index e063dab..9782113 100644
>> --- a/arch/arm/boot/dts/sun6i-a31-mele-a1000g-quad.dts
>> +++ b/arch/arm/boot/dts/sun6i-a31-mele-a1000g-quad.dts
>> @@ -72,6 +72,10 @@
>>         };
>>  };
>>
>> +&cpu0 {
>> +       cpu-supply = <&reg_dcdc3>;
>> +};
>> +
>>  &ehci0 {
>>         status = "okay";
>>  };
>> @@ -85,6 +89,7 @@
>>         pinctrl-0 = <&gmac_pins_mii_a>;
>>         phy = <&phy1>;
>>         phy-mode = "mii";
>> +       phy-supply = <&reg_dldo1>;
>>         status = "okay";
>>
>>         phy1: ethernet-phy@1 {
>> @@ -101,13 +106,26 @@
>>  &mmc0 {
>>         pinctrl-names = "default";
>>         pinctrl-0 = <&mmc0_pins_a>, <&mmc0_cd_pin_m9>;
>> -       vmmc-supply = <&reg_vcc3v3>;
>> +       vmmc-supply = <&reg_dcdc1>;
>>         bus-width = <4>;
>>         cd-gpios = <&pio 7 22 GPIO_ACTIVE_HIGH>; /* PH22 */
>>         cd-inverted;
>>         status = "okay";
>>  };
>>
>> +&p2wi {
>> +       status = "okay";
>> +
>> +       axp22x: pmic@68 {
>> +               compatible = "x-powers,axp221";
>> +               reg = <0x68>;
>> +               interrupt-parent = <&nmi_intc>;
>> +               interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
>> +       };
>> +};
>> +
>> +#include "axp22x.dtsi"
>> +
>>  &pio {
>>         led_pins_m9: led_pins@0 {
>>                 allwinner,pins = "PH13";
>> @@ -131,6 +149,73 @@
>>         };
>>  };
>>
>> +&reg_aldo1 {
>> +       regulator-min-microvolt = <3300000>;
>> +       regulator-max-microvolt = <3300000>;
>> +       regulator-name = "vcc-wifi";
>> +};
>> +
>> +&reg_aldo3 {
>> +       regulator-always-on;
>> +       regulator-min-microvolt = <2700000>;
>> +       regulator-max-microvolt = <3300000>;
>> +       regulator-name = "avcc";
>> +};
>> +
>> +&reg_dc5ldo {
>> +       regulator-always-on;
>> +       regulator-min-microvolt = <700000>;
>> +       regulator-max-microvolt = <1320000>;
>> +       regulator-name = "vdd-cpus"; /* This is an educated guess */
>> +};
>> +
>> +&reg_dcdc1 {
>> +       regulator-always-on;
>> +       regulator-min-microvolt = <3300000>;
>> +       regulator-max-microvolt = <3300000>;
>> +       regulator-name = "vcc-3v3";
>> +};
>> +
>> +&reg_dcdc2 {
>> +       regulator-min-microvolt = <700000>;
>> +       regulator-max-microvolt = <1320000>;
>> +       regulator-name = "vdd-gpu";
>> +};
>> +
>> +&reg_dcdc3 {
>> +       regulator-always-on;
>> +       regulator-min-microvolt = <700000>;
>> +       regulator-max-microvolt = <1320000>;
>> +       regulator-name = "vdd-cpu";
>> +};
>> +
>> +&reg_dcdc4 {
>> +       regulator-always-on;
>> +       regulator-min-microvolt = <700000>;
>> +       regulator-max-microvolt = <1320000>;
>> +       regulator-name = "vdd-sys-dll";
>> +};
>> +
>> +&reg_dcdc5 {
>> +       regulator-always-on;
>> +       regulator-min-microvolt = <1500000>;
>> +       regulator-max-microvolt = <1500000>;
>> +       regulator-name = "vcc-dram";
>> +};
>> +
>> +&reg_dldo1 {
>> +       regulator-min-microvolt = <3300000>;
>> +       regulator-max-microvolt = <3300000>;
>> +       regulator-name = "vcc-ethernet-phy";
>> +};
>> +
>> +&reg_dldo4 {
>> +       regulator-always-on;
>
> Why not tie this to the usbphy? Same for the other patch.

Because both reg_usb1_vbus and reg_dldo4 need to be on
for the hub attached to usb1 to work, and I can list
only one usb1_vbus-supply.

Regards,

Hans
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 14+ messages in thread
* [PATCH 1/2] ARM: dts: sun6i: Add pmic / regulator nodes to Mele A1000G quad dts
@ 2016-06-06  7:23         ` Hans de Goede
  0 siblings, 0 replies; 14+ messages in thread
From: Hans de Goede @ 2016-06-06  7:23 UTC (permalink / raw)
  To: linux-arm-kernel

Hi,

On 06-06-16 09:12, Chen-Yu Tsai wrote:
> On Sun, Jun 5, 2016 at 9:37 PM, Hans de Goede <hdegoede@redhat.com> wrote:
>> Add pmic / regulator nodes to Mele A1000G quad dts.
>>
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>> ---
>>  arch/arm/boot/dts/sun6i-a31-mele-a1000g-quad.dts | 88 +++++++++++++++++++++++-
>>  1 file changed, 87 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/sun6i-a31-mele-a1000g-quad.dts b/arch/arm/boot/dts/sun6i-a31-mele-a1000g-quad.dts
>> index e063dab..9782113 100644
>> --- a/arch/arm/boot/dts/sun6i-a31-mele-a1000g-quad.dts
>> +++ b/arch/arm/boot/dts/sun6i-a31-mele-a1000g-quad.dts
>> @@ -72,6 +72,10 @@
>>         };
>>  };
>>
>> +&cpu0 {
>> +       cpu-supply = <&reg_dcdc3>;
>> +};
>> +
>>  &ehci0 {
>>         status = "okay";
>>  };
>> @@ -85,6 +89,7 @@
>>         pinctrl-0 = <&gmac_pins_mii_a>;
>>         phy = <&phy1>;
>>         phy-mode = "mii";
>> +       phy-supply = <&reg_dldo1>;
>>         status = "okay";
>>
>>         phy1: ethernet-phy at 1 {
>> @@ -101,13 +106,26 @@
>>  &mmc0 {
>>         pinctrl-names = "default";
>>         pinctrl-0 = <&mmc0_pins_a>, <&mmc0_cd_pin_m9>;
>> -       vmmc-supply = <&reg_vcc3v3>;
>> +       vmmc-supply = <&reg_dcdc1>;
>>         bus-width = <4>;
>>         cd-gpios = <&pio 7 22 GPIO_ACTIVE_HIGH>; /* PH22 */
>>         cd-inverted;
>>         status = "okay";
>>  };
>>
>> +&p2wi {
>> +       status = "okay";
>> +
>> +       axp22x: pmic at 68 {
>> +               compatible = "x-powers,axp221";
>> +               reg = <0x68>;
>> +               interrupt-parent = <&nmi_intc>;
>> +               interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
>> +       };
>> +};
>> +
>> +#include "axp22x.dtsi"
>> +
>>  &pio {
>>         led_pins_m9: led_pins at 0 {
>>                 allwinner,pins = "PH13";
>> @@ -131,6 +149,73 @@
>>         };
>>  };
>>
>> +&reg_aldo1 {
>> +       regulator-min-microvolt = <3300000>;
>> +       regulator-max-microvolt = <3300000>;
>> +       regulator-name = "vcc-wifi";
>> +};
>> +
>> +&reg_aldo3 {
>> +       regulator-always-on;
>> +       regulator-min-microvolt = <2700000>;
>> +       regulator-max-microvolt = <3300000>;
>> +       regulator-name = "avcc";
>> +};
>> +
>> +&reg_dc5ldo {
>> +       regulator-always-on;
>> +       regulator-min-microvolt = <700000>;
>> +       regulator-max-microvolt = <1320000>;
>> +       regulator-name = "vdd-cpus"; /* This is an educated guess */
>> +};
>> +
>> +&reg_dcdc1 {
>> +       regulator-always-on;
>> +       regulator-min-microvolt = <3300000>;
>> +       regulator-max-microvolt = <3300000>;
>> +       regulator-name = "vcc-3v3";
>> +};
>> +
>> +&reg_dcdc2 {
>> +       regulator-min-microvolt = <700000>;
>> +       regulator-max-microvolt = <1320000>;
>> +       regulator-name = "vdd-gpu";
>> +};
>> +
>> +&reg_dcdc3 {
>> +       regulator-always-on;
>> +       regulator-min-microvolt = <700000>;
>> +       regulator-max-microvolt = <1320000>;
>> +       regulator-name = "vdd-cpu";
>> +};
>> +
>> +&reg_dcdc4 {
>> +       regulator-always-on;
>> +       regulator-min-microvolt = <700000>;
>> +       regulator-max-microvolt = <1320000>;
>> +       regulator-name = "vdd-sys-dll";
>> +};
>> +
>> +&reg_dcdc5 {
>> +       regulator-always-on;
>> +       regulator-min-microvolt = <1500000>;
>> +       regulator-max-microvolt = <1500000>;
>> +       regulator-name = "vcc-dram";
>> +};
>> +
>> +&reg_dldo1 {
>> +       regulator-min-microvolt = <3300000>;
>> +       regulator-max-microvolt = <3300000>;
>> +       regulator-name = "vcc-ethernet-phy";
>> +};
>> +
>> +&reg_dldo4 {
>> +       regulator-always-on;
>
> Why not tie this to the usbphy? Same for the other patch.

Because both reg_usb1_vbus and reg_dldo4 need to be on
for the hub attached to usb1 to work, and I can list
only one usb1_vbus-supply.

Regards,

Hans

^ permalink raw reply	[flat|nested] 14+ messages in thread
* Re: [PATCH 1/2] ARM: dts: sun6i: Add pmic / regulator nodes to Mele A1000G quad dts
  2016-06-06  7:23         ` Hans de Goede
@ 2016-06-06  7:33             ` Chen-Yu Tsai
  -1 siblings, 0 replies; 14+ messages in thread
From: Chen-Yu Tsai @ 2016-06-06  7:33 UTC (permalink / raw)
  To: Hans de Goede; +Cc: Chen-Yu Tsai, Maxime Ripard, linux-arm-kernel, devicetree

On Mon, Jun 6, 2016 at 3:23 PM, Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> wrote:
> Hi,
>
>
> On 06-06-16 09:12, Chen-Yu Tsai wrote:
>>
>> On Sun, Jun 5, 2016 at 9:37 PM, Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> wrote:
>>>
>>> Add pmic / regulator nodes to Mele A1000G quad dts.
>>>
>>> Signed-off-by: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
>>> ---
>>>  arch/arm/boot/dts/sun6i-a31-mele-a1000g-quad.dts | 88
>>> +++++++++++++++++++++++-
>>>  1 file changed, 87 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm/boot/dts/sun6i-a31-mele-a1000g-quad.dts
>>> b/arch/arm/boot/dts/sun6i-a31-mele-a1000g-quad.dts
>>> index e063dab..9782113 100644
>>> --- a/arch/arm/boot/dts/sun6i-a31-mele-a1000g-quad.dts
>>> +++ b/arch/arm/boot/dts/sun6i-a31-mele-a1000g-quad.dts
>>> @@ -72,6 +72,10 @@
>>>         };
>>>  };
>>>
>>> +&cpu0 {
>>> +       cpu-supply = <&reg_dcdc3>;
>>> +};
>>> +
>>>  &ehci0 {
>>>         status = "okay";
>>>  };
>>> @@ -85,6 +89,7 @@
>>>         pinctrl-0 = <&gmac_pins_mii_a>;
>>>         phy = <&phy1>;
>>>         phy-mode = "mii";
>>> +       phy-supply = <&reg_dldo1>;
>>>         status = "okay";
>>>
>>>         phy1: ethernet-phy@1 {
>>> @@ -101,13 +106,26 @@
>>>  &mmc0 {
>>>         pinctrl-names = "default";
>>>         pinctrl-0 = <&mmc0_pins_a>, <&mmc0_cd_pin_m9>;
>>> -       vmmc-supply = <&reg_vcc3v3>;
>>> +       vmmc-supply = <&reg_dcdc1>;
>>>         bus-width = <4>;
>>>         cd-gpios = <&pio 7 22 GPIO_ACTIVE_HIGH>; /* PH22 */
>>>         cd-inverted;
>>>         status = "okay";
>>>  };
>>>
>>> +&p2wi {
>>> +       status = "okay";
>>> +
>>> +       axp22x: pmic@68 {
>>> +               compatible = "x-powers,axp221";
>>> +               reg = <0x68>;
>>> +               interrupt-parent = <&nmi_intc>;
>>> +               interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
>>> +       };
>>> +};
>>> +
>>> +#include "axp22x.dtsi"
>>> +
>>>  &pio {
>>>         led_pins_m9: led_pins@0 {
>>>                 allwinner,pins = "PH13";
>>> @@ -131,6 +149,73 @@
>>>         };
>>>  };
>>>
>>> +&reg_aldo1 {
>>> +       regulator-min-microvolt = <3300000>;
>>> +       regulator-max-microvolt = <3300000>;
>>> +       regulator-name = "vcc-wifi";
>>> +};
>>> +
>>> +&reg_aldo3 {
>>> +       regulator-always-on;
>>> +       regulator-min-microvolt = <2700000>;
>>> +       regulator-max-microvolt = <3300000>;
>>> +       regulator-name = "avcc";
>>> +};
>>> +
>>> +&reg_dc5ldo {
>>> +       regulator-always-on;
>>> +       regulator-min-microvolt = <700000>;
>>> +       regulator-max-microvolt = <1320000>;
>>> +       regulator-name = "vdd-cpus"; /* This is an educated guess */
>>> +};
>>> +
>>> +&reg_dcdc1 {
>>> +       regulator-always-on;
>>> +       regulator-min-microvolt = <3300000>;
>>> +       regulator-max-microvolt = <3300000>;
>>> +       regulator-name = "vcc-3v3";
>>> +};
>>> +
>>> +&reg_dcdc2 {
>>> +       regulator-min-microvolt = <700000>;
>>> +       regulator-max-microvolt = <1320000>;
>>> +       regulator-name = "vdd-gpu";
>>> +};
>>> +
>>> +&reg_dcdc3 {
>>> +       regulator-always-on;
>>> +       regulator-min-microvolt = <700000>;
>>> +       regulator-max-microvolt = <1320000>;
>>> +       regulator-name = "vdd-cpu";
>>> +};
>>> +
>>> +&reg_dcdc4 {
>>> +       regulator-always-on;
>>> +       regulator-min-microvolt = <700000>;
>>> +       regulator-max-microvolt = <1320000>;
>>> +       regulator-name = "vdd-sys-dll";
>>> +};
>>> +
>>> +&reg_dcdc5 {
>>> +       regulator-always-on;
>>> +       regulator-min-microvolt = <1500000>;
>>> +       regulator-max-microvolt = <1500000>;
>>> +       regulator-name = "vcc-dram";
>>> +};
>>> +
>>> +&reg_dldo1 {
>>> +       regulator-min-microvolt = <3300000>;
>>> +       regulator-max-microvolt = <3300000>;
>>> +       regulator-name = "vcc-ethernet-phy";
>>> +};
>>> +
>>> +&reg_dldo4 {
>>> +       regulator-always-on;
>>
>>
>> Why not tie this to the usbphy? Same for the other patch.
>
>
> Because both reg_usb1_vbus and reg_dldo4 need to be on
> for the hub attached to usb1 to work, and I can list
> only one usb1_vbus-supply.

Understood. We'll have to wait for the generic pwrseq stuff for
a proper description of this.

For now,

Acked-by: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>

for both patches.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 14+ messages in thread
* [PATCH 1/2] ARM: dts: sun6i: Add pmic / regulator nodes to Mele A1000G quad dts
@ 2016-06-06  7:33             ` Chen-Yu Tsai
  0 siblings, 0 replies; 14+ messages in thread
From: Chen-Yu Tsai @ 2016-06-06  7:33 UTC (permalink / raw)
  To: linux-arm-kernel

On Mon, Jun 6, 2016 at 3:23 PM, Hans de Goede <hdegoede@redhat.com> wrote:
> Hi,
>
>
> On 06-06-16 09:12, Chen-Yu Tsai wrote:
>>
>> On Sun, Jun 5, 2016 at 9:37 PM, Hans de Goede <hdegoede@redhat.com> wrote:
>>>
>>> Add pmic / regulator nodes to Mele A1000G quad dts.
>>>
>>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>>> ---
>>>  arch/arm/boot/dts/sun6i-a31-mele-a1000g-quad.dts | 88
>>> +++++++++++++++++++++++-
>>>  1 file changed, 87 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm/boot/dts/sun6i-a31-mele-a1000g-quad.dts
>>> b/arch/arm/boot/dts/sun6i-a31-mele-a1000g-quad.dts
>>> index e063dab..9782113 100644
>>> --- a/arch/arm/boot/dts/sun6i-a31-mele-a1000g-quad.dts
>>> +++ b/arch/arm/boot/dts/sun6i-a31-mele-a1000g-quad.dts
>>> @@ -72,6 +72,10 @@
>>>         };
>>>  };
>>>
>>> +&cpu0 {
>>> +       cpu-supply = <&reg_dcdc3>;
>>> +};
>>> +
>>>  &ehci0 {
>>>         status = "okay";
>>>  };
>>> @@ -85,6 +89,7 @@
>>>         pinctrl-0 = <&gmac_pins_mii_a>;
>>>         phy = <&phy1>;
>>>         phy-mode = "mii";
>>> +       phy-supply = <&reg_dldo1>;
>>>         status = "okay";
>>>
>>>         phy1: ethernet-phy at 1 {
>>> @@ -101,13 +106,26 @@
>>>  &mmc0 {
>>>         pinctrl-names = "default";
>>>         pinctrl-0 = <&mmc0_pins_a>, <&mmc0_cd_pin_m9>;
>>> -       vmmc-supply = <&reg_vcc3v3>;
>>> +       vmmc-supply = <&reg_dcdc1>;
>>>         bus-width = <4>;
>>>         cd-gpios = <&pio 7 22 GPIO_ACTIVE_HIGH>; /* PH22 */
>>>         cd-inverted;
>>>         status = "okay";
>>>  };
>>>
>>> +&p2wi {
>>> +       status = "okay";
>>> +
>>> +       axp22x: pmic at 68 {
>>> +               compatible = "x-powers,axp221";
>>> +               reg = <0x68>;
>>> +               interrupt-parent = <&nmi_intc>;
>>> +               interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
>>> +       };
>>> +};
>>> +
>>> +#include "axp22x.dtsi"
>>> +
>>>  &pio {
>>>         led_pins_m9: led_pins at 0 {
>>>                 allwinner,pins = "PH13";
>>> @@ -131,6 +149,73 @@
>>>         };
>>>  };
>>>
>>> +&reg_aldo1 {
>>> +       regulator-min-microvolt = <3300000>;
>>> +       regulator-max-microvolt = <3300000>;
>>> +       regulator-name = "vcc-wifi";
>>> +};
>>> +
>>> +&reg_aldo3 {
>>> +       regulator-always-on;
>>> +       regulator-min-microvolt = <2700000>;
>>> +       regulator-max-microvolt = <3300000>;
>>> +       regulator-name = "avcc";
>>> +};
>>> +
>>> +&reg_dc5ldo {
>>> +       regulator-always-on;
>>> +       regulator-min-microvolt = <700000>;
>>> +       regulator-max-microvolt = <1320000>;
>>> +       regulator-name = "vdd-cpus"; /* This is an educated guess */
>>> +};
>>> +
>>> +&reg_dcdc1 {
>>> +       regulator-always-on;
>>> +       regulator-min-microvolt = <3300000>;
>>> +       regulator-max-microvolt = <3300000>;
>>> +       regulator-name = "vcc-3v3";
>>> +};
>>> +
>>> +&reg_dcdc2 {
>>> +       regulator-min-microvolt = <700000>;
>>> +       regulator-max-microvolt = <1320000>;
>>> +       regulator-name = "vdd-gpu";
>>> +};
>>> +
>>> +&reg_dcdc3 {
>>> +       regulator-always-on;
>>> +       regulator-min-microvolt = <700000>;
>>> +       regulator-max-microvolt = <1320000>;
>>> +       regulator-name = "vdd-cpu";
>>> +};
>>> +
>>> +&reg_dcdc4 {
>>> +       regulator-always-on;
>>> +       regulator-min-microvolt = <700000>;
>>> +       regulator-max-microvolt = <1320000>;
>>> +       regulator-name = "vdd-sys-dll";
>>> +};
>>> +
>>> +&reg_dcdc5 {
>>> +       regulator-always-on;
>>> +       regulator-min-microvolt = <1500000>;
>>> +       regulator-max-microvolt = <1500000>;
>>> +       regulator-name = "vcc-dram";
>>> +};
>>> +
>>> +&reg_dldo1 {
>>> +       regulator-min-microvolt = <3300000>;
>>> +       regulator-max-microvolt = <3300000>;
>>> +       regulator-name = "vcc-ethernet-phy";
>>> +};
>>> +
>>> +&reg_dldo4 {
>>> +       regulator-always-on;
>>
>>
>> Why not tie this to the usbphy? Same for the other patch.
>
>
> Because both reg_usb1_vbus and reg_dldo4 need to be on
> for the hub attached to usb1 to work, and I can list
> only one usb1_vbus-supply.

Understood. We'll have to wait for the generic pwrseq stuff for
a proper description of this.

For now,

Acked-by: Chen-Yu Tsai <wens@csie.org>

for both patches.

^ permalink raw reply	[flat|nested] 14+ messages in thread
* Re: [PATCH 1/2] ARM: dts: sun6i: Add pmic / regulator nodes to Mele A1000G quad dts
  2016-06-06  7:23         ` Hans de Goede
@ 2016-06-07 21:25             ` Maxime Ripard
  -1 siblings, 0 replies; 14+ messages in thread
From: Maxime Ripard @ 2016-06-07 21:25 UTC (permalink / raw)
  To: Hans de Goede; +Cc: Chen-Yu Tsai, linux-arm-kernel, devicetree

[-- Attachment #1: Type: text/plain, Size: 4395 bytes --]

On Mon, Jun 06, 2016 at 09:23:36AM +0200, Hans de Goede wrote:
> Hi,
> 
> On 06-06-16 09:12, Chen-Yu Tsai wrote:
> >On Sun, Jun 5, 2016 at 9:37 PM, Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> wrote:
> >>Add pmic / regulator nodes to Mele A1000G quad dts.
> >>
> >>Signed-off-by: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> >>---
> >> arch/arm/boot/dts/sun6i-a31-mele-a1000g-quad.dts | 88 +++++++++++++++++++++++-
> >> 1 file changed, 87 insertions(+), 1 deletion(-)
> >>
> >>diff --git a/arch/arm/boot/dts/sun6i-a31-mele-a1000g-quad.dts b/arch/arm/boot/dts/sun6i-a31-mele-a1000g-quad.dts
> >>index e063dab..9782113 100644
> >>--- a/arch/arm/boot/dts/sun6i-a31-mele-a1000g-quad.dts
> >>+++ b/arch/arm/boot/dts/sun6i-a31-mele-a1000g-quad.dts
> >>@@ -72,6 +72,10 @@
> >>        };
> >> };
> >>
> >>+&cpu0 {
> >>+       cpu-supply = <&reg_dcdc3>;
> >>+};
> >>+
> >> &ehci0 {
> >>        status = "okay";
> >> };
> >>@@ -85,6 +89,7 @@
> >>        pinctrl-0 = <&gmac_pins_mii_a>;
> >>        phy = <&phy1>;
> >>        phy-mode = "mii";
> >>+       phy-supply = <&reg_dldo1>;
> >>        status = "okay";
> >>
> >>        phy1: ethernet-phy@1 {
> >>@@ -101,13 +106,26 @@
> >> &mmc0 {
> >>        pinctrl-names = "default";
> >>        pinctrl-0 = <&mmc0_pins_a>, <&mmc0_cd_pin_m9>;
> >>-       vmmc-supply = <&reg_vcc3v3>;
> >>+       vmmc-supply = <&reg_dcdc1>;
> >>        bus-width = <4>;
> >>        cd-gpios = <&pio 7 22 GPIO_ACTIVE_HIGH>; /* PH22 */
> >>        cd-inverted;
> >>        status = "okay";
> >> };
> >>
> >>+&p2wi {
> >>+       status = "okay";
> >>+
> >>+       axp22x: pmic@68 {
> >>+               compatible = "x-powers,axp221";
> >>+               reg = <0x68>;
> >>+               interrupt-parent = <&nmi_intc>;
> >>+               interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
> >>+       };
> >>+};
> >>+
> >>+#include "axp22x.dtsi"
> >>+
> >> &pio {
> >>        led_pins_m9: led_pins@0 {
> >>                allwinner,pins = "PH13";
> >>@@ -131,6 +149,73 @@
> >>        };
> >> };
> >>
> >>+&reg_aldo1 {
> >>+       regulator-min-microvolt = <3300000>;
> >>+       regulator-max-microvolt = <3300000>;
> >>+       regulator-name = "vcc-wifi";
> >>+};
> >>+
> >>+&reg_aldo3 {
> >>+       regulator-always-on;
> >>+       regulator-min-microvolt = <2700000>;
> >>+       regulator-max-microvolt = <3300000>;
> >>+       regulator-name = "avcc";
> >>+};
> >>+
> >>+&reg_dc5ldo {
> >>+       regulator-always-on;
> >>+       regulator-min-microvolt = <700000>;
> >>+       regulator-max-microvolt = <1320000>;
> >>+       regulator-name = "vdd-cpus"; /* This is an educated guess */
> >>+};
> >>+
> >>+&reg_dcdc1 {
> >>+       regulator-always-on;
> >>+       regulator-min-microvolt = <3300000>;
> >>+       regulator-max-microvolt = <3300000>;
> >>+       regulator-name = "vcc-3v3";
> >>+};
> >>+
> >>+&reg_dcdc2 {
> >>+       regulator-min-microvolt = <700000>;
> >>+       regulator-max-microvolt = <1320000>;
> >>+       regulator-name = "vdd-gpu";
> >>+};
> >>+
> >>+&reg_dcdc3 {
> >>+       regulator-always-on;
> >>+       regulator-min-microvolt = <700000>;
> >>+       regulator-max-microvolt = <1320000>;
> >>+       regulator-name = "vdd-cpu";
> >>+};
> >>+
> >>+&reg_dcdc4 {
> >>+       regulator-always-on;
> >>+       regulator-min-microvolt = <700000>;
> >>+       regulator-max-microvolt = <1320000>;
> >>+       regulator-name = "vdd-sys-dll";
> >>+};
> >>+
> >>+&reg_dcdc5 {
> >>+       regulator-always-on;
> >>+       regulator-min-microvolt = <1500000>;
> >>+       regulator-max-microvolt = <1500000>;
> >>+       regulator-name = "vcc-dram";
> >>+};
> >>+
> >>+&reg_dldo1 {
> >>+       regulator-min-microvolt = <3300000>;
> >>+       regulator-max-microvolt = <3300000>;
> >>+       regulator-name = "vcc-ethernet-phy";
> >>+};
> >>+
> >>+&reg_dldo4 {
> >>+       regulator-always-on;
> >
> >Why not tie this to the usbphy? Same for the other patch.
> 
> Because both reg_usb1_vbus and reg_dldo4 need to be on
> for the hub attached to usb1 to work, and I can list
> only one usb1_vbus-supply.

Adding a comment stating that would be great :)

Thanks!
Maxime


-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 14+ messages in thread
* [PATCH 1/2] ARM: dts: sun6i: Add pmic / regulator nodes to Mele A1000G quad dts
@ 2016-06-07 21:25             ` Maxime Ripard
  0 siblings, 0 replies; 14+ messages in thread
From: Maxime Ripard @ 2016-06-07 21:25 UTC (permalink / raw)
  To: linux-arm-kernel

On Mon, Jun 06, 2016 at 09:23:36AM +0200, Hans de Goede wrote:
> Hi,
> 
> On 06-06-16 09:12, Chen-Yu Tsai wrote:
> >On Sun, Jun 5, 2016 at 9:37 PM, Hans de Goede <hdegoede@redhat.com> wrote:
> >>Add pmic / regulator nodes to Mele A1000G quad dts.
> >>
> >>Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> >>---
> >> arch/arm/boot/dts/sun6i-a31-mele-a1000g-quad.dts | 88 +++++++++++++++++++++++-
> >> 1 file changed, 87 insertions(+), 1 deletion(-)
> >>
> >>diff --git a/arch/arm/boot/dts/sun6i-a31-mele-a1000g-quad.dts b/arch/arm/boot/dts/sun6i-a31-mele-a1000g-quad.dts
> >>index e063dab..9782113 100644
> >>--- a/arch/arm/boot/dts/sun6i-a31-mele-a1000g-quad.dts
> >>+++ b/arch/arm/boot/dts/sun6i-a31-mele-a1000g-quad.dts
> >>@@ -72,6 +72,10 @@
> >>        };
> >> };
> >>
> >>+&cpu0 {
> >>+       cpu-supply = <&reg_dcdc3>;
> >>+};
> >>+
> >> &ehci0 {
> >>        status = "okay";
> >> };
> >>@@ -85,6 +89,7 @@
> >>        pinctrl-0 = <&gmac_pins_mii_a>;
> >>        phy = <&phy1>;
> >>        phy-mode = "mii";
> >>+       phy-supply = <&reg_dldo1>;
> >>        status = "okay";
> >>
> >>        phy1: ethernet-phy at 1 {
> >>@@ -101,13 +106,26 @@
> >> &mmc0 {
> >>        pinctrl-names = "default";
> >>        pinctrl-0 = <&mmc0_pins_a>, <&mmc0_cd_pin_m9>;
> >>-       vmmc-supply = <&reg_vcc3v3>;
> >>+       vmmc-supply = <&reg_dcdc1>;
> >>        bus-width = <4>;
> >>        cd-gpios = <&pio 7 22 GPIO_ACTIVE_HIGH>; /* PH22 */
> >>        cd-inverted;
> >>        status = "okay";
> >> };
> >>
> >>+&p2wi {
> >>+       status = "okay";
> >>+
> >>+       axp22x: pmic at 68 {
> >>+               compatible = "x-powers,axp221";
> >>+               reg = <0x68>;
> >>+               interrupt-parent = <&nmi_intc>;
> >>+               interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
> >>+       };
> >>+};
> >>+
> >>+#include "axp22x.dtsi"
> >>+
> >> &pio {
> >>        led_pins_m9: led_pins at 0 {
> >>                allwinner,pins = "PH13";
> >>@@ -131,6 +149,73 @@
> >>        };
> >> };
> >>
> >>+&reg_aldo1 {
> >>+       regulator-min-microvolt = <3300000>;
> >>+       regulator-max-microvolt = <3300000>;
> >>+       regulator-name = "vcc-wifi";
> >>+};
> >>+
> >>+&reg_aldo3 {
> >>+       regulator-always-on;
> >>+       regulator-min-microvolt = <2700000>;
> >>+       regulator-max-microvolt = <3300000>;
> >>+       regulator-name = "avcc";
> >>+};
> >>+
> >>+&reg_dc5ldo {
> >>+       regulator-always-on;
> >>+       regulator-min-microvolt = <700000>;
> >>+       regulator-max-microvolt = <1320000>;
> >>+       regulator-name = "vdd-cpus"; /* This is an educated guess */
> >>+};
> >>+
> >>+&reg_dcdc1 {
> >>+       regulator-always-on;
> >>+       regulator-min-microvolt = <3300000>;
> >>+       regulator-max-microvolt = <3300000>;
> >>+       regulator-name = "vcc-3v3";
> >>+};
> >>+
> >>+&reg_dcdc2 {
> >>+       regulator-min-microvolt = <700000>;
> >>+       regulator-max-microvolt = <1320000>;
> >>+       regulator-name = "vdd-gpu";
> >>+};
> >>+
> >>+&reg_dcdc3 {
> >>+       regulator-always-on;
> >>+       regulator-min-microvolt = <700000>;
> >>+       regulator-max-microvolt = <1320000>;
> >>+       regulator-name = "vdd-cpu";
> >>+};
> >>+
> >>+&reg_dcdc4 {
> >>+       regulator-always-on;
> >>+       regulator-min-microvolt = <700000>;
> >>+       regulator-max-microvolt = <1320000>;
> >>+       regulator-name = "vdd-sys-dll";
> >>+};
> >>+
> >>+&reg_dcdc5 {
> >>+       regulator-always-on;
> >>+       regulator-min-microvolt = <1500000>;
> >>+       regulator-max-microvolt = <1500000>;
> >>+       regulator-name = "vcc-dram";
> >>+};
> >>+
> >>+&reg_dldo1 {
> >>+       regulator-min-microvolt = <3300000>;
> >>+       regulator-max-microvolt = <3300000>;
> >>+       regulator-name = "vcc-ethernet-phy";
> >>+};
> >>+
> >>+&reg_dldo4 {
> >>+       regulator-always-on;
> >
> >Why not tie this to the usbphy? Same for the other patch.
> 
> Because both reg_usb1_vbus and reg_dldo4 need to be on
> for the hub attached to usb1 to work, and I can list
> only one usb1_vbus-supply.

Adding a comment stating that would be great :)

Thanks!
Maxime


-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160607/06c25ecb/attachment.sig>

^ permalink raw reply	[flat|nested] 14+ messages in thread
* Re: [PATCH 1/2] ARM: dts: sun6i: Add pmic / regulator nodes to Mele A1000G quad dts
  2016-06-07 21:25             ` Maxime Ripard
@ 2016-06-09 10:53               ` Hans de Goede
  -1 siblings, 0 replies; 14+ messages in thread
From: Hans de Goede @ 2016-06-09 10:53 UTC (permalink / raw)
  To: Maxime Ripard; +Cc: Chen-Yu Tsai, linux-arm-kernel, devicetree

HI,

On 07-06-16 23:25, Maxime Ripard wrote:
> On Mon, Jun 06, 2016 at 09:23:36AM +0200, Hans de Goede wrote:
>> Hi,
>>
>> On 06-06-16 09:12, Chen-Yu Tsai wrote:
>>> On Sun, Jun 5, 2016 at 9:37 PM, Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> wrote:
>>>> Add pmic / regulator nodes to Mele A1000G quad dts.
>>>>
>>>> Signed-off-by: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
>>>> ---
>>>> arch/arm/boot/dts/sun6i-a31-mele-a1000g-quad.dts | 88 +++++++++++++++++++++++-
>>>> 1 file changed, 87 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/arch/arm/boot/dts/sun6i-a31-mele-a1000g-quad.dts b/arch/arm/boot/dts/sun6i-a31-mele-a1000g-quad.dts
>>>> index e063dab..9782113 100644
>>>> --- a/arch/arm/boot/dts/sun6i-a31-mele-a1000g-quad.dts
>>>> +++ b/arch/arm/boot/dts/sun6i-a31-mele-a1000g-quad.dts
>>>> @@ -72,6 +72,10 @@
>>>>        };
>>>> };
>>>>
>>>> +&cpu0 {
>>>> +       cpu-supply = <&reg_dcdc3>;
>>>> +};
>>>> +
>>>> &ehci0 {
>>>>        status = "okay";
>>>> };
>>>> @@ -85,6 +89,7 @@
>>>>        pinctrl-0 = <&gmac_pins_mii_a>;
>>>>        phy = <&phy1>;
>>>>        phy-mode = "mii";
>>>> +       phy-supply = <&reg_dldo1>;
>>>>        status = "okay";
>>>>
>>>>        phy1: ethernet-phy@1 {
>>>> @@ -101,13 +106,26 @@
>>>> &mmc0 {
>>>>        pinctrl-names = "default";
>>>>        pinctrl-0 = <&mmc0_pins_a>, <&mmc0_cd_pin_m9>;
>>>> -       vmmc-supply = <&reg_vcc3v3>;
>>>> +       vmmc-supply = <&reg_dcdc1>;
>>>>        bus-width = <4>;
>>>>        cd-gpios = <&pio 7 22 GPIO_ACTIVE_HIGH>; /* PH22 */
>>>>        cd-inverted;
>>>>        status = "okay";
>>>> };
>>>>
>>>> +&p2wi {
>>>> +       status = "okay";
>>>> +
>>>> +       axp22x: pmic@68 {
>>>> +               compatible = "x-powers,axp221";
>>>> +               reg = <0x68>;
>>>> +               interrupt-parent = <&nmi_intc>;
>>>> +               interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
>>>> +       };
>>>> +};
>>>> +
>>>> +#include "axp22x.dtsi"
>>>> +
>>>> &pio {
>>>>        led_pins_m9: led_pins@0 {
>>>>                allwinner,pins = "PH13";
>>>> @@ -131,6 +149,73 @@
>>>>        };
>>>> };
>>>>
>>>> +&reg_aldo1 {
>>>> +       regulator-min-microvolt = <3300000>;
>>>> +       regulator-max-microvolt = <3300000>;
>>>> +       regulator-name = "vcc-wifi";
>>>> +};
>>>> +
>>>> +&reg_aldo3 {
>>>> +       regulator-always-on;
>>>> +       regulator-min-microvolt = <2700000>;
>>>> +       regulator-max-microvolt = <3300000>;
>>>> +       regulator-name = "avcc";
>>>> +};
>>>> +
>>>> +&reg_dc5ldo {
>>>> +       regulator-always-on;
>>>> +       regulator-min-microvolt = <700000>;
>>>> +       regulator-max-microvolt = <1320000>;
>>>> +       regulator-name = "vdd-cpus"; /* This is an educated guess */
>>>> +};
>>>> +
>>>> +&reg_dcdc1 {
>>>> +       regulator-always-on;
>>>> +       regulator-min-microvolt = <3300000>;
>>>> +       regulator-max-microvolt = <3300000>;
>>>> +       regulator-name = "vcc-3v3";
>>>> +};
>>>> +
>>>> +&reg_dcdc2 {
>>>> +       regulator-min-microvolt = <700000>;
>>>> +       regulator-max-microvolt = <1320000>;
>>>> +       regulator-name = "vdd-gpu";
>>>> +};
>>>> +
>>>> +&reg_dcdc3 {
>>>> +       regulator-always-on;
>>>> +       regulator-min-microvolt = <700000>;
>>>> +       regulator-max-microvolt = <1320000>;
>>>> +       regulator-name = "vdd-cpu";
>>>> +};
>>>> +
>>>> +&reg_dcdc4 {
>>>> +       regulator-always-on;
>>>> +       regulator-min-microvolt = <700000>;
>>>> +       regulator-max-microvolt = <1320000>;
>>>> +       regulator-name = "vdd-sys-dll";
>>>> +};
>>>> +
>>>> +&reg_dcdc5 {
>>>> +       regulator-always-on;
>>>> +       regulator-min-microvolt = <1500000>;
>>>> +       regulator-max-microvolt = <1500000>;
>>>> +       regulator-name = "vcc-dram";
>>>> +};
>>>> +
>>>> +&reg_dldo1 {
>>>> +       regulator-min-microvolt = <3300000>;
>>>> +       regulator-max-microvolt = <3300000>;
>>>> +       regulator-name = "vcc-ethernet-phy";
>>>> +};
>>>> +
>>>> +&reg_dldo4 {
>>>> +       regulator-always-on;
>>>
>>> Why not tie this to the usbphy? Same for the other patch.
>>
>> Because both reg_usb1_vbus and reg_dldo4 need to be on
>> for the hub attached to usb1 to work, and I can list
>> only one usb1_vbus-supply.
>
> Adding a comment stating that would be great :)

Ok I'll send a v2 of both patch with an amended commit msg.

Regards,

Hans
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 14+ messages in thread
* [PATCH 1/2] ARM: dts: sun6i: Add pmic / regulator nodes to Mele A1000G quad dts
@ 2016-06-09 10:53               ` Hans de Goede
  0 siblings, 0 replies; 14+ messages in thread
From: Hans de Goede @ 2016-06-09 10:53 UTC (permalink / raw)
  To: linux-arm-kernel

HI,

On 07-06-16 23:25, Maxime Ripard wrote:
> On Mon, Jun 06, 2016 at 09:23:36AM +0200, Hans de Goede wrote:
>> Hi,
>>
>> On 06-06-16 09:12, Chen-Yu Tsai wrote:
>>> On Sun, Jun 5, 2016 at 9:37 PM, Hans de Goede <hdegoede@redhat.com> wrote:
>>>> Add pmic / regulator nodes to Mele A1000G quad dts.
>>>>
>>>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>>>> ---
>>>> arch/arm/boot/dts/sun6i-a31-mele-a1000g-quad.dts | 88 +++++++++++++++++++++++-
>>>> 1 file changed, 87 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/arch/arm/boot/dts/sun6i-a31-mele-a1000g-quad.dts b/arch/arm/boot/dts/sun6i-a31-mele-a1000g-quad.dts
>>>> index e063dab..9782113 100644
>>>> --- a/arch/arm/boot/dts/sun6i-a31-mele-a1000g-quad.dts
>>>> +++ b/arch/arm/boot/dts/sun6i-a31-mele-a1000g-quad.dts
>>>> @@ -72,6 +72,10 @@
>>>>        };
>>>> };
>>>>
>>>> +&cpu0 {
>>>> +       cpu-supply = <&reg_dcdc3>;
>>>> +};
>>>> +
>>>> &ehci0 {
>>>>        status = "okay";
>>>> };
>>>> @@ -85,6 +89,7 @@
>>>>        pinctrl-0 = <&gmac_pins_mii_a>;
>>>>        phy = <&phy1>;
>>>>        phy-mode = "mii";
>>>> +       phy-supply = <&reg_dldo1>;
>>>>        status = "okay";
>>>>
>>>>        phy1: ethernet-phy at 1 {
>>>> @@ -101,13 +106,26 @@
>>>> &mmc0 {
>>>>        pinctrl-names = "default";
>>>>        pinctrl-0 = <&mmc0_pins_a>, <&mmc0_cd_pin_m9>;
>>>> -       vmmc-supply = <&reg_vcc3v3>;
>>>> +       vmmc-supply = <&reg_dcdc1>;
>>>>        bus-width = <4>;
>>>>        cd-gpios = <&pio 7 22 GPIO_ACTIVE_HIGH>; /* PH22 */
>>>>        cd-inverted;
>>>>        status = "okay";
>>>> };
>>>>
>>>> +&p2wi {
>>>> +       status = "okay";
>>>> +
>>>> +       axp22x: pmic at 68 {
>>>> +               compatible = "x-powers,axp221";
>>>> +               reg = <0x68>;
>>>> +               interrupt-parent = <&nmi_intc>;
>>>> +               interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
>>>> +       };
>>>> +};
>>>> +
>>>> +#include "axp22x.dtsi"
>>>> +
>>>> &pio {
>>>>        led_pins_m9: led_pins at 0 {
>>>>                allwinner,pins = "PH13";
>>>> @@ -131,6 +149,73 @@
>>>>        };
>>>> };
>>>>
>>>> +&reg_aldo1 {
>>>> +       regulator-min-microvolt = <3300000>;
>>>> +       regulator-max-microvolt = <3300000>;
>>>> +       regulator-name = "vcc-wifi";
>>>> +};
>>>> +
>>>> +&reg_aldo3 {
>>>> +       regulator-always-on;
>>>> +       regulator-min-microvolt = <2700000>;
>>>> +       regulator-max-microvolt = <3300000>;
>>>> +       regulator-name = "avcc";
>>>> +};
>>>> +
>>>> +&reg_dc5ldo {
>>>> +       regulator-always-on;
>>>> +       regulator-min-microvolt = <700000>;
>>>> +       regulator-max-microvolt = <1320000>;
>>>> +       regulator-name = "vdd-cpus"; /* This is an educated guess */
>>>> +};
>>>> +
>>>> +&reg_dcdc1 {
>>>> +       regulator-always-on;
>>>> +       regulator-min-microvolt = <3300000>;
>>>> +       regulator-max-microvolt = <3300000>;
>>>> +       regulator-name = "vcc-3v3";
>>>> +};
>>>> +
>>>> +&reg_dcdc2 {
>>>> +       regulator-min-microvolt = <700000>;
>>>> +       regulator-max-microvolt = <1320000>;
>>>> +       regulator-name = "vdd-gpu";
>>>> +};
>>>> +
>>>> +&reg_dcdc3 {
>>>> +       regulator-always-on;
>>>> +       regulator-min-microvolt = <700000>;
>>>> +       regulator-max-microvolt = <1320000>;
>>>> +       regulator-name = "vdd-cpu";
>>>> +};
>>>> +
>>>> +&reg_dcdc4 {
>>>> +       regulator-always-on;
>>>> +       regulator-min-microvolt = <700000>;
>>>> +       regulator-max-microvolt = <1320000>;
>>>> +       regulator-name = "vdd-sys-dll";
>>>> +};
>>>> +
>>>> +&reg_dcdc5 {
>>>> +       regulator-always-on;
>>>> +       regulator-min-microvolt = <1500000>;
>>>> +       regulator-max-microvolt = <1500000>;
>>>> +       regulator-name = "vcc-dram";
>>>> +};
>>>> +
>>>> +&reg_dldo1 {
>>>> +       regulator-min-microvolt = <3300000>;
>>>> +       regulator-max-microvolt = <3300000>;
>>>> +       regulator-name = "vcc-ethernet-phy";
>>>> +};
>>>> +
>>>> +&reg_dldo4 {
>>>> +       regulator-always-on;
>>>
>>> Why not tie this to the usbphy? Same for the other patch.
>>
>> Because both reg_usb1_vbus and reg_dldo4 need to be on
>> for the hub attached to usb1 to work, and I can list
>> only one usb1_vbus-supply.
>
> Adding a comment stating that would be great :)

Ok I'll send a v2 of both patch with an amended commit msg.

Regards,

Hans

^ permalink raw reply	[flat|nested] 14+ messages in thread
end of thread, other threads:[~2016-06-09 10:53 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-05 13:37 [PATCH 1/2] ARM: dts: sun6i: Add pmic / regulator nodes to Mele A1000G quad dts Hans de Goede
2016-06-05 13:37 ` Hans de Goede
     [not found] ` <1465133880-22921-1-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-06-05 13:38   ` [PATCH 2/2] ARM: dts: sun6i: Add pmic / regulator nodes to Mele M9 dts Hans de Goede
2016-06-05 13:38     ` Hans de Goede
2016-06-06  7:12   ` [PATCH 1/2] ARM: dts: sun6i: Add pmic / regulator nodes to Mele A1000G quad dts Chen-Yu Tsai
2016-06-06  7:12     ` Chen-Yu Tsai
     [not found]     ` <CAGb2v67Jo6MO7bp4JdV4hXrB4T60z4=ROkvAvE1i7dhAXk_UtQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-06-06  7:23       ` Hans de Goede
2016-06-06  7:23         ` Hans de Goede
     [not found]         ` <0a42bc82-83f2-80ce-93d4-a85c5ce69e24-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-06-06  7:33           ` Chen-Yu Tsai
2016-06-06  7:33             ` Chen-Yu Tsai
2016-06-07 21:25           ` Maxime Ripard
2016-06-07 21:25             ` Maxime Ripard
2016-06-09 10:53             ` Hans de Goede
2016-06-09 10:53               ` Hans de Goede

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.