* [PATCH -next] intel/iwlwifi: use DEFINE_MUTEX (and mutex_init() had been too late)
@ 2020-12-23 14:11 Zheng Yongjun
2020-12-23 15:02 ` Heiner Kallweit
0 siblings, 1 reply; 2+ messages in thread
From: Zheng Yongjun @ 2020-12-23 14:11 UTC (permalink / raw)
To: kvalo, davem, kuba, linux-wireless, netdev, linux-kernel; +Cc: Zheng Yongjun
Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
---
drivers/net/wireless/intel/iwlwifi/iwl-drv.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-drv.c b/drivers/net/wireless/intel/iwlwifi/iwl-drv.c
index 9dcd2e990c9c..71119044382f 100644
--- a/drivers/net/wireless/intel/iwlwifi/iwl-drv.c
+++ b/drivers/net/wireless/intel/iwlwifi/iwl-drv.c
@@ -133,7 +133,7 @@ enum {
};
/* Protects the table contents, i.e. the ops pointer & drv list */
-static struct mutex iwlwifi_opmode_table_mtx;
+static DEFINE_MUTEX(iwlwifi_opmode_table_mtx);
static struct iwlwifi_opmode_table {
const char *name; /* name: iwldvm, iwlmvm, etc */
const struct iwl_op_mode_ops *ops; /* pointer to op_mode ops */
@@ -1786,8 +1786,6 @@ static int __init iwl_drv_init(void)
{
int i, err;
- mutex_init(&iwlwifi_opmode_table_mtx);
-
for (i = 0; i < ARRAY_SIZE(iwlwifi_opmode_table); i++)
INIT_LIST_HEAD(&iwlwifi_opmode_table[i].drv);
--
2.22.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] intel/iwlwifi: use DEFINE_MUTEX (and mutex_init() had been too late)
2020-12-23 14:11 [PATCH -next] intel/iwlwifi: use DEFINE_MUTEX (and mutex_init() had been too late) Zheng Yongjun
@ 2020-12-23 15:02 ` Heiner Kallweit
0 siblings, 0 replies; 2+ messages in thread
From: Heiner Kallweit @ 2020-12-23 15:02 UTC (permalink / raw)
To: Zheng Yongjun, kvalo, davem, kuba, linux-wireless, netdev, linux-kernel
On 23.12.2020 15:11, Zheng Yongjun wrote:
> Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
> ---
> drivers/net/wireless/intel/iwlwifi/iwl-drv.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-drv.c b/drivers/net/wireless/intel/iwlwifi/iwl-drv.c
> index 9dcd2e990c9c..71119044382f 100644
> --- a/drivers/net/wireless/intel/iwlwifi/iwl-drv.c
> +++ b/drivers/net/wireless/intel/iwlwifi/iwl-drv.c
> @@ -133,7 +133,7 @@ enum {
> };
>
> /* Protects the table contents, i.e. the ops pointer & drv list */
> -static struct mutex iwlwifi_opmode_table_mtx;
> +static DEFINE_MUTEX(iwlwifi_opmode_table_mtx);
> static struct iwlwifi_opmode_table {
> const char *name; /* name: iwldvm, iwlmvm, etc */
> const struct iwl_op_mode_ops *ops; /* pointer to op_mode ops */
> @@ -1786,8 +1786,6 @@ static int __init iwl_drv_init(void)
> {
> int i, err;
>
> - mutex_init(&iwlwifi_opmode_table_mtx);
> -
> for (i = 0; i < ARRAY_SIZE(iwlwifi_opmode_table); i++)
> INIT_LIST_HEAD(&iwlwifi_opmode_table[i].drv);
>
>
The change itself is ok, but:
- commit message is missing (did you run checkpatch?)
- Why should the current mutex_init() call be too late?
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-12-23 15:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-23 14:11 [PATCH -next] intel/iwlwifi: use DEFINE_MUTEX (and mutex_init() had been too late) Zheng Yongjun
2020-12-23 15:02 ` Heiner Kallweit
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.