* [PATCH] drm/komeda: Clean warnings: candidate for 'gnu_printf’ format attribute
@ 2019-11-14 10:04 ` james qian wang (Arm Technology China)
0 siblings, 0 replies; 12+ messages in thread
From: james qian wang (Arm Technology China) @ 2019-11-14 10:04 UTC (permalink / raw)
To: Liviu Dudau, Mihail Atanassov
Cc: Lowry Li (Arm Technology China),
nd, linux-kernel, dri-devel,
james qian wang (Arm Technology China)
komeda/komeda_event.c: In function ‘komeda_sprintf’:
komeda/komeda_event.c:31:2: warning: function ‘komeda_sprintf’ might be a candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format]
num = vsnprintf(str->str + str->len, free_sz, fmt, args);
v2: Update the comment msg.
Signed-off-by: james qian wang (Arm Technology China) <james.qian.wang@arm.com>
---
drivers/gpu/drm/arm/display/komeda/komeda_event.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_event.c b/drivers/gpu/drm/arm/display/komeda/komeda_event.c
index bf269683f811..977c38d516da 100644
--- a/drivers/gpu/drm/arm/display/komeda/komeda_event.c
+++ b/drivers/gpu/drm/arm/display/komeda/komeda_event.c
@@ -17,6 +17,7 @@ struct komeda_str {
/* return 0 on success, < 0 on no space.
*/
+__printf(2, 3)
static int komeda_sprintf(struct komeda_str *str, const char *fmt, ...)
{
va_list args;
--
2.20.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH] drm/komeda: Clean warnings: candidate for 'gnu_printf’ format attribute
@ 2019-11-14 10:04 ` james qian wang (Arm Technology China)
0 siblings, 0 replies; 12+ messages in thread
From: james qian wang (Arm Technology China) @ 2019-11-14 10:04 UTC (permalink / raw)
To: Liviu Dudau, Mihail Atanassov
Cc: nd, Lowry Li (Arm Technology China),
james qian wang (Arm Technology China),
linux-kernel, dri-devel
komeda/komeda_event.c: In function ‘komeda_sprintf’:
komeda/komeda_event.c:31:2: warning: function ‘komeda_sprintf’ might be a candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format]
num = vsnprintf(str->str + str->len, free_sz, fmt, args);
v2: Update the comment msg.
Signed-off-by: james qian wang (Arm Technology China) <james.qian.wang@arm.com>
---
drivers/gpu/drm/arm/display/komeda/komeda_event.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_event.c b/drivers/gpu/drm/arm/display/komeda/komeda_event.c
index bf269683f811..977c38d516da 100644
--- a/drivers/gpu/drm/arm/display/komeda/komeda_event.c
+++ b/drivers/gpu/drm/arm/display/komeda/komeda_event.c
@@ -17,6 +17,7 @@ struct komeda_str {
/* return 0 on success, < 0 on no space.
*/
+__printf(2, 3)
static int komeda_sprintf(struct komeda_str *str, const char *fmt, ...)
{
va_list args;
--
2.20.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH] drm/komeda: Clean warnings: candidate for 'gnu_printf’ format attribute
2019-11-14 10:04 ` james qian wang (Arm Technology China)
(?)
@ 2019-11-15 0:01 ` Mihail Atanassov
-1 siblings, 0 replies; 12+ messages in thread
From: Mihail Atanassov @ 2019-11-15 0:01 UTC (permalink / raw)
To: james qian wang (Arm Technology China)
Cc: nd, Liviu Dudau, Lowry Li (Arm Technology China),
nd, linux-kernel, dri-devel
On Thursday, 14 November 2019 10:04:37 GMT james qian wang (Arm Technology China) wrote:
> komeda/komeda_event.c: In function ‘komeda_sprintf’:
> komeda/komeda_event.c:31:2: warning: function ‘komeda_sprintf’ might be a candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format]
> num = vsnprintf(str->str + str->len, free_sz, fmt, args);
>
> v2: Update the comment msg.
>
> Signed-off-by: james qian wang (Arm Technology China) <james.qian.wang@arm.com>
> ---
> drivers/gpu/drm/arm/display/komeda/komeda_event.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_event.c b/drivers/gpu/drm/arm/display/komeda/komeda_event.c
> index bf269683f811..977c38d516da 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_event.c
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_event.c
> @@ -17,6 +17,7 @@ struct komeda_str {
>
> /* return 0 on success, < 0 on no space.
> */
> +__printf(2, 3)
> static int komeda_sprintf(struct komeda_str *str, const char *fmt, ...)
> {
> va_list args;
> --
> 2.20.1
>
>
Reviewed-by: Mihail Atanassov <mihail.atanassov@arm.com>
--
Mihail
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] drm/komeda: Clean warnings: candidate for 'gnu_printf’ format attribute
@ 2019-11-15 0:01 ` Mihail Atanassov
0 siblings, 0 replies; 12+ messages in thread
From: Mihail Atanassov @ 2019-11-15 0:01 UTC (permalink / raw)
To: james qian wang (Arm Technology China)
Cc: Lowry Li (Arm Technology China),
nd, Liviu Dudau, linux-kernel, dri-devel
On Thursday, 14 November 2019 10:04:37 GMT james qian wang (Arm Technology China) wrote:
> komeda/komeda_event.c: In function ‘komeda_sprintf’:
> komeda/komeda_event.c:31:2: warning: function ‘komeda_sprintf’ might be a candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format]
> num = vsnprintf(str->str + str->len, free_sz, fmt, args);
>
> v2: Update the comment msg.
>
> Signed-off-by: james qian wang (Arm Technology China) <james.qian.wang@arm.com>
> ---
> drivers/gpu/drm/arm/display/komeda/komeda_event.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_event.c b/drivers/gpu/drm/arm/display/komeda/komeda_event.c
> index bf269683f811..977c38d516da 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_event.c
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_event.c
> @@ -17,6 +17,7 @@ struct komeda_str {
>
> /* return 0 on success, < 0 on no space.
> */
> +__printf(2, 3)
> static int komeda_sprintf(struct komeda_str *str, const char *fmt, ...)
> {
> va_list args;
> --
> 2.20.1
>
>
Reviewed-by: Mihail Atanassov <mihail.atanassov@arm.com>
--
Mihail
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] drm/komeda: Clean warnings: candidate for 'gnu_printf’ format attribute
@ 2019-11-15 0:01 ` Mihail Atanassov
0 siblings, 0 replies; 12+ messages in thread
From: Mihail Atanassov @ 2019-11-15 0:01 UTC (permalink / raw)
To: james qian wang (Arm Technology China)
Cc: Lowry Li (Arm Technology China),
nd, Liviu Dudau, linux-kernel, dri-devel
On Thursday, 14 November 2019 10:04:37 GMT james qian wang (Arm Technology China) wrote:
> komeda/komeda_event.c: In function ‘komeda_sprintf’:
> komeda/komeda_event.c:31:2: warning: function ‘komeda_sprintf’ might be a candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format]
> num = vsnprintf(str->str + str->len, free_sz, fmt, args);
>
> v2: Update the comment msg.
>
> Signed-off-by: james qian wang (Arm Technology China) <james.qian.wang@arm.com>
> ---
> drivers/gpu/drm/arm/display/komeda/komeda_event.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_event.c b/drivers/gpu/drm/arm/display/komeda/komeda_event.c
> index bf269683f811..977c38d516da 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_event.c
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_event.c
> @@ -17,6 +17,7 @@ struct komeda_str {
>
> /* return 0 on success, < 0 on no space.
> */
> +__printf(2, 3)
> static int komeda_sprintf(struct komeda_str *str, const char *fmt, ...)
> {
> va_list args;
> --
> 2.20.1
>
>
Reviewed-by: Mihail Atanassov <mihail.atanassov@arm.com>
--
Mihail
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] drm/komeda: Clean warnings: candidate for 'gnu_printf’ format attribute
2019-11-14 8:47 ` Mihail Atanassov
@ 2019-11-14 8:58 ` james qian wang (Arm Technology China)
-1 siblings, 0 replies; 12+ messages in thread
From: james qian wang (Arm Technology China) @ 2019-11-14 8:58 UTC (permalink / raw)
To: Mihail Atanassov; +Cc: nd, Liviu Dudau, lowryli, linux-kernel, dri-devel
On Thu, Nov 14, 2019 at 08:47:58AM +0000, Mihail Atanassov wrote:
> Hi James,
>
> On Thursday, 14 November 2019 07:18:56 GMT james qian wang (Arm Technology China) wrote:
> > komeda/komeda_pipeline.c: In function ‘komeda_component_add’:
> > komeda/komeda_pipeline.c:213:3: warning: function ‘komeda_component_add’ might be a candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format]
> > vsnprintf(c->name, sizeof(c->name), name_fmt, args);
> > ^~~~~~~~~
>
> The fix for this one isn't in the patch below.
Because the upstream code already have it, But I forgot to update the
comment msg, will send v2 to fix it.
Thanks
James
> >
> > komeda/komeda_event.c: In function ‘komeda_sprintf’:
> > komeda/komeda_event.c:31:2: warning: function ‘komeda_sprintf’ might be a candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format]
> > num = vsnprintf(str->str + str->len, free_sz, fmt, args);
> >
> > Signed-off-by: james qian wang (Arm Technology China) <james.qian.wang@arm.com>
> > ---
> > drivers/gpu/drm/arm/display/komeda/komeda_event.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_event.c b/drivers/gpu/drm/arm/display/komeda/komeda_event.c
> > index bf269683f811..977c38d516da 100644
> > --- a/drivers/gpu/drm/arm/display/komeda/komeda_event.c
> > +++ b/drivers/gpu/drm/arm/display/komeda/komeda_event.c
> > @@ -17,6 +17,7 @@ struct komeda_str {
> >
> > /* return 0 on success, < 0 on no space.
> > */
> > +__printf(2, 3)
> > static int komeda_sprintf(struct komeda_str *str, const char *fmt, ...)
> > {
> > va_list args;
> > --
> > 2.20.1
> >
> >
>
>
> --
> Mihail
>
>
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] drm/komeda: Clean warnings: candidate for 'gnu_printf’ format attribute
@ 2019-11-14 8:58 ` james qian wang (Arm Technology China)
0 siblings, 0 replies; 12+ messages in thread
From: james qian wang (Arm Technology China) @ 2019-11-14 8:58 UTC (permalink / raw)
To: Mihail Atanassov; +Cc: lowryli, nd, Liviu Dudau, linux-kernel, dri-devel
On Thu, Nov 14, 2019 at 08:47:58AM +0000, Mihail Atanassov wrote:
> Hi James,
>
> On Thursday, 14 November 2019 07:18:56 GMT james qian wang (Arm Technology China) wrote:
> > komeda/komeda_pipeline.c: In function ‘komeda_component_add’:
> > komeda/komeda_pipeline.c:213:3: warning: function ‘komeda_component_add’ might be a candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format]
> > vsnprintf(c->name, sizeof(c->name), name_fmt, args);
> > ^~~~~~~~~
>
> The fix for this one isn't in the patch below.
Because the upstream code already have it, But I forgot to update the
comment msg, will send v2 to fix it.
Thanks
James
> >
> > komeda/komeda_event.c: In function ‘komeda_sprintf’:
> > komeda/komeda_event.c:31:2: warning: function ‘komeda_sprintf’ might be a candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format]
> > num = vsnprintf(str->str + str->len, free_sz, fmt, args);
> >
> > Signed-off-by: james qian wang (Arm Technology China) <james.qian.wang@arm.com>
> > ---
> > drivers/gpu/drm/arm/display/komeda/komeda_event.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_event.c b/drivers/gpu/drm/arm/display/komeda/komeda_event.c
> > index bf269683f811..977c38d516da 100644
> > --- a/drivers/gpu/drm/arm/display/komeda/komeda_event.c
> > +++ b/drivers/gpu/drm/arm/display/komeda/komeda_event.c
> > @@ -17,6 +17,7 @@ struct komeda_str {
> >
> > /* return 0 on success, < 0 on no space.
> > */
> > +__printf(2, 3)
> > static int komeda_sprintf(struct komeda_str *str, const char *fmt, ...)
> > {
> > va_list args;
> > --
> > 2.20.1
> >
> >
>
>
> --
> Mihail
>
>
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] drm/komeda: Clean warnings: candidate for 'gnu_printf’ format attribute
2019-11-14 7:18 ` james qian wang (Arm Technology China)
@ 2019-11-14 8:47 ` Mihail Atanassov
-1 siblings, 0 replies; 12+ messages in thread
From: Mihail Atanassov @ 2019-11-14 8:47 UTC (permalink / raw)
To: james qian wang (Arm Technology China)
Cc: nd, Liviu Dudau, lowryli, nd, linux-kernel, dri-devel
Hi James,
On Thursday, 14 November 2019 07:18:56 GMT james qian wang (Arm Technology China) wrote:
> komeda/komeda_pipeline.c: In function ‘komeda_component_add’:
> komeda/komeda_pipeline.c:213:3: warning: function ‘komeda_component_add’ might be a candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format]
> vsnprintf(c->name, sizeof(c->name), name_fmt, args);
> ^~~~~~~~~
The fix for this one isn't in the patch below.
>
> komeda/komeda_event.c: In function ‘komeda_sprintf’:
> komeda/komeda_event.c:31:2: warning: function ‘komeda_sprintf’ might be a candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format]
> num = vsnprintf(str->str + str->len, free_sz, fmt, args);
>
> Signed-off-by: james qian wang (Arm Technology China) <james.qian.wang@arm.com>
> ---
> drivers/gpu/drm/arm/display/komeda/komeda_event.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_event.c b/drivers/gpu/drm/arm/display/komeda/komeda_event.c
> index bf269683f811..977c38d516da 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_event.c
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_event.c
> @@ -17,6 +17,7 @@ struct komeda_str {
>
> /* return 0 on success, < 0 on no space.
> */
> +__printf(2, 3)
> static int komeda_sprintf(struct komeda_str *str, const char *fmt, ...)
> {
> va_list args;
> --
> 2.20.1
>
>
--
Mihail
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] drm/komeda: Clean warnings: candidate for 'gnu_printf’ format attribute
@ 2019-11-14 8:47 ` Mihail Atanassov
0 siblings, 0 replies; 12+ messages in thread
From: Mihail Atanassov @ 2019-11-14 8:47 UTC (permalink / raw)
To: james qian wang (Arm Technology China)
Cc: lowryli, nd, Liviu Dudau, linux-kernel, dri-devel
Hi James,
On Thursday, 14 November 2019 07:18:56 GMT james qian wang (Arm Technology China) wrote:
> komeda/komeda_pipeline.c: In function ‘komeda_component_add’:
> komeda/komeda_pipeline.c:213:3: warning: function ‘komeda_component_add’ might be a candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format]
> vsnprintf(c->name, sizeof(c->name), name_fmt, args);
> ^~~~~~~~~
The fix for this one isn't in the patch below.
>
> komeda/komeda_event.c: In function ‘komeda_sprintf’:
> komeda/komeda_event.c:31:2: warning: function ‘komeda_sprintf’ might be a candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format]
> num = vsnprintf(str->str + str->len, free_sz, fmt, args);
>
> Signed-off-by: james qian wang (Arm Technology China) <james.qian.wang@arm.com>
> ---
> drivers/gpu/drm/arm/display/komeda/komeda_event.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_event.c b/drivers/gpu/drm/arm/display/komeda/komeda_event.c
> index bf269683f811..977c38d516da 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_event.c
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_event.c
> @@ -17,6 +17,7 @@ struct komeda_str {
>
> /* return 0 on success, < 0 on no space.
> */
> +__printf(2, 3)
> static int komeda_sprintf(struct komeda_str *str, const char *fmt, ...)
> {
> va_list args;
> --
> 2.20.1
>
>
--
Mihail
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH] drm/komeda: Clean warnings: candidate for 'gnu_printf’ format attribute
@ 2019-11-14 7:18 ` james qian wang (Arm Technology China)
0 siblings, 0 replies; 12+ messages in thread
From: james qian wang (Arm Technology China) @ 2019-11-14 7:18 UTC (permalink / raw)
To: Liviu Dudau, Mihail Atanassov
Cc: lowryli, nd, linux-kernel, dri-devel,
james qian wang (Arm Technology China)
komeda/komeda_pipeline.c: In function ‘komeda_component_add’:
komeda/komeda_pipeline.c:213:3: warning: function ‘komeda_component_add’ might be a candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format]
vsnprintf(c->name, sizeof(c->name), name_fmt, args);
^~~~~~~~~
komeda/komeda_event.c: In function ‘komeda_sprintf’:
komeda/komeda_event.c:31:2: warning: function ‘komeda_sprintf’ might be a candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format]
num = vsnprintf(str->str + str->len, free_sz, fmt, args);
Signed-off-by: james qian wang (Arm Technology China) <james.qian.wang@arm.com>
---
drivers/gpu/drm/arm/display/komeda/komeda_event.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_event.c b/drivers/gpu/drm/arm/display/komeda/komeda_event.c
index bf269683f811..977c38d516da 100644
--- a/drivers/gpu/drm/arm/display/komeda/komeda_event.c
+++ b/drivers/gpu/drm/arm/display/komeda/komeda_event.c
@@ -17,6 +17,7 @@ struct komeda_str {
/* return 0 on success, < 0 on no space.
*/
+__printf(2, 3)
static int komeda_sprintf(struct komeda_str *str, const char *fmt, ...)
{
va_list args;
--
2.20.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH] drm/komeda: Clean warnings: candidate for 'gnu_printf’ format attribute
@ 2019-11-14 7:18 ` james qian wang (Arm Technology China)
0 siblings, 0 replies; 12+ messages in thread
From: james qian wang (Arm Technology China) @ 2019-11-14 7:18 UTC (permalink / raw)
To: Liviu Dudau, Mihail Atanassov
Cc: lowryli, nd, james qian wang (Arm Technology China),
linux-kernel, dri-devel
komeda/komeda_pipeline.c: In function ‘komeda_component_add’:
komeda/komeda_pipeline.c:213:3: warning: function ‘komeda_component_add’ might be a candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format]
vsnprintf(c->name, sizeof(c->name), name_fmt, args);
^~~~~~~~~
komeda/komeda_event.c: In function ‘komeda_sprintf’:
komeda/komeda_event.c:31:2: warning: function ‘komeda_sprintf’ might be a candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format]
num = vsnprintf(str->str + str->len, free_sz, fmt, args);
Signed-off-by: james qian wang (Arm Technology China) <james.qian.wang@arm.com>
---
drivers/gpu/drm/arm/display/komeda/komeda_event.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_event.c b/drivers/gpu/drm/arm/display/komeda/komeda_event.c
index bf269683f811..977c38d516da 100644
--- a/drivers/gpu/drm/arm/display/komeda/komeda_event.c
+++ b/drivers/gpu/drm/arm/display/komeda/komeda_event.c
@@ -17,6 +17,7 @@ struct komeda_str {
/* return 0 on success, < 0 on no space.
*/
+__printf(2, 3)
static int komeda_sprintf(struct komeda_str *str, const char *fmt, ...)
{
va_list args;
--
2.20.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH] drm/komeda: Clean warnings: candidate for 'gnu_printf’ format attribute
@ 2019-11-14 7:18 ` james qian wang (Arm Technology China)
0 siblings, 0 replies; 12+ messages in thread
From: james qian wang (Arm Technology China) @ 2019-11-14 7:18 UTC (permalink / raw)
To: Liviu Dudau, Mihail Atanassov
Cc: lowryli, nd, james qian wang (Arm Technology China),
linux-kernel, dri-devel
komeda/komeda_pipeline.c: In function ‘komeda_component_add’:
komeda/komeda_pipeline.c:213:3: warning: function ‘komeda_component_add’ might be a candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format]
vsnprintf(c->name, sizeof(c->name), name_fmt, args);
^~~~~~~~~
komeda/komeda_event.c: In function ‘komeda_sprintf’:
komeda/komeda_event.c:31:2: warning: function ‘komeda_sprintf’ might be a candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format]
num = vsnprintf(str->str + str->len, free_sz, fmt, args);
Signed-off-by: james qian wang (Arm Technology China) <james.qian.wang@arm.com>
---
drivers/gpu/drm/arm/display/komeda/komeda_event.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_event.c b/drivers/gpu/drm/arm/display/komeda/komeda_event.c
index bf269683f811..977c38d516da 100644
--- a/drivers/gpu/drm/arm/display/komeda/komeda_event.c
+++ b/drivers/gpu/drm/arm/display/komeda/komeda_event.c
@@ -17,6 +17,7 @@ struct komeda_str {
/* return 0 on success, < 0 on no space.
*/
+__printf(2, 3)
static int komeda_sprintf(struct komeda_str *str, const char *fmt, ...)
{
va_list args;
--
2.20.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 12+ messages in thread
end of thread, other threads:[~2019-11-15 0:01 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-14 10:04 [PATCH] drm/komeda: Clean warnings: candidate for 'gnu_printf’ format attribute james qian wang (Arm Technology China)
2019-11-14 10:04 ` james qian wang (Arm Technology China)
2019-11-15 0:01 ` Mihail Atanassov
2019-11-15 0:01 ` Mihail Atanassov
2019-11-15 0:01 ` Mihail Atanassov
-- strict thread matches above, loose matches on Subject: below --
2019-11-14 7:18 james qian wang (Arm Technology China)
2019-11-14 7:18 ` james qian wang (Arm Technology China)
2019-11-14 7:18 ` james qian wang (Arm Technology China)
2019-11-14 8:47 ` Mihail Atanassov
2019-11-14 8:47 ` Mihail Atanassov
2019-11-14 8:58 ` james qian wang (Arm Technology China)
2019-11-14 8:58 ` james qian wang (Arm Technology China)
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.