From: "Wang, Yalin" <Yalin.Wang@sonymobile.com> To: "'Minchan Kim'" <minchan@kernel.org>, Andrew Morton <akpm@linux-foundation.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-mm@kvack.org" <linux-mm@kvack.org>, Michal Hocko <mhocko@suse.cz>, Johannes Weiner <hannes@cmpxchg.org>, Mel Gorman <mgorman@suse.de>, Rik van Riel <riel@redhat.com>, Shaohua Li <shli@kernel.org> Subject: [RFC] mm:do recheck for freeable page in reclaim path Date: Wed, 11 Mar 2015 17:47:28 +0800 [thread overview] Message-ID: <35FD53F367049845BC99AC72306C23D10458D6173C0C@CNBJMBX05.corpusers.net> (raw) In-Reply-To: <1426036838-18154-3-git-send-email-minchan@kernel.org> In reclaim path, if encounter a freeable page, the try_to_unmap may fail, because the page's pte is dirty, we can recheck this page as normal non-freeable page, this means we can swap out this page into swap partition. Signed-off-by: Yalin Wang <yalin.wang@sonymobile.com> --- mm/vmscan.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/mm/vmscan.c b/mm/vmscan.c index 260c413..9930850 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -1000,6 +1000,7 @@ static unsigned long shrink_page_list(struct list_head *page_list, } } +recheck: if (!force_reclaim) references = page_check_references(page, sc, &freeable); @@ -1045,6 +1046,10 @@ unmap: switch (try_to_unmap(page, freeable ? TTU_FREE : ttu_flags)) { case SWAP_FAIL: + if (freeable) { + freeable = false; + goto recheck; + } goto activate_locked; case SWAP_AGAIN: goto keep_locked; -- 2.2.2
WARNING: multiple messages have this Message-ID (diff)
From: "Wang, Yalin" <Yalin.Wang@sonymobile.com> To: 'Minchan Kim' <minchan@kernel.org>, Andrew Morton <akpm@linux-foundation.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-mm@kvack.org" <linux-mm@kvack.org>, Michal Hocko <mhocko@suse.cz>, Johannes Weiner <hannes@cmpxchg.org>, Mel Gorman <mgorman@suse.de>, Rik van Riel <riel@redhat.com>, Shaohua Li <shli@kernel.org> Subject: [RFC] mm:do recheck for freeable page in reclaim path Date: Wed, 11 Mar 2015 17:47:28 +0800 [thread overview] Message-ID: <35FD53F367049845BC99AC72306C23D10458D6173C0C@CNBJMBX05.corpusers.net> (raw) In-Reply-To: <1426036838-18154-3-git-send-email-minchan@kernel.org> In reclaim path, if encounter a freeable page, the try_to_unmap may fail, because the page's pte is dirty, we can recheck this page as normal non-freeable page, this means we can swap out this page into swap partition. Signed-off-by: Yalin Wang <yalin.wang@sonymobile.com> --- mm/vmscan.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/mm/vmscan.c b/mm/vmscan.c index 260c413..9930850 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -1000,6 +1000,7 @@ static unsigned long shrink_page_list(struct list_head *page_list, } } +recheck: if (!force_reclaim) references = page_check_references(page, sc, &freeable); @@ -1045,6 +1046,10 @@ unmap: switch (try_to_unmap(page, freeable ? TTU_FREE : ttu_flags)) { case SWAP_FAIL: + if (freeable) { + freeable = false; + goto recheck; + } goto activate_locked; case SWAP_AGAIN: goto keep_locked; -- 2.2.2 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-03-11 9:47 UTC|newest] Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-03-11 1:20 [PATCH 1/4] mm: free swp_entry in madvise_free Minchan Kim 2015-03-11 1:20 ` Minchan Kim 2015-03-11 1:20 ` [PATCH 2/4] mm: change deactivate_page with deactivate_file_page Minchan Kim 2015-03-11 1:20 ` Minchan Kim 2015-03-11 1:20 ` [PATCH 3/4] mm: move lazy free pages to inactive list Minchan Kim 2015-03-11 1:20 ` Minchan Kim 2015-03-11 2:14 ` Wang, Yalin 2015-03-11 2:14 ` Wang, Yalin 2015-03-11 4:30 ` Minchan Kim 2015-03-11 4:30 ` Minchan Kim 2015-04-01 20:38 ` Rik van Riel 2015-04-01 20:38 ` Rik van Riel 2015-03-11 9:05 ` [RFC ] mm: don't ignore file map pages for madvise_free( ) Wang, Yalin 2015-03-11 9:05 ` Wang, Yalin 2015-03-11 9:47 ` Wang, Yalin [this message] 2015-03-11 9:47 ` [RFC] mm:do recheck for freeable page in reclaim path Wang, Yalin 2015-03-20 22:43 ` [PATCH 3/4] mm: move lazy free pages to inactive list Andrew Morton 2015-03-20 22:43 ` Andrew Morton 2015-03-30 5:35 ` Minchan Kim 2015-03-30 5:35 ` Minchan Kim 2015-03-30 21:20 ` Andrew Morton 2015-03-30 21:20 ` Andrew Morton 2015-03-31 4:45 ` Minchan Kim 2015-03-31 4:45 ` Minchan Kim 2015-03-31 5:28 ` Andrew Morton 2015-03-31 5:28 ` Andrew Morton 2015-03-31 5:57 ` Minchan Kim 2015-03-31 5:57 ` Minchan Kim 2015-03-11 1:20 ` [PATCH 4/4] mm: make every pte dirty on do_swap_page Minchan Kim 2015-03-11 1:20 ` Minchan Kim 2015-03-30 5:22 ` Minchan Kim 2015-03-30 5:22 ` Minchan Kim 2015-03-30 8:51 ` Cyrill Gorcunov 2015-03-30 8:51 ` Cyrill Gorcunov 2015-03-30 8:59 ` Minchan Kim 2015-03-30 8:59 ` Minchan Kim 2015-03-30 21:14 ` Cyrill Gorcunov 2015-03-30 21:14 ` Cyrill Gorcunov 2015-03-31 4:38 ` Minchan Kim 2015-03-31 4:38 ` Minchan Kim 2015-04-08 23:50 ` Minchan Kim 2015-04-08 23:50 ` Minchan Kim 2015-04-09 20:59 ` Andrew Morton 2015-04-09 20:59 ` Andrew Morton 2015-04-10 0:08 ` Minchan Kim 2015-04-10 0:08 ` Minchan Kim 2015-04-10 0:14 ` Rik van Riel 2015-04-10 0:14 ` Rik van Riel 2015-04-11 21:40 ` Hugh Dickins 2015-04-11 21:40 ` Hugh Dickins 2015-04-12 14:48 ` Minchan Kim 2015-04-12 14:48 ` Minchan Kim 2015-04-15 6:49 ` Minchan Kim 2015-04-15 6:49 ` Minchan Kim 2015-03-19 0:46 ` [PATCH 1/4] mm: free swp_entry in madvise_free Minchan Kim 2015-03-19 0:46 ` Minchan Kim 2015-03-19 0:42 [RFC] mm:do recheck for freeable page in reclaim path Minchan Kim 2015-03-19 0:42 ` Minchan Kim
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=35FD53F367049845BC99AC72306C23D10458D6173C0C@CNBJMBX05.corpusers.net \ --to=yalin.wang@sonymobile.com \ --cc=akpm@linux-foundation.org \ --cc=hannes@cmpxchg.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=mgorman@suse.de \ --cc=mhocko@suse.cz \ --cc=minchan@kernel.org \ --cc=riel@redhat.com \ --cc=shli@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.