From: "Andrew Jeffery" <andrew@aj.id.au> To: "Rob Herring" <robh+dt@kernel.org> Cc: linux-mmc <linux-mmc@vger.kernel.org>, "Ulf Hansson" <ulf.hansson@linaro.org>, "Mark Rutland" <mark.rutland@arm.com>, "Joel Stanley" <joel@jms.id.au>, "Adrian Hunter" <adrian.hunter@intel.com>, devicetree@vger.kernel.org, "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" <linux-arm-kernel@lists.infradead.org>, linux-aspeed@lists.ozlabs.org, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "Ryan Chen" <ryanchen.aspeed@gmail.com> Subject: Re: [PATCH v3 1/2] dt-bindings: mmc: Document Aspeed SD controller Date: Mon, 05 Aug 2019 11:40:17 +0930 [thread overview] Message-ID: <35aaa5a4-1e0d-4f64-8985-36e2c01ccc05@www.fastmail.com> (raw) In-Reply-To: <CAL_Jsq+oZRREV=VjYUxT3WphOa5tBaF1pvS_JKSphBY=3XB5MA@mail.gmail.com> On Fri, 2 Aug 2019, at 08:29, Rob Herring wrote: > On Tue, Jul 30, 2019 at 12:23 AM Andrew Jeffery <andrew@aj.id.au> wrote: > > > > The ASPEED SD/SDIO/eMMC controller exposes two slots implementing the > > SDIO Host Specification v2.00, with 1 or 4 bit data buses, or an 8 bit > > data bus if only a single slot is enabled. > > > > Signed-off-by: Andrew Jeffery <andrew@aj.id.au> > > > > --- > > v3: > > * Fix compatible enums > > * Add AST2600 compatibles > > * Describe #address-cells / #size-cells > > --- > > .../devicetree/bindings/mmc/aspeed,sdhci.yaml | 100 ++++++++++++++++++ > > 1 file changed, 100 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml > > > > diff --git a/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml b/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml > > new file mode 100644 > > index 000000000000..dd2a00c59641 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml > > @@ -0,0 +1,100 @@ > > +# SPDX-License-Identifier: GPL-2.0-or-later > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/mmc/aspeed,sdhci.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: ASPEED SD/SDIO/eMMC Controller > > + > > +maintainers: > > + - Andrew Jeffery <andrew@aj.id.au> > > + - Ryan Chen <ryanchen.aspeed@gmail.com> > > + > > +description: |+ > > + The ASPEED SD/SDIO/eMMC controller exposes two slots implementing the SDIO > > + Host Specification v2.00, with 1 or 4 bit data buses, or an 8 bit data bus if > > + only a single slot is enabled. > > + > > + The two slots are supported by a common configuration area. As the SDHCIs for > > + the slots are dependent on the common configuration area, they are described > > + as child nodes. > > + > > +properties: > > + compatible: > > + enum: > > + - aspeed,ast2400-sd-controller > > + - aspeed,ast2500-sd-controller > > + - aspeed,ast2600-sd-controller > > + reg: > > + maxItems: 1 > > + description: Common configuration registers > > + "#address-cells": > > + const: 1 > > + "#size-cells": > > + const: 1 > > + ranges: true > > + clocks: > > + maxItems: 1 > > + description: The SD/SDIO controller clock gate > > + > > +patternProperties: > > + "^sdhci@[0-9a-f]+$": > > This should probably have: > > allOf: > - $ref: mmc-controller.yaml > > Another new thing in 5.3. :) Ack. > > > + type: object > > + properties: > > + compatible: > > + enum: > > + - aspeed,ast2400-sdhci > > + - aspeed,ast2500-sdhci > > + - aspeed,ast2600-sdhci > > + reg: > > + maxItems: 1 > > + description: The SDHCI registers > > + clocks: > > + maxItems: 1 > > + description: The SD bus clock > > + interrupts: > > + maxItems: 1 > > + description: The SD interrupt shared between both slots > > + required: > > + - compatible > > + - reg > > + - clocks > > + - interrupts > > + > > +additionalProperties: false > > + > > +required: > > + - compatible > > + - reg > > + - "#address-cells" > > + - "#size-cells" > > + - ranges > > + - clocks > > + > > +examples: > > + - | > > + #include <dt-bindings/clock/aspeed-clock.h> > > + sdc@1e740000 { > > + compatible = "aspeed,ast2500-sd-controller"; > > + reg = <0x1e740000 0x100>; > > + #address-cells = <1>; > > + #size-cells = <1>; > > + ranges = <0 0x1e740000 0x10000>; > > + clocks = <&syscon ASPEED_CLK_GATE_SDCLK>; > > + > > + sdhci0: sdhci@100 { > > + compatible = "aspeed,ast2500-sdhci"; > > + reg = <0x100 0x100>; > > + interrupts = <26>; > > + sdhci,auto-cmd12; > > Not documented. Maybe should be common, but there's only a few users. I'll document it locally for the moment. Cheers, Andrew
WARNING: multiple messages have this Message-ID (diff)
From: "Andrew Jeffery" <andrew@aj.id.au> To: "Rob Herring" <robh+dt@kernel.org> Cc: Mark Rutland <mark.rutland@arm.com>, devicetree@vger.kernel.org, Ulf Hansson <ulf.hansson@linaro.org>, linux-aspeed@lists.ozlabs.org, Ryan Chen <ryanchen.aspeed@gmail.com>, linux-mmc <linux-mmc@vger.kernel.org>, Adrian Hunter <adrian.hunter@intel.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Joel Stanley <joel@jms.id.au>, "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH v3 1/2] dt-bindings: mmc: Document Aspeed SD controller Date: Mon, 05 Aug 2019 11:40:17 +0930 [thread overview] Message-ID: <35aaa5a4-1e0d-4f64-8985-36e2c01ccc05@www.fastmail.com> (raw) In-Reply-To: <CAL_Jsq+oZRREV=VjYUxT3WphOa5tBaF1pvS_JKSphBY=3XB5MA@mail.gmail.com> On Fri, 2 Aug 2019, at 08:29, Rob Herring wrote: > On Tue, Jul 30, 2019 at 12:23 AM Andrew Jeffery <andrew@aj.id.au> wrote: > > > > The ASPEED SD/SDIO/eMMC controller exposes two slots implementing the > > SDIO Host Specification v2.00, with 1 or 4 bit data buses, or an 8 bit > > data bus if only a single slot is enabled. > > > > Signed-off-by: Andrew Jeffery <andrew@aj.id.au> > > > > --- > > v3: > > * Fix compatible enums > > * Add AST2600 compatibles > > * Describe #address-cells / #size-cells > > --- > > .../devicetree/bindings/mmc/aspeed,sdhci.yaml | 100 ++++++++++++++++++ > > 1 file changed, 100 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml > > > > diff --git a/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml b/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml > > new file mode 100644 > > index 000000000000..dd2a00c59641 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml > > @@ -0,0 +1,100 @@ > > +# SPDX-License-Identifier: GPL-2.0-or-later > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/mmc/aspeed,sdhci.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: ASPEED SD/SDIO/eMMC Controller > > + > > +maintainers: > > + - Andrew Jeffery <andrew@aj.id.au> > > + - Ryan Chen <ryanchen.aspeed@gmail.com> > > + > > +description: |+ > > + The ASPEED SD/SDIO/eMMC controller exposes two slots implementing the SDIO > > + Host Specification v2.00, with 1 or 4 bit data buses, or an 8 bit data bus if > > + only a single slot is enabled. > > + > > + The two slots are supported by a common configuration area. As the SDHCIs for > > + the slots are dependent on the common configuration area, they are described > > + as child nodes. > > + > > +properties: > > + compatible: > > + enum: > > + - aspeed,ast2400-sd-controller > > + - aspeed,ast2500-sd-controller > > + - aspeed,ast2600-sd-controller > > + reg: > > + maxItems: 1 > > + description: Common configuration registers > > + "#address-cells": > > + const: 1 > > + "#size-cells": > > + const: 1 > > + ranges: true > > + clocks: > > + maxItems: 1 > > + description: The SD/SDIO controller clock gate > > + > > +patternProperties: > > + "^sdhci@[0-9a-f]+$": > > This should probably have: > > allOf: > - $ref: mmc-controller.yaml > > Another new thing in 5.3. :) Ack. > > > + type: object > > + properties: > > + compatible: > > + enum: > > + - aspeed,ast2400-sdhci > > + - aspeed,ast2500-sdhci > > + - aspeed,ast2600-sdhci > > + reg: > > + maxItems: 1 > > + description: The SDHCI registers > > + clocks: > > + maxItems: 1 > > + description: The SD bus clock > > + interrupts: > > + maxItems: 1 > > + description: The SD interrupt shared between both slots > > + required: > > + - compatible > > + - reg > > + - clocks > > + - interrupts > > + > > +additionalProperties: false > > + > > +required: > > + - compatible > > + - reg > > + - "#address-cells" > > + - "#size-cells" > > + - ranges > > + - clocks > > + > > +examples: > > + - | > > + #include <dt-bindings/clock/aspeed-clock.h> > > + sdc@1e740000 { > > + compatible = "aspeed,ast2500-sd-controller"; > > + reg = <0x1e740000 0x100>; > > + #address-cells = <1>; > > + #size-cells = <1>; > > + ranges = <0 0x1e740000 0x10000>; > > + clocks = <&syscon ASPEED_CLK_GATE_SDCLK>; > > + > > + sdhci0: sdhci@100 { > > + compatible = "aspeed,ast2500-sdhci"; > > + reg = <0x100 0x100>; > > + interrupts = <26>; > > + sdhci,auto-cmd12; > > Not documented. Maybe should be common, but there's only a few users. I'll document it locally for the moment. Cheers, Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-08-05 2:09 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-07-30 6:23 [PATCH v3 0/2] mmc: Add support for the ASPEED SD controller Andrew Jeffery 2019-07-30 6:23 ` Andrew Jeffery 2019-07-30 6:23 ` [PATCH v3 1/2] dt-bindings: mmc: Document Aspeed " Andrew Jeffery 2019-07-30 6:23 ` Andrew Jeffery 2019-08-01 22:59 ` Rob Herring 2019-08-01 22:59 ` Rob Herring 2019-08-01 22:59 ` Rob Herring 2019-08-05 2:10 ` Andrew Jeffery [this message] 2019-08-05 2:10 ` Andrew Jeffery 2019-08-05 2:10 ` Andrew Jeffery 2019-07-30 6:23 ` [PATCH v3 2/2] mmc: Add support for the ASPEED " Andrew Jeffery 2019-07-30 6:23 ` Andrew Jeffery
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=35aaa5a4-1e0d-4f64-8985-36e2c01ccc05@www.fastmail.com \ --to=andrew@aj.id.au \ --cc=adrian.hunter@intel.com \ --cc=devicetree@vger.kernel.org \ --cc=joel@jms.id.au \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-aspeed@lists.ozlabs.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mmc@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=robh+dt@kernel.org \ --cc=ryanchen.aspeed@gmail.com \ --cc=ulf.hansson@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.