[U-Boot] [PATCH] serial: Use static inline for _debug_uart_init()

[U-Boot] [PATCH] serial: Use static inline for _debug_uart_init()

[Michal Simek]

Reported-by: Thomas Chou <thomas@wytron.com.tw>
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---

 drivers/serial/serial_xuartlite.c | 2 +-
 drivers/serial/serial_zynq.c      | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/serial/serial_xuartlite.c b/drivers/serial/serial_xuartlite.c
index fe87b515d902..0238a52380c7 100644
--- a/drivers/serial/serial_xuartlite.c
+++ b/drivers/serial/serial_xuartlite.c
@@ -122,7 +122,7 @@ U_BOOT_DRIVER(serial_uartlite) = {
 };
 
 #ifdef CONFIG_DEBUG_UART_UARTLITE
-void _debug_uart_init(void)
+static inline void _debug_uart_init(void)
 {
 	struct uartlite *regs = (struct uartlite *)CONFIG_DEBUG_UART_BASE;
 
diff --git a/drivers/serial/serial_zynq.c b/drivers/serial/serial_zynq.c
index b2b98dea1561..3430482f8d8b 100644
--- a/drivers/serial/serial_zynq.c
+++ b/drivers/serial/serial_zynq.c
@@ -192,7 +192,7 @@ U_BOOT_DRIVER(serial_zynq) = {
 };
 
 #ifdef CONFIG_DEBUG_UART_ZYNQ
-void _debug_uart_init(void)
+static inline void _debug_uart_init(void)
 {
 	struct uart_zynq *regs = (struct uart_zynq *)CONFIG_DEBUG_UART_BASE;
 
-- 
1.9.1

[U-Boot] [PATCH] serial: Use static inline for _debug_uart_init()

[Simon Glass]

On 14 December 2015 at 08:53, Michal Simek <michal.simek@xilinx.com> wrote:
> Reported-by: Thomas Chou <thomas@wytron.com.tw>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>
>  drivers/serial/serial_xuartlite.c | 2 +-
>  drivers/serial/serial_zynq.c      | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

[U-Boot] [PATCH] serial: Use static inline for _debug_uart_init()

[Bin Meng]

Hi Michal,

On Mon, Dec 14, 2015 at 11:53 PM, Michal Simek <michal.simek@xilinx.com> wrote:
> Reported-by: Thomas Chou <thomas@wytron.com.tw>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---

Could you always include a simple sentence in the commit message?

>
>  drivers/serial/serial_xuartlite.c | 2 +-
>  drivers/serial/serial_zynq.c      | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/serial/serial_xuartlite.c b/drivers/serial/serial_xuartlite.c
> index fe87b515d902..0238a52380c7 100644
> --- a/drivers/serial/serial_xuartlite.c
> +++ b/drivers/serial/serial_xuartlite.c
> @@ -122,7 +122,7 @@ U_BOOT_DRIVER(serial_uartlite) = {
>  };
>
>  #ifdef CONFIG_DEBUG_UART_UARTLITE
> -void _debug_uart_init(void)
> +static inline void _debug_uart_init(void)
>  {
>         struct uartlite *regs = (struct uartlite *)CONFIG_DEBUG_UART_BASE;
>
> diff --git a/drivers/serial/serial_zynq.c b/drivers/serial/serial_zynq.c
> index b2b98dea1561..3430482f8d8b 100644
> --- a/drivers/serial/serial_zynq.c
> +++ b/drivers/serial/serial_zynq.c
> @@ -192,7 +192,7 @@ U_BOOT_DRIVER(serial_zynq) = {
>  };
>
>  #ifdef CONFIG_DEBUG_UART_ZYNQ
> -void _debug_uart_init(void)
> +static inline void _debug_uart_init(void)
>  {
>         struct uart_zynq *regs = (struct uart_zynq *)CONFIG_DEBUG_UART_BASE;
>
> --

Other than that,

Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

Regards,
Bin

[U-Boot] [PATCH] serial: Use static inline for _debug_uart_init()

[Thomas Chou]

Hi Michal,

On 2015?12?14? 23:53, Michal Simek wrote:
> Reported-by: Thomas Chou <thomas@wytron.com.tw>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>
>   drivers/serial/serial_xuartlite.c | 2 +-
>   drivers/serial/serial_zynq.c      | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/serial/serial_xuartlite.c b/drivers/serial/serial_xuartlite.c
> index fe87b515d902..0238a52380c7 100644
> --- a/drivers/serial/serial_xuartlite.c
> +++ b/drivers/serial/serial_xuartlite.c
> @@ -122,7 +122,7 @@ U_BOOT_DRIVER(serial_uartlite) = {
>   };
>
>   #ifdef CONFIG_DEBUG_UART_UARTLITE
> -void _debug_uart_init(void)
> +static inline void _debug_uart_init(void)
>   {
>   	struct uartlite *regs = (struct uartlite *)CONFIG_DEBUG_UART_BASE;
>
> diff --git a/drivers/serial/serial_zynq.c b/drivers/serial/serial_zynq.c
> index b2b98dea1561..3430482f8d8b 100644
> --- a/drivers/serial/serial_zynq.c
> +++ b/drivers/serial/serial_zynq.c
> @@ -192,7 +192,7 @@ U_BOOT_DRIVER(serial_zynq) = {
>   };
>
>   #ifdef CONFIG_DEBUG_UART_ZYNQ
> -void _debug_uart_init(void)
> +static inline void _debug_uart_init(void)
>   {
>   	struct uart_zynq *regs = (struct uart_zynq *)CONFIG_DEBUG_UART_BASE;
>
>

Reviewed-by: Thomas Chou <thomas@wytron.com.tw>

Thanks,
Thomas

[U-Boot] [PATCH] serial: Use static inline for _debug_uart_init()

[Michal Simek]

On 15.12.2015 05:20, Bin Meng wrote:
> Hi Michal,
> 
> On Mon, Dec 14, 2015 at 11:53 PM, Michal Simek <michal.simek@xilinx.com> wrote:
>> Reported-by: Thomas Chou <thomas@wytron.com.tw>
>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
>> ---
> 
> Could you always include a simple sentence in the commit message?

done in v2.

Thanks,
Michal