* [PATCH] tests: add (riscv virt) machine mapping to testenv
@ 2022-03-07 14:13 ` laokz
0 siblings, 0 replies; 8+ messages in thread
From: laokz @ 2022-03-07 14:13 UTC (permalink / raw)
To: qemu-devel, qemu-riscv; +Cc: kwolf, laokz, hreitz
Some qemu-iotests(040 etc) use PCI disk to do test. Without the
mapping, RISC-V flavor use spike as default machine which has no
PCI bus, causing test failure.
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/894
Signed-off-by: laokz <laokz@foxmail.com>
---
tests/qemu-iotests/testenv.py | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/qemu-iotests/testenv.py b/tests/qemu-iotests/testenv.py
index 0f32897fe8..975f26a785 100644
--- a/tests/qemu-iotests/testenv.py
+++ b/tests/qemu-iotests/testenv.py
@@ -238,6 +238,8 @@ def __init__(self, imgfmt: str, imgproto: str, aiomode: str,
('aarch64', 'virt'),
('avr', 'mega2560'),
('m68k', 'virt'),
+ ('riscv32', 'virt'),
+ ('riscv64', 'virt'),
('rx', 'gdbsim-r5f562n8'),
('tricore', 'tricore_testboard')
)
--
2.34.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] tests: add (riscv virt) machine mapping to testenv
@ 2022-03-07 14:13 ` laokz
0 siblings, 0 replies; 8+ messages in thread
From: laokz @ 2022-03-07 14:13 UTC (permalink / raw)
To: qemu-devel, qemu-riscv; +Cc: hreitz, kwolf, laokz
Some qemu-iotests(040 etc) use PCI disk to do test. Without the
mapping, RISC-V flavor use spike as default machine which has no
PCI bus, causing test failure.
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/894
Signed-off-by: laokz <laokz@foxmail.com>
---
tests/qemu-iotests/testenv.py | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/qemu-iotests/testenv.py b/tests/qemu-iotests/testenv.py
index 0f32897fe8..975f26a785 100644
--- a/tests/qemu-iotests/testenv.py
+++ b/tests/qemu-iotests/testenv.py
@@ -238,6 +238,8 @@ def __init__(self, imgfmt: str, imgproto: str, aiomode: str,
('aarch64', 'virt'),
('avr', 'mega2560'),
('m68k', 'virt'),
+ ('riscv32', 'virt'),
+ ('riscv64', 'virt'),
('rx', 'gdbsim-r5f562n8'),
('tricore', 'tricore_testboard')
)
--
2.34.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] tests: add (riscv virt) machine mapping to testenv
2022-03-07 14:13 ` laokz
(?)
@ 2022-03-07 17:04 ` Hanna Reitz
2022-03-08 4:33 ` [PATCH v2] " laokz
-1 siblings, 1 reply; 8+ messages in thread
From: Hanna Reitz @ 2022-03-07 17:04 UTC (permalink / raw)
To: laokz, qemu-devel, qemu-riscv; +Cc: kwolf
On 07.03.22 15:13, laokz wrote:
> Some qemu-iotests(040 etc) use PCI disk to do test. Without the
> mapping, RISC-V flavor use spike as default machine which has no
> PCI bus, causing test failure.
>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/894
>
> Signed-off-by: laokz <laokz@foxmail.com>
Hi!
Thank you for this quick patch, it looks good to me! I can reproduce
the problem you reported, and this patch does resolve it.
There might be one problem, though, and that’s the Signed-off-by tag.
The qemu project requires it to be formatted like the Linux kernel does,
and so our docs/devel/submitting-a-patch.rst file links to
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/SubmittingPatches?id=f6f94e2ab1b33f0082ac22d71f66385a60d8157f#n297
. Like the kernel, we thus require a real name to appear in the S-o-b.
I’m used to seeing names written with a capital letter, and personal
names consisting just of a single name are rare, so that’s why I have to
ask you – is laokz your real name, i.e. not a pseudonym? If you say it
is, that’ll be fine for me.
If it isn’t and you don’t wish to disclose your real name, that will be
a bit of a problem legally, but I think in this case the patch is simple
enough that we can probably find a way around it.
Hanna
> ---
> tests/qemu-iotests/testenv.py | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tests/qemu-iotests/testenv.py b/tests/qemu-iotests/testenv.py
> index 0f32897fe8..975f26a785 100644
> --- a/tests/qemu-iotests/testenv.py
> +++ b/tests/qemu-iotests/testenv.py
> @@ -238,6 +238,8 @@ def __init__(self, imgfmt: str, imgproto: str, aiomode: str,
> ('aarch64', 'virt'),
> ('avr', 'mega2560'),
> ('m68k', 'virt'),
> + ('riscv32', 'virt'),
> + ('riscv64', 'virt'),
> ('rx', 'gdbsim-r5f562n8'),
> ('tricore', 'tricore_testboard')
> )
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2] tests: add (riscv virt) machine mapping to testenv
2022-03-07 17:04 ` Hanna Reitz
@ 2022-03-08 4:33 ` laokz
2022-03-08 6:40 ` Alistair Francis
2022-03-09 14:56 ` Hanna Reitz
0 siblings, 2 replies; 8+ messages in thread
From: laokz @ 2022-03-08 4:33 UTC (permalink / raw)
To: hreitz, qemu-devel, qemu-riscv; +Cc: kwolf, laokz
Some qemu-iotests(040 etc) use PCI disk to do test. Without the
mapping, RISC-V flavor use spike as default machine which has no
PCI bus, causing test failure.
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/894
Signed-off-by: Kai Zhang <laokz@foxmail.com>
---
Thanks for the detailed info. Corrected S-o-b tag.
tests/qemu-iotests/testenv.py | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/qemu-iotests/testenv.py b/tests/qemu-iotests/testenv.py
index 0f32897fe8..975f26a785 100644
--- a/tests/qemu-iotests/testenv.py
+++ b/tests/qemu-iotests/testenv.py
@@ -238,6 +238,8 @@ def __init__(self, imgfmt: str, imgproto: str, aiomode: str,
('aarch64', 'virt'),
('avr', 'mega2560'),
('m68k', 'virt'),
+ ('riscv32', 'virt'),
+ ('riscv64', 'virt'),
('rx', 'gdbsim-r5f562n8'),
('tricore', 'tricore_testboard')
)
--
2.34.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v2] tests: add (riscv virt) machine mapping to testenv
2022-03-08 4:33 ` [PATCH v2] " laokz
@ 2022-03-08 6:40 ` Alistair Francis
2022-03-09 14:56 ` Hanna Reitz
1 sibling, 0 replies; 8+ messages in thread
From: Alistair Francis @ 2022-03-08 6:40 UTC (permalink / raw)
To: laokz
Cc: Kevin Wolf, hreitz, open list:RISC-V, qemu-devel@nongnu.org Developers
On Tue, Mar 8, 2022 at 2:34 PM laokz <laokz@foxmail.com> wrote:
>
> Some qemu-iotests(040 etc) use PCI disk to do test. Without the
> mapping, RISC-V flavor use spike as default machine which has no
> PCI bus, causing test failure.
>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/894
>
> Signed-off-by: Kai Zhang <laokz@foxmail.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Alistair
> ---
> Thanks for the detailed info. Corrected S-o-b tag.
>
> tests/qemu-iotests/testenv.py | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tests/qemu-iotests/testenv.py b/tests/qemu-iotests/testenv.py
> index 0f32897fe8..975f26a785 100644
> --- a/tests/qemu-iotests/testenv.py
> +++ b/tests/qemu-iotests/testenv.py
> @@ -238,6 +238,8 @@ def __init__(self, imgfmt: str, imgproto: str, aiomode: str,
> ('aarch64', 'virt'),
> ('avr', 'mega2560'),
> ('m68k', 'virt'),
> + ('riscv32', 'virt'),
> + ('riscv64', 'virt'),
> ('rx', 'gdbsim-r5f562n8'),
> ('tricore', 'tricore_testboard')
> )
> --
> 2.34.1
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] tests: add (riscv virt) machine mapping to testenv
@ 2022-03-08 6:40 ` Alistair Francis
0 siblings, 0 replies; 8+ messages in thread
From: Alistair Francis @ 2022-03-08 6:40 UTC (permalink / raw)
To: laokz
Cc: hreitz, qemu-devel@nongnu.org Developers, open list:RISC-V, Kevin Wolf
On Tue, Mar 8, 2022 at 2:34 PM laokz <laokz@foxmail.com> wrote:
>
> Some qemu-iotests(040 etc) use PCI disk to do test. Without the
> mapping, RISC-V flavor use spike as default machine which has no
> PCI bus, causing test failure.
>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/894
>
> Signed-off-by: Kai Zhang <laokz@foxmail.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Alistair
> ---
> Thanks for the detailed info. Corrected S-o-b tag.
>
> tests/qemu-iotests/testenv.py | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tests/qemu-iotests/testenv.py b/tests/qemu-iotests/testenv.py
> index 0f32897fe8..975f26a785 100644
> --- a/tests/qemu-iotests/testenv.py
> +++ b/tests/qemu-iotests/testenv.py
> @@ -238,6 +238,8 @@ def __init__(self, imgfmt: str, imgproto: str, aiomode: str,
> ('aarch64', 'virt'),
> ('avr', 'mega2560'),
> ('m68k', 'virt'),
> + ('riscv32', 'virt'),
> + ('riscv64', 'virt'),
> ('rx', 'gdbsim-r5f562n8'),
> ('tricore', 'tricore_testboard')
> )
> --
> 2.34.1
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] tests: add (riscv virt) machine mapping to testenv
2022-03-08 4:33 ` [PATCH v2] " laokz
2022-03-08 6:40 ` Alistair Francis
@ 2022-03-09 14:56 ` Hanna Reitz
2022-03-10 6:05 ` laokz
1 sibling, 1 reply; 8+ messages in thread
From: Hanna Reitz @ 2022-03-09 14:56 UTC (permalink / raw)
To: laokz, qemu-devel, qemu-riscv; +Cc: kwolf
On 08.03.22 05:33, laokz wrote:
> Some qemu-iotests(040 etc) use PCI disk to do test. Without the
> mapping, RISC-V flavor use spike as default machine which has no
> PCI bus, causing test failure.
>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/894
>
> Signed-off-by: Kai Zhang <laokz@foxmail.com>
> ---
> Thanks for the detailed info. Corrected S-o-b tag.
>
> tests/qemu-iotests/testenv.py | 2 ++
> 1 file changed, 2 insertions(+)
Thanks!
I’ve applied this patch to my block branch:
https://gitlab.com/hreitz/qemu/-/commits/block
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] tests: add (riscv virt) machine mapping to testenv
2022-03-09 14:56 ` Hanna Reitz
@ 2022-03-10 6:05 ` laokz
0 siblings, 0 replies; 8+ messages in thread
From: laokz @ 2022-03-10 6:05 UTC (permalink / raw)
To: Hanna Reitz, qemu-devel, qemu-riscv; +Cc: kwolf
On Wed, Mar 09, 2022 at 15:56 +0100,Hanna Reitz wrote:
> On 08.03.22 05:33, laokz wrote:
> > Some qemu-iotests(040 etc) use PCI disk to do test. Without the
> > mapping, RISC-V flavor use spike as default machine which has no
> > PCI bus, causing test failure.
> >
> > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/894
> >
> > Signed-off-by: Kai Zhang <laokz@foxmail.com>
> > ---
> > Thanks for the detailed info. Corrected S-o-b tag.
> >
> > tests/qemu-iotests/testenv.py | 2 ++
> > 1 file changed, 2 insertions(+)
>
> Thanks!
>
> I’ve applied this patch to my block branch:
>
> https://gitlab.com/hreitz/qemu/-/commits/block
>
Got it. Thanks for your help!
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-03-10 6:07 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-07 14:13 [PATCH] tests: add (riscv virt) machine mapping to testenv laokz
2022-03-07 14:13 ` laokz
2022-03-07 17:04 ` Hanna Reitz
2022-03-08 4:33 ` [PATCH v2] " laokz
2022-03-08 6:40 ` Alistair Francis
2022-03-08 6:40 ` Alistair Francis
2022-03-09 14:56 ` Hanna Reitz
2022-03-10 6:05 ` laokz
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.