From: Sven Eckelmann <sven@narfation.org>
To: Sebastian Gottschall <s.gottschall@dd-wrt.com>
Cc: ath10k@lists.infradead.org, John Crispin <john@phrozen.org>,
Ansuel Smith <ansuelsmth@gmail.com>,
openwrt-devel@lists.openwrt.org,
Kalle Valo <kvalo@codeaurora.org>,
Sebastian Gottschall <s.gottschall@newmedia-net.de>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH v13] ath10k: add LED and GPIO controlling support for various chipsets
Date: Mon, 25 May 2020 11:22:13 +0200 [thread overview]
Message-ID: <3608947.bSrYYtX6KI@bentobox> (raw)
In-Reply-To: <b23e65cf-4be7-72db-7955-32eae196953e@dd-wrt.com>
[-- Attachment #1: Type: text/plain, Size: 2007 bytes --]
On Wednesday, 20 May 2020 09:39:45 CEST Sebastian Gottschall wrote:
[...]
> could somone clarify the state here and why it was dropped?
> the original patch i wrote does exclude the soc chipsets, but the patch
> was later reorganized and some part have been rewritten
> so i'm not sure if it covers the scenario mentioned here, which i did
[...]
> > This patch was imported to OpenWrt in commit 61d57a2f88b9 ("mac80211: ath10k
> > add leds support") and broke the 11s support for IPQ4019 and QCA4019 (5GHz)
> > firmware versions 10.4-3.5.3-00053, 10.4-3.5.3-00057, 10.4-3.6-00140:
Just noticed that there was a copy and paste error in my message. The 5GHz was
an QCA9888 [1,2] and not an QCA4019. Otherwise the _pci error wouldn't have made
any sense.
And I can only say at the moment (remember that this was observer 14 months
ago), that it could be reproduced easily on IPQ40xx with an QCA9888 and the
given config running OpenWrt reboot-9440-g0f89c17b57. The diffconfig (seed) of
the installation was:
CONFIG_TARGET_ipq40xx=y
CONFIG_TARGET_ipq40xx_generic=y
CONFIG_TARGET_ipq40xx_generic_DEVICE_openmesh_a62=y
CONFIG_ATH10K_LEDS=y
CONFIG_PACKAGE_ath10k-firmware-qca4019=y
# CONFIG_PACKAGE_ath10k-firmware-qca4019-ct is not set
CONFIG_PACKAGE_ath10k-firmware-qca9888=y
# CONFIG_PACKAGE_ath10k-firmware-qca9888-ct is not set
CONFIG_PACKAGE_kmod-ath10k=y
# CONFIG_PACKAGE_kmod-ath10k-ct is not set
# CONFIG_PACKAGE_kmod-hwmon-core is not set
And it still can with this OpenWrt version. But it doesn't seem to happen with
the most recent OpenWrt reboot-13353-gb1604b744b. But there are nearly 4000
commits inbetween. So no idea what changed (just a timing thing or an actual
fix - no idea).
Btw. the wireless config was given in the original mail [2,3]
Kind regards,
Sven
[1] https://openwrt.org/toh/hwdata/open-mesh/open-mesh_a62
[2] https://patchwork.kernel.org/patch/10723033/#22502191
[3] https://patchwork.kernel.org/patch/10327075/#22502179
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Sven Eckelmann <sven@narfation.org>
To: Sebastian Gottschall <s.gottschall@dd-wrt.com>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org,
John Crispin <john@phrozen.org>,
Sebastian Gottschall <s.gottschall@newmedia-net.de>,
openwrt-devel@lists.openwrt.org,
Ansuel Smith <ansuelsmth@gmail.com>,
Kalle Valo <kvalo@codeaurora.org>
Subject: Re: [PATCH v13] ath10k: add LED and GPIO controlling support for various chipsets
Date: Mon, 25 May 2020 11:22:13 +0200 [thread overview]
Message-ID: <3608947.bSrYYtX6KI@bentobox> (raw)
In-Reply-To: <b23e65cf-4be7-72db-7955-32eae196953e@dd-wrt.com>
[-- Attachment #1.1: Type: text/plain, Size: 2007 bytes --]
On Wednesday, 20 May 2020 09:39:45 CEST Sebastian Gottschall wrote:
[...]
> could somone clarify the state here and why it was dropped?
> the original patch i wrote does exclude the soc chipsets, but the patch
> was later reorganized and some part have been rewritten
> so i'm not sure if it covers the scenario mentioned here, which i did
[...]
> > This patch was imported to OpenWrt in commit 61d57a2f88b9 ("mac80211: ath10k
> > add leds support") and broke the 11s support for IPQ4019 and QCA4019 (5GHz)
> > firmware versions 10.4-3.5.3-00053, 10.4-3.5.3-00057, 10.4-3.6-00140:
Just noticed that there was a copy and paste error in my message. The 5GHz was
an QCA9888 [1,2] and not an QCA4019. Otherwise the _pci error wouldn't have made
any sense.
And I can only say at the moment (remember that this was observer 14 months
ago), that it could be reproduced easily on IPQ40xx with an QCA9888 and the
given config running OpenWrt reboot-9440-g0f89c17b57. The diffconfig (seed) of
the installation was:
CONFIG_TARGET_ipq40xx=y
CONFIG_TARGET_ipq40xx_generic=y
CONFIG_TARGET_ipq40xx_generic_DEVICE_openmesh_a62=y
CONFIG_ATH10K_LEDS=y
CONFIG_PACKAGE_ath10k-firmware-qca4019=y
# CONFIG_PACKAGE_ath10k-firmware-qca4019-ct is not set
CONFIG_PACKAGE_ath10k-firmware-qca9888=y
# CONFIG_PACKAGE_ath10k-firmware-qca9888-ct is not set
CONFIG_PACKAGE_kmod-ath10k=y
# CONFIG_PACKAGE_kmod-ath10k-ct is not set
# CONFIG_PACKAGE_kmod-hwmon-core is not set
And it still can with this OpenWrt version. But it doesn't seem to happen with
the most recent OpenWrt reboot-13353-gb1604b744b. But there are nearly 4000
commits inbetween. So no idea what changed (just a timing thing or an actual
fix - no idea).
Btw. the wireless config was given in the original mail [2,3]
Kind regards,
Sven
[1] https://openwrt.org/toh/hwdata/open-mesh/open-mesh_a62
[2] https://patchwork.kernel.org/patch/10723033/#22502191
[3] https://patchwork.kernel.org/patch/10327075/#22502179
[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 146 bytes --]
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2020-05-25 9:22 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-06 15:17 [PATCH v13] ath10k: add LED and GPIO controlling support for various chipsets Kalle Valo
2018-04-06 15:17 ` Kalle Valo
2018-04-06 15:22 ` Kalle Valo
2018-04-06 15:22 ` Kalle Valo
2018-04-06 18:31 ` Sebastian Gottschall
2018-04-06 18:31 ` Sebastian Gottschall
2018-04-09 15:49 ` Kalle Valo
2018-04-09 15:49 ` Kalle Valo
2018-04-10 10:33 ` Sebastian Gottschall
2018-04-10 10:33 ` Sebastian Gottschall
2018-04-08 8:21 ` Stefan Lippers-Hollmann
2018-04-08 8:21 ` Stefan Lippers-Hollmann
2019-02-26 9:16 ` Sven Eckelmann
2019-02-26 9:16 ` Sven Eckelmann
2020-05-20 7:39 ` Sebastian Gottschall
2020-05-20 7:39 ` Sebastian Gottschall
2020-05-20 10:40 ` [OpenWrt-Devel] " Vincent Wiemann
2020-05-20 10:40 ` Vincent Wiemann
2020-05-20 13:00 ` Sebastian Gottschall
2020-05-20 13:00 ` Sebastian Gottschall
2020-05-20 19:05 ` Vincent Wiemann
2020-05-20 19:05 ` Vincent Wiemann
2020-05-22 10:29 ` Kalle Valo
2020-05-22 10:29 ` Kalle Valo
2020-05-22 14:26 ` Sebastian Gottschall
2020-05-22 14:26 ` Sebastian Gottschall
2020-05-25 9:22 ` Sven Eckelmann [this message]
2020-05-25 9:22 ` Sven Eckelmann
2020-05-25 9:27 ` Sebastian Gottschall
2020-05-25 9:27 ` Sebastian Gottschall
2020-05-25 16:04 ` Sven Eckelmann
2020-05-25 16:04 ` Sven Eckelmann
2020-05-29 15:34 ` Kalle Valo
2020-05-29 15:34 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3608947.bSrYYtX6KI@bentobox \
--to=sven@narfation.org \
--cc=ansuelsmth@gmail.com \
--cc=ath10k@lists.infradead.org \
--cc=john@phrozen.org \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=openwrt-devel@lists.openwrt.org \
--cc=s.gottschall@dd-wrt.com \
--cc=s.gottschall@newmedia-net.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.