Re: Survey for final decision about per-port offload API

From: Thomas Monjalon <thomas@monjalon.net>
To: "Patil, Harish" <Harish.Patil@cavium.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	Ajit Khaparde <ajit.khaparde@broadcom.com>,
	"Jacob, Jerin" <Jerin.JacobKollanukkaran@cavium.com>,
	"Thotton, Shijith" <Shijith.Thotton@cavium.com>,
	"Shukla, Santosh" <Santosh.Shukla@cavium.com>,
	Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>,
	John Daley <johndale@cisco.com>,
	Wenzhuo Lu <wenzhuo.lu@intel.com>,
	Konstantin Ananyev <konstantin.ananyev@intel.com>,
	Beilei Xing <beilei.xing@intel.com>,
	Qi Zhang <qi.z.zhang@intel.com>,
	Jingjing Wu <jingjing.wu@intel.com>,
	Adrien Mazarguil <adrien.mazarguil@6wind.com>,
	Nelio Laranjeiro <nelio.laranjeiro@6wind.com>,
	Yongseok Koh <yskoh@mellanox.com>,
	Shahaf Shuler <shahafs@mellanox.com>,
	Tomasz Duszynski <tdu@semihalf.com>,
	Jianbo Liu <jianbo.liu@arm.com>,
	Alejandro Lucero <alejandro.lucero@netronome.com>,
	Hemant Agrawal <hemant.agrawal@nxp.com>,
	Shreyansh Jain <shreyansh.jain@nxp.com>,
	"Mody, Ra
Subject: Re: Survey for final decision about per-port offload API
Date: Mon, 02 Apr 2018 22:10:14 +0200	[thread overview]
Message-ID: <3635124.eX5m4pFW80@xps> (raw)
In-Reply-To: <D6E7B50D.1BC853%Harish.Patil@cavium.com>

02/04/2018 19:39, Patil, Harish:
> >It was also proposed to relax the API and allow "forgetting" port
> >offloads in queue offloads:
> >	http://dpdk.org/ml/archives/dev/2018-March/092978.html
> >
> >It would mean the offloads applied to a queue result of OR operation:
> >	rte_eth_conf.[rt]xmode.offloads | rte_eth_[rt]xconf.offloads
> >
> >1/ Do you agree with above API change?
> 
> Yes. But pls confirm that this would still work properly if RX supports
> port-only based offloads and doesn’t support queue based offloads at all,
> as advertised in dev_infos_get().
> 
> dev_info->rx_queue_offload_capa = 0 and
> dev_info->rx_offload_capa = (DEV_RX_OFFLOAD_IPV4_CKSUM | ...);

Yes, of course, no queue offload at all is possible.