From: "Hunter, Adrian" <adrian.hunter@intel.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
linux-block <linux-block@vger.kernel.org>,
"Jens Axboe" <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
Arnd Bergmann <arnd@arndb.de>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Paolo Valente <paolo.valente@linaro.org>,
Avri Altman <Avri.Altman@sandisk.com>
Subject: RE: [PATCH 00/12 v4] multiqueue for MMC/SD
Date: Thu, 26 Oct 2017 19:27:28 +0000 [thread overview]
Message-ID: <363DA0ED52042842948283D2FC38E4649BF396BD@IRSMSX106.ger.corp.intel.com> (raw)
In-Reply-To: <CACRpkdb_ZN+3YKYJ2L-5JNt1SgUqyCS3G-HER4e+LRcV64Jfag@mail.gmail.com>
PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBMaW51cyBXYWxsZWlqIFttYWls
dG86bGludXMud2FsbGVpakBsaW5hcm8ub3JnXQ0KPiBTZW50OiBUaHVyc2RheSwgT2N0b2JlciAy
NiwgMjAxNyA1OjIwIFBNDQo+IFRvOiBIdW50ZXIsIEFkcmlhbiA8YWRyaWFuLmh1bnRlckBpbnRl
bC5jb20+DQo+IENjOiBsaW51eC1tbWNAdmdlci5rZXJuZWwub3JnOyBVbGYgSGFuc3NvbiA8dWxm
LmhhbnNzb25AbGluYXJvLm9yZz47DQo+IGxpbnV4LWJsb2NrIDxsaW51eC1ibG9ja0B2Z2VyLmtl
cm5lbC5vcmc+OyBKZW5zIEF4Ym9lIDxheGJvZUBrZXJuZWwuZGs+Ow0KPiBDaHJpc3RvcGggSGVs
bHdpZyA8aGNoQGxzdC5kZT47IEFybmQgQmVyZ21hbm4gPGFybmRAYXJuZGIuZGU+Ow0KPiBCYXJ0
bG9taWVqIFpvbG5pZXJraWV3aWN6IDxiLnpvbG5pZXJraWVAc2Ftc3VuZy5jb20+OyBQYW9sbyBW
YWxlbnRlDQo+IDxwYW9sby52YWxlbnRlQGxpbmFyby5vcmc+OyBBdnJpIEFsdG1hbiA8QXZyaS5B
bHRtYW5Ac2FuZGlzay5jb20+DQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggMDAvMTIgdjRdIG11bHRp
cXVldWUgZm9yIE1NQy9TRA0KPiANCj4gT24gVGh1LCBPY3QgMjYsIDIwMTcgYXQgMzozNCBQTSwg
QWRyaWFuIEh1bnRlciA8YWRyaWFuLmh1bnRlckBpbnRlbC5jb20+DQo+IHdyb3RlOg0KPiA+IE9u
IDI2LzEwLzE3IDE1OjU3LCBMaW51cyBXYWxsZWlqIHdyb3RlOg0KPiA+PiBJbiBteSBvcGluaW9u
IHRoaXMgaXMgYWxzbyBhIGJldHRlciBmaXQgZm9yIGNvbW1hbmQgcXVldWV1aW5nLg0KPiA+DQo+
ID4gTm90IHRydWUuICBDUUUgc3VwcG9ydCB3b3JrZWQgcGVyZmVjdGx5IGJlZm9yZSBibGstbXEg
YW5kIGRpZCBub3QNCj4gPiBkZXBlbmQgb24gYmxrLW1xIGluIGFueSB3YXkuICBPYnZpb3VzbHkg
dGhlIGN1cnJlbnQgQ1FFIHBhdGNoIHNldA0KPiA+IGFjdHVhbGx5IGltcGxlbWVudHMgdGhlIENR
RSByZXF1aXJlbWVudHMgZm9yIGJsay1tcSAtIHdoaWNoIHRoaXMgcGF0Y2ggc2V0DQo+IGRvZXMg
bm90Lg0KPiANCj4gV2hhdCBJIG1lYW4gaXMgdGhhdCB0aGUgQ1FFIGNvZGUgd2lsbCBsaWtlbHkg
bG9vayBiZXR0ZXIgb24gdG9wIG9mIHRoZXNlDQo+IHJlZmFjdG9yaW5ncy4NCj4gDQo+IEJ1dCBh
cyBJIHNheSBpdCBpcyBhIG1hdHRlciBvZiB0YXN0ZS4gSSBqdXN0IGxvdmUgdGhlIGxvb2tzIG9m
IG15IG93biBjb2RlIGFzDQo+IG11Y2ggYXMgdGhlIG5leHQgcHJvZ3JhbW1lciBzbyBJIGNhbid0
IGp1ZGdlIHRoYXQuIExldCdzIHNlZSB3aGF0IHRoZQ0KPiByZXZpZXdlcnMgc2F5Lg0KDQpJdCBk
b2Vzbid0IGxvb2sgcmVhZHkuICBUaGVyZSBzZWVtcyBzdGlsbCB0byBiZSAyIHRhc2sgc3dpdGNo
ZXMgYmV0d2Vlbg0KZWFjaCB0cmFuc2Zlci4gIG1tY19ibGtfcndfZG9uZV9lcnJvcigpIGlzIHN0
aWxsIHVzaW5nIHRoZSBtZXNzeSBlcnJvcg0KaGFuZGxpbmcgYW5kIGRvZXNu4oCZdCBoYW5kbGUg
cmV0cmllcyBlLmcuICdyZXRyeScgaXMgYSBsb2NhbCB2YXJpYWJsZSBzbyBpdCBjYW4ndA0KY291
bnQgdGhlIG51bWJlciBvZiByZXRyaWVzIG5vdyB0aGF0IHRoZXJlIGlzIG5vIGxvb3AuDQoNCj4g
Pj4gSXQgc291bmRzIHNpbXBsZSBidXQgSSBiZXQgdGhpcyBkcml2ZXMgYSB0cnVjayB0aHJvdWdo
IEFkcmlhbnMgcGF0Y2gNCj4gPj4gc2VyaWVzLiBTb3JyeS4gOigNCj4gPg0KPiA+IEkgd2FpdGVk
IGEgbG9uZyB0aW1lIGZvciB5b3VyIHBhdGNoZXMgYnV0IEkgaGFkIHRvIGdpdmUgdXAgd2FpdGlu
Zw0KPiA+IHdoZW4gVWxmIGJlbGF0ZWQgaW5zaXN0ZWQgb24gYmxrLW1xIGJlZm9yZSBDUUUuICBJ
IGFtIG5vdCBzdXJlIHdoYXQNCj4gPiB5b3UgYXJlIGV4cGVjdGluZyBub3cgaXQgc2VlbXMgdG9v
IGxhdGUuDQo+IA0KPiBUb28gbGF0ZSBmb3Igd2hhdD8gSXQncyBqdXN0IGEgcGF0Y2ggc2V0LCBJ
IGRvbid0IHJlYWxseSBoYXZlIGEgZGVhZGxpbmUgZm9yIHRoaXMgb3INCj4gYW55dGhpbmcuIEFz
IEkgZXhwbGFpbmVkIGFib3ZlIEkgaGF2ZSBiZWVuIHdvcmtpbmcgb24gdGhpcyBhbGwgdGhlIHRp
bWUsIHRoZQ0KPiBwcm9ibGVtIHdhcyB0aGF0IEkgd2FzL2FtIG5vdCBzbWFydCBlbm91Z2ggdG8g
ZmluZCB0aGF0IHNvbHV0aW9uIGZvciBob3N0DQo+IGNsYWltaW5nIGJ5IGNvbnRleHQuDQoNClRv
byBsYXRlIHRvIGdvIGJlZm9yZSBDUUUuICBBbGwgdGhlIGJsay1tcSB3b3JrIGlzIG5vdyBpbiB0
aGUgQ1FFIHBhdGNoc2V0Lg0KDQo+IA0KPiBUaGUgaG9zdCBjbGFpbWluZyBieSBjb250ZXh0IHdh
cyBtZXJnZWQgYSBtb250aCBhZ28gYW5kIG5vdyBJIGhhdmUNCj4gdW5kZXJzdG9vZCB0aGF0IEkg
Y2FuIHVzZSB0aGF0IGFuZCByZWJhc2VkIG15IHBhdGNoZXMgb24gaXQuIFNsb3cgbGVhcm5lciwg
SQ0KPiBndWVzcy4NCj4gDQo+IElmIHlvdSBmZWVsIGl0IGlzIHVuZ3JhdGVmdWwgdGhhdCB5b3Ug
aGF2ZSBwdXQgaW4gc28gbXVjaCB3b3JrIGFuZCB0aGluZ3MgYXJlDQo+IG5vdCBnZXR0aW5nIG1l
cmdlZCwgYW5kIHlvdSBmZWVsIHlvdXIgcGF0Y2hlcyBkZXNlcnZlIHRvIGJlIG1lcmdlZCBmaXJz
dA0KPiAoYmVjYXVzZSBvZiBodW1hbiBuYXR1cmUgcmVhc29ucykgSSBjYW4gZW1wYXRoaXplIHdp
dGggdGhhdC4gSXQncyBzYWQgdGhhdA0KPiB5b3VyIHBhdGNoZXMgYXJlIGF0IHYxMi4gQWxzbyBJ
IHNlZSB0aGF0IHBhdGNoIDQgYmVhcnMgdGhlIHNpZ25vZmZzIG9mIGENCj4gc2lnbmlmaWNhbnQg
dGVhbSBhdCBDb2RlQXVyb3JhLCBzbyB0aGV5IGFyZSBsaWtlbHkgYXMgaW1wYXRpZW50Lg0KDQpJ
dCBpcyBpbXBvcnRhbnQgdGhhdCB5b3UgdW5kZXJzdGFuZCB0aGF0IHRoaXMgaGFzIG5vdGhpbmcg
dG8gZG8gd2l0aA0KImh1bWFuIG5hdHVyZSByZWFzb25zIi4gICAgTGludXggZGlzdHJpYnV0aW9u
cyB1c2UgdXBzdHJlYW0ga2VybmVscy4gDQpDaHJvbWVPUyAgaGFzIGFuICJ1cHN0cmVhbSBmaXJz
dCIgcG9saWN5LiAgRGVsYXlpbmcgZmVhdHVyZXMgZm9yIGxvbmcNCnBlcmlvZHMgaGFzIHJlYWwt
d29ybGQgY29uc2VxdWVuY2VzLiAgV2hlbiBwZW9wbGUgYXNrLCB3aGF0IGtlcm5lbA0Kc2hvdWxk
IHRoZXkgdXNlLCB3ZSBleHBlY3QgdG8gcmVwbHksIGp1c3QgdXNlIG1haW5saW5lLg0KDQo=
WARNING: multiple messages have this Message-ID (diff)
From: "Hunter, Adrian" <adrian.hunter@intel.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
linux-block <linux-block@vger.kernel.org>,
Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
Arnd Bergmann <arnd@arndb.de>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Paolo Valente <paolo.valente@linaro.org>,
Avri Altman <Avri.Altman@sandisk.com>
Subject: RE: [PATCH 00/12 v4] multiqueue for MMC/SD
Date: Thu, 26 Oct 2017 19:27:28 +0000 [thread overview]
Message-ID: <363DA0ED52042842948283D2FC38E4649BF396BD@IRSMSX106.ger.corp.intel.com> (raw)
In-Reply-To: <CACRpkdb_ZN+3YKYJ2L-5JNt1SgUqyCS3G-HER4e+LRcV64Jfag@mail.gmail.com>
> -----Original Message-----
> From: Linus Walleij [mailto:linus.walleij@linaro.org]
> Sent: Thursday, October 26, 2017 5:20 PM
> To: Hunter, Adrian <adrian.hunter@intel.com>
> Cc: linux-mmc@vger.kernel.org; Ulf Hansson <ulf.hansson@linaro.org>;
> linux-block <linux-block@vger.kernel.org>; Jens Axboe <axboe@kernel.dk>;
> Christoph Hellwig <hch@lst.de>; Arnd Bergmann <arnd@arndb.de>;
> Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>; Paolo Valente
> <paolo.valente@linaro.org>; Avri Altman <Avri.Altman@sandisk.com>
> Subject: Re: [PATCH 00/12 v4] multiqueue for MMC/SD
>
> On Thu, Oct 26, 2017 at 3:34 PM, Adrian Hunter <adrian.hunter@intel.com>
> wrote:
> > On 26/10/17 15:57, Linus Walleij wrote:
> >> In my opinion this is also a better fit for command queueuing.
> >
> > Not true. CQE support worked perfectly before blk-mq and did not
> > depend on blk-mq in any way. Obviously the current CQE patch set
> > actually implements the CQE requirements for blk-mq - which this patch set
> does not.
>
> What I mean is that the CQE code will likely look better on top of these
> refactorings.
>
> But as I say it is a matter of taste. I just love the looks of my own code as
> much as the next programmer so I can't judge that. Let's see what the
> reviewers say.
It doesn't look ready. There seems still to be 2 task switches between
each transfer. mmc_blk_rw_done_error() is still using the messy error
handling and doesn’t handle retries e.g. 'retry' is a local variable so it can't
count the number of retries now that there is no loop.
> >> It sounds simple but I bet this drives a truck through Adrians patch
> >> series. Sorry. :(
> >
> > I waited a long time for your patches but I had to give up waiting
> > when Ulf belated insisted on blk-mq before CQE. I am not sure what
> > you are expecting now it seems too late.
>
> Too late for what? It's just a patch set, I don't really have a deadline for this or
> anything. As I explained above I have been working on this all the time, the
> problem was that I was/am not smart enough to find that solution for host
> claiming by context.
Too late to go before CQE. All the blk-mq work is now in the CQE patchset.
>
> The host claiming by context was merged a month ago and now I have
> understood that I can use that and rebased my patches on it. Slow learner, I
> guess.
>
> If you feel it is ungrateful that you have put in so much work and things are
> not getting merged, and you feel your patches deserve to be merged first
> (because of human nature reasons) I can empathize with that. It's sad that
> your patches are at v12. Also I see that patch 4 bears the signoffs of a
> significant team at CodeAurora, so they are likely as impatient.
It is important that you understand that this has nothing to do with
"human nature reasons". Linux distributions use upstream kernels.
ChromeOS has an "upstream first" policy. Delaying features for long
periods has real-world consequences. When people ask, what kernel
should they use, we expect to reply, just use mainline.
next prev parent reply other threads:[~2017-10-26 19:27 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-26 12:57 [PATCH 00/12 v4] multiqueue for MMC/SD Linus Walleij
2017-10-26 12:57 ` [PATCH 01/12 v4] mmc: core: move the asynchronous post-processing Linus Walleij
2017-10-26 12:57 ` [PATCH 02/12 v4] mmc: core: add a workqueue for completing requests Linus Walleij
2017-10-26 12:57 ` [PATCH 03/12 v4] mmc: core: replace waitqueue with worker Linus Walleij
2017-10-26 12:57 ` [PATCH 04/12 v4] mmc: core: do away with is_done_rcv Linus Walleij
2017-10-26 12:57 ` [PATCH 05/12 v4] mmc: core: do away with is_new_req Linus Walleij
2017-10-26 12:57 ` [PATCH 06/12 v4] mmc: core: kill off the context info Linus Walleij
2017-10-26 12:57 ` [PATCH 07/12 v4] mmc: queue: simplify queue logic Linus Walleij
2017-10-26 12:57 ` [PATCH 08/12 v4] mmc: block: shuffle retry and error handling Linus Walleij
2017-10-26 12:57 ` [PATCH 09/12 v4] mmc: queue: stop flushing the pipeline with NULL Linus Walleij
2017-10-26 12:57 ` [PATCH 10/12 v4] mmc: queue/block: pass around struct mmc_queue_req*s Linus Walleij
2017-10-26 12:57 ` [PATCH 11/12 v4] mmc: block: issue requests in massive parallel Linus Walleij
2017-10-27 14:19 ` Ulf Hansson
2017-10-26 12:57 ` [PATCH 12/12 v4] mmc: switch MMC/SD to use blk-mq multiqueueing Linus Walleij
2017-10-26 13:34 ` [PATCH 00/12 v4] multiqueue for MMC/SD Adrian Hunter
2017-10-26 14:20 ` Linus Walleij
2017-10-26 19:27 ` Hunter, Adrian [this message]
2017-10-26 19:27 ` Hunter, Adrian
2017-10-27 11:25 ` Linus Walleij
2017-10-27 11:25 ` Linus Walleij
2017-10-27 12:59 ` Adrian Hunter
2017-10-27 14:29 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=363DA0ED52042842948283D2FC38E4649BF396BD@IRSMSX106.ger.corp.intel.com \
--to=adrian.hunter@intel.com \
--cc=Avri.Altman@sandisk.com \
--cc=arnd@arndb.de \
--cc=axboe@kernel.dk \
--cc=b.zolnierkie@samsung.com \
--cc=hch@lst.de \
--cc=linus.walleij@linaro.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=paolo.valente@linaro.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.