Re: [LTP] regression: selinux testsuite broken since October

From: Garrett Cooper <yanegomi@gmail.com>
To: Stephen Smalley <sds@tycho.nsa.gov>
Cc: Eric Paris <eparis@parisplace.org>,
	James Morris <jmorris@namei.org>,
	ltp-list@lists.sourceforge.net
Subject: Re: [LTP] regression: selinux testsuite broken since October
Date: Thu, 14 Jan 2010 12:10:28 -0800	[thread overview]
Message-ID: <364299f41001141210o49c97980yc703601e7340362f@mail.gmail.com> (raw)
In-Reply-To: <1263478021.8548.3.camel@moss-pluto.epoch.ncsc.mil>

On Thu, Jan 14, 2010 at 6:07 AM, Stephen Smalley <sds@tycho.nsa.gov> wrote:
> On Wed, 2010-01-13 at 14:49 -0800, Garrett Cooper wrote:
>> Which is what it's doing now, but the original author of the test
>> wrote the load logic and unload logic so that it used make instead of
>> using a bourne shell script, etc.
>
> To clarify, there are two things happening under that load target
> presently, one of which is properly handled at build time and one of
> which is properly handled at test execution time.  The first part is
> building test_policy.pp.  The latter is running semodule -i
> test_policy.pp.  So we could split up the Makefile so that the first
> part is done by the make all/install, and test_selinux.sh merely runs
> semodule -i test_policy.pp before the test and semodule -r test_policy
> after the test.  One other item I notice is that the current logic
> copies test_policy* to $POLICY_DEVEL_DIR and runs make there, which
> isn't necessary - you could just leave them in the refpolicy directory
> and run make -f $POLICY_DEVEL_DIR/Makefile test_policy.pp.

Ok, this is interesting. So -- is there any particular reason why
clean (which in this case just called cleanup) should be called before
load?

So at the end of the day, all of the junk done as part of `load' could
in fact be done in test_selinux.sh // runtests.sh (I assume the only
step that couldn't be done is semodule -i? I don't have any hard
feelings for not putting that logic in those scripts...

>> The other thing that's kind of amusing is that its setup / teardown
>> isn't very robust -- I could send a signal, or the process could get
>> terminated leaving the test policy files hanging around the system
>> under test. That's a side issue but it's also another good reason to
>> migrate away from this make paradigm for setup / teardown -_-...

Thanks!
-Garrett

------------------------------------------------------------------------------
Throughout its 18-year history, RSA Conference consistently attracts the
world's best and brightest in the field, creating opportunities for Conference
attendees to learn about information security's most important issues through
interactions with peers, luminaries and emerging and established companies.
http://p.sf.net/sfu/rsaconf-dev2dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list