Re: [LTP] regression: selinux testsuite broken since October

[Garrett Cooper <yanegomi@gmail.com>]

On Thu, Jan 28, 2010 at 6:02 AM, Stephen Smalley <sds@tycho.nsa.gov> wrote:
> On Wed, 2010-01-27 at 21:56 -0800, Garrett Cooper wrote:
>> On Wed, Jan 27, 2010 at 2:37 PM, Garrett Cooper <yanegomi@gmail.com> wrote:
>> > Ok. Send me a patch that does a readlink -f of the LTPPATH and set
>> > your PATH to include $LTPROOT/testcases/bin, and you'll be good to go
>>
>>     Nevermind. I just committed the change... please retest and
>> hopefully all goes well for you this time around.
>
> Looks good.  Patch below fixes two bugs in the selinux tests, noticed by
> examining the selinux.outfile carefully for errors (No such file or
> directory, Segmentation fault).
>
> Index: testcases/kernel/security/selinux-testsuite/tests/file/selinux_file.sh
> ===================================================================
> RCS file: /cvsroot/ltp/ltp/testcases/kernel/security/selinux-testsuite/tests/file/selinux_file.sh,v
> retrieving revision 1.10
> diff -u -r1.10 selinux_file.sh
> --- testcases/kernel/security/selinux-testsuite/tests/file/selinux_file.sh      26 Jan 2010 07:05:02 -0000      1.10
> +++ testcases/kernel/security/selinux-testsuite/tests/file/selinux_file.sh      28 Jan 2010 13:50:31 -0000
> @@ -47,7 +47,8 @@
>        #
>        # Change the context of the test executable
>        #
> -       chcon -t fileop_exec_t selinux_wait_io 2>&1 > /dev/null
> +       LTPBIN=${LTPBIN:-$LTPROOT/testcases/bin}
> +       chcon -t fileop_exec_t $LTPBIN/selinux_wait_io 2>&1 > /dev/null
>
>        #
>        # Get the SID of the good file.
> Index: testcases/kernel/security/selinux-testsuite/tests/shm/selinux_shmat.c
> ===================================================================
> RCS file: /cvsroot/ltp/ltp/testcases/kernel/security/selinux-testsuite/tests/shm/selinux_shmat.c,v
> retrieving revision 1.4
> diff -u -r1.4 selinux_shmat.c
> --- testcases/kernel/security/selinux-testsuite/tests/shm/selinux_shmat.c       13 Jan 2010 08:16:57 -0000      1.4
> +++ testcases/kernel/security/selinux-testsuite/tests/shm/selinux_shmat.c       28 Jan 2010 13:50:31 -0000
> @@ -40,7 +40,7 @@
>                return 1;
>
>        buf = shmat(id, 0, 0);
> -       error = (*buf == -1) ? -1 : 0;
> +       error = (buf == (void*)-1) ? -1 : 0;
>        printf("shmat: buf=%p, returned %d\n", buf, error);
>        return error;
>  }

Done -- thanks!
-Garrett

------------------------------------------------------------------------------
The Planet: dedicated and managed hosting, cloud storage, colocation
Stay online with enterprise data centers and the best network in the business
Choose flexible plans and management services without long-term contracts
Personal 24x7 support from experience hosting pros just a phone call away.
http://p.sf.net/sfu/theplanet-com
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list