* [PATCH -next] staging: comedi: dyna_pci10xx: remove set but not used variables 'chan' and range'
@ 2019-04-06 3:07 ` YueHaibing
0 siblings, 0 replies; 6+ messages in thread
From: YueHaibing @ 2019-04-06 2:57 UTC (permalink / raw)
To: Ian Abbott, H Hartley Sweeten, Greg Kroah-Hartman, Sanjana Sanikommu
Cc: YueHaibing, devel, linux-kernel, kernel-janitors
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/staging/comedi/drivers/dyna_pci10xx.c: In function 'dyna_pci10xx_insn_write_ao':
drivers/staging/comedi/drivers/dyna_pci10xx.c:109:21: warning:
variable 'range' set but not used [-Wunused-but-set-variable]
unsigned int chan, range;
drivers/staging/comedi/drivers/dyna_pci10xx.c:109:15: warning:
variable 'chan' set but not used [-Wunused-but-set-variable]
unsigned int chan, range;
They are never used since introduction in commit 16a7373a8e14 ("Staging:
comedi: add dyna_pci10xx driver")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/staging/comedi/drivers/dyna_pci10xx.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/comedi/drivers/dyna_pci10xx.c b/drivers/staging/comedi/drivers/dyna_pci10xx.c
index 9bdd5bf2eb99..d38bfc6113e8 100644
--- a/drivers/staging/comedi/drivers/dyna_pci10xx.c
+++ b/drivers/staging/comedi/drivers/dyna_pci10xx.c
@@ -106,10 +106,6 @@ static int dyna_pci10xx_insn_write_ao(struct comedi_device *dev,
{
struct dyna_pci10xx_private *devpriv = dev->private;
int n;
- unsigned int chan, range;
-
- chan = CR_CHAN(insn->chanspec);
- range = range_codes_pci1050_ai[CR_RANGE((insn->chanspec))];
mutex_lock(&devpriv->mutex);
for (n = 0; n < insn->n; n++) {
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH -next] staging: comedi: dyna_pci10xx: remove set but not used variables 'chan' and range'
@ 2019-04-06 3:07 ` YueHaibing
0 siblings, 0 replies; 6+ messages in thread
From: YueHaibing @ 2019-04-06 3:07 UTC (permalink / raw)
To: Ian Abbott, H Hartley Sweeten, Greg Kroah-Hartman, Sanjana Sanikommu
Cc: YueHaibing, devel, linux-kernel, kernel-janitors
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/staging/comedi/drivers/dyna_pci10xx.c: In function 'dyna_pci10xx_insn_write_ao':
drivers/staging/comedi/drivers/dyna_pci10xx.c:109:21: warning:
variable 'range' set but not used [-Wunused-but-set-variable]
unsigned int chan, range;
drivers/staging/comedi/drivers/dyna_pci10xx.c:109:15: warning:
variable 'chan' set but not used [-Wunused-but-set-variable]
unsigned int chan, range;
They are never used since introduction in commit 16a7373a8e14 ("Staging:
comedi: add dyna_pci10xx driver")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/staging/comedi/drivers/dyna_pci10xx.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/comedi/drivers/dyna_pci10xx.c b/drivers/staging/comedi/drivers/dyna_pci10xx.c
index 9bdd5bf2eb99..d38bfc6113e8 100644
--- a/drivers/staging/comedi/drivers/dyna_pci10xx.c
+++ b/drivers/staging/comedi/drivers/dyna_pci10xx.c
@@ -106,10 +106,6 @@ static int dyna_pci10xx_insn_write_ao(struct comedi_device *dev,
{
struct dyna_pci10xx_private *devpriv = dev->private;
int n;
- unsigned int chan, range;
-
- chan = CR_CHAN(insn->chanspec);
- range = range_codes_pci1050_ai[CR_RANGE((insn->chanspec))];
mutex_lock(&devpriv->mutex);
for (n = 0; n < insn->n; n++) {
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH -next] staging: comedi: dyna_pci10xx: remove set but not used variables 'chan' and range'
2019-04-06 3:07 ` YueHaibing
@ 2019-04-06 8:32 ` Mukesh Ojha
-1 siblings, 0 replies; 6+ messages in thread
From: Mukesh Ojha @ 2019-04-06 8:20 UTC (permalink / raw)
To: YueHaibing, Ian Abbott, H Hartley Sweeten, Greg Kroah-Hartman,
Sanjana Sanikommu
Cc: devel, linux-kernel, kernel-janitors
On 4/6/2019 8:37 AM, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/staging/comedi/drivers/dyna_pci10xx.c: In function 'dyna_pci10xx_insn_write_ao':
> drivers/staging/comedi/drivers/dyna_pci10xx.c:109:21: warning:
> variable 'range' set but not used [-Wunused-but-set-variable]
> unsigned int chan, range;
>
> drivers/staging/comedi/drivers/dyna_pci10xx.c:109:15: warning:
> variable 'chan' set but not used [-Wunused-but-set-variable]
> unsigned int chan, range;
>
> They are never used since introduction in commit 16a7373a8e14 ("Staging:
> comedi: add dyna_pci10xx driver")
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
Cheers,
-Mukesh
> ---
> drivers/staging/comedi/drivers/dyna_pci10xx.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/dyna_pci10xx.c b/drivers/staging/comedi/drivers/dyna_pci10xx.c
> index 9bdd5bf2eb99..d38bfc6113e8 100644
> --- a/drivers/staging/comedi/drivers/dyna_pci10xx.c
> +++ b/drivers/staging/comedi/drivers/dyna_pci10xx.c
> @@ -106,10 +106,6 @@ static int dyna_pci10xx_insn_write_ao(struct comedi_device *dev,
> {
> struct dyna_pci10xx_private *devpriv = dev->private;
> int n;
> - unsigned int chan, range;
> -
> - chan = CR_CHAN(insn->chanspec);
> - range = range_codes_pci1050_ai[CR_RANGE((insn->chanspec))];
>
> mutex_lock(&devpriv->mutex);
> for (n = 0; n < insn->n; n++) {
>
>
>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next] staging: comedi: dyna_pci10xx: remove set but not used variables 'chan' and range'
@ 2019-04-06 8:32 ` Mukesh Ojha
0 siblings, 0 replies; 6+ messages in thread
From: Mukesh Ojha @ 2019-04-06 8:32 UTC (permalink / raw)
To: YueHaibing, Ian Abbott, H Hartley Sweeten, Greg Kroah-Hartman,
Sanjana Sanikommu
Cc: devel, linux-kernel, kernel-janitors
On 4/6/2019 8:37 AM, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/staging/comedi/drivers/dyna_pci10xx.c: In function 'dyna_pci10xx_insn_write_ao':
> drivers/staging/comedi/drivers/dyna_pci10xx.c:109:21: warning:
> variable 'range' set but not used [-Wunused-but-set-variable]
> unsigned int chan, range;
>
> drivers/staging/comedi/drivers/dyna_pci10xx.c:109:15: warning:
> variable 'chan' set but not used [-Wunused-but-set-variable]
> unsigned int chan, range;
>
> They are never used since introduction in commit 16a7373a8e14 ("Staging:
> comedi: add dyna_pci10xx driver")
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
Cheers,
-Mukesh
> ---
> drivers/staging/comedi/drivers/dyna_pci10xx.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/dyna_pci10xx.c b/drivers/staging/comedi/drivers/dyna_pci10xx.c
> index 9bdd5bf2eb99..d38bfc6113e8 100644
> --- a/drivers/staging/comedi/drivers/dyna_pci10xx.c
> +++ b/drivers/staging/comedi/drivers/dyna_pci10xx.c
> @@ -106,10 +106,6 @@ static int dyna_pci10xx_insn_write_ao(struct comedi_device *dev,
> {
> struct dyna_pci10xx_private *devpriv = dev->private;
> int n;
> - unsigned int chan, range;
> -
> - chan = CR_CHAN(insn->chanspec);
> - range = range_codes_pci1050_ai[CR_RANGE((insn->chanspec))];
>
> mutex_lock(&devpriv->mutex);
> for (n = 0; n < insn->n; n++) {
>
>
>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next] staging: comedi: dyna_pci10xx: remove set but not used variables 'chan' and range'
2019-04-06 3:07 ` YueHaibing
@ 2019-04-06 10:13 ` Ian Abbott
-1 siblings, 0 replies; 6+ messages in thread
From: Ian Abbott @ 2019-04-06 10:13 UTC (permalink / raw)
To: YueHaibing, H Hartley Sweeten, Greg Kroah-Hartman, Sanjana Sanikommu
Cc: devel, linux-kernel, kernel-janitors
On 06/04/2019 04:07, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/staging/comedi/drivers/dyna_pci10xx.c: In function 'dyna_pci10xx_insn_write_ao':
> drivers/staging/comedi/drivers/dyna_pci10xx.c:109:21: warning:
> variable 'range' set but not used [-Wunused-but-set-variable]
> unsigned int chan, range;
>
> drivers/staging/comedi/drivers/dyna_pci10xx.c:109:15: warning:
> variable 'chan' set but not used [-Wunused-but-set-variable]
> unsigned int chan, range;
>
> They are never used since introduction in commit 16a7373a8e14 ("Staging:
> comedi: add dyna_pci10xx driver")
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/staging/comedi/drivers/dyna_pci10xx.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/dyna_pci10xx.c b/drivers/staging/comedi/drivers/dyna_pci10xx.c
> index 9bdd5bf2eb99..d38bfc6113e8 100644
> --- a/drivers/staging/comedi/drivers/dyna_pci10xx.c
> +++ b/drivers/staging/comedi/drivers/dyna_pci10xx.c
> @@ -106,10 +106,6 @@ static int dyna_pci10xx_insn_write_ao(struct comedi_device *dev,
> {
> struct dyna_pci10xx_private *devpriv = dev->private;
> int n;
> - unsigned int chan, range;
> -
> - chan = CR_CHAN(insn->chanspec);
> - range = range_codes_pci1050_ai[CR_RANGE((insn->chanspec))];
>
> mutex_lock(&devpriv->mutex);
> for (n = 0; n < insn->n; n++) {
That seems fine, thanks. The lines being removed appear to have been
copy and pasted from dyna_pci10xx_insn_read_ai(). The AO subdevice
supports a single range, so no 'range' code is needed. I believe the
card has only one analog output channel[*], so the 'chan' is irrelevant.
This means the 'n_chans' value in the AO subdevice configuration is
incorrect. I'll send a follow-up patch to correct that after Greg KH
takes this one.
[*] Very little information seems to be available about this card
online. It is no longer listed on the manufacturer's web-site and I
couldn't find any archives on archive.org. I found part of a scientific
paper
<http://shodhganga.inflibnet.ac.in/bitstream/10603/150646/15/15_chapter%205.pdf>
which describes the card as having a single channel D/A converter.
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
--
-=( Ian Abbott <abbotti@mev.co.uk> || Web: www.mev.co.uk )=-
-=( MEV Ltd. is a company registered in England & Wales. )=-
-=( Registered number: 02862268. Registered address: )=-
-=( 15 West Park Road, Bramhall, STOCKPORT, SK7 3JZ, UK. )=-
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next] staging: comedi: dyna_pci10xx: remove set but not used variables 'chan' and range'
@ 2019-04-06 10:13 ` Ian Abbott
0 siblings, 0 replies; 6+ messages in thread
From: Ian Abbott @ 2019-04-06 10:13 UTC (permalink / raw)
To: YueHaibing, H Hartley Sweeten, Greg Kroah-Hartman, Sanjana Sanikommu
Cc: devel, linux-kernel, kernel-janitors
On 06/04/2019 04:07, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/staging/comedi/drivers/dyna_pci10xx.c: In function 'dyna_pci10xx_insn_write_ao':
> drivers/staging/comedi/drivers/dyna_pci10xx.c:109:21: warning:
> variable 'range' set but not used [-Wunused-but-set-variable]
> unsigned int chan, range;
>
> drivers/staging/comedi/drivers/dyna_pci10xx.c:109:15: warning:
> variable 'chan' set but not used [-Wunused-but-set-variable]
> unsigned int chan, range;
>
> They are never used since introduction in commit 16a7373a8e14 ("Staging:
> comedi: add dyna_pci10xx driver")
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/staging/comedi/drivers/dyna_pci10xx.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/dyna_pci10xx.c b/drivers/staging/comedi/drivers/dyna_pci10xx.c
> index 9bdd5bf2eb99..d38bfc6113e8 100644
> --- a/drivers/staging/comedi/drivers/dyna_pci10xx.c
> +++ b/drivers/staging/comedi/drivers/dyna_pci10xx.c
> @@ -106,10 +106,6 @@ static int dyna_pci10xx_insn_write_ao(struct comedi_device *dev,
> {
> struct dyna_pci10xx_private *devpriv = dev->private;
> int n;
> - unsigned int chan, range;
> -
> - chan = CR_CHAN(insn->chanspec);
> - range = range_codes_pci1050_ai[CR_RANGE((insn->chanspec))];
>
> mutex_lock(&devpriv->mutex);
> for (n = 0; n < insn->n; n++) {
That seems fine, thanks. The lines being removed appear to have been
copy and pasted from dyna_pci10xx_insn_read_ai(). The AO subdevice
supports a single range, so no 'range' code is needed. I believe the
card has only one analog output channel[*], so the 'chan' is irrelevant.
This means the 'n_chans' value in the AO subdevice configuration is
incorrect. I'll send a follow-up patch to correct that after Greg KH
takes this one.
[*] Very little information seems to be available about this card
online. It is no longer listed on the manufacturer's web-site and I
couldn't find any archives on archive.org. I found part of a scientific
paper
<http://shodhganga.inflibnet.ac.in/bitstream/10603/150646/15/15_chapter%205.pdf>
which describes the card as having a single channel D/A converter.
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
--
-=( Ian Abbott <abbotti@mev.co.uk> || Web: www.mev.co.uk )=-
-=( MEV Ltd. is a company registered in England & Wales. )=-
-=( Registered number: 02862268. Registered address: )=-
-=( 15 West Park Road, Bramhall, STOCKPORT, SK7 3JZ, UK. )=-
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-04-06 10:13 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-06 2:57 [PATCH -next] staging: comedi: dyna_pci10xx: remove set but not used variables 'chan' and range' YueHaibing
2019-04-06 3:07 ` YueHaibing
2019-04-06 8:20 ` Mukesh Ojha
2019-04-06 8:32 ` Mukesh Ojha
2019-04-06 10:13 ` Ian Abbott
2019-04-06 10:13 ` Ian Abbott
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.