* [PATCH 1/3] mfd: lp87565: fix typo in define names
@ 2021-02-19 22:39 Luca Ceresoli
2021-02-19 22:39 ` [PATCH 2/3] mfd: lp87565: remove unused define Luca Ceresoli
` (4 more replies)
0 siblings, 5 replies; 12+ messages in thread
From: Luca Ceresoli @ 2021-02-19 22:39 UTC (permalink / raw)
To: Lee Jones
Cc: Luca Ceresoli, Linus Walleij, Bartosz Golaszewski, Liam Girdwood,
Mark Brown, linux-gpio, linux-kernel
"GOIO" should be "GPIO" here.
Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
---
drivers/gpio/gpio-lp87565.c | 6 +++---
include/linux/mfd/lp87565.h | 28 ++++++++++++++--------------
2 files changed, 17 insertions(+), 17 deletions(-)
diff --git a/drivers/gpio/gpio-lp87565.c b/drivers/gpio/gpio-lp87565.c
index e1244520cf7d..fcde6708b5df 100644
--- a/drivers/gpio/gpio-lp87565.c
+++ b/drivers/gpio/gpio-lp87565.c
@@ -123,14 +123,14 @@ static int lp87565_gpio_set_config(struct gpio_chip *gc, unsigned int offset,
return regmap_update_bits(gpio->map,
LP87565_REG_GPIO_CONFIG,
BIT(offset +
- __ffs(LP87565_GOIO1_OD)),
+ __ffs(LP87565_GPIO1_OD)),
BIT(offset +
- __ffs(LP87565_GOIO1_OD)));
+ __ffs(LP87565_GPIO1_OD)));
case PIN_CONFIG_DRIVE_PUSH_PULL:
return regmap_update_bits(gpio->map,
LP87565_REG_GPIO_CONFIG,
BIT(offset +
- __ffs(LP87565_GOIO1_OD)), 0);
+ __ffs(LP87565_GPIO1_OD)), 0);
default:
return -ENOTSUPP;
}
diff --git a/include/linux/mfd/lp87565.h b/include/linux/mfd/lp87565.h
index d44ddfb6bb63..2620554f357a 100644
--- a/include/linux/mfd/lp87565.h
+++ b/include/linux/mfd/lp87565.h
@@ -222,20 +222,20 @@ enum lp87565_device_type {
#define LP87565_GPIO2_SEL BIT(1)
#define LP87565_GPIO1_SEL BIT(0)
-#define LP87565_GOIO3_OD BIT(6)
-#define LP87565_GOIO2_OD BIT(5)
-#define LP87565_GOIO1_OD BIT(4)
-#define LP87565_GOIO3_DIR BIT(2)
-#define LP87565_GOIO2_DIR BIT(1)
-#define LP87565_GOIO1_DIR BIT(0)
-
-#define LP87565_GOIO3_IN BIT(2)
-#define LP87565_GOIO2_IN BIT(1)
-#define LP87565_GOIO1_IN BIT(0)
-
-#define LP87565_GOIO3_OUT BIT(2)
-#define LP87565_GOIO2_OUT BIT(1)
-#define LP87565_GOIO1_OUT BIT(0)
+#define LP87565_GPIO3_OD BIT(6)
+#define LP87565_GPIO2_OD BIT(5)
+#define LP87565_GPIO1_OD BIT(4)
+#define LP87565_GPIO3_DIR BIT(2)
+#define LP87565_GPIO2_DIR BIT(1)
+#define LP87565_GPIO1_DIR BIT(0)
+
+#define LP87565_GPIO3_IN BIT(2)
+#define LP87565_GPIO2_IN BIT(1)
+#define LP87565_GPIO1_IN BIT(0)
+
+#define LP87565_GPIO3_OUT BIT(2)
+#define LP87565_GPIO2_OUT BIT(1)
+#define LP87565_GPIO1_OUT BIT(0)
/* Number of step-down converters available */
#define LP87565_NUM_BUCK 6
--
2.30.0
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 2/3] mfd: lp87565: remove unused define
2021-02-19 22:39 [PATCH 1/3] mfd: lp87565: fix typo in define names Luca Ceresoli
@ 2021-02-19 22:39 ` Luca Ceresoli
2021-03-08 14:07 ` Lee Jones
2021-02-19 22:39 ` [PATCH 3/3] mfd: lp87565: move LP87565_regulator_id to .c file Luca Ceresoli
` (3 subsequent siblings)
4 siblings, 1 reply; 12+ messages in thread
From: Luca Ceresoli @ 2021-02-19 22:39 UTC (permalink / raw)
To: Lee Jones
Cc: Luca Ceresoli, Linus Walleij, Bartosz Golaszewski, Liam Girdwood,
Mark Brown, linux-gpio, linux-kernel
This define appears incorrect, but it is completely unused so it can be
removed.
Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
---
include/linux/mfd/lp87565.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/include/linux/mfd/lp87565.h b/include/linux/mfd/lp87565.h
index 2620554f357a..a8799ae50dcf 100644
--- a/include/linux/mfd/lp87565.h
+++ b/include/linux/mfd/lp87565.h
@@ -237,9 +237,6 @@ enum lp87565_device_type {
#define LP87565_GPIO2_OUT BIT(1)
#define LP87565_GPIO1_OUT BIT(0)
-/* Number of step-down converters available */
-#define LP87565_NUM_BUCK 6
-
enum LP87565_regulator_id {
/* BUCK's */
LP87565_BUCK_0,
--
2.30.0
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 3/3] mfd: lp87565: move LP87565_regulator_id to .c file
2021-02-19 22:39 [PATCH 1/3] mfd: lp87565: fix typo in define names Luca Ceresoli
2021-02-19 22:39 ` [PATCH 2/3] mfd: lp87565: remove unused define Luca Ceresoli
@ 2021-02-19 22:39 ` Luca Ceresoli
2021-03-08 14:07 ` Lee Jones
2021-03-08 14:04 ` [PATCH 1/3] mfd: lp87565: fix typo in define names Lee Jones
` (2 subsequent siblings)
4 siblings, 1 reply; 12+ messages in thread
From: Luca Ceresoli @ 2021-02-19 22:39 UTC (permalink / raw)
To: Lee Jones
Cc: Luca Ceresoli, Linus Walleij, Bartosz Golaszewski, Liam Girdwood,
Mark Brown, linux-gpio, linux-kernel
This enum is used only internally to the regulator driver for buck indexes.
Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
---
drivers/regulator/lp87565-regulator.c | 11 +++++++++++
include/linux/mfd/lp87565.h | 11 -----------
2 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/regulator/lp87565-regulator.c b/drivers/regulator/lp87565-regulator.c
index eeab9d3c824b..d059ae85047a 100644
--- a/drivers/regulator/lp87565-regulator.c
+++ b/drivers/regulator/lp87565-regulator.c
@@ -11,6 +11,17 @@
#include <linux/mfd/lp87565.h>
+enum LP87565_regulator_id {
+ /* BUCK's */
+ LP87565_BUCK_0,
+ LP87565_BUCK_1,
+ LP87565_BUCK_2,
+ LP87565_BUCK_3,
+ LP87565_BUCK_10,
+ LP87565_BUCK_23,
+ LP87565_BUCK_3210,
+};
+
#define LP87565_REGULATOR(_name, _id, _of, _ops, _n, _vr, _vm, \
_er, _em, _ev, _delay, _lr, _cr) \
[_id] = { \
diff --git a/include/linux/mfd/lp87565.h b/include/linux/mfd/lp87565.h
index a8799ae50dcf..94cb581af34b 100644
--- a/include/linux/mfd/lp87565.h
+++ b/include/linux/mfd/lp87565.h
@@ -237,17 +237,6 @@ enum lp87565_device_type {
#define LP87565_GPIO2_OUT BIT(1)
#define LP87565_GPIO1_OUT BIT(0)
-enum LP87565_regulator_id {
- /* BUCK's */
- LP87565_BUCK_0,
- LP87565_BUCK_1,
- LP87565_BUCK_2,
- LP87565_BUCK_3,
- LP87565_BUCK_10,
- LP87565_BUCK_23,
- LP87565_BUCK_3210,
-};
-
/**
* struct LP87565 - state holder for the LP87565 driver
* @dev: struct device pointer for MFD device
--
2.30.0
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH 1/3] mfd: lp87565: fix typo in define names
2021-02-19 22:39 [PATCH 1/3] mfd: lp87565: fix typo in define names Luca Ceresoli
2021-02-19 22:39 ` [PATCH 2/3] mfd: lp87565: remove unused define Luca Ceresoli
2021-02-19 22:39 ` [PATCH 3/3] mfd: lp87565: move LP87565_regulator_id to .c file Luca Ceresoli
@ 2021-03-08 14:04 ` Lee Jones
2021-05-12 9:17 ` Luca Ceresoli
2021-03-08 14:59 ` Bartosz Golaszewski
2021-05-19 12:35 ` [GIT PULL] Immutable branch between MFD, GPIO and Regulator due for the v5.14 merge window Lee Jones
4 siblings, 1 reply; 12+ messages in thread
From: Lee Jones @ 2021-03-08 14:04 UTC (permalink / raw)
To: Luca Ceresoli
Cc: Linus Walleij, Bartosz Golaszewski, Liam Girdwood, Mark Brown,
linux-gpio, linux-kernel
On Fri, 19 Feb 2021, Luca Ceresoli wrote:
> "GOIO" should be "GPIO" here.
>
> Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
> ---
> drivers/gpio/gpio-lp87565.c | 6 +++---
> include/linux/mfd/lp87565.h | 28 ++++++++++++++--------------
> 2 files changed, 17 insertions(+), 17 deletions(-)
For my own reference (apply this as-is to your sign-off block):
Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 2/3] mfd: lp87565: remove unused define
2021-02-19 22:39 ` [PATCH 2/3] mfd: lp87565: remove unused define Luca Ceresoli
@ 2021-03-08 14:07 ` Lee Jones
0 siblings, 0 replies; 12+ messages in thread
From: Lee Jones @ 2021-03-08 14:07 UTC (permalink / raw)
To: Luca Ceresoli
Cc: Linus Walleij, Bartosz Golaszewski, Liam Girdwood, Mark Brown,
linux-gpio, linux-kernel
On Fri, 19 Feb 2021, Luca Ceresoli wrote:
> This define appears incorrect, but it is completely unused so it can be
> removed.
>
> Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
> ---
> include/linux/mfd/lp87565.h | 3 ---
> 1 file changed, 3 deletions(-)
Applied, thanks.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 3/3] mfd: lp87565: move LP87565_regulator_id to .c file
2021-02-19 22:39 ` [PATCH 3/3] mfd: lp87565: move LP87565_regulator_id to .c file Luca Ceresoli
@ 2021-03-08 14:07 ` Lee Jones
0 siblings, 0 replies; 12+ messages in thread
From: Lee Jones @ 2021-03-08 14:07 UTC (permalink / raw)
To: Luca Ceresoli
Cc: Linus Walleij, Bartosz Golaszewski, Liam Girdwood, Mark Brown,
linux-gpio, linux-kernel
On Fri, 19 Feb 2021, Luca Ceresoli wrote:
> This enum is used only internally to the regulator driver for buck indexes.
>
> Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
> ---
> drivers/regulator/lp87565-regulator.c | 11 +++++++++++
> include/linux/mfd/lp87565.h | 11 -----------
> 2 files changed, 11 insertions(+), 11 deletions(-)
For my own reference (apply this as-is to your sign-off block):
Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/3] mfd: lp87565: fix typo in define names
2021-02-19 22:39 [PATCH 1/3] mfd: lp87565: fix typo in define names Luca Ceresoli
` (2 preceding siblings ...)
2021-03-08 14:04 ` [PATCH 1/3] mfd: lp87565: fix typo in define names Lee Jones
@ 2021-03-08 14:59 ` Bartosz Golaszewski
2021-05-12 10:00 ` Lee Jones
2021-05-19 12:35 ` [GIT PULL] Immutable branch between MFD, GPIO and Regulator due for the v5.14 merge window Lee Jones
4 siblings, 1 reply; 12+ messages in thread
From: Bartosz Golaszewski @ 2021-03-08 14:59 UTC (permalink / raw)
To: Luca Ceresoli
Cc: Lee Jones, Linus Walleij, Liam Girdwood, Mark Brown, linux-gpio, LKML
On Fri, Feb 19, 2021 at 11:39 PM Luca Ceresoli <luca@lucaceresoli.net> wrote:
>
> "GOIO" should be "GPIO" here.
>
> Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
> ---
For GPIO part:
Acked-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/3] mfd: lp87565: fix typo in define names
2021-03-08 14:04 ` [PATCH 1/3] mfd: lp87565: fix typo in define names Lee Jones
@ 2021-05-12 9:17 ` Luca Ceresoli
2021-05-12 9:59 ` Lee Jones
0 siblings, 1 reply; 12+ messages in thread
From: Luca Ceresoli @ 2021-05-12 9:17 UTC (permalink / raw)
To: Lee Jones
Cc: Linus Walleij, Bartosz Golaszewski, Liam Girdwood, Mark Brown,
linux-gpio, linux-kernel
Hi,
On 08/03/21 15:04, Lee Jones wrote:
> On Fri, 19 Feb 2021, Luca Ceresoli wrote:
>
>> "GOIO" should be "GPIO" here.
>>
>> Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
>> ---
>> drivers/gpio/gpio-lp87565.c | 6 +++---
>> include/linux/mfd/lp87565.h | 28 ++++++++++++++--------------
>> 2 files changed, 17 insertions(+), 17 deletions(-)
>
> For my own reference (apply this as-is to your sign-off block):
>
> Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>
Gentle ping on patches 1 and 3. Both have at least an ack and are fairly
trivial. Both apply cleanly on current master.
Thanks.
--
Luca
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/3] mfd: lp87565: fix typo in define names
2021-05-12 9:17 ` Luca Ceresoli
@ 2021-05-12 9:59 ` Lee Jones
2021-05-12 11:01 ` Luca Ceresoli
0 siblings, 1 reply; 12+ messages in thread
From: Lee Jones @ 2021-05-12 9:59 UTC (permalink / raw)
To: Luca Ceresoli
Cc: Linus Walleij, Bartosz Golaszewski, Liam Girdwood, Mark Brown,
linux-gpio, linux-kernel
On Wed, 12 May 2021, Luca Ceresoli wrote:
> Hi,
>
> On 08/03/21 15:04, Lee Jones wrote:
> > On Fri, 19 Feb 2021, Luca Ceresoli wrote:
> >
> >> "GOIO" should be "GPIO" here.
> >>
> >> Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
> >> ---
> >> drivers/gpio/gpio-lp87565.c | 6 +++---
> >> include/linux/mfd/lp87565.h | 28 ++++++++++++++--------------
> >> 2 files changed, 17 insertions(+), 17 deletions(-)
> >
> > For my own reference (apply this as-is to your sign-off block):
> >
> > Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>
>
> Gentle ping on patches 1 and 3. Both have at least an ack and are fairly
> trivial. Both apply cleanly on current master.
I'll take care of these this time, but in future, if you don't receive
further responses for ~2 weeks, you should collect all of the Acks and
submit a [RESEND].
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/3] mfd: lp87565: fix typo in define names
2021-03-08 14:59 ` Bartosz Golaszewski
@ 2021-05-12 10:00 ` Lee Jones
0 siblings, 0 replies; 12+ messages in thread
From: Lee Jones @ 2021-05-12 10:00 UTC (permalink / raw)
To: Bartosz Golaszewski
Cc: Luca Ceresoli, Linus Walleij, Liam Girdwood, Mark Brown,
linux-gpio, LKML
On Mon, 08 Mar 2021, Bartosz Golaszewski wrote:
> On Fri, Feb 19, 2021 at 11:39 PM Luca Ceresoli <luca@lucaceresoli.net> wrote:
> >
> > "GOIO" should be "GPIO" here.
> >
> > Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
> > ---
>
> For GPIO part:
>
> Acked-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Do you require a pull-request from an immutable branch?
Or can I just take these as-is?
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/3] mfd: lp87565: fix typo in define names
2021-05-12 9:59 ` Lee Jones
@ 2021-05-12 11:01 ` Luca Ceresoli
0 siblings, 0 replies; 12+ messages in thread
From: Luca Ceresoli @ 2021-05-12 11:01 UTC (permalink / raw)
To: Lee Jones
Cc: Linus Walleij, Bartosz Golaszewski, Liam Girdwood, Mark Brown,
linux-gpio, linux-kernel
Hi Lee,
On 12/05/21 11:59, Lee Jones wrote:
> On Wed, 12 May 2021, Luca Ceresoli wrote:
>
>> Hi,
>>
>> On 08/03/21 15:04, Lee Jones wrote:
>>> On Fri, 19 Feb 2021, Luca Ceresoli wrote:
>>>
>>>> "GOIO" should be "GPIO" here.
>>>>
>>>> Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
>>>> ---
>>>> drivers/gpio/gpio-lp87565.c | 6 +++---
>>>> include/linux/mfd/lp87565.h | 28 ++++++++++++++--------------
>>>> 2 files changed, 17 insertions(+), 17 deletions(-)
>>>
>>> For my own reference (apply this as-is to your sign-off block):
>>>
>>> Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>
>>
>> Gentle ping on patches 1 and 3. Both have at least an ack and are fairly
>> trivial. Both apply cleanly on current master.
>
> I'll take care of these this time, but in future, if you don't receive
> further responses for ~2 weeks, you should collect all of the Acks and
> submit a [RESEND].
Apologies, I'll try to remember next time. Thanks for taking care of them.
--
Luca
^ permalink raw reply [flat|nested] 12+ messages in thread
* [GIT PULL] Immutable branch between MFD, GPIO and Regulator due for the v5.14 merge window
2021-02-19 22:39 [PATCH 1/3] mfd: lp87565: fix typo in define names Luca Ceresoli
` (3 preceding siblings ...)
2021-03-08 14:59 ` Bartosz Golaszewski
@ 2021-05-19 12:35 ` Lee Jones
4 siblings, 0 replies; 12+ messages in thread
From: Lee Jones @ 2021-05-19 12:35 UTC (permalink / raw)
To: Luca Ceresoli
Cc: Linus Walleij, Bartosz Golaszewski, Liam Girdwood, Mark Brown,
linux-gpio, linux-kernel
Enjoy!
The following changes since commit 6efb943b8616ec53a5e444193dccf1af9ad627b5:
Linux 5.13-rc1 (2021-05-09 14:17:44 -0700)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git tb-mfd-gpio-regulator-v5.14
for you to fetch changes up to 5258f7eed42f4565d065726fd82d3430dd618a68:
mfd: lp87565: Move LP87565_regulator_id to .c file (2021-05-19 13:34:00 +0100)
----------------------------------------------------------------
Immutable branch between MFD, GPIO and Regulator due for the v5.14 merge window
----------------------------------------------------------------
Luca Ceresoli (2):
mfd: lp87565: Fix typo in define names
mfd: lp87565: Move LP87565_regulator_id to .c file
drivers/gpio/gpio-lp87565.c | 6 +++---
drivers/regulator/lp87565-regulator.c | 11 ++++++++++
include/linux/mfd/lp87565.h | 39 +++++++++++++----------------------
3 files changed, 28 insertions(+), 28 deletions(-)
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2021-05-19 12:35 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-19 22:39 [PATCH 1/3] mfd: lp87565: fix typo in define names Luca Ceresoli
2021-02-19 22:39 ` [PATCH 2/3] mfd: lp87565: remove unused define Luca Ceresoli
2021-03-08 14:07 ` Lee Jones
2021-02-19 22:39 ` [PATCH 3/3] mfd: lp87565: move LP87565_regulator_id to .c file Luca Ceresoli
2021-03-08 14:07 ` Lee Jones
2021-03-08 14:04 ` [PATCH 1/3] mfd: lp87565: fix typo in define names Lee Jones
2021-05-12 9:17 ` Luca Ceresoli
2021-05-12 9:59 ` Lee Jones
2021-05-12 11:01 ` Luca Ceresoli
2021-03-08 14:59 ` Bartosz Golaszewski
2021-05-12 10:00 ` Lee Jones
2021-05-19 12:35 ` [GIT PULL] Immutable branch between MFD, GPIO and Regulator due for the v5.14 merge window Lee Jones
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.