* [3.7-rc6] Build failure with scripts/Makefile.headersinst
@ 2012-11-17 13:27 Tetsuo Handa
2012-11-18 13:53 ` David Howells
2012-11-19 11:10 ` David Howells
0 siblings, 2 replies; 12+ messages in thread
From: Tetsuo Handa @ 2012-11-17 13:27 UTC (permalink / raw)
To: dhowells; +Cc: arnd, tglx, paulmck, davej, linux-kernel
I get build error which complains that include/uapi/asm-generic/auxvec.h is
missing although the file exists. I'm using gcc 3.3.5.
This bug seems to not happen with gcc 4.x.
# make
make[1]: Nothing to be done for `all'.
make[1]: Nothing to be done for `relocs'.
CHK include/generated/uapi/linux/version.h
CHK include/generated/utsrelease.h
CALL scripts/checksyscalls.sh
CHK include/generated/compile.h
make[3]: `arch/x86/realmode/rm/realmode.bin' is up to date.
CHK include/generated/uapi/linux/version.h
make[2]: Nothing to be done for `all'.
make[2]: Nothing to be done for `relocs'.
/usr/src/all/linux/scripts/Makefile.headersinst:50: *** Missing UAPI file /usr/src/all/linux/include/uapi/asm-generic/auxvec.h. Stop.
make[2]: *** [asm-generic] Error 2
make[1]: *** [headers_install] Error 2
make: *** [vmlinux] Error 2
# ls -l /usr/src/all/linux/include/uapi/asm-generic/auxvec.h
-rw-r--r-- 1 root root 218 Oct 20 14:56 /usr/src/all/linux/include/uapi/asm-generic/auxvec.h
Linux 3.6 builds fine. I can't use "git bisect" until Linux 3.7-rc6 but
possibly caused by either commit 10b63956 "UAPI: Plumb the UAPI Kbuilds into
the user header installation and checking" or commit 40f1d4c2 "UAPI: Remove the
objhdr-y export list".
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [3.7-rc6] Build failure with scripts/Makefile.headersinst
2012-11-17 13:27 [3.7-rc6] Build failure with scripts/Makefile.headersinst Tetsuo Handa
@ 2012-11-18 13:53 ` David Howells
2012-11-18 15:14 ` Tetsuo Handa
2012-11-19 11:10 ` David Howells
1 sibling, 1 reply; 12+ messages in thread
From: David Howells @ 2012-11-18 13:53 UTC (permalink / raw)
To: Tetsuo Handa; +Cc: dhowells, arnd, tglx, paulmck, davej, linux-kernel
Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> wrote:
> I get build error which complains that include/uapi/asm-generic/auxvec.h is
> missing although the file exists. I'm using gcc 3.3.5.
> This bug seems to not happen with gcc 4.x.
What configuration?
David
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [3.7-rc6] Build failure with scripts/Makefile.headersinst
2012-11-18 13:53 ` David Howells
@ 2012-11-18 15:14 ` Tetsuo Handa
0 siblings, 0 replies; 12+ messages in thread
From: Tetsuo Handa @ 2012-11-18 15:14 UTC (permalink / raw)
To: dhowells; +Cc: arnd, tglx, paulmck, davej, linux-kernel
David Howells wrote:
> Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> wrote:
>
> > I get build error which complains that include/uapi/asm-generic/auxvec.h is
> > missing although the file exists. I'm using gcc 3.3.5.
> > This bug seems to not happen with gcc 4.x.
>
> What configuration?
>
> David
>
It is available at http://I-love.SAKURA.ne.jp/tmp/config-3.7-rc6 .
Workaround is to change to CONFIG_HEADERS_CHECK=n.
Regards.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [3.7-rc6] Build failure with scripts/Makefile.headersinst
2012-11-17 13:27 [3.7-rc6] Build failure with scripts/Makefile.headersinst Tetsuo Handa
2012-11-18 13:53 ` David Howells
@ 2012-11-19 11:10 ` David Howells
2012-11-19 13:02 ` Tetsuo Handa
[not found] ` <26846.1353334165@warthog.procyon.org.uk>
1 sibling, 2 replies; 12+ messages in thread
From: David Howells @ 2012-11-19 11:10 UTC (permalink / raw)
To: Tetsuo Handa; +Cc: dhowells, arnd, tglx, paulmck, davej, linux-kernel
Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> wrote:
> /usr/src/all/linux/scripts/Makefile.headersinst:50: *** Missing UAPI file /usr/src/all/linux/include/uapi/asm-generic/auxvec.h. Stop.
That line is here:
input-files := $(foreach hdr, $(header-y), \
$(or \
$(wildcard $(srcdir)/$(hdr)), \
$(wildcard $(oldsrcdir)/$(hdr)), \
---> $(error Missing UAPI file $(srcdir)/$(hdr)) \
)) \
$(foreach hdr, $(genhdr-y), \
$(or \
$(wildcard $(gendir)/$(hdr)), \
$(error Missing generated UAPI file $(gendir)/$(hdr)) \
))
The version of the compiler shouldn't have any effect as far as I can see.
Can you add the following:
$(info XXXX $(srcdir)/$(hdr)) \
$(info YYYY $(oldsrcdir)/$(hdr)) \
immediately before the marked line and look for the lines in the output from
make. The error suggests that neither pattern match worked.
Btw, are you supplying an O= flag to make when you build?
David
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [3.7-rc6] Build failure with scripts/Makefile.headersinst
2012-11-19 11:10 ` David Howells
@ 2012-11-19 13:02 ` Tetsuo Handa
[not found] ` <26846.1353334165@warthog.procyon.org.uk>
1 sibling, 0 replies; 12+ messages in thread
From: Tetsuo Handa @ 2012-11-19 13:02 UTC (permalink / raw)
To: dhowells; +Cc: arnd, tglx, paulmck, davej, linux-kernel
David Howells wrote:
> The version of the compiler shouldn't have any effect as far as I can see.
> Can you add the following:
>
> $(info XXXX $(srcdir)/$(hdr)) \
> $(info YYYY $(oldsrcdir)/$(hdr)) \
>
> immediately before the marked line and look for the lines in the output from
> make. The error suggests that neither pattern match worked.
Inserting
$(info XXXX $(srcdir)/$(hdr)), \
$(info YYYY $(oldsrcdir)/$(hdr)), \
did not work.
> Btw, are you supplying an O= flag to make when you build?
No. But supplying V=1 revealed that $(_dst) is an empty string at
# Recursion
hdr-inst := -rR -f $(srctree)/scripts/Makefile.headersinst obj
.PHONY: $(subdirs)
$(subdirs):
$(Q)$(MAKE) $(hdr-inst)=$(obj)/$@ dst=$(_dst)/$@
when using GNU Make 3.80, while $(_dst) contains appropriate string when using
GNU Make 3.81.
With Make 3.81:
make -f scripts/Makefile.build obj=scripts build_unifdef
make -rR -f /usr/src/all/linux/scripts/Makefile.headersinst obj=include/uapi
make -rR -f /usr/src/all/linux/scripts/Makefile.headersinst obj=include/uapi/asm-generic dst=include/uapi/asm-generic
make -rR -f /usr/src/all/linux/scripts/Makefile.headersinst obj=include/uapi/drm dst=include/uapi/drm
make -rR -f /usr/src/all/linux/scripts/Makefile.headersinst obj=include/uapi/linux dst=include/uapi/linux
make -rR -f /usr/src/all/linux/scripts/Makefile.headersinst obj=include/uapi/linux/byteorder dst=include/uapi/linux/byteorder
make -rR -f /usr/src/all/linux/scripts/Makefile.headersinst obj=include/uapi/linux/caif dst=include/uapi/linux/caif
(...snipped...)
With Make 3.80:
make -f scripts/Makefile.build obj=scripts build_unifdef
make -rR -f /usr/src/all/linux/scripts/Makefile.headersinst obj=include/uapi
make -rR -f /usr/src/all/linux/scripts/Makefile.headersinst obj=include/uapi/asm-generic dst=/asm-generic
/usr/src/all/linux/scripts/Makefile.headersinst:50: *** Missing UAPI file /usr/src/all/linux/include/uapi/asm-generic/auxvec.h. Stop.
make[2]: *** [asm-generic] Error 2
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [3.7-rc6] Build failure with scripts/Makefile.headersinst
[not found] ` <26846.1353334165@warthog.procyon.org.uk>
@ 2012-11-20 14:22 ` Tetsuo Handa
2012-11-25 9:02 ` Tetsuo Handa
2012-11-28 13:55 ` David Howells
0 siblings, 2 replies; 12+ messages in thread
From: Tetsuo Handa @ 2012-11-20 14:22 UTC (permalink / raw)
To: dhowells, sam; +Cc: arnd, tglx, paulmck, davej, linux-kernel
David Howells wrote:
> Does $(info ...) not work at all in version 3.80? If it does, can you get it
> to display the values $(destination-y), $(dst) and $(obj) at the top of
> Makefile.headersinst? If $(info ...) doesn't exist, does $(warning ...)?
$(info ...) does not work, but $(warning ...) works.
Debug print shows that command line variable "dst=" passed to
make -rR -f /usr/src/all/linux/scripts/Makefile.headersinst
line is wrong.
---------- debug print ----------
--- a/scripts/Makefile.headersinst
+++ b/scripts/Makefile.headersinst
@@ -7,6 +7,10 @@
#
# ==========================================================================
+$(warning DDDDD "$(destination-y)")
+$(warning EEEEE "$(dst)")
+$(warning FFFFF "$(obj)")
+
# called may set destination dir (when installing to asm/)
_dst := $(or $(destination-y),$(dst),$(obj))
---------- make 3.81 ----------
make -f scripts/Makefile.build obj=scripts build_unifdef
make -rR -f /usr/src/all/linux/scripts/Makefile.headersinst obj=include/uapi
/usr/src/all/linux/scripts/Makefile.headersinst:10: DDDDD ""
/usr/src/all/linux/scripts/Makefile.headersinst:11: EEEEE ""
/usr/src/all/linux/scripts/Makefile.headersinst:12: FFFFF "include/uapi"
make -rR -f /usr/src/all/linux/scripts/Makefile.headersinst obj=include/uapi/asm-generic dst=include/uapi/asm-generic
/usr/src/all/linux/scripts/Makefile.headersinst:10: DDDDD ""
/usr/src/all/linux/scripts/Makefile.headersinst:11: EEEEE "include/uapi/asm-generic"
/usr/src/all/linux/scripts/Makefile.headersinst:12: FFFFF "include/uapi/asm-generic"
make -rR -f /usr/src/all/linux/scripts/Makefile.headersinst obj=include/uapi/drm dst=include/uapi/drm
/usr/src/all/linux/scripts/Makefile.headersinst:10: DDDDD ""
/usr/src/all/linux/scripts/Makefile.headersinst:11: EEEEE "include/uapi/drm"
/usr/src/all/linux/scripts/Makefile.headersinst:12: FFFFF "include/uapi/drm"
---------- make 3.80 ----------
make -f scripts/Makefile.build obj=scripts build_unifdef
make -rR -f /usr/src/all/linux/scripts/Makefile.headersinst obj=include/uapi
/usr/src/all/linux/scripts/Makefile.headersinst:10: DDDDD ""
/usr/src/all/linux/scripts/Makefile.headersinst:11: EEEEE ""
/usr/src/all/linux/scripts/Makefile.headersinst:12: FFFFF "include/uapi"
make -rR -f /usr/src/all/linux/scripts/Makefile.headersinst obj=include/uapi/asm-generic dst=/asm-generic
/usr/src/all/linux/scripts/Makefile.headersinst:10: DDDDD ""
/usr/src/all/linux/scripts/Makefile.headersinst:11: EEEEE "/asm-generic"
/usr/src/all/linux/scripts/Makefile.headersinst:12: FFFFF "include/uapi/asm-generic"
/usr/src/all/linux/scripts/Makefile.headersinst:54: *** Missing UAPI file /usr/src/all/linux/include/uapi/asm-generic/auxvec.h. Stop.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [3.7-rc6] Build failure with scripts/Makefile.headersinst
2012-11-20 14:22 ` Tetsuo Handa
@ 2012-11-25 9:02 ` Tetsuo Handa
2012-11-28 13:55 ` David Howells
1 sibling, 0 replies; 12+ messages in thread
From: Tetsuo Handa @ 2012-11-25 9:02 UTC (permalink / raw)
To: dhowells, sam; +Cc: arnd, tglx, paulmck, davej, linux-kernel
Tetsuo Handa wrote:
> Linux 3.6 builds fine. I can't use "git bisect" until Linux 3.7-rc6 but
> possibly caused by either commit 10b63956 "UAPI: Plumb the UAPI Kbuilds into
> the user header installation and checking" or commit 40f1d4c2 "UAPI: Remove the
> objhdr-y export list".
Bisected to commit 10b63956 "UAPI: Plumb the UAPI Kbuilds into the user header
installation and checking".
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [3.7-rc6] Build failure with scripts/Makefile.headersinst
2012-11-20 14:22 ` Tetsuo Handa
2012-11-25 9:02 ` Tetsuo Handa
@ 2012-11-28 13:55 ` David Howells
2013-03-03 12:02 ` Sam Ravnborg
1 sibling, 1 reply; 12+ messages in thread
From: David Howells @ 2012-11-28 13:55 UTC (permalink / raw)
To: Tetsuo Handa, sam; +Cc: dhowells, arnd, tglx, paulmck, davej, linux-kernel
Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> wrote:
> Tetsuo Handa wrote:
> > Linux 3.6 builds fine. I can't use "git bisect" until Linux 3.7-rc6 but
> > possibly caused by either commit 10b63956 "UAPI: Plumb the UAPI Kbuilds
> > into the user header installation and checking" or commit 40f1d4c2 "UAPI:
> > Remove the objhdr-y export list".
>
> Bisected to commit 10b63956 "UAPI: Plumb the UAPI Kbuilds into the user header
> installation and checking".
Indeed, but that doesn't help much. The problem is that make's behaviour has
apparently changed. I could do with Sam Ravnborg's help to work around this
since I think he's mainly responsible for the Makefile infrastructure.
David
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [3.7-rc6] Build failure with scripts/Makefile.headersinst
2012-11-28 13:55 ` David Howells
@ 2013-03-03 12:02 ` Sam Ravnborg
2013-03-03 15:07 ` Tetsuo Handa
0 siblings, 1 reply; 12+ messages in thread
From: Sam Ravnborg @ 2013-03-03 12:02 UTC (permalink / raw)
To: David Howells; +Cc: Tetsuo Handa, arnd, tglx, paulmck, davej, linux-kernel
On Wed, Nov 28, 2012 at 01:55:14PM +0000, David Howells wrote:
> Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> wrote:
>
> > Tetsuo Handa wrote:
> > > Linux 3.6 builds fine. I can't use "git bisect" until Linux 3.7-rc6 but
> > > possibly caused by either commit 10b63956 "UAPI: Plumb the UAPI Kbuilds
> > > into the user header installation and checking" or commit 40f1d4c2 "UAPI:
> > > Remove the objhdr-y export list".
> >
> > Bisected to commit 10b63956 "UAPI: Plumb the UAPI Kbuilds into the user header
> > installation and checking".
>
> Indeed, but that doesn't help much. The problem is that make's behaviour has
> apparently changed. I could do with Sam Ravnborg's help to work around this
> since I think he's mainly responsible for the Makefile infrastructure.
Mical is the kbuild person these days.
Anyway - it this still relevant?
I took a quick look and my suspect is the use of $(or ..),
as this feature was added recently to make.
Sam
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [3.7-rc6] Build failure with scripts/Makefile.headersinst
2013-03-03 12:02 ` Sam Ravnborg
@ 2013-03-03 15:07 ` Tetsuo Handa
2013-03-03 15:34 ` Sam Ravnborg
0 siblings, 1 reply; 12+ messages in thread
From: Tetsuo Handa @ 2013-03-03 15:07 UTC (permalink / raw)
To: sam, dhowells, mmarek; +Cc: arnd, tglx, paulmck, davej, linux-kernel
Sam Ravnborg wrote:
> On Wed, Nov 28, 2012 at 01:55:14PM +0000, David Howells wrote:
> > Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> wrote:
> >
> > > Tetsuo Handa wrote:
> > > > Linux 3.6 builds fine. I can't use "git bisect" until Linux 3.7-rc6 but
> > > > possibly caused by either commit 10b63956 "UAPI: Plumb the UAPI Kbuilds
> > > > into the user header installation and checking" or commit 40f1d4c2 "UAPI:
> > > > Remove the objhdr-y export list".
> > >
> > > Bisected to commit 10b63956 "UAPI: Plumb the UAPI Kbuilds into the user header
> > > installation and checking".
> >
> > Indeed, but that doesn't help much. The problem is that make's behaviour has
> > apparently changed. I could do with Sam Ravnborg's help to work around this
> > since I think he's mainly responsible for the Makefile infrastructure.
>
> Mical is the kbuild person these days.
> Anyway - it this still relevant?
>
Yes, as of commit a7c1120d "Merge tag 'ext4_for_linus' of
git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4" in linux.git still
has this problem.
> I took a quick look and my suspect is the use of $(or ..),
> as this feature was added recently to make.
>
> Sam
>
Michal, this thread starts at https://lkml.org/lkml/2012/11/17/71 .
Regards.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [3.7-rc6] Build failure with scripts/Makefile.headersinst
2013-03-03 15:07 ` Tetsuo Handa
@ 2013-03-03 15:34 ` Sam Ravnborg
2013-03-03 22:03 ` Tetsuo Handa
0 siblings, 1 reply; 12+ messages in thread
From: Sam Ravnborg @ 2013-03-03 15:34 UTC (permalink / raw)
To: Tetsuo Handa; +Cc: dhowells, mmarek, arnd, tglx, paulmck, davej, linux-kernel
On Mon, Mar 04, 2013 at 12:07:31AM +0900, Tetsuo Handa wrote:
> Sam Ravnborg wrote:
> > On Wed, Nov 28, 2012 at 01:55:14PM +0000, David Howells wrote:
> > > Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> wrote:
> > >
> > > > Tetsuo Handa wrote:
> > > > > Linux 3.6 builds fine. I can't use "git bisect" until Linux 3.7-rc6 but
> > > > > possibly caused by either commit 10b63956 "UAPI: Plumb the UAPI Kbuilds
> > > > > into the user header installation and checking" or commit 40f1d4c2 "UAPI:
> > > > > Remove the objhdr-y export list".
> > > >
> > > > Bisected to commit 10b63956 "UAPI: Plumb the UAPI Kbuilds into the user header
> > > > installation and checking".
> > >
> > > Indeed, but that doesn't help much. The problem is that make's behaviour has
> > > apparently changed. I could do with Sam Ravnborg's help to work around this
> > > since I think he's mainly responsible for the Makefile infrastructure.
> >
> > Mical is the kbuild person these days.
> > Anyway - it this still relevant?
> >
> Yes, as of commit a7c1120d "Merge tag 'ext4_for_linus' of
> git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4" in linux.git still
> has this problem.
>
> > I took a quick look and my suspect is the use of $(or ..),
> > as this feature was added recently to make.
Hi Tetsuo.
If my guess is correct this patch should help.
I have gmake 3.81 and I do nto see the beforementioned problem.
Sam
diff --git a/scripts/Makefile.headersinst b/scripts/Makefile.headersinst
index 25f216a..477d137 100644
--- a/scripts/Makefile.headersinst
+++ b/scripts/Makefile.headersinst
@@ -14,7 +14,7 @@ kbuild-file := $(srctree)/$(obj)/Kbuild
include $(kbuild-file)
# called may set destination dir (when installing to asm/)
-_dst := $(or $(destination-y),$(dst),$(obj))
+_dst := $(if $(destination-y),$(destination-y),$(if $(dst),$(dst),$(obj)))
old-kbuild-file := $(srctree)/$(subst uapi/,,$(obj))/Kbuild
ifneq ($(wildcard $(old-kbuild-file)),)
@@ -48,13 +48,14 @@ all-files := $(header-y) $(genhdr-y) $(wrapper-files)
output-files := $(addprefix $(installdir)/, $(all-files))
input-files := $(foreach hdr, $(header-y), \
- $(or \
+ $(if $(wildcard $(srcdir)/$(hdr)), \
$(wildcard $(srcdir)/$(hdr)), \
- $(wildcard $(oldsrcdir)/$(hdr)), \
- $(error Missing UAPI file $(srcdir)/$(hdr)) \
+ $(if $(wildcard $(oldsrcdir)/$(hdr)), \
+ $(wildcard $(oldsrcdir)/$(hdr)), \
+ $(error Missing UAPI file $(srcdir)/$(hdr))) \
)) \
$(foreach hdr, $(genhdr-y), \
- $(or \
+ $(if $(wildcard $(gendir)/$(hdr)), \
$(wildcard $(gendir)/$(hdr)), \
$(error Missing generated UAPI file $(gendir)/$(hdr)) \
))
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [3.7-rc6] Build failure with scripts/Makefile.headersinst
2013-03-03 15:34 ` Sam Ravnborg
@ 2013-03-03 22:03 ` Tetsuo Handa
0 siblings, 0 replies; 12+ messages in thread
From: Tetsuo Handa @ 2013-03-03 22:03 UTC (permalink / raw)
To: sam; +Cc: dhowells, mmarek, arnd, tglx, paulmck, davej, linux-kernel
Sam Ravnborg wrote:
> On Mon, Mar 04, 2013 at 12:07:31AM +0900, Tetsuo Handa wrote:
> > Sam Ravnborg wrote:
> > > On Wed, Nov 28, 2012 at 01:55:14PM +0000, David Howells wrote:
> > > > Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> wrote:
> > > >
> > > > > Tetsuo Handa wrote:
> > > > > > Linux 3.6 builds fine. I can't use "git bisect" until Linux 3.7-rc6 but
> > > > > > possibly caused by either commit 10b63956 "UAPI: Plumb the UAPI Kbuilds
> > > > > > into the user header installation and checking" or commit 40f1d4c2 "UAPI:
> > > > > > Remove the objhdr-y export list".
> > > > >
> > > > > Bisected to commit 10b63956 "UAPI: Plumb the UAPI Kbuilds into the user header
> > > > > installation and checking".
> > > >
> > > > Indeed, but that doesn't help much. The problem is that make's behaviour has
> > > > apparently changed. I could do with Sam Ravnborg's help to work around this
> > > > since I think he's mainly responsible for the Makefile infrastructure.
> > >
> > > Mical is the kbuild person these days.
> > > Anyway - it this still relevant?
> > >
> > Yes, as of commit a7c1120d "Merge tag 'ext4_for_linus' of
> > git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4" in linux.git still
> > has this problem.
> >
> > > I took a quick look and my suspect is the use of $(or ..),
> > > as this feature was added recently to make.
>
> Hi Tetsuo.
>
> If my guess is correct this patch should help.
> I have gmake 3.81 and I do nto see the beforementioned problem.
Yes, I'm using 3.80 and this patch fixes my problem. Thank you.
>
> Sam
>
> diff --git a/scripts/Makefile.headersinst b/scripts/Makefile.headersinst
> index 25f216a..477d137 100644
> --- a/scripts/Makefile.headersinst
> +++ b/scripts/Makefile.headersinst
> @@ -14,7 +14,7 @@ kbuild-file := $(srctree)/$(obj)/Kbuild
> include $(kbuild-file)
>
> # called may set destination dir (when installing to asm/)
> -_dst := $(or $(destination-y),$(dst),$(obj))
> +_dst := $(if $(destination-y),$(destination-y),$(if $(dst),$(dst),$(obj)))
>
> old-kbuild-file := $(srctree)/$(subst uapi/,,$(obj))/Kbuild
> ifneq ($(wildcard $(old-kbuild-file)),)
> @@ -48,13 +48,14 @@ all-files := $(header-y) $(genhdr-y) $(wrapper-files)
> output-files := $(addprefix $(installdir)/, $(all-files))
>
> input-files := $(foreach hdr, $(header-y), \
> - $(or \
> + $(if $(wildcard $(srcdir)/$(hdr)), \
> $(wildcard $(srcdir)/$(hdr)), \
> - $(wildcard $(oldsrcdir)/$(hdr)), \
> - $(error Missing UAPI file $(srcdir)/$(hdr)) \
> + $(if $(wildcard $(oldsrcdir)/$(hdr)), \
> + $(wildcard $(oldsrcdir)/$(hdr)), \
> + $(error Missing UAPI file $(srcdir)/$(hdr))) \
> )) \
> $(foreach hdr, $(genhdr-y), \
> - $(or \
> + $(if $(wildcard $(gendir)/$(hdr)), \
> $(wildcard $(gendir)/$(hdr)), \
> $(error Missing generated UAPI file $(gendir)/$(hdr)) \
> ))
>
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2013-03-03 22:03 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-11-17 13:27 [3.7-rc6] Build failure with scripts/Makefile.headersinst Tetsuo Handa
2012-11-18 13:53 ` David Howells
2012-11-18 15:14 ` Tetsuo Handa
2012-11-19 11:10 ` David Howells
2012-11-19 13:02 ` Tetsuo Handa
[not found] ` <26846.1353334165@warthog.procyon.org.uk>
2012-11-20 14:22 ` Tetsuo Handa
2012-11-25 9:02 ` Tetsuo Handa
2012-11-28 13:55 ` David Howells
2013-03-03 12:02 ` Sam Ravnborg
2013-03-03 15:07 ` Tetsuo Handa
2013-03-03 15:34 ` Sam Ravnborg
2013-03-03 22:03 ` Tetsuo Handa
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.