* [PATCH] x86emul: increase FPU save area in test harness/fuzzer
@ 2020-10-22 13:39 Jan Beulich
2020-10-22 13:55 ` Andrew Cooper
0 siblings, 1 reply; 2+ messages in thread
From: Jan Beulich @ 2020-10-22 13:39 UTC (permalink / raw)
To: xen-devel; +Cc: Andrew Cooper, Wei Liu, Roger Pau Monné
Running them on a system (or emulator) with AMX support requires this
to be quite a bit larger than 8k, to avoid triggering the assert() in
emul_test_init(). Bump all the way up to 16k right away.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
Intel's Software Development Emulator properly reports XSAVE-related AMX
CPUID data for Sapphire Rapids emulation as of 8.59.0.
--- a/tools/tests/x86_emulator/x86-emulate.c
+++ b/tools/tests/x86_emulator/x86-emulate.c
@@ -33,7 +33,7 @@
uint32_t mxcsr_mask = 0x0000ffbf;
struct cpuid_policy cp;
-static char fpu_save_area[4096] __attribute__((__aligned__((64))));
+static char fpu_save_area[0x4000] __attribute__((__aligned__((64))));
static bool use_xsave;
/*
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] x86emul: increase FPU save area in test harness/fuzzer
2020-10-22 13:39 [PATCH] x86emul: increase FPU save area in test harness/fuzzer Jan Beulich
@ 2020-10-22 13:55 ` Andrew Cooper
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Cooper @ 2020-10-22 13:55 UTC (permalink / raw)
To: Jan Beulich, xen-devel; +Cc: Wei Liu, Roger Pau Monné
On 22/10/2020 14:39, Jan Beulich wrote:
> Running them on a system (or emulator) with AMX support requires this
> to be quite a bit larger than 8k, to avoid triggering the assert() in
> emul_test_init(). Bump all the way up to 16k right away.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
> ---
> Intel's Software Development Emulator properly reports XSAVE-related AMX
> CPUID data for Sapphire Rapids emulation as of 8.59.0.
>
> --- a/tools/tests/x86_emulator/x86-emulate.c
> +++ b/tools/tests/x86_emulator/x86-emulate.c
> @@ -33,7 +33,7 @@
> uint32_t mxcsr_mask = 0x0000ffbf;
> struct cpuid_policy cp;
>
> -static char fpu_save_area[4096] __attribute__((__aligned__((64))));
> +static char fpu_save_area[0x4000] __attribute__((__aligned__((64))));
> static bool use_xsave;
>
> /*
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-22 13:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-22 13:39 [PATCH] x86emul: increase FPU save area in test harness/fuzzer Jan Beulich
2020-10-22 13:55 ` Andrew Cooper
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.