All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: John Snow <jsnow@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 6/6] ide: introduce ide_transfer_start_norecurse
Date: Mon, 4 Jun 2018 17:51:03 +0200	[thread overview]
Message-ID: <369237e8-a956-9e17-6f95-ff0e059f2591@redhat.com> (raw)
In-Reply-To: <c07b6574-b20b-28db-157d-15d882cd072c@redhat.com>

On 02/06/2018 03:17, John Snow wrote:
> 
> 
> On 04/17/2018 11:39 AM, Paolo Bonzini wrote:
>> For the case where the end_transfer_func is also the caller of
>> ide_transfer_start, the mutual recursion can lead to unlimited
>> stack usage.  Introduce a new version that can be used to change
>> tail recursion into a loop, and use it in trace_ide_atapi_cmd_reply_end.
> 
> probably you mean ide_atapi_cmd_reply_end

Yeah.  Cut-and-paste...

Paolo

>>
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> 
> Reviewed-by: John Snow <jsnow@redhat.com>
> 

      reply	other threads:[~2018-06-04 15:51 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-17 15:39 [Qemu-devel] [PATCH 0/6] atapi: change unlimited recursion to while loop Paolo Bonzini
2018-04-17 15:39 ` [Qemu-devel] [PATCH 1/6] ahci: move PIO Setup FIS before transfer, fix it for ATAPI commands Paolo Bonzini
2018-06-02  1:22   ` John Snow
2018-06-04 15:50     ` Paolo Bonzini
2018-06-04 23:27       ` John Snow
2018-06-06 13:44         ` Paolo Bonzini
2018-04-17 15:39 ` [Qemu-devel] [PATCH 2/6] ide: push end_transfer_func out of start_transfer callback, rename callback Paolo Bonzini
2018-06-02  0:24   ` John Snow
2018-06-04 15:48     ` Paolo Bonzini
2018-06-04 17:42       ` John Snow
2018-04-17 15:39 ` [Qemu-devel] [PATCH 3/6] ide: call ide_cmd_done from ide_transfer_stop Paolo Bonzini
2018-06-02  0:26   ` John Snow
2018-04-17 15:39 ` [Qemu-devel] [PATCH 4/6] ide: make ide_transfer_stop idempotent Paolo Bonzini
2018-06-02  0:28   ` John Snow
2018-04-17 15:39 ` [Qemu-devel] [PATCH 5/6] atapi: call ide_set_irq before ide_transfer_start Paolo Bonzini
2018-06-02  1:07   ` John Snow
2018-04-17 15:39 ` [Qemu-devel] [PATCH 6/6] ide: introduce ide_transfer_start_norecurse Paolo Bonzini
2018-06-02  1:17   ` John Snow
2018-06-04 15:51     ` Paolo Bonzini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=369237e8-a956-9e17-6f95-ff0e059f2591@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.