[dpdk-dev] [PATCH] kni: fix possible buffer overflow

[dpdk-dev] [PATCH] kni: fix possible buffer overflow

[Ferruh Yigit]

'kni_net_rx_lo_fifo()' can get segmented buffers, using 'pkt_len' for
that case will be wrong and some values can cause buffer overflow
in destination mbuf data.

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
 kernel/linux/kni/kni_net.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/linux/kni/kni_net.c b/kernel/linux/kni/kni_net.c
index ad8365877..84341ac92 100644
--- a/kernel/linux/kni/kni_net.c
+++ b/kernel/linux/kni/kni_net.c
@@ -435,7 +435,7 @@ kni_net_rx_lo_fifo(struct kni_dev *kni)
 		/* Copy mbufs */
 		for (i = 0; i < num; i++) {
 			kva = pa2kva(kni->pa[i]);
-			len = kva->pkt_len;
+			len = kva->data_len;
 			data_kva = kva2data_kva(kva);
 			kni->va[i] = pa2va(kni->pa[i], kva);
 
-- 
2.21.0

Re: [dpdk-dev] [PATCH] kni: fix possible buffer overflow

[Stephen Hemminger]

On Thu, 11 Jul 2019 13:35:07 +0100
Ferruh Yigit <ferruh.yigit@intel.com> wrote:

> 'kni_net_rx_lo_fifo()' can get segmented buffers, using 'pkt_len' for
> that case will be wrong and some values can cause buffer overflow
> in destination mbuf data.
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
>  kernel/linux/kni/kni_net.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/linux/kni/kni_net.c b/kernel/linux/kni/kni_net.c
> index ad8365877..84341ac92 100644
> --- a/kernel/linux/kni/kni_net.c
> +++ b/kernel/linux/kni/kni_net.c
> @@ -435,7 +435,7 @@ kni_net_rx_lo_fifo(struct kni_dev *kni)
>  		/* Copy mbufs */
>  		for (i = 0; i < num; i++) {
>  			kva = pa2kva(kni->pa[i]);
> -			len = kva->pkt_len;
> +			len = kva->data_len;
>  			data_kva = kva2data_kva(kva);
>  			kni->va[i] = pa2va(kni->pa[i], kva);
>  

Acked-by: Stephen Hemminger <stephen@networkplumber.org>

Re: [dpdk-dev] [PATCH] kni: fix possible buffer overflow

[Thomas Monjalon]

11/07/2019 17:33, Stephen Hemminger:
> On Thu, 11 Jul 2019 13:35:07 +0100
> Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> 
> > 'kni_net_rx_lo_fifo()' can get segmented buffers, using 'pkt_len' for
> > that case will be wrong and some values can cause buffer overflow
> > in destination mbuf data.
> > 
> > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 
> Acked-by: Stephen Hemminger <stephen@networkplumber.org>

Applied, thanks

Re: [dpdk-dev] [PATCH] kni: fix possible buffer overflow

[Thomas Monjalon]

18/07/2019 23:24, Thomas Monjalon:
> 11/07/2019 17:33, Stephen Hemminger:
> > On Thu, 11 Jul 2019 13:35:07 +0100
> > Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> > 
> > > 'kni_net_rx_lo_fifo()' can get segmented buffers, using 'pkt_len' for
> > > that case will be wrong and some values can cause buffer overflow
> > > in destination mbuf data.
> > > 
> > > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> > 
> > Acked-by: Stephen Hemminger <stephen@networkplumber.org>
> 
> Applied, thanks

I hope these lines are correct:

    Fixes: d89a58dfe90b ("kni: support chained mbufs")
    Cc: stable@dpdk.org

Re: [dpdk-dev] [PATCH] kni: fix possible buffer overflow

[Ferruh Yigit]

On 7/18/2019 10:35 PM, Thomas Monjalon wrote:
> 18/07/2019 23:24, Thomas Monjalon:
>> 11/07/2019 17:33, Stephen Hemminger:
>>> On Thu, 11 Jul 2019 13:35:07 +0100
>>> Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>>>
>>>> 'kni_net_rx_lo_fifo()' can get segmented buffers, using 'pkt_len' for
>>>> that case will be wrong and some values can cause buffer overflow
>>>> in destination mbuf data.
>>>>
>>>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>>>
>>> Acked-by: Stephen Hemminger <stephen@networkplumber.org>
>>
>> Applied, thanks
> 
> I hope these lines are correct:
> 
>     Fixes: d89a58dfe90b ("kni: support chained mbufs")
>     Cc: stable@dpdk.org

Thanks for updating it, even before this commit the related code was wrong I
think, but agree that this commit should have fixed it, so agreed with the fixes
line.