From: "Arnd Bergmann" <arnd@kernel.org>
To: "Jan Kiszka" <jan.kiszka@siemens.com>,
"Harald Mommer" <hmo@opensynergy.com>,
"Marc Kleine-Budde" <mkl@pengutronix.de>,
"Harald Mommer" <harald.mommer@opensynergy.com>
Cc: virtio-dev@lists.oasis-open.org, linux-can@vger.kernel.org,
Netdev <netdev@vger.kernel.org>,
linux-kernel@vger.kernel.org,
"Wolfgang Grandegger" <wg@grandegger.com>,
"David S . Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Dariusz Stojaczyk" <Dariusz.Stojaczyk@opensynergy.com>,
stratos-dev@op-lists.linaro.org
Subject: Re: [virtio-dev] Re: [RFC PATCH 1/1] can: virtio: Initial virtio CAN driver.
Date: Fri, 04 Nov 2022 18:03:50 +0100 [thread overview]
Message-ID: <36bb910c-4874-409b-ac71-d141cd1d8ecb@app.fastmail.com> (raw)
In-Reply-To: <c2c0ba34-2985-21ea-0809-b96a3aa5e401@siemens.com>
On Fri, Nov 4, 2022, at 16:32, Jan Kiszka wrote:
> On 03.11.22 14:55, Harald Mommer wrote:
>>
>> On 27.08.22 11:39, Marc Kleine-Budde wrote:
>>> Is there an Open Source implementation of the host side of this
>>> interface?
>> there is neither an open source device nor is it currently planned. The
>> device I'm developing is closed source.
>
> Likely not helpful long-term /wrt kernel QA - how should kernelci or
> others even have a chance to test the driver? Keep in mind that you are
> not proposing a specific driver for an Opensynergy hypervisor, rather
> for the open and vendor-agnostic virtio spec.
>
> But QEMU already supports both CAN and virtio, thus should be relatively
> easy to augment with this new device.
Agreed, either hooking into the qemu support, or having a separate
vhost-user backend that forwards data to the host stack would be
helpful here, in particular to see how the flow control works.
IIRC when we discussed virtio-can on the stratos list, one of the
issues that was pointed out was filtering of frames for specific
CAN IDs in the host socketcan for assigning individual IDs to
separate guests. It would be good to understand whether a generic
host implementation has the same problems, and what can be
done in socketcan to help with that.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: "Arnd Bergmann" <arnd@kernel.org>
To: Jan Kiszka <jan.kiszka@siemens.com>,
Harald Mommer <hmo@opensynergy.com>,
Marc Kleine-Budde <mkl@pengutronix.de>,
Harald Mommer <harald.mommer@opensynergy.com>
Cc: virtio-dev@lists.oasis-open.org, linux-can@vger.kernel.org,
Netdev <netdev@vger.kernel.org>,
linux-kernel@vger.kernel.org,
Wolfgang Grandegger <wg@grandegger.com>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Dariusz Stojaczyk <Dariusz.Stojaczyk@opensynergy.com>,
stratos-dev@op-lists.linaro.org
Subject: Re: [virtio-dev] Re: [RFC PATCH 1/1] can: virtio: Initial virtio CAN driver.
Date: Fri, 04 Nov 2022 18:03:50 +0100 [thread overview]
Message-ID: <36bb910c-4874-409b-ac71-d141cd1d8ecb@app.fastmail.com> (raw)
In-Reply-To: <c2c0ba34-2985-21ea-0809-b96a3aa5e401@siemens.com>
On Fri, Nov 4, 2022, at 16:32, Jan Kiszka wrote:
> On 03.11.22 14:55, Harald Mommer wrote:
>>
>> On 27.08.22 11:39, Marc Kleine-Budde wrote:
>>> Is there an Open Source implementation of the host side of this
>>> interface?
>> there is neither an open source device nor is it currently planned. The
>> device I'm developing is closed source.
>
> Likely not helpful long-term /wrt kernel QA - how should kernelci or
> others even have a chance to test the driver? Keep in mind that you are
> not proposing a specific driver for an Opensynergy hypervisor, rather
> for the open and vendor-agnostic virtio spec.
>
> But QEMU already supports both CAN and virtio, thus should be relatively
> easy to augment with this new device.
Agreed, either hooking into the qemu support, or having a separate
vhost-user backend that forwards data to the host stack would be
helpful here, in particular to see how the flow control works.
IIRC when we discussed virtio-can on the stratos list, one of the
issues that was pointed out was filtering of frames for specific
CAN IDs in the host socketcan for assigning individual IDs to
separate guests. It would be good to understand whether a generic
host implementation has the same problems, and what can be
done in socketcan to help with that.
Arnd
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
next prev parent reply other threads:[~2022-11-04 17:04 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-25 13:44 [RFC PATCH 1/1] can: virtio: Initial virtio CAN driver Harald Mommer
2022-08-25 13:44 ` [virtio-dev] " Harald Mommer
2022-08-25 18:21 ` Arnd Bergmann
2022-08-25 18:21 ` Arnd Bergmann
2022-11-03 12:26 ` Harald Mommer
2022-11-03 12:26 ` Harald Mommer
2022-11-04 10:50 ` Arnd Bergmann
2022-11-04 10:50 ` Arnd Bergmann
2022-11-05 9:21 ` Vincent Mailhol
2023-05-12 13:19 ` Harald Mommer
2023-05-12 13:19 ` Harald Mommer
2023-05-15 5:58 ` Vincent Mailhol
2023-05-23 13:39 ` Harald Mommer
2023-05-23 13:39 ` Harald Mommer
2022-08-27 9:02 ` Oliver Hartkopp
2022-11-03 13:02 ` Harald Mommer
2022-11-03 13:02 ` [virtio-dev] " Harald Mommer
2022-08-27 9:39 ` Marc Kleine-Budde
2022-08-27 9:39 ` [virtio-dev] " Marc Kleine-Budde
2022-08-27 11:12 ` Oliver Hartkopp
2022-11-03 13:55 ` Harald Mommer
2022-11-03 13:55 ` [virtio-dev] " Harald Mommer
2022-11-04 15:32 ` Jan Kiszka
2022-11-04 15:32 ` Jan Kiszka
2022-11-04 17:03 ` Arnd Bergmann [this message]
2022-11-04 17:03 ` Arnd Bergmann
2023-02-03 15:02 ` Harald Mommer
2023-02-03 15:02 ` Harald Mommer
2023-04-14 19:20 ` Marc Kleine-Budde
2023-04-18 9:50 ` Harald Mommer
2023-04-18 9:50 ` Harald Mommer
2023-04-18 12:06 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36bb910c-4874-409b-ac71-d141cd1d8ecb@app.fastmail.com \
--to=arnd@kernel.org \
--cc=Dariusz.Stojaczyk@opensynergy.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=harald.mommer@opensynergy.com \
--cc=hmo@opensynergy.com \
--cc=jan.kiszka@siemens.com \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stratos-dev@op-lists.linaro.org \
--cc=virtio-dev@lists.oasis-open.org \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.