From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> To: Rob Herring <robh@kernel.org> Cc: wim@linux-watchdog.org, linux@roeck-us.net, krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com, allen-kh.cheng@mediatek.com, seiya.wang@mediatek.com, tinghan.shen@mediatek.com, linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/5] dt-bindings: watchdog: mediatek: Convert mtk-wdt to json-schema Date: Wed, 5 Oct 2022 15:42:16 +0200 [thread overview] Message-ID: <36ca5e72-db5d-65f6-db2c-1f0066842d18@collabora.com> (raw) In-Reply-To: <20221005133848.GA3278938-robh@kernel.org> Il 05/10/22 15:38, Rob Herring ha scritto: > On Wed, Oct 05, 2022 at 01:35:15PM +0200, AngeloGioacchino Del Regno wrote: >> Convert the MediaTek watchdog bindings to schema. >> >> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> >> --- >> .../bindings/watchdog/mediatek,mtk-wdt.yaml | 80 +++++++++++++++++++ >> .../devicetree/bindings/watchdog/mtk-wdt.txt | 42 ---------- >> 2 files changed, 80 insertions(+), 42 deletions(-) >> create mode 100644 Documentation/devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml >> delete mode 100644 Documentation/devicetree/bindings/watchdog/mtk-wdt.txt >> >> diff --git a/Documentation/devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml b/Documentation/devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml >> new file mode 100644 >> index 000000000000..f43b5af92d40 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml >> @@ -0,0 +1,80 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/watchdog/mediatek,mtk-wdt.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: MediaTek SoCs Watchdog timer >> + >> +maintainers: >> + - Matthias Brugger <matthias.bgg@gmail.com> >> + >> +description: >> + The watchdog supports a pre-timeout interrupt that fires >> + timeout-sec/2 before the expiry. >> + >> +allOf: >> + - $ref: watchdog.yaml# >> + >> +properties: >> + compatible: >> + oneOf: >> + - items: >> + - enum: >> + - mediatek,mt2712-wdt >> + - mediatek,mt6589-wdt >> + - mediatek,mt7986-wdt >> + - mediatek,mt8183-wdt >> + - mediatek,mt8186-wdt >> + - mediatek,mt8192-wdt >> + - mediatek,mt8195-wdt > > The original binding only had 4 without a fallback. It's fine to add or > change, but note the changes in the commit msg. Are all of these really > each unique and not the same? > Ok I will note the changes in the commit for v2. And... yes, they're really each unique and not the same, as these are exposing a reset controller of their own (as well with different platform data in the driver). > >> + - items: >> + - enum: >> + - mediatek,mt2701-wdt >> + - mediatek,mt6582-wdt >> + - mediatek,mt6797-wdt >> + - mediatek,mt7622-wdt >> + - mediatek,mt7623-wdt >> + - mediatek,mt7629-wdt >> + - mediatek,mt8516-wdt >> + - const: mediatek,mt6589-wdt >> + >> + reg: >> + maxItems: 1 >> + >> + interrupts: >> + items: >> + - description: Watchdog pre-timeout (bark) interrupt >> + >> + mediatek,disable-extrst: >> + description: Disable sending output reset signal >> + type: boolean >> + >> + timeout-sec: true > > Drop this and use 'unevaluatedProperties'. > Noted. Will do for v2. Thanks! Angelo
WARNING: multiple messages have this Message-ID (diff)
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> To: Rob Herring <robh@kernel.org> Cc: wim@linux-watchdog.org, linux@roeck-us.net, krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com, allen-kh.cheng@mediatek.com, seiya.wang@mediatek.com, tinghan.shen@mediatek.com, linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/5] dt-bindings: watchdog: mediatek: Convert mtk-wdt to json-schema Date: Wed, 5 Oct 2022 15:42:16 +0200 [thread overview] Message-ID: <36ca5e72-db5d-65f6-db2c-1f0066842d18@collabora.com> (raw) In-Reply-To: <20221005133848.GA3278938-robh@kernel.org> Il 05/10/22 15:38, Rob Herring ha scritto: > On Wed, Oct 05, 2022 at 01:35:15PM +0200, AngeloGioacchino Del Regno wrote: >> Convert the MediaTek watchdog bindings to schema. >> >> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> >> --- >> .../bindings/watchdog/mediatek,mtk-wdt.yaml | 80 +++++++++++++++++++ >> .../devicetree/bindings/watchdog/mtk-wdt.txt | 42 ---------- >> 2 files changed, 80 insertions(+), 42 deletions(-) >> create mode 100644 Documentation/devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml >> delete mode 100644 Documentation/devicetree/bindings/watchdog/mtk-wdt.txt >> >> diff --git a/Documentation/devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml b/Documentation/devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml >> new file mode 100644 >> index 000000000000..f43b5af92d40 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml >> @@ -0,0 +1,80 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/watchdog/mediatek,mtk-wdt.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: MediaTek SoCs Watchdog timer >> + >> +maintainers: >> + - Matthias Brugger <matthias.bgg@gmail.com> >> + >> +description: >> + The watchdog supports a pre-timeout interrupt that fires >> + timeout-sec/2 before the expiry. >> + >> +allOf: >> + - $ref: watchdog.yaml# >> + >> +properties: >> + compatible: >> + oneOf: >> + - items: >> + - enum: >> + - mediatek,mt2712-wdt >> + - mediatek,mt6589-wdt >> + - mediatek,mt7986-wdt >> + - mediatek,mt8183-wdt >> + - mediatek,mt8186-wdt >> + - mediatek,mt8192-wdt >> + - mediatek,mt8195-wdt > > The original binding only had 4 without a fallback. It's fine to add or > change, but note the changes in the commit msg. Are all of these really > each unique and not the same? > Ok I will note the changes in the commit for v2. And... yes, they're really each unique and not the same, as these are exposing a reset controller of their own (as well with different platform data in the driver). > >> + - items: >> + - enum: >> + - mediatek,mt2701-wdt >> + - mediatek,mt6582-wdt >> + - mediatek,mt6797-wdt >> + - mediatek,mt7622-wdt >> + - mediatek,mt7623-wdt >> + - mediatek,mt7629-wdt >> + - mediatek,mt8516-wdt >> + - const: mediatek,mt6589-wdt >> + >> + reg: >> + maxItems: 1 >> + >> + interrupts: >> + items: >> + - description: Watchdog pre-timeout (bark) interrupt >> + >> + mediatek,disable-extrst: >> + description: Disable sending output reset signal >> + type: boolean >> + >> + timeout-sec: true > > Drop this and use 'unevaluatedProperties'. > Noted. Will do for v2. Thanks! Angelo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-10-05 13:42 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-10-05 11:35 [PATCH 0/5] MediaTek watchdog: MT6795 support and YAML conversion AngeloGioacchino Del Regno 2022-10-05 11:35 ` AngeloGioacchino Del Regno 2022-10-05 11:35 ` [PATCH 1/5] arm64: dts: mediatek: mt8186: Fix watchdog compatible AngeloGioacchino Del Regno 2022-10-05 11:35 ` AngeloGioacchino Del Regno 2022-10-05 11:35 ` [PATCH 2/5] arm64: dts: mediatek: mt8195: " AngeloGioacchino Del Regno 2022-10-05 11:35 ` AngeloGioacchino Del Regno 2022-10-05 11:35 ` [PATCH 3/5] dt-bindings: watchdog: mediatek: Convert mtk-wdt to json-schema AngeloGioacchino Del Regno 2022-10-05 11:35 ` AngeloGioacchino Del Regno 2022-10-05 13:38 ` Rob Herring 2022-10-05 13:38 ` Rob Herring 2022-10-05 13:42 ` AngeloGioacchino Del Regno [this message] 2022-10-05 13:42 ` AngeloGioacchino Del Regno 2022-10-05 16:33 ` Krzysztof Kozlowski 2022-10-05 16:33 ` Krzysztof Kozlowski 2022-10-06 2:26 ` Allen-KH Cheng (程冠勳) 2022-10-06 2:26 ` Allen-KH Cheng (程冠勳) 2022-10-06 8:36 ` AngeloGioacchino Del Regno 2022-10-06 8:36 ` AngeloGioacchino Del Regno 2022-10-06 8:43 ` Allen-KH Cheng (程冠勳) 2022-10-06 8:43 ` Allen-KH Cheng (程冠勳) 2022-10-06 8:45 ` AngeloGioacchino Del Regno 2022-10-06 8:45 ` AngeloGioacchino Del Regno 2022-10-05 11:35 ` [PATCH 4/5] dt-bindings: watchdog: mediatek,mtk-wdt: Add compatible for MT6795 AngeloGioacchino Del Regno 2022-10-05 11:35 ` AngeloGioacchino Del Regno 2022-10-05 13:39 ` Rob Herring 2022-10-05 13:39 ` Rob Herring 2022-10-14 16:46 ` Guenter Roeck 2022-10-14 16:46 ` Guenter Roeck 2022-10-05 11:35 ` [PATCH 5/5] watchdog: mtk_wdt: Add support for MT6795 Helio X10 watchdog and toprgu AngeloGioacchino Del Regno 2022-10-05 11:35 ` AngeloGioacchino Del Regno 2022-10-06 18:15 ` Guenter Roeck 2022-10-06 18:15 ` Guenter Roeck
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=36ca5e72-db5d-65f6-db2c-1f0066842d18@collabora.com \ --to=angelogioacchino.delregno@collabora.com \ --cc=allen-kh.cheng@mediatek.com \ --cc=devicetree@vger.kernel.org \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=linux-watchdog@vger.kernel.org \ --cc=linux@roeck-us.net \ --cc=matthias.bgg@gmail.com \ --cc=robh@kernel.org \ --cc=seiya.wang@mediatek.com \ --cc=tinghan.shen@mediatek.com \ --cc=wim@linux-watchdog.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.