From: Georgi Djakov <djakov@kernel.org> To: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>, shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, abel.vesa@nxp.com, abailon@baylibre.com, l.stach@pengutronix.de, laurent.pinchart@ideasonboard.com, marex@denx.de, paul.elder@ideasonboard.com, Markus.Niebel@ew.tq-group.com, aford173@gmail.com, cw00.choi@samsung.com, kyungmin.park@samsung.com, myungjoo.ham@samsung.com Cc: kernel@pengutronix.de, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-imx@nxp.com, abelvesa@kernel.org, Peng Fan <peng.fan@nxp.com> Subject: Re: [PATCH V3 10/10] arm64: dts: imx8mp: add NoC node Date: Mon, 4 Jul 2022 16:50:51 +0300 [thread overview] Message-ID: <36d8fbe2-b64d-4997-5836-b2c32e4d987f@kernel.org> (raw) In-Reply-To: <20220703091132.1412063-11-peng.fan@oss.nxp.com> Hi Peng, On 3.07.22 12:11, Peng Fan (OSS) wrote: > From: Peng Fan <peng.fan@nxp.com> > > Add i.MX8MP NoC node to make the interconnect i.MX8MP driver could work. > Currently dynamic frequency scaling of the i.MX8MP NoC has not been > supported, only NoC initial settings are configured by interconnect > driver. > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > --- > arch/arm64/boot/dts/freescale/imx8mp.dtsi | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > index eb2d516278eb..13a2ee77d3c6 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > @@ -4,6 +4,7 @@ > */ > > #include <dt-bindings/clock/imx8mp-clock.h> > +#include <dt-bindings/interconnect/fsl,imx8mp.h> It's also possible to drop this line for now and add it in the next patches when we add the interconnect consumers. This will allow merging this DT patch independently. But it's up to Shawn. > #include <dt-bindings/power/imx8mp-power.h> > #include <dt-bindings/gpio/gpio.h> > #include <dt-bindings/input/input.h> > @@ -1019,6 +1020,27 @@ eqos: ethernet@30bf0000 { > }; > }; > > + noc: interconnect@32700000 { > + compatible = "fsl,imx8mp-noc", "fsl,imx8m-noc", "syscon"; I got the impression that we are dropping the syscon, or not? > + reg = <0x32700000 0x100000>; > + clocks = <&clk IMX8MP_CLK_NOC>; > + #interconnect-cells = <1>; > + > + operating-points-v2 = <&noc_opp_table>; > + > + noc_opp_table: opp-table { > + compatible = "operating-points-v2"; > + > + opp-200M { > + opp-hz = /bits/ 64 <200000000>; > + }; > + > + opp-1000M { > + opp-hz = /bits/ 64 <1000000000>; > + }; > + }; > + }; > + > aips4: bus@32c00000 { > compatible = "fsl,aips-bus", "simple-bus"; > reg = <0x32c00000 0x400000>; Patches 1-9 look good and I am planning to merge them. Thanks, Georgi
WARNING: multiple messages have this Message-ID (diff)
From: Georgi Djakov <djakov@kernel.org> To: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>, shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, abel.vesa@nxp.com, abailon@baylibre.com, l.stach@pengutronix.de, laurent.pinchart@ideasonboard.com, marex@denx.de, paul.elder@ideasonboard.com, Markus.Niebel@ew.tq-group.com, aford173@gmail.com, cw00.choi@samsung.com, kyungmin.park@samsung.com, myungjoo.ham@samsung.com Cc: kernel@pengutronix.de, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-imx@nxp.com, abelvesa@kernel.org, Peng Fan <peng.fan@nxp.com> Subject: Re: [PATCH V3 10/10] arm64: dts: imx8mp: add NoC node Date: Mon, 4 Jul 2022 16:50:51 +0300 [thread overview] Message-ID: <36d8fbe2-b64d-4997-5836-b2c32e4d987f@kernel.org> (raw) In-Reply-To: <20220703091132.1412063-11-peng.fan@oss.nxp.com> Hi Peng, On 3.07.22 12:11, Peng Fan (OSS) wrote: > From: Peng Fan <peng.fan@nxp.com> > > Add i.MX8MP NoC node to make the interconnect i.MX8MP driver could work. > Currently dynamic frequency scaling of the i.MX8MP NoC has not been > supported, only NoC initial settings are configured by interconnect > driver. > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > --- > arch/arm64/boot/dts/freescale/imx8mp.dtsi | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > index eb2d516278eb..13a2ee77d3c6 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > @@ -4,6 +4,7 @@ > */ > > #include <dt-bindings/clock/imx8mp-clock.h> > +#include <dt-bindings/interconnect/fsl,imx8mp.h> It's also possible to drop this line for now and add it in the next patches when we add the interconnect consumers. This will allow merging this DT patch independently. But it's up to Shawn. > #include <dt-bindings/power/imx8mp-power.h> > #include <dt-bindings/gpio/gpio.h> > #include <dt-bindings/input/input.h> > @@ -1019,6 +1020,27 @@ eqos: ethernet@30bf0000 { > }; > }; > > + noc: interconnect@32700000 { > + compatible = "fsl,imx8mp-noc", "fsl,imx8m-noc", "syscon"; I got the impression that we are dropping the syscon, or not? > + reg = <0x32700000 0x100000>; > + clocks = <&clk IMX8MP_CLK_NOC>; > + #interconnect-cells = <1>; > + > + operating-points-v2 = <&noc_opp_table>; > + > + noc_opp_table: opp-table { > + compatible = "operating-points-v2"; > + > + opp-200M { > + opp-hz = /bits/ 64 <200000000>; > + }; > + > + opp-1000M { > + opp-hz = /bits/ 64 <1000000000>; > + }; > + }; > + }; > + > aips4: bus@32c00000 { > compatible = "fsl,aips-bus", "simple-bus"; > reg = <0x32c00000 0x400000>; Patches 1-9 look good and I am planning to merge them. Thanks, Georgi _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-07-04 13:51 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-07-03 9:11 [PATCH V3 00/10] interconnect: support i.MX8MP Peng Fan (OSS) 2022-07-03 9:11 ` Peng Fan (OSS) 2022-07-03 9:11 ` [PATCH V3 01/10] dt-bindings: interconnect: imx8m: Add bindings for imx8mp noc Peng Fan (OSS) 2022-07-03 9:11 ` Peng Fan (OSS) 2022-07-03 13:55 ` Chanwoo Choi 2022-07-03 13:55 ` Chanwoo Choi 2022-07-03 9:11 ` [PATCH V3 02/10] dt-bindings: interconnect: add fsl,imx8mp.h Peng Fan (OSS) 2022-07-03 9:11 ` Peng Fan (OSS) 2022-07-03 9:11 ` [PATCH V3 03/10] interconnect: add device managed bulk API Peng Fan (OSS) 2022-07-03 9:11 ` Peng Fan (OSS) 2022-07-03 9:11 ` [PATCH V3 04/10] interconnect: imx: fix max_node_id Peng Fan (OSS) 2022-07-03 9:11 ` Peng Fan (OSS) 2022-07-03 9:11 ` [PATCH V3 05/10] interconnect: imx: set src node Peng Fan (OSS) 2022-07-03 9:11 ` Peng Fan (OSS) 2022-07-03 9:11 ` [PATCH V3 06/10] interconnect: imx: introduce imx_icc_provider Peng Fan (OSS) 2022-07-03 9:11 ` Peng Fan (OSS) 2022-07-03 9:11 ` [PATCH V3 07/10] interconnect: imx: configure NoC mode/prioriry/ext_control Peng Fan (OSS) 2022-07-03 9:11 ` Peng Fan (OSS) 2022-07-03 9:11 ` [PATCH V3 08/10] interconnect: imx: Add platform driver for imx8mp Peng Fan (OSS) 2022-07-03 9:11 ` Peng Fan (OSS) 2022-07-03 9:11 ` [PATCH V3 09/10] PM / devfreq: imx: Register i.MX8MP interconnect device Peng Fan (OSS) 2022-07-03 9:11 ` Peng Fan (OSS) 2022-07-03 13:55 ` Chanwoo Choi 2022-07-03 13:55 ` Chanwoo Choi 2022-07-03 9:11 ` [PATCH V3 10/10] arm64: dts: imx8mp: add NoC node Peng Fan (OSS) 2022-07-03 9:11 ` Peng Fan (OSS) 2022-07-04 13:50 ` Georgi Djakov [this message] 2022-07-04 13:50 ` Georgi Djakov 2022-07-05 7:55 ` Peng Fan 2022-07-05 7:55 ` Peng Fan
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=36d8fbe2-b64d-4997-5836-b2c32e4d987f@kernel.org \ --to=djakov@kernel.org \ --cc=Markus.Niebel@ew.tq-group.com \ --cc=abailon@baylibre.com \ --cc=abel.vesa@nxp.com \ --cc=abelvesa@kernel.org \ --cc=aford173@gmail.com \ --cc=cw00.choi@samsung.com \ --cc=devicetree@vger.kernel.org \ --cc=festevam@gmail.com \ --cc=kernel@pengutronix.de \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=kyungmin.park@samsung.com \ --cc=l.stach@pengutronix.de \ --cc=laurent.pinchart@ideasonboard.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=marex@denx.de \ --cc=myungjoo.ham@samsung.com \ --cc=paul.elder@ideasonboard.com \ --cc=peng.fan@nxp.com \ --cc=peng.fan@oss.nxp.com \ --cc=robh+dt@kernel.org \ --cc=s.hauer@pengutronix.de \ --cc=shawnguo@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.