From: Icenowy Zheng <icenowy@aosc.xyz>
To: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Michal Suchanek <hramrach@gmail.com>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Jaehoon Chung <jh80.chung@samsung.com>,
Hans de Goede <hdegoede@redhat.com>, Chen-Yu Tsai <wens@csie.org>,
Rob Herring <robh+dt@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v3 1/2] Documentation: dt: Add new compatible to sunxi mmc driver bindings
Date: Mon, 22 Aug 2016 16:47:51 +0800 [thread overview]
Message-ID: <370671471855671@web30j.yandex.ru> (raw)
In-Reply-To: <20160822075847.GD7104@lukather>
22.08.2016, 15:58, "Maxime Ripard" <maxime.ripard@free-electrons.com>:
> Hi Icenowy,
>
> On Mon, Aug 01, 2016 at 11:13:50PM +0800, Icenowy Zheng wrote:
>> Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>
>> ---
>> Changes in v2:
>> - Rebased on Hans de Goede's patchset.
>>
>> Documentation/devicetree/bindings/mmc/sunxi-mmc.txt | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/mmc/sunxi-mmc.txt b/Documentation/devicetree/bindings/mmc/sunxi-mmc.txt
>> index 904ff9f..55cdd80 100644
>> --- a/Documentation/devicetree/bindings/mmc/sunxi-mmc.txt
>> +++ b/Documentation/devicetree/bindings/mmc/sunxi-mmc.txt
>> @@ -13,6 +13,7 @@ Required properties:
>> * "allwinner,sun5i-a13-mmc"
>> * "allwinner,sun7i-a20-mmc"
>> * "allwinner,sun9i-a80-mmc"
>> + * "allwinner,sun50i-a64-mmc"
>> - reg : mmc controller base registers
>> - clocks : a list with 4 phandle + clock specifier pairs
>> - clock-names : must contain "ahb", "mmc", "output" and "sample"
>
> You need to document that the output and sample clocks are not
> mandatory in the A64 case.
Oh, sorry.
This series of patch is dropped now...
At least I and Andre have no SD Card suitable for DDR mode...
Maybe the patches can only be tested on eMMC.
However, at least on Pine64, our SD Cards are working steaily.
>
> Thanks!
> Maxime
>
> --
> Maxime Ripard, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: icenowy@aosc.xyz (Icenowy Zheng)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 1/2] Documentation: dt: Add new compatible to sunxi mmc driver bindings
Date: Mon, 22 Aug 2016 16:47:51 +0800 [thread overview]
Message-ID: <370671471855671@web30j.yandex.ru> (raw)
In-Reply-To: <20160822075847.GD7104@lukather>
22.08.2016, 15:58, "Maxime Ripard" <maxime.ripard@free-electrons.com>:
> Hi Icenowy,
>
> On Mon, Aug 01, 2016 at 11:13:50PM +0800, Icenowy Zheng wrote:
>> ?Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>
>> ?---
>> ?Changes in v2:
>> ?- Rebased on Hans de Goede's patchset.
>>
>> ??Documentation/devicetree/bindings/mmc/sunxi-mmc.txt | 1 +
>> ??1 file changed, 1 insertion(+)
>>
>> ?diff --git a/Documentation/devicetree/bindings/mmc/sunxi-mmc.txt b/Documentation/devicetree/bindings/mmc/sunxi-mmc.txt
>> ?index 904ff9f..55cdd80 100644
>> ?--- a/Documentation/devicetree/bindings/mmc/sunxi-mmc.txt
>> ?+++ b/Documentation/devicetree/bindings/mmc/sunxi-mmc.txt
>> ?@@ -13,6 +13,7 @@ Required properties:
>> ?????* "allwinner,sun5i-a13-mmc"
>> ?????* "allwinner,sun7i-a20-mmc"
>> ?????* "allwinner,sun9i-a80-mmc"
>> ?+ * "allwinner,sun50i-a64-mmc"
>> ???- reg : mmc controller base registers
>> ???- clocks : a list with 4 phandle + clock specifier pairs
>> ???- clock-names : must contain "ahb", "mmc", "output" and "sample"
>
> You need to document that the output and sample clocks are not
> mandatory in the A64 case.
Oh, sorry.
This series of patch is dropped now...
At least I and Andre have no SD Card suitable for DDR mode...
Maybe the patches can only be tested on eMMC.
However, at least on Pine64, our SD Cards are working steaily.
>
> Thanks!
> Maxime
>
> --
> Maxime Ripard, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com
next prev parent reply other threads:[~2016-08-22 8:47 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-01 15:13 [PATCH v3 0/2] Add support for Allwinner A64 mmc controller Icenowy Zheng
2016-08-01 15:13 ` Icenowy Zheng
2016-08-01 15:13 ` [PATCH v3 1/2] Documentation: dt: Add new compatible to sunxi mmc driver bindings Icenowy Zheng
2016-08-01 15:13 ` Icenowy Zheng
2016-08-22 7:58 ` Maxime Ripard
2016-08-22 7:58 ` Maxime Ripard
2016-08-22 7:58 ` Maxime Ripard
2016-08-22 8:47 ` Icenowy Zheng [this message]
2016-08-22 8:47 ` Icenowy Zheng
2016-08-01 15:13 ` [PATCH v3 2/2] mmc: host: sunxi: add support for A64 mmc controller Icenowy Zheng
2016-08-01 15:13 ` Icenowy Zheng
2016-08-02 23:43 ` Jaehoon Chung
2016-08-02 23:43 ` Jaehoon Chung
2016-08-02 23:43 ` Jaehoon Chung
2016-08-03 2:13 ` Icenowy Zheng
2016-08-03 2:13 ` Icenowy Zheng
2016-08-02 8:45 ` [PATCH v3 0/2] Add support for Allwinner " Hans de Goede
2016-08-02 8:45 ` Hans de Goede
2016-08-02 8:45 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=370671471855671@web30j.yandex.ru \
--to=icenowy@aosc.xyz \
--cc=devicetree@vger.kernel.org \
--cc=hdegoede@redhat.com \
--cc=hramrach@gmail.com \
--cc=jh80.chung@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@free-electrons.com \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.