All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: Anshuman Khandual <anshuman.khandual@arm.com>,
	Sudarshan Rajagopalan <sudaraja@codeaurora.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Logan Gunthorpe <logang@deltatee.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Steven Price <steven.price@arm.com>
Subject: Re: [PATCH] arm64/mm: add fallback option to allocate virtually contiguous memory
Date: Thu, 10 Sep 2020 10:08:56 +0200	[thread overview]
Message-ID: <372df305-3bff-bf8e-e2a3-a03932df58d5@redhat.com> (raw)
In-Reply-To: <0475e813-cb95-0992-39e4-593bfd5cdbf8@arm.com>

On 10.09.20 08:45, Anshuman Khandual wrote:
> Hello Sudarshan,
> 
> On 09/10/2020 11:35 AM, Sudarshan Rajagopalan wrote:
>> When section mappings are enabled, we allocate vmemmap pages from physically
>> continuous memory of size PMD_SZIE using vmemmap_alloc_block_buf(). Section> mappings are good to reduce TLB pressure. But when system is highly fragmented
>> and memory blocks are being hot-added at runtime, its possible that such
>> physically continuous memory allocations can fail. Rather than failing the
> 
> Did you really see this happen on a system ?
> 
>> memory hot-add procedure, add a fallback option to allocate vmemmap pages from
>> discontinuous pages using vmemmap_populate_basepages().
> 
> Which could lead to a mixed page size mapping in the VMEMMAP area.

Right, with gives you a slight performance hit - nobody really cares,
especially if it happens in corner cases only.

At least x86_64 (see vmemmap_populate_hugepages()) and s390x (added
recently by me) implement that behavior.

Assume you run in a virtualized environment where your hypervisor tries
to do some smart dynamic guest resizing - like monitoring the guest
memory consumption and adding more memory on demand. You much rather
want hotadd to succeed (in these corner cases) that failing just because
you weren't able to grab a huge page in one instance.

Examples include XEN balloon, Hyper-V balloon, and virtio-mem. We might
see some of these for arm64 as well (if don't already do).

> Allocation failure in vmemmap_populate() should just cleanly fail
> the memory hot add operation, which can then be retried. Why the
> retry has to be offloaded to kernel ?

(not sure what "offloaded to kernel" really means here - add_memory() is
also just triggered from the kernel) I disagree, we should try our best
to add memory and make it available, especially when short on memory
already.

-- 
Thanks,

David / dhildenb


WARNING: multiple messages have this Message-ID (diff)
From: David Hildenbrand <david@redhat.com>
To: Anshuman Khandual <anshuman.khandual@arm.com>,
	Sudarshan Rajagopalan <sudaraja@codeaurora.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Cc: Mark Rutland <mark.rutland@arm.com>,
	Will Deacon <will@kernel.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Steven Price <steven.price@arm.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Logan Gunthorpe <logang@deltatee.com>
Subject: Re: [PATCH] arm64/mm: add fallback option to allocate virtually contiguous memory
Date: Thu, 10 Sep 2020 10:08:56 +0200	[thread overview]
Message-ID: <372df305-3bff-bf8e-e2a3-a03932df58d5@redhat.com> (raw)
In-Reply-To: <0475e813-cb95-0992-39e4-593bfd5cdbf8@arm.com>

On 10.09.20 08:45, Anshuman Khandual wrote:
> Hello Sudarshan,
> 
> On 09/10/2020 11:35 AM, Sudarshan Rajagopalan wrote:
>> When section mappings are enabled, we allocate vmemmap pages from physically
>> continuous memory of size PMD_SZIE using vmemmap_alloc_block_buf(). Section> mappings are good to reduce TLB pressure. But when system is highly fragmented
>> and memory blocks are being hot-added at runtime, its possible that such
>> physically continuous memory allocations can fail. Rather than failing the
> 
> Did you really see this happen on a system ?
> 
>> memory hot-add procedure, add a fallback option to allocate vmemmap pages from
>> discontinuous pages using vmemmap_populate_basepages().
> 
> Which could lead to a mixed page size mapping in the VMEMMAP area.

Right, with gives you a slight performance hit - nobody really cares,
especially if it happens in corner cases only.

At least x86_64 (see vmemmap_populate_hugepages()) and s390x (added
recently by me) implement that behavior.

Assume you run in a virtualized environment where your hypervisor tries
to do some smart dynamic guest resizing - like monitoring the guest
memory consumption and adding more memory on demand. You much rather
want hotadd to succeed (in these corner cases) that failing just because
you weren't able to grab a huge page in one instance.

Examples include XEN balloon, Hyper-V balloon, and virtio-mem. We might
see some of these for arm64 as well (if don't already do).

> Allocation failure in vmemmap_populate() should just cleanly fail
> the memory hot add operation, which can then be retried. Why the
> retry has to be offloaded to kernel ?

(not sure what "offloaded to kernel" really means here - add_memory() is
also just triggered from the kernel) I disagree, we should try our best
to add memory and make it available, especially when short on memory
already.

-- 
Thanks,

David / dhildenb


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-09-10  8:09 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <01010174769e2b68-a6f3768e-aef8-43c7-b357-a8cb1e17d3eb-000000@us-west-2.amazonses.com>
2020-09-10  6:45 ` [PATCH] arm64/mm: add fallback option to allocate virtually contiguous memory Anshuman Khandual
2020-09-10  6:45   ` Anshuman Khandual
2020-09-10  8:08   ` David Hildenbrand [this message]
2020-09-10  8:08     ` David Hildenbrand
2020-09-10 10:58     ` Anshuman Khandual
2020-09-10 10:58       ` Anshuman Khandual
2020-09-10  8:27   ` sudaraja
2020-09-10 11:16     ` Anshuman Khandual
2020-09-10 11:16       ` Anshuman Khandual
2020-09-10  8:27   ` sudaraja
2020-09-10  8:27 ` Steven Price
2020-09-10  8:27   ` Steven Price
2020-09-10 10:50   ` Anshuman Khandual
2020-09-10 10:50     ` Anshuman Khandual
2020-09-10 20:48     ` sudaraja
2020-09-21 17:43       ` Will Deacon
2020-09-21 17:43         ` Will Deacon
2020-09-10 20:48     ` sudaraja
2020-09-10  6:05 Sudarshan Rajagopalan
  -- strict thread matches above, loose matches on Subject: below --
2020-09-10  6:05 Sudarshan Rajagopalan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=372df305-3bff-bf8e-e2a3-a03932df58d5@redhat.com \
    --to=david@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=anshuman.khandual@arm.com \
    --cc=catalin.marinas@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=logang@deltatee.com \
    --cc=mark.rutland@arm.com \
    --cc=steven.price@arm.com \
    --cc=sudaraja@codeaurora.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.