* [PATCH linux dev-6.5 0/4] ARM: dts: aspeed: p10bmc: Add fan controller properties
@ 2023-10-06 17:27 Eddie James
2023-10-06 17:27 ` [PATCH linux dev-6.5 1/4] ARM: dts: aspeed: Rainier: " Eddie James
` (5 more replies)
0 siblings, 6 replies; 13+ messages in thread
From: Eddie James @ 2023-10-06 17:27 UTC (permalink / raw)
To: openbmc; +Cc: Eddie James, joel
Now that the max31785 driver can parse the relevant properties, update
the device trees with the necessary properties.
Eddie James (4):
ARM: dts: aspeed: Rainier: Add fan controller properties
ARM: dts: aspeed: Everest: Add fan controller properties
ARM: dts: aspeed: Bonnell: Add fan controller properties
ARM: dts: aspeed: Rainier 4U: Delete fan dual-tach properties
.../dts/aspeed/aspeed-bmc-ibm-bonnell.dts | 14 +++++++
.../dts/aspeed/aspeed-bmc-ibm-everest.dts | 28 +++++++++++++
.../dts/aspeed/aspeed-bmc-ibm-rainier-4u.dts | 24 +++++++++++
.../dts/aspeed/aspeed-bmc-ibm-rainier.dts | 42 +++++++++++++++++++
4 files changed, 108 insertions(+)
--
2.39.3
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH linux dev-6.5 1/4] ARM: dts: aspeed: Rainier: Add fan controller properties
2023-10-06 17:27 [PATCH linux dev-6.5 0/4] ARM: dts: aspeed: p10bmc: Add fan controller properties Eddie James
@ 2023-10-06 17:27 ` Eddie James
2023-10-06 18:31 ` Ninad Palsule
2023-10-06 17:27 ` [PATCH linux dev-6.5 2/4] ARM: dts: aspeed: Everest: " Eddie James
` (4 subsequent siblings)
5 siblings, 1 reply; 13+ messages in thread
From: Eddie James @ 2023-10-06 17:27 UTC (permalink / raw)
To: openbmc; +Cc: Eddie James, joel
Add the necessary Max chip specific fan properties.
Signed-off-by: Eddie James <eajames@linux.ibm.com>
Signed-off-by: Joel Stanley <joel@jms.id.au>
---
.../dts/aspeed/aspeed-bmc-ibm-rainier.dts | 42 +++++++++++++++++++
1 file changed, 42 insertions(+)
diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-rainier.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-rainier.dts
index 2566d26f6714..29d7ac2e3867 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-rainier.dts
+++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-rainier.dts
@@ -1083,36 +1083,78 @@ fan0: fan@0 {
compatible = "pmbus-fan";
reg = <0>;
tach-pulses = <2>;
+ maxim,fan-rotor-input = "tach";
+ maxim,fan-pwm-freq = <25000>;
+ maxim,fan-dual-tach;
+ maxim,fan-no-watchdog;
+ maxim,fan-no-fault-ramp;
+ maxim,fan-ramp = <2>;
+ maxim,fan-fault-pin-mon;
};
fan1: fan@1 {
compatible = "pmbus-fan";
reg = <1>;
tach-pulses = <2>;
+ maxim,fan-rotor-input = "tach";
+ maxim,fan-pwm-freq = <25000>;
+ maxim,fan-dual-tach;
+ maxim,fan-no-watchdog;
+ maxim,fan-no-fault-ramp;
+ maxim,fan-ramp = <2>;
+ maxim,fan-fault-pin-mon;
};
fan2: fan@2 {
compatible = "pmbus-fan";
reg = <2>;
tach-pulses = <2>;
+ maxim,fan-rotor-input = "tach";
+ maxim,fan-pwm-freq = <25000>;
+ maxim,fan-dual-tach;
+ maxim,fan-no-watchdog;
+ maxim,fan-no-fault-ramp;
+ maxim,fan-ramp = <2>;
+ maxim,fan-fault-pin-mon;
};
fan3: fan@3 {
compatible = "pmbus-fan";
reg = <3>;
tach-pulses = <2>;
+ maxim,fan-rotor-input = "tach";
+ maxim,fan-pwm-freq = <25000>;
+ maxim,fan-dual-tach;
+ maxim,fan-no-watchdog;
+ maxim,fan-no-fault-ramp;
+ maxim,fan-ramp = <2>;
+ maxim,fan-fault-pin-mon;
};
fan4: fan@4 {
compatible = "pmbus-fan";
reg = <4>;
tach-pulses = <2>;
+ maxim,fan-rotor-input = "tach";
+ maxim,fan-pwm-freq = <25000>;
+ maxim,fan-dual-tach;
+ maxim,fan-no-watchdog;
+ maxim,fan-no-fault-ramp;
+ maxim,fan-ramp = <2>;
+ maxim,fan-fault-pin-mon;
};
fan5: fan@5 {
compatible = "pmbus-fan";
reg = <5>;
tach-pulses = <2>;
+ maxim,fan-rotor-input = "tach";
+ maxim,fan-pwm-freq = <25000>;
+ maxim,fan-dual-tach;
+ maxim,fan-no-watchdog;
+ maxim,fan-no-fault-ramp;
+ maxim,fan-ramp = <2>;
+ maxim,fan-fault-pin-mon;
};
};
--
2.39.3
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH linux dev-6.5 2/4] ARM: dts: aspeed: Everest: Add fan controller properties
2023-10-06 17:27 [PATCH linux dev-6.5 0/4] ARM: dts: aspeed: p10bmc: Add fan controller properties Eddie James
2023-10-06 17:27 ` [PATCH linux dev-6.5 1/4] ARM: dts: aspeed: Rainier: " Eddie James
@ 2023-10-06 17:27 ` Eddie James
2023-10-06 18:32 ` Ninad Palsule
2023-10-06 17:27 ` [PATCH linux dev-6.5 3/4] ARM: dts: aspeed: Bonnell: " Eddie James
` (3 subsequent siblings)
5 siblings, 1 reply; 13+ messages in thread
From: Eddie James @ 2023-10-06 17:27 UTC (permalink / raw)
To: openbmc; +Cc: Eddie James, joel
Add the necessary Max chip specific fan properties.
Signed-off-by: Eddie James <eajames@linux.ibm.com>
Signed-off-by: Joel Stanley <joel@jms.id.au>
---
.../dts/aspeed/aspeed-bmc-ibm-everest.dts | 28 +++++++++++++++++++
1 file changed, 28 insertions(+)
diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dts
index 1f59ab28d29b..fdb3ccaf0cb5 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dts
+++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dts
@@ -2042,24 +2042,52 @@ fan@0 {
compatible = "pmbus-fan";
reg = <0>;
tach-pulses = <2>;
+ maxim,fan-rotor-input = "tach";
+ maxim,fan-pwm-freq = <25000>;
+ maxim,fan-dual-tach;
+ maxim,fan-no-watchdog;
+ maxim,fan-no-fault-ramp;
+ maxim,fan-ramp = <2>;
+ maxim,fan-fault-pin-mon;
};
fan@1 {
compatible = "pmbus-fan";
reg = <1>;
tach-pulses = <2>;
+ maxim,fan-rotor-input = "tach";
+ maxim,fan-pwm-freq = <25000>;
+ maxim,fan-dual-tach;
+ maxim,fan-no-watchdog;
+ maxim,fan-no-fault-ramp;
+ maxim,fan-ramp = <2>;
+ maxim,fan-fault-pin-mon;
};
fan@2 {
compatible = "pmbus-fan";
reg = <2>;
tach-pulses = <2>;
+ maxim,fan-rotor-input = "tach";
+ maxim,fan-pwm-freq = <25000>;
+ maxim,fan-dual-tach;
+ maxim,fan-no-watchdog;
+ maxim,fan-no-fault-ramp;
+ maxim,fan-ramp = <2>;
+ maxim,fan-fault-pin-mon;
};
fan@3 {
compatible = "pmbus-fan";
reg = <3>;
tach-pulses = <2>;
+ maxim,fan-rotor-input = "tach";
+ maxim,fan-pwm-freq = <25000>;
+ maxim,fan-dual-tach;
+ maxim,fan-no-watchdog;
+ maxim,fan-no-fault-ramp;
+ maxim,fan-ramp = <2>;
+ maxim,fan-fault-pin-mon;
};
};
--
2.39.3
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH linux dev-6.5 3/4] ARM: dts: aspeed: Bonnell: Add fan controller properties
2023-10-06 17:27 [PATCH linux dev-6.5 0/4] ARM: dts: aspeed: p10bmc: Add fan controller properties Eddie James
2023-10-06 17:27 ` [PATCH linux dev-6.5 1/4] ARM: dts: aspeed: Rainier: " Eddie James
2023-10-06 17:27 ` [PATCH linux dev-6.5 2/4] ARM: dts: aspeed: Everest: " Eddie James
@ 2023-10-06 17:27 ` Eddie James
2023-10-06 18:34 ` Ninad Palsule
2023-10-06 17:27 ` [PATCH linux dev-6.5 4/4] ARM: dts: aspeed: Rainier 4U: Delete fan dual-tach properties Eddie James
` (2 subsequent siblings)
5 siblings, 1 reply; 13+ messages in thread
From: Eddie James @ 2023-10-06 17:27 UTC (permalink / raw)
To: openbmc; +Cc: Eddie James, Eddie James, joel
From: Eddie James <eajames@us.ibm.com>
Bonnell uses the same dual rotor fans as Rainier 2U.
Signed-off-by: Eddie James <eajames@linux.ibm.com>
Signed-off-by: Joel Stanley <joel@jms.id.au>
---
.../arm/boot/dts/aspeed/aspeed-bmc-ibm-bonnell.dts | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-bonnell.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-bonnell.dts
index cad1b9aac97b..29d68d7e876f 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-bonnell.dts
+++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-bonnell.dts
@@ -280,12 +280,26 @@ fan0: fan@0 {
compatible = "pmbus-fan";
reg = <0>;
tach-pulses = <2>;
+ maxim,fan-rotor-input = "tach";
+ maxim,fan-pwm-freq = <25000>;
+ maxim,fan-dual-tach;
+ maxim,fan-no-watchdog;
+ maxim,fan-no-fault-ramp;
+ maxim,fan-ramp = <2>;
+ maxim,fan-fault-pin-mon;
};
fan1: fan@1 {
compatible = "pmbus-fan";
reg = <1>;
tach-pulses = <2>;
+ maxim,fan-rotor-input = "tach";
+ maxim,fan-pwm-freq = <25000>;
+ maxim,fan-dual-tach;
+ maxim,fan-no-watchdog;
+ maxim,fan-no-fault-ramp;
+ maxim,fan-ramp = <2>;
+ maxim,fan-fault-pin-mon;
};
};
--
2.39.3
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH linux dev-6.5 4/4] ARM: dts: aspeed: Rainier 4U: Delete fan dual-tach properties
2023-10-06 17:27 [PATCH linux dev-6.5 0/4] ARM: dts: aspeed: p10bmc: Add fan controller properties Eddie James
` (2 preceding siblings ...)
2023-10-06 17:27 ` [PATCH linux dev-6.5 3/4] ARM: dts: aspeed: Bonnell: " Eddie James
@ 2023-10-06 17:27 ` Eddie James
2023-10-06 18:39 ` Ninad Palsule
2023-10-06 18:24 ` [PATCH linux dev-6.5 0/4] ARM: dts: aspeed: p10bmc: Add fan controller properties Ninad Palsule
2023-10-11 1:46 ` Joel Stanley
5 siblings, 1 reply; 13+ messages in thread
From: Eddie James @ 2023-10-06 17:27 UTC (permalink / raw)
To: openbmc; +Cc: Eddie James, joel
The fans in the 4U chassis do not have dual tachometers, so remove those
properties in the device tree.
Signed-off-by: Eddie James <eajames@linux.ibm.com>
Signed-off-by: Joel Stanley <joel@jms.id.au>
---
.../dts/aspeed/aspeed-bmc-ibm-rainier-4u.dts | 24 +++++++++++++++++++
1 file changed, 24 insertions(+)
diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-rainier-4u.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-rainier-4u.dts
index 342546a3c0f5..24283cc3d486 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-rainier-4u.dts
+++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-rainier-4u.dts
@@ -19,3 +19,27 @@ power-supply@6b {
reg = <0x6b>;
};
};
+
+&fan0 {
+ /delete-property/ maxim,fan-dual-tach;
+};
+
+&fan1 {
+ /delete-property/ maxim,fan-dual-tach;
+};
+
+&fan2 {
+ /delete-property/ maxim,fan-dual-tach;
+};
+
+&fan3 {
+ /delete-property/ maxim,fan-dual-tach;
+};
+
+&fan4 {
+ /delete-property/ maxim,fan-dual-tach;
+};
+
+&fan5 {
+ /delete-property/ maxim,fan-dual-tach;
+};
--
2.39.3
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH linux dev-6.5 0/4] ARM: dts: aspeed: p10bmc: Add fan controller properties
2023-10-06 17:27 [PATCH linux dev-6.5 0/4] ARM: dts: aspeed: p10bmc: Add fan controller properties Eddie James
` (3 preceding siblings ...)
2023-10-06 17:27 ` [PATCH linux dev-6.5 4/4] ARM: dts: aspeed: Rainier 4U: Delete fan dual-tach properties Eddie James
@ 2023-10-06 18:24 ` Ninad Palsule
2023-10-11 1:46 ` Joel Stanley
5 siblings, 0 replies; 13+ messages in thread
From: Ninad Palsule @ 2023-10-06 18:24 UTC (permalink / raw)
To: Eddie James, openbmc; +Cc: joel
On 10/6/23 12:27, Eddie James wrote:
> Now that the max31785 driver can parse the relevant properties, update
> the device trees with the necessary properties.
>
> Eddie James (4):
> ARM: dts: aspeed: Rainier: Add fan controller properties
> ARM: dts: aspeed: Everest: Add fan controller properties
> ARM: dts: aspeed: Bonnell: Add fan controller properties
> ARM: dts: aspeed: Rainier 4U: Delete fan dual-tach properties
>
> .../dts/aspeed/aspeed-bmc-ibm-bonnell.dts | 14 +++++++
> .../dts/aspeed/aspeed-bmc-ibm-everest.dts | 28 +++++++++++++
> .../dts/aspeed/aspeed-bmc-ibm-rainier-4u.dts | 24 +++++++++++
> .../dts/aspeed/aspeed-bmc-ibm-rainier.dts | 42 +++++++++++++++++++
> 4 files changed, 108 insertions(+)
>
Reviewed-by: Ninad Palsule <ninad@linux.ibm.com>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH linux dev-6.5 1/4] ARM: dts: aspeed: Rainier: Add fan controller properties
2023-10-06 17:27 ` [PATCH linux dev-6.5 1/4] ARM: dts: aspeed: Rainier: " Eddie James
@ 2023-10-06 18:31 ` Ninad Palsule
0 siblings, 0 replies; 13+ messages in thread
From: Ninad Palsule @ 2023-10-06 18:31 UTC (permalink / raw)
To: Eddie James, openbmc; +Cc: joel
[-- Attachment #1: Type: text/plain, Size: 2639 bytes --]
On 10/6/23 12:27, Eddie James wrote:
> Add the necessary Max chip specific fan properties.
>
> Signed-off-by: Eddie James<eajames@linux.ibm.com>
> Signed-off-by: Joel Stanley<joel@jms.id.au>
> ---
> .../dts/aspeed/aspeed-bmc-ibm-rainier.dts | 42 +++++++++++++++++++
> 1 file changed, 42 insertions(+)
>
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-rainier.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-rainier.dts
> index 2566d26f6714..29d7ac2e3867 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-rainier.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-rainier.dts
> @@ -1083,36 +1083,78 @@ fan0: fan@0 {
> compatible = "pmbus-fan";
> reg = <0>;
> tach-pulses = <2>;
> + maxim,fan-rotor-input = "tach";
> + maxim,fan-pwm-freq = <25000>;
> + maxim,fan-dual-tach;
> + maxim,fan-no-watchdog;
> + maxim,fan-no-fault-ramp;
> + maxim,fan-ramp = <2>;
> + maxim,fan-fault-pin-mon;
> };
>
> fan1: fan@1 {
> compatible = "pmbus-fan";
> reg = <1>;
> tach-pulses = <2>;
> + maxim,fan-rotor-input = "tach";
> + maxim,fan-pwm-freq = <25000>;
> + maxim,fan-dual-tach;
> + maxim,fan-no-watchdog;
> + maxim,fan-no-fault-ramp;
> + maxim,fan-ramp = <2>;
> + maxim,fan-fault-pin-mon;
> };
>
> fan2: fan@2 {
> compatible = "pmbus-fan";
> reg = <2>;
> tach-pulses = <2>;
> + maxim,fan-rotor-input = "tach";
> + maxim,fan-pwm-freq = <25000>;
> + maxim,fan-dual-tach;
> + maxim,fan-no-watchdog;
> + maxim,fan-no-fault-ramp;
> + maxim,fan-ramp = <2>;
> + maxim,fan-fault-pin-mon;
> };
>
> fan3: fan@3 {
> compatible = "pmbus-fan";
> reg = <3>;
> tach-pulses = <2>;
> + maxim,fan-rotor-input = "tach";
> + maxim,fan-pwm-freq = <25000>;
> + maxim,fan-dual-tach;
> + maxim,fan-no-watchdog;
> + maxim,fan-no-fault-ramp;
> + maxim,fan-ramp = <2>;
> + maxim,fan-fault-pin-mon;
> };
>
> fan4: fan@4 {
> compatible = "pmbus-fan";
> reg = <4>;
> tach-pulses = <2>;
> + maxim,fan-rotor-input = "tach";
> + maxim,fan-pwm-freq = <25000>;
> + maxim,fan-dual-tach;
> + maxim,fan-no-watchdog;
> + maxim,fan-no-fault-ramp;
> + maxim,fan-ramp = <2>;
> + maxim,fan-fault-pin-mon;
> };
>
> fan5: fan@5 {
> compatible = "pmbus-fan";
> reg = <5>;
> tach-pulses = <2>;
> + maxim,fan-rotor-input = "tach";
> + maxim,fan-pwm-freq = <25000>;
> + maxim,fan-dual-tach;
> + maxim,fan-no-watchdog;
> + maxim,fan-no-fault-ramp;
> + maxim,fan-ramp = <2>;
> + maxim,fan-fault-pin-mon;
> };
> };
>
Reviewed-by: Ninad Palsule <ninad@linux.ibm.com>
[-- Attachment #2: Type: text/html, Size: 3342 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH linux dev-6.5 2/4] ARM: dts: aspeed: Everest: Add fan controller properties
2023-10-06 17:27 ` [PATCH linux dev-6.5 2/4] ARM: dts: aspeed: Everest: " Eddie James
@ 2023-10-06 18:32 ` Ninad Palsule
0 siblings, 0 replies; 13+ messages in thread
From: Ninad Palsule @ 2023-10-06 18:32 UTC (permalink / raw)
To: Eddie James, openbmc; +Cc: joel
On 10/6/23 12:27, Eddie James wrote:
> Add the necessary Max chip specific fan properties.
>
> Signed-off-by: Eddie James <eajames@linux.ibm.com>
> Signed-off-by: Joel Stanley <joel@jms.id.au>
> ---
> .../dts/aspeed/aspeed-bmc-ibm-everest.dts | 28 +++++++++++++++++++
> 1 file changed, 28 insertions(+)
>
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dts
> index 1f59ab28d29b..fdb3ccaf0cb5 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dts
> @@ -2042,24 +2042,52 @@ fan@0 {
> compatible = "pmbus-fan";
> reg = <0>;
> tach-pulses = <2>;
> + maxim,fan-rotor-input = "tach";
> + maxim,fan-pwm-freq = <25000>;
> + maxim,fan-dual-tach;
> + maxim,fan-no-watchdog;
> + maxim,fan-no-fault-ramp;
> + maxim,fan-ramp = <2>;
> + maxim,fan-fault-pin-mon;
> };
>
> fan@1 {
> compatible = "pmbus-fan";
> reg = <1>;
> tach-pulses = <2>;
> + maxim,fan-rotor-input = "tach";
> + maxim,fan-pwm-freq = <25000>;
> + maxim,fan-dual-tach;
> + maxim,fan-no-watchdog;
> + maxim,fan-no-fault-ramp;
> + maxim,fan-ramp = <2>;
> + maxim,fan-fault-pin-mon;
> };
>
> fan@2 {
> compatible = "pmbus-fan";
> reg = <2>;
> tach-pulses = <2>;
> + maxim,fan-rotor-input = "tach";
> + maxim,fan-pwm-freq = <25000>;
> + maxim,fan-dual-tach;
> + maxim,fan-no-watchdog;
> + maxim,fan-no-fault-ramp;
> + maxim,fan-ramp = <2>;
> + maxim,fan-fault-pin-mon;
> };
>
> fan@3 {
> compatible = "pmbus-fan";
> reg = <3>;
> tach-pulses = <2>;
> + maxim,fan-rotor-input = "tach";
> + maxim,fan-pwm-freq = <25000>;
> + maxim,fan-dual-tach;
> + maxim,fan-no-watchdog;
> + maxim,fan-no-fault-ramp;
> + maxim,fan-ramp = <2>;
> + maxim,fan-fault-pin-mon;
> };
> };
Reviewed-by: Ninad Palsule <ninad@linux.ibm.com>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH linux dev-6.5 3/4] ARM: dts: aspeed: Bonnell: Add fan controller properties
2023-10-06 17:27 ` [PATCH linux dev-6.5 3/4] ARM: dts: aspeed: Bonnell: " Eddie James
@ 2023-10-06 18:34 ` Ninad Palsule
0 siblings, 0 replies; 13+ messages in thread
From: Ninad Palsule @ 2023-10-06 18:34 UTC (permalink / raw)
To: Eddie James, openbmc; +Cc: Eddie James, joel
On 10/6/23 12:27, Eddie James wrote:
> From: Eddie James <eajames@us.ibm.com>
>
> Bonnell uses the same dual rotor fans as Rainier 2U.
>
> Signed-off-by: Eddie James <eajames@linux.ibm.com>
> Signed-off-by: Joel Stanley <joel@jms.id.au>
> ---
> .../arm/boot/dts/aspeed/aspeed-bmc-ibm-bonnell.dts | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-bonnell.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-bonnell.dts
> index cad1b9aac97b..29d68d7e876f 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-bonnell.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-bonnell.dts
> @@ -280,12 +280,26 @@ fan0: fan@0 {
> compatible = "pmbus-fan";
> reg = <0>;
> tach-pulses = <2>;
> + maxim,fan-rotor-input = "tach";
> + maxim,fan-pwm-freq = <25000>;
> + maxim,fan-dual-tach;
> + maxim,fan-no-watchdog;
> + maxim,fan-no-fault-ramp;
> + maxim,fan-ramp = <2>;
> + maxim,fan-fault-pin-mon;
> };
>
> fan1: fan@1 {
> compatible = "pmbus-fan";
> reg = <1>;
> tach-pulses = <2>;
> + maxim,fan-rotor-input = "tach";
> + maxim,fan-pwm-freq = <25000>;
> + maxim,fan-dual-tach;
> + maxim,fan-no-watchdog;
> + maxim,fan-no-fault-ramp;
> + maxim,fan-ramp = <2>;
> + maxim,fan-fault-pin-mon;
> };
> };
Reviewed-by: Ninad Palsule <ninad@linux.ibm.com>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH linux dev-6.5 4/4] ARM: dts: aspeed: Rainier 4U: Delete fan dual-tach properties
2023-10-06 17:27 ` [PATCH linux dev-6.5 4/4] ARM: dts: aspeed: Rainier 4U: Delete fan dual-tach properties Eddie James
@ 2023-10-06 18:39 ` Ninad Palsule
0 siblings, 0 replies; 13+ messages in thread
From: Ninad Palsule @ 2023-10-06 18:39 UTC (permalink / raw)
To: Eddie James, openbmc; +Cc: joel
On 10/6/23 12:27, Eddie James wrote:
> The fans in the 4U chassis do not have dual tachometers, so remove those
> properties in the device tree.
>
> Signed-off-by: Eddie James <eajames@linux.ibm.com>
> Signed-off-by: Joel Stanley <joel@jms.id.au>
> ---
> .../dts/aspeed/aspeed-bmc-ibm-rainier-4u.dts | 24 +++++++++++++++++++
> 1 file changed, 24 insertions(+)
>
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-rainier-4u.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-rainier-4u.dts
> index 342546a3c0f5..24283cc3d486 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-rainier-4u.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-rainier-4u.dts
> @@ -19,3 +19,27 @@ power-supply@6b {
> reg = <0x6b>;
> };
> };
> +
> +&fan0 {
> + /delete-property/ maxim,fan-dual-tach;
> +};
> +
> +&fan1 {
> + /delete-property/ maxim,fan-dual-tach;
> +};
> +
> +&fan2 {
> + /delete-property/ maxim,fan-dual-tach;
> +};
> +
> +&fan3 {
> + /delete-property/ maxim,fan-dual-tach;
> +};
> +
> +&fan4 {
> + /delete-property/ maxim,fan-dual-tach;
> +};
> +
> +&fan5 {
> + /delete-property/ maxim,fan-dual-tach;
> +};
Reviewed-by: Ninad Palsule <ninad@linux.ibm.com>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH linux dev-6.5 0/4] ARM: dts: aspeed: p10bmc: Add fan controller properties
2023-10-06 17:27 [PATCH linux dev-6.5 0/4] ARM: dts: aspeed: p10bmc: Add fan controller properties Eddie James
` (4 preceding siblings ...)
2023-10-06 18:24 ` [PATCH linux dev-6.5 0/4] ARM: dts: aspeed: p10bmc: Add fan controller properties Ninad Palsule
@ 2023-10-11 1:46 ` Joel Stanley
2023-10-11 13:43 ` Eddie James
5 siblings, 1 reply; 13+ messages in thread
From: Joel Stanley @ 2023-10-11 1:46 UTC (permalink / raw)
To: Eddie James; +Cc: openbmc
On Sat, 7 Oct 2023 at 03:58, Eddie James <eajames@linux.ibm.com> wrote:
>
> Now that the max31785 driver can parse the relevant properties, update
I can't see a patch that adds that support. Can you point it out?
Cheers,
Joel
> the device trees with the necessary properties.
>
> Eddie James (4):
> ARM: dts: aspeed: Rainier: Add fan controller properties
> ARM: dts: aspeed: Everest: Add fan controller properties
> ARM: dts: aspeed: Bonnell: Add fan controller properties
> ARM: dts: aspeed: Rainier 4U: Delete fan dual-tach properties
>
> .../dts/aspeed/aspeed-bmc-ibm-bonnell.dts | 14 +++++++
> .../dts/aspeed/aspeed-bmc-ibm-everest.dts | 28 +++++++++++++
> .../dts/aspeed/aspeed-bmc-ibm-rainier-4u.dts | 24 +++++++++++
> .../dts/aspeed/aspeed-bmc-ibm-rainier.dts | 42 +++++++++++++++++++
> 4 files changed, 108 insertions(+)
>
> --
> 2.39.3
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH linux dev-6.5 0/4] ARM: dts: aspeed: p10bmc: Add fan controller properties
2023-10-11 1:46 ` Joel Stanley
@ 2023-10-11 13:43 ` Eddie James
2023-10-13 1:19 ` Joel Stanley
0 siblings, 1 reply; 13+ messages in thread
From: Eddie James @ 2023-10-11 13:43 UTC (permalink / raw)
To: Joel Stanley; +Cc: openbmc
On 10/10/23 20:46, Joel Stanley wrote:
> On Sat, 7 Oct 2023 at 03:58, Eddie James <eajames@linux.ibm.com> wrote:
>> Now that the max31785 driver can parse the relevant properties, update
> I can't see a patch that adds that support. Can you point it out?
Sure,
https://github.com/openbmc/linux/commit/ebd863b5c2a2f5bc3ee26fadf39a213a2cdc6efb
Thanks,
Eddie
>
> Cheers,
>
> Joel
>
>> the device trees with the necessary properties.
>>
>> Eddie James (4):
>> ARM: dts: aspeed: Rainier: Add fan controller properties
>> ARM: dts: aspeed: Everest: Add fan controller properties
>> ARM: dts: aspeed: Bonnell: Add fan controller properties
>> ARM: dts: aspeed: Rainier 4U: Delete fan dual-tach properties
>>
>> .../dts/aspeed/aspeed-bmc-ibm-bonnell.dts | 14 +++++++
>> .../dts/aspeed/aspeed-bmc-ibm-everest.dts | 28 +++++++++++++
>> .../dts/aspeed/aspeed-bmc-ibm-rainier-4u.dts | 24 +++++++++++
>> .../dts/aspeed/aspeed-bmc-ibm-rainier.dts | 42 +++++++++++++++++++
>> 4 files changed, 108 insertions(+)
>>
>> --
>> 2.39.3
>>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH linux dev-6.5 0/4] ARM: dts: aspeed: p10bmc: Add fan controller properties
2023-10-11 13:43 ` Eddie James
@ 2023-10-13 1:19 ` Joel Stanley
0 siblings, 0 replies; 13+ messages in thread
From: Joel Stanley @ 2023-10-13 1:19 UTC (permalink / raw)
To: Eddie James; +Cc: openbmc
On Thu, 12 Oct 2023 at 00:13, Eddie James <eajames@linux.ibm.com> wrote:
>
>
> On 10/10/23 20:46, Joel Stanley wrote:
> > On Sat, 7 Oct 2023 at 03:58, Eddie James <eajames@linux.ibm.com> wrote:
> >> Now that the max31785 driver can parse the relevant properties, update
> > I can't see a patch that adds that support. Can you point it out?
>
>
> Sure,
> https://github.com/openbmc/linux/commit/ebd863b5c2a2f5bc3ee26fadf39a213a2cdc6efb
Right, that's the openbmc downstream patch. We would like to see that
patch go upstream. Are you able to work on that?
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2023-10-13 1:20 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-06 17:27 [PATCH linux dev-6.5 0/4] ARM: dts: aspeed: p10bmc: Add fan controller properties Eddie James
2023-10-06 17:27 ` [PATCH linux dev-6.5 1/4] ARM: dts: aspeed: Rainier: " Eddie James
2023-10-06 18:31 ` Ninad Palsule
2023-10-06 17:27 ` [PATCH linux dev-6.5 2/4] ARM: dts: aspeed: Everest: " Eddie James
2023-10-06 18:32 ` Ninad Palsule
2023-10-06 17:27 ` [PATCH linux dev-6.5 3/4] ARM: dts: aspeed: Bonnell: " Eddie James
2023-10-06 18:34 ` Ninad Palsule
2023-10-06 17:27 ` [PATCH linux dev-6.5 4/4] ARM: dts: aspeed: Rainier 4U: Delete fan dual-tach properties Eddie James
2023-10-06 18:39 ` Ninad Palsule
2023-10-06 18:24 ` [PATCH linux dev-6.5 0/4] ARM: dts: aspeed: p10bmc: Add fan controller properties Ninad Palsule
2023-10-11 1:46 ` Joel Stanley
2023-10-11 13:43 ` Eddie James
2023-10-13 1:19 ` Joel Stanley
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.