vm_power_manager uses non-public API, broken build on top of installed SDK

vm_power_manager uses non-public API, broken build on top of installed SDK

[Jan Viktorin]

Hello Thomas,

I have encountered an issue with the examples/vm_power_manager. It
includes the file lib/librte_power/channel_commands.h which is not a
public API. This breaks builds of examples based on just the installed
SDK (after calling install-sdk) as the channel_commands.h header is
missing there. I suppose that most of the time, the examples are being
build directly from the DPDK base directory and so nobody could see
this failing.

Steps:

DPDK_CONFIG=arm-armv7a-linuxapp-gcc
$(MAKE) -C $(@D) T=$(DPDK_CONFIG) RTE_KERNELDIR=$(LINUX_DIR) \          
         CROSS=$(TARGET_CROSS) config
$(MAKE) -C $(@D) T=$(DPDK_CONFIG) RTE_KERNELDIR=$(LINUX_DIR) \          
         CROSS=$(TARGET_CROSS) all
$(MAKE) -C $(@D) DESTDIR=$(@D)/examples-sdk \                           
         CROSS=$(TARGET_CROSS) install-sdk install-runtime              
$(MAKE) -C $(@D) RTE_KERNELDIR=$(LINUX_DIR) CROSS=$(TARGET_CROSS) \    
        RTE_SDK=$(@D)/examples-sdk/usr/local/share/dpdk \               
        T=$(DPDK_CONFIG) examples

(I also set CONFIG_RTE_BUILD_SHARED_LIB=y and
CONFIG_RTE_BUILD_COMBINE_LIBS=y but I don't see any relation here.)

I am not sure about the solution. Probably, it's possible to move the
contents of channel_commands.h into the rte_power.h.

And, there is no maintainer listed for the librte_power and related
stuff...

By the way, is there a command that installs the examples on the
target? I didn't find any yet...

Regards
Jan

-- 
   Jan Viktorin                  E-mail: Viktorin@RehiveTech.com
   System Architect              Web:    www.RehiveTech.com
   RehiveTech
   Brno, Czech Republic

Re: vm_power_manager uses non-public API, broken build on top of installed SDK

[Thomas Monjalon]

Hi,

2016-02-16 18:21, Jan Viktorin:
> I have encountered an issue with the examples/vm_power_manager. It
> includes the file lib/librte_power/channel_commands.h which is not a
> public API. This breaks builds of examples based on just the installed
> SDK (after calling install-sdk) as the channel_commands.h header is
> missing there. I suppose that most of the time, the examples are being
> build directly from the DPDK base directory and so nobody could see
> this failing.

Please check this thread where it has already been reported:
	http://dpdk.org/ml/archives/dev/2016-February/033202.html

> By the way, is there a command that installs the examples on the
> target? I didn't find any yet...

No you can only specify a build directory for the examples.