[Qemu-devel] [PATCH] edid: fix vendor default

[Qemu-devel] [PATCH] edid: fix vendor default

[Gerd Hoffmann]

"EMU" actually is "Emulex Corporation", so not a good idea to use that
by default.  Lets use the Red Hat vendor id instead, which is in line
with the pci ids which are allocated from Red Hat vendor ids too.

Vendor list is available from http://www.uefi.org/pnp_id_list

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 include/hw/display/edid.h  | 2 +-
 hw/display/edid-generate.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/hw/display/edid.h b/include/hw/display/edid.h
index bd51d26916..bacf170889 100644
--- a/include/hw/display/edid.h
+++ b/include/hw/display/edid.h
@@ -4,7 +4,7 @@
 #include "hw/hw.h"
 
 typedef struct qemu_edid_info {
-    const char *vendor;
+    const char *vendor; /* http://www.uefi.org/pnp_id_list */
     const char *name;
     const char *serial;
     uint32_t    dpi;
diff --git a/hw/display/edid-generate.c b/hw/display/edid-generate.c
index c80397ea96..37e60fe42a 100644
--- a/hw/display/edid-generate.c
+++ b/hw/display/edid-generate.c
@@ -301,7 +301,7 @@ void qemu_edid_generate(uint8_t *edid, size_t size,
     /* =============== set defaults  =============== */
 
     if (!info->vendor || strlen(info->vendor) != 3) {
-        info->vendor = "EMU";
+        info->vendor = "RHT";
     }
     if (!info->name) {
         info->name = "QEMU Monitor";
-- 
2.9.3

Re: [Qemu-devel] [PATCH] edid: fix vendor default

[Philippe Mathieu-Daudé]

On 05/10/2018 11:19, Gerd Hoffmann wrote:
> "EMU" actually is "Emulex Corporation", so not a good idea to use that
> by default.  Lets use the Red Hat vendor id instead, which is in line
> with the pci ids which are allocated from Red Hat vendor ids too.
> 
> Vendor list is available from http://www.uefi.org/pnp_id_list
> 
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

> ---
>  include/hw/display/edid.h  | 2 +-
>  hw/display/edid-generate.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/hw/display/edid.h b/include/hw/display/edid.h
> index bd51d26916..bacf170889 100644
> --- a/include/hw/display/edid.h
> +++ b/include/hw/display/edid.h
> @@ -4,7 +4,7 @@
>  #include "hw/hw.h"
>  
>  typedef struct qemu_edid_info {
> -    const char *vendor;
> +    const char *vendor; /* http://www.uefi.org/pnp_id_list */
>      const char *name;
>      const char *serial;
>      uint32_t    dpi;
> diff --git a/hw/display/edid-generate.c b/hw/display/edid-generate.c
> index c80397ea96..37e60fe42a 100644
> --- a/hw/display/edid-generate.c
> +++ b/hw/display/edid-generate.c
> @@ -301,7 +301,7 @@ void qemu_edid_generate(uint8_t *edid, size_t size,
>      /* =============== set defaults  =============== */
>  
>      if (!info->vendor || strlen(info->vendor) != 3) {
> -        info->vendor = "EMU";
> +        info->vendor = "RHT";
>      }
>      if (!info->name) {
>          info->name = "QEMU Monitor";
>