All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] [MTD] [NAND] : Correcting file name in the header section.
       [not found] <35044.192.168.10.89.1229077681.squirrel@dbdmail.itg.ti.com>
@ 2008-12-12 12:25 ` Manasa Gangaiah
  2008-12-12 15:06   ` Josh Boyer
  0 siblings, 1 reply; 4+ messages in thread
From: Manasa Gangaiah @ 2008-12-12 12:25 UTC (permalink / raw)
  To: linux-mtd

This patch corrects the file name in the header section.

Signed-off-by: Manasa Gangaiah <manasa.gangaiah@ti.com>
---

 drivers/mtd/nand/autcpu12.c  |    2 +-
 drivers/mtd/nand/nand_base.c |    2 +-
 drivers/mtd/nand/nand_bbt.c  |    2 +-
 drivers/mtd/nand/nandids.c   |    2 +-
 drivers/mtd/nand/ndfc.c      |    2 +-
 5 files changed, 5 insertions(+), 5 deletions(-)
--- a/drivers/mtd/nand/nand_base.c	2008-12-12 16:59:41.000000000 +0530
+++ b/drivers/mtd/nand/nand_base.c	2008-12-12 17:11:27.000000000 +0530
@@ -1,5 +1,5 @@
 /*
- *  drivers/mtd/nand.c
+ *  drivers/mtd/nand/nand_base.c
  *
  *  Overview:
  *   This is the generic MTD driver for NAND flash devices. It should be
--- a/drivers/mtd/nand/nandids.c	2008-12-12 17:23:44.000000000 +0530
+++ b/drivers/mtd/nand/nandids.c	2008-12-12 17:23:58.000000000 +0530
@@ -1,5 +1,5 @@
 /*
- *  drivers/mtd/nandids.c
+ *  drivers/mtd/nand/nandids.c
  *
  *  Copyright (C) 2002 Thomas Gleixner (tglx@linutronix.de)
  *
--- a/drivers/mtd/nand/ndfc.c	2008-12-12 17:28:56.000000000 +0530
+++ b/drivers/mtd/nand/ndfc.c	2008-12-12 17:29:08.000000000 +0530
@@ -1,5 +1,5 @@
 /*
- *  drivers/mtd/ndfc.c
+ *  drivers/mtd/nand/ndfc.c
  *
  *  Overview:
  *   Platform independend driver for NDFC (NanD Flash Controller)
--- a/drivers/mtd/nand/autcpu12.c	2008-12-12 17:32:38.000000000 +0530
+++ b/drivers/mtd/nand/autcpu12.c	2008-12-12 17:32:56.000000000 +0530
@@ -1,5 +1,5 @@
 /*
- *  drivers/mtd/autcpu12.c
+ *  drivers/mtd/nand/autcpu12.c
  *
  *  Copyright (c) 2002 Thomas Gleixner <tgxl@linutronix.de>
  *
--- a/drivers/mtd/nand/nand_bbt.c	2008-12-12 17:42:50.000000000 +0530
+++ b/drivers/mtd/nand/nand_bbt.c	2008-12-12 17:43:17.000000000 +0530
@@ -1,5 +1,5 @@
 /*
- *  drivers/mtd/nand_bbt.c
+ *  drivers/mtd/nand/nand_bbt.c
  *
  *  Overview:
  *   Bad block table support for the NAND driver

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] [MTD] [NAND] : Correcting file name in the header section.
  2008-12-12 12:25 ` [PATCH] [MTD] [NAND] : Correcting file name in the header section Manasa Gangaiah
@ 2008-12-12 15:06   ` Josh Boyer
  2008-12-12 15:11     ` Artem Bityutskiy
  0 siblings, 1 reply; 4+ messages in thread
From: Josh Boyer @ 2008-12-12 15:06 UTC (permalink / raw)
  To: Manasa Gangaiah; +Cc: linux-mtd

On Fri, 12 Dec 2008 17:55:24 +0530 (IST)
"Manasa Gangaiah" <x0099189@ti.com> wrote:

> This patch corrects the file name in the header section.
> 
> Signed-off-by: Manasa Gangaiah <manasa.gangaiah@ti.com>

NAK.

It would be better to remove them entirely.  That way they don't need
to be updated again if the file is renamed or moved.

josh

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] [MTD] [NAND] : Correcting file name in the header section.
  2008-12-12 15:06   ` Josh Boyer
@ 2008-12-12 15:11     ` Artem Bityutskiy
  2008-12-15  4:58       ` Manasa Gangaiah
  0 siblings, 1 reply; 4+ messages in thread
From: Artem Bityutskiy @ 2008-12-12 15:11 UTC (permalink / raw)
  To: Josh Boyer; +Cc: Manasa Gangaiah, linux-mtd

On Fri, 2008-12-12 at 10:06 -0500, Josh Boyer wrote:
> On Fri, 12 Dec 2008 17:55:24 +0530 (IST)
> "Manasa Gangaiah" <x0099189@ti.com> wrote:
> 
> > This patch corrects the file name in the header section.
> > 
> > Signed-off-by: Manasa Gangaiah <manasa.gangaiah@ti.com>
> 
> NAK.
> 
> It would be better to remove them entirely.  That way they don't need
> to be updated again if the file is renamed or moved.

Agree, there is little point in putting file name and path there.

-- 
Best regards,
Artem Bityutskiy (Битюцкий Артём)

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] [MTD] [NAND] : Correcting file name in the header section.
  2008-12-12 15:11     ` Artem Bityutskiy
@ 2008-12-15  4:58       ` Manasa Gangaiah
  0 siblings, 0 replies; 4+ messages in thread
From: Manasa Gangaiah @ 2008-12-15  4:58 UTC (permalink / raw)
  To: dedekind; +Cc: linux-mtd

> On Fri, 2008-12-12 at 10:06 -0500, Josh Boyer wrote:
>> On Fri, 12 Dec 2008 17:55:24 +0530 (IST)
>> "Manasa Gangaiah" <x0099189@ti.com> wrote:
>>
>> > This patch corrects the file name in the header section.
>> >
>> > Signed-off-by: Manasa Gangaiah <manasa.gangaiah@ti.com>
>>
>> NAK.
>>
>> It would be better to remove them entirely.  That way they don't need
>> to be updated again if the file is renamed or moved.
>
> Agree, there is little point in putting file name and path there.

Thanks for the comments. Will make changes and send the patch.

- manasa

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2008-12-15  4:59 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <35044.192.168.10.89.1229077681.squirrel@dbdmail.itg.ti.com>
2008-12-12 12:25 ` [PATCH] [MTD] [NAND] : Correcting file name in the header section Manasa Gangaiah
2008-12-12 15:06   ` Josh Boyer
2008-12-12 15:11     ` Artem Bityutskiy
2008-12-15  4:58       ` Manasa Gangaiah

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.