* [PATCH 0/1] Do not use command in profile
@ 2017-04-13 12:23 Peter Kjellerstedt
2017-04-13 12:23 ` [PATCH 1/1] base-files: profile: Avoid using "command" to determine if programs exist Peter Kjellerstedt
0 siblings, 1 reply; 2+ messages in thread
From: Peter Kjellerstedt @ 2017-04-13 12:23 UTC (permalink / raw)
To: openembedded-core
Since we apparently cannot rely on the command utility to always
exist, it is better to avoid using it in the profile script. Rather
than using command to detect if tty and resize exist (which obviously
will not work if command itself does not exist), just call them
directly while piping any output for stderr to /dev/null. This should
actually be a little bit more efficient in the case that they do
exist, and the same in the case that they do not exist.
I leave to you to decide whether you want to revert commit e41c90b852
that enabled the command utility in busybox or not.
//Peter
The following changes since commit fe47bff64b17562593c620d2daf748735bb5c3d6:
linux-yocto: Update genericx86* SRCREVs for linux-yocto 4.10 (2017-04-13 10:54:37 +0100)
are available in the git repository at:
git://git.yoctoproject.org/poky-contrib pkj/profile_without_command
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=pkj/profile_without_command
Peter Kjellerstedt (1):
base-files: profile: Avoid using "command" to determine if programs
exist
meta/recipes-core/base-files/base-files/profile | 14 ++++++--------
1 file changed, 6 insertions(+), 8 deletions(-)
--
2.12.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH 1/1] base-files: profile: Avoid using "command" to determine if programs exist
2017-04-13 12:23 [PATCH 0/1] Do not use command in profile Peter Kjellerstedt
@ 2017-04-13 12:23 ` Peter Kjellerstedt
0 siblings, 0 replies; 2+ messages in thread
From: Peter Kjellerstedt @ 2017-04-13 12:23 UTC (permalink / raw)
To: openembedded-core
Since the existence of "command" in itself is not guaranteed, using it
to determine if other executables exist is mote. Instead just run the
executables and let the shell determine if they exist. By piping stderr
to /dev/null we avoid unnecessary warnings in case they do not exist.
Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
---
meta/recipes-core/base-files/base-files/profile | 14 ++++++--------
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/meta/recipes-core/base-files/base-files/profile b/meta/recipes-core/base-files/base-files/profile
index ceaf15f799..e05c8840db 100644
--- a/meta/recipes-core/base-files/base-files/profile
+++ b/meta/recipes-core/base-files/base-files/profile
@@ -22,14 +22,12 @@ if [ -d /etc/profile.d ]; then
unset i
fi
-if command -v resize >/dev/null && command -v tty >/dev/null; then
- # Make sure we are on a serial console (i.e. the device used starts with
- # /dev/tty[A-z]), otherwise we confuse e.g. the eclipse launcher which
- # tries do use ssh
- case $(tty) in
- /dev/tty[A-z]*) resize >/dev/null;;
- esac
-fi
+# Make sure we are on a serial console (i.e. the device used starts with
+# /dev/tty[A-z]), otherwise we confuse e.g. the eclipse launcher which tries do
+# use ssh
+case $(tty 2>/dev/null) in
+ /dev/tty[A-z]*) resize >/dev/null 2>&1;;
+esac
export PATH PS1 OPIEDIR QPEDIR QTDIR EDITOR TERM
--
2.12.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-04-13 12:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-13 12:23 [PATCH 0/1] Do not use command in profile Peter Kjellerstedt
2017-04-13 12:23 ` [PATCH 1/1] base-files: profile: Avoid using "command" to determine if programs exist Peter Kjellerstedt
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.