All of lore.kernel.org
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Georgi Djakov <djakov@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Cc: Rajendra Nayak <quic_rjendra@quicinc.com>,
	Thara Gopinath <thara.gopinath@gmail.com>
Subject: Re: [PATCH v8 2/4] soc: qcom: icc-bwmon: Add bandwidth monitoring driver
Date: Mon, 4 Jul 2022 08:20:24 -0700	[thread overview]
Message-ID: <3770bc6d-b3cc-9e49-a832-4c15af0b5f1a@infradead.org> (raw)
In-Reply-To: <20220704121730.127925-3-krzysztof.kozlowski@linaro.org>

Hi,

On 7/4/22 05:17, Krzysztof Kozlowski wrote:
> diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig
> index e718b8735444..2c8091535bf7 100644
> --- a/drivers/soc/qcom/Kconfig
> +++ b/drivers/soc/qcom/Kconfig
> @@ -228,4 +228,19 @@ config QCOM_APR
>  	  application processor and QDSP6. APR is
>  	  used by audio driver to configure QDSP6
>  	  ASM, ADM and AFE modules.
> +
> +config QCOM_ICC_BWMON
> +	tristate "QCOM Interconnect Bandwidth Monitor driver"
> +	depends on ARCH_QCOM || COMPILE_TEST
> +	select PM_OPP
> +	help
> +	  Sets up driver monitoring bandwidth on various interconnects and

	  Sets up driver bandwidth monitoring

would be better, I think.

> +	  based on that voting for interconnect bandwidth, adjusting their
> +	  speed to current demand.
> +	  Current implementation brings support for BWMON v4, used for example
> +	  on SDM845 to measure bandwidth between CPU (gladiator_noc) and Last
> +	  Level Cache (memnoc).  Usage of this BWMON allows to remove some of
> +	  the fixed bandwidth votes from cpufreq (CPU nodes) thus achieve high
> +	  memory throughput even with lower CPU frequencies.

-- 
~Randy

WARNING: multiple messages have this Message-ID (diff)
From: Randy Dunlap <rdunlap@infradead.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Georgi Djakov <djakov@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Cc: Rajendra Nayak <quic_rjendra@quicinc.com>,
	Thara Gopinath <thara.gopinath@gmail.com>
Subject: Re: [PATCH v8 2/4] soc: qcom: icc-bwmon: Add bandwidth monitoring driver
Date: Mon, 4 Jul 2022 08:20:24 -0700	[thread overview]
Message-ID: <3770bc6d-b3cc-9e49-a832-4c15af0b5f1a@infradead.org> (raw)
In-Reply-To: <20220704121730.127925-3-krzysztof.kozlowski@linaro.org>

Hi,

On 7/4/22 05:17, Krzysztof Kozlowski wrote:
> diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig
> index e718b8735444..2c8091535bf7 100644
> --- a/drivers/soc/qcom/Kconfig
> +++ b/drivers/soc/qcom/Kconfig
> @@ -228,4 +228,19 @@ config QCOM_APR
>  	  application processor and QDSP6. APR is
>  	  used by audio driver to configure QDSP6
>  	  ASM, ADM and AFE modules.
> +
> +config QCOM_ICC_BWMON
> +	tristate "QCOM Interconnect Bandwidth Monitor driver"
> +	depends on ARCH_QCOM || COMPILE_TEST
> +	select PM_OPP
> +	help
> +	  Sets up driver monitoring bandwidth on various interconnects and

	  Sets up driver bandwidth monitoring

would be better, I think.

> +	  based on that voting for interconnect bandwidth, adjusting their
> +	  speed to current demand.
> +	  Current implementation brings support for BWMON v4, used for example
> +	  on SDM845 to measure bandwidth between CPU (gladiator_noc) and Last
> +	  Level Cache (memnoc).  Usage of this BWMON allows to remove some of
> +	  the fixed bandwidth votes from cpufreq (CPU nodes) thus achieve high
> +	  memory throughput even with lower CPU frequencies.

-- 
~Randy

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-07-04 15:20 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-04 12:17 [PATCH v8 0/4] soc/arm64: qcom: Add initial version of bwmon Krzysztof Kozlowski
2022-07-04 12:17 ` Krzysztof Kozlowski
2022-07-04 12:17 ` [PATCH v8 1/4] dt-bindings: interconnect: qcom,msm8998-cpu-bwmon: add BWMON device Krzysztof Kozlowski
2022-07-04 12:17   ` Krzysztof Kozlowski
2022-07-04 12:17 ` [PATCH v8 2/4] soc: qcom: icc-bwmon: Add bandwidth monitoring driver Krzysztof Kozlowski
2022-07-04 12:17   ` Krzysztof Kozlowski
2022-07-04 15:20   ` Randy Dunlap [this message]
2022-07-04 15:20     ` Randy Dunlap
2022-07-04 15:22     ` Krzysztof Kozlowski
2022-07-04 15:22       ` Krzysztof Kozlowski
2022-07-04 19:15       ` Randy Dunlap
2022-07-04 19:15         ` Randy Dunlap
2022-07-04 12:17 ` [PATCH v8 3/4] arm64: defconfig: enable Qualcomm Bandwidth Monitor Krzysztof Kozlowski
2022-07-04 12:17   ` Krzysztof Kozlowski
2022-07-07  2:31   ` (subset) " Bjorn Andersson
2022-07-07  2:31     ` Bjorn Andersson
2022-07-04 12:17 ` [PATCH v8 4/4] arm64: dts: qcom: sdm845: Add CPU BWMON Krzysztof Kozlowski
2022-07-04 12:17   ` Krzysztof Kozlowski
2022-07-07  2:31 ` (subset) [PATCH v8 0/4] soc/arm64: qcom: Add initial version of bwmon Bjorn Andersson
2022-07-07  2:31   ` Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3770bc6d-b3cc-9e49-a832-4c15af0b5f1a@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=catalin.marinas@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=djakov@kernel.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=quic_rjendra@quicinc.com \
    --cc=robh+dt@kernel.org \
    --cc=thara.gopinath@gmail.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.