All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2 14/18] arm64: dts: ulcb-kf: enable PCA9539 on I2C2
@ 2017-09-14 14:19 ` Vladimir Barinov
  0 siblings, 0 replies; 5+ messages in thread
From: Vladimir Barinov @ 2017-09-14 14:19 UTC (permalink / raw)
  To: Simon Horman, Magnus Damm, Rob Herring, Mark Rutland,
	Catalin Marinas, Will Deacon
  Cc: devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA, Vladimir Barinov

This supports PCA9539 gpio expanders on I2C2 bus on ULCB Kingfisher board

Signed-off-by: Vladimir Barinov <vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
---
Changes in version 2:
- use generic node name "gpio"

 arch/arm64/boot/dts/renesas/ulcb-kf.dtsi | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
index 71dee77..40885e7 100644
--- a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
+++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
@@ -48,6 +48,28 @@
 	status = "okay";
 };
 
+&i2c2 {
+	gpio_exp_74: gpio@74 {
+		compatible = "nxp,pca9539";
+		reg = <0x74>;
+		gpio-controller;
+		#gpio-cells = <2>;
+		interrupt-controller;
+		interrupt-parent = <&gpio6>;
+		interrupts = <8 IRQ_TYPE_EDGE_FALLING>;
+	};
+
+	gpio_exp_75: gpio@75 {
+		compatible = "nxp,pca9539";
+		reg = <0x75>;
+		gpio-controller;
+		#gpio-cells = <2>;
+		interrupt-controller;
+		interrupt-parent = <&gpio6>;
+		interrupts = <4 IRQ_TYPE_EDGE_FALLING>;
+	};
+};
+
 &ohci0 {
 	status = "okay";
 };
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* [PATCH v2 14/18] arm64: dts: ulcb-kf: enable PCA9539 on I2C2
@ 2017-09-14 14:19 ` Vladimir Barinov
  0 siblings, 0 replies; 5+ messages in thread
From: Vladimir Barinov @ 2017-09-14 14:19 UTC (permalink / raw)
  To: Simon Horman, Magnus Damm, Rob Herring, Mark Rutland,
	Catalin Marinas, Will Deacon
  Cc: devicetree, linux-renesas-soc, Vladimir Barinov

This supports PCA9539 gpio expanders on I2C2 bus on ULCB Kingfisher board

Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
---
Changes in version 2:
- use generic node name "gpio"

 arch/arm64/boot/dts/renesas/ulcb-kf.dtsi | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
index 71dee77..40885e7 100644
--- a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
+++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
@@ -48,6 +48,28 @@
 	status = "okay";
 };
 
+&i2c2 {
+	gpio_exp_74: gpio@74 {
+		compatible = "nxp,pca9539";
+		reg = <0x74>;
+		gpio-controller;
+		#gpio-cells = <2>;
+		interrupt-controller;
+		interrupt-parent = <&gpio6>;
+		interrupts = <8 IRQ_TYPE_EDGE_FALLING>;
+	};
+
+	gpio_exp_75: gpio@75 {
+		compatible = "nxp,pca9539";
+		reg = <0x75>;
+		gpio-controller;
+		#gpio-cells = <2>;
+		interrupt-controller;
+		interrupt-parent = <&gpio6>;
+		interrupts = <4 IRQ_TYPE_EDGE_FALLING>;
+	};
+};
+
 &ohci0 {
 	status = "okay";
 };
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [PATCH v2 14/18] arm64: dts: ulcb-kf: enable PCA9539 on I2C2
  2017-09-14 14:19 ` Vladimir Barinov
  (?)
@ 2017-09-20 13:44 ` Geert Uytterhoeven
       [not found]   ` <CAMuHMdWvhm_bbLz8cBqPWC-nXrTr6jw4cBV1A_WAsvi6DzsR0w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
  -1 siblings, 1 reply; 5+ messages in thread
From: Geert Uytterhoeven @ 2017-09-20 13:44 UTC (permalink / raw)
  To: Vladimir Barinov
  Cc: Simon Horman, Magnus Damm, Rob Herring, Mark Rutland,
	Catalin Marinas, Will Deacon, devicetree, Linux-Renesas

Hi Vladimir,

On Thu, Sep 14, 2017 at 4:19 PM, Vladimir Barinov
<vladimir.barinov@cogentembedded.com> wrote:
> This supports PCA9539 gpio expanders on I2C2 bus on ULCB Kingfisher board
>
> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

> --- a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
> +++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
> @@ -48,6 +48,28 @@
>         status = "okay";
>  };
>
> +&i2c2 {
> +       gpio_exp_74: gpio@74 {
> +               compatible = "nxp,pca9539";

According to the schematics, this is the TI TCA9539, an enhanced version
of the NXP PCA9539. So I'd expect "ti,tca9539".

However, using the latter may not work (I didn't try), as pca953x_id[]
lists both parts, while pca953x_dt_ids[] lists only the NXP part number.

> +               reg = <0x74>;
> +               gpio-controller;
> +               #gpio-cells = <2>;
> +               interrupt-controller;
> +               interrupt-parent = <&gpio6>;
> +               interrupts = <8 IRQ_TYPE_EDGE_FALLING>;
> +       };
> +
> +       gpio_exp_75: gpio@75 {
> +               compatible = "nxp,pca9539";

Likewise.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH v2 14/18] arm64: dts: ulcb-kf: enable PCA9539 on I2C2
  2017-09-20 13:44 ` Geert Uytterhoeven
@ 2017-10-06  2:40       ` Vladimir Barinov
  0 siblings, 0 replies; 5+ messages in thread
From: Vladimir Barinov @ 2017-10-06  2:40 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Simon Horman, Magnus Damm, Rob Herring, Mark Rutland,
	Catalin Marinas, Will Deacon, devicetree-u79uwXL29TY76Z2rM5mHXA,
	Linux-Renesas

Hi Geert,

On 20.09.2017 16:44, Geert Uytterhoeven wrote:
> Hi Vladimir,
>
> On Thu, Sep 14, 2017 at 4:19 PM, Vladimir Barinov
> <vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> wrote:
>> This supports PCA9539 gpio expanders on I2C2 bus on ULCB Kingfisher board
>>
>> Signed-off-by: Vladimir Barinov <vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
> Reviewed-by: Geert Uytterhoeven <geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>
>
>> --- a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
>> +++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
>> @@ -48,6 +48,28 @@
>>          status = "okay";
>>   };
>>
>> +&i2c2 {
>> +       gpio_exp_74: gpio@74 {
>> +               compatible = "nxp,pca9539";
> According to the schematics, this is the TI TCA9539, an enhanced version
> of the NXP PCA9539. So I'd expect "ti,tca9539".
>
> However, using the latter may not work (I didn't try), as pca953x_id[]
> lists both parts, while pca953x_dt_ids[] lists only the NXP part number.
It works with "ti,tca9539"

-- 
Regards,
Vladimir

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH v2 14/18] arm64: dts: ulcb-kf: enable PCA9539 on I2C2
@ 2017-10-06  2:40       ` Vladimir Barinov
  0 siblings, 0 replies; 5+ messages in thread
From: Vladimir Barinov @ 2017-10-06  2:40 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Simon Horman, Magnus Damm, Rob Herring, Mark Rutland,
	Catalin Marinas, Will Deacon, devicetree, Linux-Renesas

Hi Geert,

On 20.09.2017 16:44, Geert Uytterhoeven wrote:
> Hi Vladimir,
>
> On Thu, Sep 14, 2017 at 4:19 PM, Vladimir Barinov
> <vladimir.barinov@cogentembedded.com> wrote:
>> This supports PCA9539 gpio expanders on I2C2 bus on ULCB Kingfisher board
>>
>> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
>> --- a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
>> +++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
>> @@ -48,6 +48,28 @@
>>          status = "okay";
>>   };
>>
>> +&i2c2 {
>> +       gpio_exp_74: gpio@74 {
>> +               compatible = "nxp,pca9539";
> According to the schematics, this is the TI TCA9539, an enhanced version
> of the NXP PCA9539. So I'd expect "ti,tca9539".
>
> However, using the latter may not work (I didn't try), as pca953x_id[]
> lists both parts, while pca953x_dt_ids[] lists only the NXP part number.
It works with "ti,tca9539"

-- 
Regards,
Vladimir

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-10-06  2:40 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-14 14:19 [PATCH v2 14/18] arm64: dts: ulcb-kf: enable PCA9539 on I2C2 Vladimir Barinov
2017-09-14 14:19 ` Vladimir Barinov
2017-09-20 13:44 ` Geert Uytterhoeven
     [not found]   ` <CAMuHMdWvhm_bbLz8cBqPWC-nXrTr6jw4cBV1A_WAsvi6DzsR0w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-10-06  2:40     ` Vladimir Barinov
2017-10-06  2:40       ` Vladimir Barinov

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.